Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swatches legend requires ordinal scale #971

Merged
merged 2 commits into from
Jul 4, 2022
Merged

swatches legend requires ordinal scale #971

merged 2 commits into from
Jul 4, 2022

Conversation

mbostock
Copy link
Member

@mbostock mbostock commented Jul 4, 2022

Fixes #844.

@mbostock mbostock requested a review from Fil July 4, 2022 02:06
Fil
Fil approved these changes Jul 4, 2022
View reviewed changes
@mbostock @Fil
Update test/legends/legends-test.ts
e024d1b 
Co-authored-by: Philippe Rivière <fil@rezo.net>
@mbostock mbostock merged commit 68f2f86 into main Jul 4, 2022
@mbostock mbostock deleted the mbostock/only-ordinal-swatches branch July 4, 2022 11:07
@mbostock mbostock mentioned this pull request Jul 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fil Fil Fil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when a continuous color scale is used with a swatches legend?
2 participants
@mbostock @Fil