fix for null scales #759
Merged
fix for null scales #759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
force-pushed
the
mbostock/null-legend
branch
from
3899a74 to
7c67b8b
Compare
Fil
requested changes
Feb 17, 2022
There was a problem hiding this comment.
It still crashes with Plot.plot({color: {legend: true}}) :)
Suggestion:
Line 78 in 7c67b8b
- if (o && o.legend) {
+ if (isScaleOptions(o) && o.legend) {
|
Checking |
mbostock
force-pushed
the
mbostock/null-legend
branch
from
7c67b8b to
203d459
Compare
Fil
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#756 changed the test used to determine whether or not a scale exists. This updates Plot.legend to match. Now
Plot.legend({color: {}})throws an error because it does not consider the color scale to be defined (there is neither a type nor a domain). Supersedes #757.