Skip to content

a chart with no colors defaults to the identity color scale #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

a chart with no colors defaults to the identity color scale #747

wants to merge 1 commit into from

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Feb 9, 2022 •
edited
Loading

fixes #744

cc: @yurivish

@Fil Fil requested a review from mbostock February 9, 2022 17:56
@Fil Fil marked this pull request as draft February 9, 2022 19:33
@mbostock mbostock mentioned this pull request Feb 12, 2022
Merged
@Fil Fil closed this Feb 13, 2022
@Fil Fil deleted the fil/default-color-scale branch February 13, 2022 12:03
@Fil
Copy link
Contributor Author

Fil commented Feb 13, 2022

superseded by #756 and #757

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbostock mbostock Awaiting requested review from mbostock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

a color scale with no channels should default to identity?
1 participant
@Fil