difference as a composite mark

src/marks/difference.d.ts

@@ -42,13 +42,13 @@ export interface DifferenceOptions extends MarkOptions, CurveOptions {
    * The fill color when the primary value is greater than the secondary value;
    * defaults to green.
    */
-  positiveColor?: string;
+  positiveColor?: ChannelValueSpec;
 
   /**
    * The fill color when the primary value is less than the secondary value;
    * defaults to blue.
    */
-  negativeColor?: string;
+  negativeColor?: ChannelValueSpec;
 
   /**
    * The fill opacity; defaults to 1.

src/marks/difference.js

@@ -1,143 +1,119 @@
-import {area as shapeArea, line as shapeLine} from "d3";
+import {area as shapeArea} from "d3";
 import {create} from "../context.js";
-import {maybeCurve} from "../curve.js";
-import {Mark, withTip} from "../mark.js";
-import {identity, indexOf, isColor, number} from "../options.js";
-import {applyIndirectStyles, applyTransform, getClipId, groupIndex} from "../style.js";
+import {identity, indexOf} from "../options.js";
+import {groupIndex, getClipId} from "../style.js";
+import {marks} from "../mark.js";
+import {area} from "./area.js";
+import {lineY} from "./line.js";
 
-const defaults = {
-  ariaLabel: "difference",
-  fill: "none",
-  stroke: "currentColor",
-  strokeWidth: 1.5,
-  strokeLinecap: "round",
-  strokeLinejoin: "round",
-  strokeMiterlimit: 1
-};
-
-function maybeColor(value) {
-  if (value == null) return "none";
-  if (!isColor(value)) throw new Error(`invalid color: ${value}`);
-  return value;
+function renderArea(X, Y, y0, {curve}) {
+  return shapeArea()
+    .curve(curve)
+    .defined((i) => i >= 0) // TODO: ??
+    .x((i) => X[i])
+    .y1((i) => Y[i])
+    .y0(y0);
 }
 
-class DifferenceY extends Mark {
-  constructor(data, options = {}) {
-    const {
+export function differenceY(
+  data,
+  {
+    x = indexOf,
+    x1 = x,
+    x2 = x,
+    y = identity,
+    y1 = y,
+    y2 = y,
+    positiveColor = "#01ab63",
+    negativeColor = "#4269d0",
+    opacity = 1,
+    positiveOpacity = opacity,
+    negativeOpacity = opacity,
+    ariaLabel = "difference",
+    positiveAriaLabel = `positive ${ariaLabel}`,
+    negativeAriaLabel = `negative ${ariaLabel}`,
+    tip,
+    channels,
+    ...options
+  } = {}
+) {
+  return marks(
+    // The positive area goes from the top (0) down to the reference value
+    // y2, and is clipped by an area going from y1 to the top (0).
+    area(data, {
       x1,
-      y1,
       x2,
+      y1,
       y2,
-      curve,
-      tension,
-      positiveColor = "#01ab63",
-      negativeColor = "#4269d0",
-      opacity = 1,
-      positiveOpacity = opacity,
-      negativeOpacity = opacity
-    } = options;
-    super(
-      data,
-      {
-        x1: {value: x1, scale: "x"},
-        y1: {value: y1, scale: "y"},
-        x2: {value: x2 === x1 ? undefined : x2, scale: "x", optional: true},
-        y2: {value: y2 === y1 ? undefined : y2, scale: "y", optional: true}
-      },
-      options,
-      defaults
-    );
-    this.curve = maybeCurve(curve, tension);
-    this.positiveColor = maybeColor(positiveColor);
-    this.negativeColor = maybeColor(negativeColor);
-    this.positiveOpacity = number(positiveOpacity);
-    this.negativeOpacity = number(negativeOpacity);
-  }
-  filter(index) {
-    return index;
-  }
-  render(index, scales, channels, dimensions, context) {
-    const {x1: X1, y1: Y1, x2: X2 = X1, y2: Y2 = Y1} = channels;
-    const {negativeColor, positiveColor, negativeOpacity, positiveOpacity} = this;
-    const {height} = dimensions;
-    const clipPositive = getClipId();
-    const clipNegative = getClipId();
-    return create("svg:g", context)
-      .call(applyIndirectStyles, this, dimensions, context)
-      .call(applyTransform, this, scales, 0, 0)
-      .call((g) =>
-        g
+      fill: positiveColor,
+      fillOpacity: positiveOpacity,
+      ...options,
+      // todo render
+      render: function (index, scales, channels, dimensions, context, next) {
+        const wrapper = create("svg:g", context);
+        const clip = getClipId();
+        const {x1: X1, y1: Y1, x2: X2 = X1} = channels;
+        const {height} = dimensions;
+        wrapper
           .append("clipPath")
-          .attr("id", clipPositive)
+          .attr("id", clip)
           .selectAll()
           .data(groupIndex(index, [X1, Y1], this, channels))
           .enter()
           .append("path")
-          .attr("d", renderArea(X1, Y1, height, this))
-      )
-      .call((g) =>
-        g
+          .attr("d", renderArea(X1, Y1, height, this));
+        const g = next(index, scales, {...channels, x1: X2, y1: new Float32Array(Y1.length)}, dimensions, context);
+        g.setAttribute("clip-path", `url(#${clip})`);
+        g.removeAttribute("aria-label");
+        wrapper.attr("aria-label", positiveAriaLabel);
+        wrapper.append(() => g);
+        return wrapper.node();
+      }
+    }),
+
+    // The negative area goes from the bottom (height) up to the reference value
+    // y2, and is clipped by an area going from y1 to the top (0).
+    area(data, {
+      x1,
+      x2,
+      y1,
+      y2,
+      fill: negativeColor,
+      fillOpacity: negativeOpacity,
+      ...options,
+      render: function (index, scales, channels, dimensions, context, next) {
+        const wrapper = create("svg:g", context);
+        const clip = getClipId();
+        const {x1: X1, y1: Y1, x2: X2 = X1} = channels;
+        const {height} = dimensions;
+        wrapper
           .append("clipPath")
-          .attr("id", clipNegative)
+          .attr("id", clip)
           .selectAll()
           .data(groupIndex(index, [X1, Y1], this, channels))
           .enter()
           .append("path")
-          .attr("d", renderArea(X1, Y1, 0, this))
-      )
-      .call((g) =>
-        g
-          .selectAll()
-          .data(groupIndex(index, [X2, Y2], this, channels))
-          .enter()
-          .append("path")
-          .attr("fill", positiveColor)
-          .attr("fill-opacity", positiveOpacity)
-          .attr("stroke", "none")
-          .attr("clip-path", `url(#${clipPositive})`)
-          .attr("d", renderArea(X2, Y2, 0, this))
-      )
-      .call((g) =>
-        g
-          .selectAll()
-          .data(groupIndex(index, [X2, Y2], this, channels))
-          .enter()
-          .append("path")
-          .attr("fill", negativeColor)
-          .attr("fill-opacity", negativeOpacity)
-          .attr("stroke", "none")
-          .attr("clip-path", `url(#${clipNegative})`)
-          .attr("d", renderArea(X2, Y2, height, this))
-      )
-      .call((g) =>
-        g
-          .selectAll()
-          .data(groupIndex(index, [X1, Y1], this, channels))
-          .enter()
-          .append("path")
-          .attr("d", renderLine(X1, Y1, this))
-      )
-      .node();
-  }
-}
-
-function renderArea(X, Y, y0, {curve}) {
-  return shapeArea()
-    .curve(curve)
-    .defined((i) => i >= 0)
-    .x((i) => X[i])
-    .y1((i) => Y[i])
-    .y0(y0);
-}
-
-function renderLine(X, Y, {curve}) {
-  return shapeLine()
-    .curve(curve)
-    .defined((i) => i >= 0)
-    .x((i) => X[i])
-    .y((i) => Y[i]);
-}
+          .attr("d", renderArea(X1, Y1, 0, this));
+        const g = next(
+          index,
+          scales,
+          {
+            ...channels,
+            x1: X2,
+            y1: new Float32Array(Y1.length).fill(height)
+          },
+          dimensions,
+          context
+        );
+        g.setAttribute("clip-path", `url(#${clip})`);
+        wrapper.append(() => g);
+        g.removeAttribute("aria-label");
+        wrapper.attr("aria-label", negativeAriaLabel);
+        return wrapper.node();
+      }
+    }),
 
-export function differenceY(data, {x = indexOf, x1 = x, x2 = x, y = identity, y1 = y, y2 = y, ...options} = {}) {
-  return new DifferenceY(data, withTip({...options, x1, x2, y1, y2}, "x"));
+    // reference line
+    lineY(data, {x: x1, y: y1, tip, channels: {...channels, y2}, ...options})
+  );
 }