Skip to content

documentation tree #1698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 19, 2023
Merged

documentation tree #1698

merged 4 commits into from
Jun 19, 2023

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Jun 17, 2023

from the d3 website: d3/d3@fbf24bb and d3/d3@9f88f02

Capture d’écran 2023-06-17 à 12 11 05

@Fil Fil requested a review from mbostock June 17, 2023 10:10
@Fil Fil enabled auto-merge (squash) June 17, 2023 10:10
Copy link
Member

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not sure if this is worth the attention. I thought it was necessary in the D3 case because the sidebar is more deeply hierarchical, but here are there are only four sections, so you can already see fairly easy what’s available?

@Fil
Copy link
Contributor Author

Fil commented Jun 18, 2023

It's such a nice overview! When I saw it in D3, I felt it was missing in Plot.

@Fil Fil merged commit dbb7d59 into main Jun 19, 2023
@Fil Fil deleted the fil/adopt-tree branch June 19, 2023 15:24
Fil added a commit that referenced this pull request Aug 21, 2023
chaichontat pushed a commit to chaichontat/plot that referenced this pull request Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants