add docs-test #1688
add docs-test #1688
Conversation
from d3/d3#3673 fix a few malformed links; the automatic renumbering of duplicate links with -1 seems fragile, so we make them explicit rather than making the link checker smarter.
|
Not satisfied that I need to check a .js link here, and not in the D3 version. |
|
I removed the exemption for .js files and nothing broke. Are you sure we still need that? What was linking to a .js file? |
|
I think it might be leftover from when you crawled the generated HTML; there is an A tag here for downloading the pre-built UMD bundles: Lines 85 to 86 in 2d4a2f6 The new test only looks for Markdown links, so I think we don’t need this exemption anymore. (And I think it’s okay that you can opt-out of link checking by using an A element instead of a Markdown link.) |
There was a problem hiding this comment.
This reminds me that we adopted a more explicit system for naming anchors in the new D3 documentation (e.g., the anchor for Plot.scale would be #scale instead of the default #scale-options or disambiguated #scale-options-1). But I think we could adopt that naming convention in a subsequent PR, and when we do, it’ll be great to have this test in place to make sure we don’t miss anything!
|
Oh, I see now. It’s just crawling the files and breaking on the symlink to dist/plot.umd.js because it hasn’t been built. Yeah. There’s no need to stat .js files. I’ll revert the last commit. |
* add docs-test from d3/d3#3673 fix a few malformed links; the automatic renumbering of duplicate links with -1 seems fragile, so we make them explicit rather than making the link checker smarter. * ignore links to plot.js * apply changes from d3/d3#3673 * ignore .js files (a link to plot.js) --------- Co-authored-by: Mike Bostock <mbostock@gmail.com>
* add docs-test from d3/d3#3673 fix a few malformed links; the automatic renumbering of duplicate links with -1 seems fragile, so we make them explicit rather than making the link checker smarter. * ignore links to plot.js * apply changes from d3/d3#3673 * ignore .js files (a link to plot.js) --------- Co-authored-by: Mike Bostock <mbostock@gmail.com>
from d3/d3#3673
fix a few malformed links; the automatic renumbering of duplicate links with -1 seems fragile, so we make them explicit rather than making the link checker smarter.