Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsdocs: contour, raster #1234

Merged
merged 5 commits into from
Jan 23, 2023
Merged

jsdocs: contour, raster #1234

merged 5 commits into from
Jan 23, 2023

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Jan 19, 2023

TODO:

  • raster, contour
  • centroid, geocentroid
  • spike
  • identity
    • (also missing from the release notes)
  • interpolateNone, interpolatorBarycentric, interpolateNearest, interpolatorRandomWalk?

@Fil
Copy link
Contributor Author

Fil commented Jan 19, 2023

@duaneatat: maybe there could be a way to log that a function is exposed without a jsdoc?

@duaneatat
Copy link
Contributor

Yep, we could do this by parsing index.js and all of the imports it references.

@Fil Fil requested a review from mbostock January 20, 2023 17:55
@Fil
Copy link
Contributor Author

Fil commented Jan 20, 2023

should we do the spatial interpolators?

@Fil Fil marked this pull request as ready for review January 20, 2023 17:56
@Fil Fil force-pushed the fil/missing-jsdocs branch from ff473e6 to 7beb993 Compare January 23, 2023 09:15
@Fil Fil merged commit 395f571 into main Jan 23, 2023
@Fil Fil deleted the fil/missing-jsdocs branch January 23, 2023 14:01
chaichontat pushed a commit to chaichontat/plot that referenced this pull request Jan 14, 2024
* jsdocs: contour, raster

* centroid, geoCentroid

* identity

* add Plot.identity in the release notes

* jsdoc for spatial interpolation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants