Skip to content

Facet expand #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 18 commits into from
Closed

Facet expand #1069

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
487eaf3
checkpoint facet expansion
mbostock Sep 30, 2022
171e97b
fix a test
mbostock Sep 30, 2022
301de0d
facet expansion
Fil Oct 4, 2022
fc37827
optimize for the common case of 1 facet
Fil Oct 5, 2022
b969392
creates a central registry of channels, with their associated scales …
Fil Oct 6, 2022
218cd70
centralize channel definitions
Fil Oct 6, 2022
e733bd0
centralize channel scale definitions
Fil Oct 6, 2022
6614ba8
use a map and export a registerChannel method; with a pretty unimagin…
Fil Oct 7, 2022
21aaf4e
Update src/transforms/dodge.js
Fil Oct 10, 2022
01a6714
Update src/plot.js
Fil Oct 10, 2022
6424882
Update src/plot.js
Fil Oct 10, 2022
252ca0a
Update src/channel.js
Fil Oct 10, 2022
9a41a9d
channelRegistry
Fil Oct 10, 2022
b5cfb76
scaleRegistry
Fil Oct 10, 2022
a4263ec
oops this test depended on the time zone
Fil Oct 10, 2022
be6e887
stricter
Fil Oct 10, 2022
1a5d831
don't export registerChannel yet
Fil Oct 10, 2022
a7f7ba9
maybeChannel
Fil Oct 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix a test
  • Loading branch information
@mbostock
mbostock committed Sep 30, 2022
commit 171e97b3c21f517fea6bc4a367226049b335c83c
9 changes: 5 additions & 4 deletions test/marks/bar-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,12 @@ it("barX(data, {fill}) allows fill to be null", () => {
});

it("barX(data, {fill}) allows fill to be a variable color", () => {
const bar = Plot.barX(undefined, {fill: "x"});
const data = [{x: 1}, {x: 2}];
const bar = Plot.barX(data, {fill: "x"});
assert.strictEqual(bar.fill, undefined);
const {fill} = bar.channels;
assert.strictEqual(fill.value, "x");
assert.strictEqual(fill.scale, "color");
const {channels} = bar.initialize([[0, 1]]);
assert.deepStrictEqual(channels.fill.value, [1, 2]);
assert.strictEqual(channels.fill.scale, "color");
});

it("barX(data, {stroke}) allows stroke to be a constant color", () => {
Expand Down