File input label regex #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en the file directly and parse headers
|
Codecov Report
@@ Coverage Diff @@
## master #376 +/- ##
==========================================
- Coverage 73.21% 73.07% -0.14%
==========================================
Files 124 124
Lines 8011 8055 +44
==========================================
+ Hits 5865 5886 +21
- Misses 1647 1666 +19
- Partials 499 503 +4
Continue to review full report at Codecov.
|
djaglowski
reviewed
Aug 11, 2021
|
…hare the same reader for reading the headers and file
|
djaglowski
reviewed
Aug 20, 2021
djaglowski
reviewed
Aug 20, 2021
Comment on lines
+317
to
+319
| /*if err := newReader.readHeaders(ctx); err != nil { | ||
| f.Errorf("error while reading file headers: %s", err) | ||
| }*/ |
djaglowski
previously approved these changes
Aug 20, 2021
|
…aderLabels are persisted to the datbase (#399)
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Context
File input should have the ability to parse a log file's headers and attach them as labels to each entry's $label map. This needs to work under the following situations:
Goals
This solution should not decrease performance of file input operator.
Changes
LabelRegex, an optional parameter for providing a regex that will be used for parsing headerskeyandvaluelabel_regex: '^#(?P<key>.*?): (?P<value>.*)'Labels map[string]stringto the Fingerprint type. This map still store the labels derived from the headersNewFingerprint()is called, the map is initialized withfp.Labels = make(map[string]string)ReadHeaders()method, which is called by ReadToEnd before a file's entry's are readReadToEnd()to attach the Labels on the fingerprint to each entryUse Cases
The initial use-case for this change is to allow for a W3C plugin to be built, where we will need to detect the field names before parsing the entry. A future PR will enable CSV parser to take an optional
FieldLabelparameter, meaning the user will not need to define the fields in their stanza config, for example:file input will read the file starting with this:
and then attach those headers as labels, to each entry
Once CSV is updated, we can do this: (removed some fields from this output to keep it small)
The pipeline config to handle this:
Please check that the PR fulfills these requirements