Fix some types for more understanding #311
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…" in "outputPaused") fix: remove unused import JsonArray in types.ts
…ActionTriggered mediaAction type (ObsMediaInputAction)
t2t2
reviewed
Nov 13, 2022
| @@ -608,7 +608,7 @@ export interface OBSEventTypes { | |||
| /** | |||
| * Action performed on the input. See `ObsMediaInputAction` enum | |||
| */ | |||
| mediaAction: string; | |||
There was a problem hiding this comment.
As mentioned at the start of this file, this file is auto generated and when there's a new release changes like this will not survive.
Either implement this to obs-websocket repo so docs/generated/protocol.json has this info that the generator can then read (preferred), or update scripts/build-types.ts so the changes persist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue (if applicable): I created an issue 2 days ago #310
Description:
In the
MediaInputActionTriggeredand theTriggerMediaInputActionthe keymediaActionwas type-hinted as string but for more understand, I added the possible value which are a little bit complicated (likeOBS_WEBSOCKET_MEDIA_INPUT_ACTION_NONE)And I also fixed a spelling mistake in the
GetRecordStatustype the keyoutputPausedwas spelledouputPaused