Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Refactor fixtures #153

Merged
merged 1 commit into from
Dec 31, 2023
Merged

test: Refactor fixtures #153

merged 1 commit into from
Dec 31, 2023

Conversation

oboukli
Copy link
Owner

@oboukli oboukli commented Dec 1, 2023

No description provided.

@oboukli oboukli self-assigned this Dec 1, 2023
@oboukli oboukli force-pushed the feature/refactor-fixture branch 6 times, most recently from 3d88bb0 to 873fb3f Compare December 3, 2023 23:47
@@ -11,50 +11,47 @@

namespace Aktabook.Data.Testing.Fixtures;

public sealed class RequesterServiceDbContextSqlServerDestructiveFixture : IDisposable
public sealed class RequesterServiceDbContextSqlServerDestructiveFixture

Check notice

Code scanning / InspectCode

Class is never instantiated: Non-private accessibility Note test

Class 'RequesterServiceDbContextSqlServerDestructiveFixture' is never instantiated
{
DbContext.Dispose();
}
if (_connectionString is null)

Check notice

Code scanning / InspectCode

'if' statement can be rewritten as '??=' assignment Note test

Convert into '??='
Copy link

sonarcloud bot commented Dec 31, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
93.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@oboukli oboukli marked this pull request as ready for review December 31, 2023 14:18
@oboukli oboukli merged commit 2342fb8 into main Dec 31, 2023
18 checks passed
@oboukli oboukli deleted the feature/refactor-fixture branch December 31, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant