Chore: Add CI to release tagged image and binary #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daishan Peng <daishan@acorn.io>
thedadams
reviewed
Aug 29, 2025
.github/workflows/release.yml
Outdated
| type: string | ||
|
|
||
| env: | ||
| GO_VERSION: "1.23" |
Contributor
There was a problem hiding this comment.
Can we go to 1.25 now? Maybe even bump the version in go.mod?
.github/workflows/release.yml
Outdated
Comment on lines
7
to
12
| workflow_dispatch: | ||
| inputs: | ||
| tag: | ||
| description: 'Tag to release (e.g., v1.0.0)' | ||
| required: true | ||
| type: string |
Contributor
There was a problem hiding this comment.
I say we remove this. Just do it with a tag.
Contributor
Author
There was a problem hiding this comment.
yeah, not idea why AI generates that. We should just do tag from event
.github/workflows/release.yml
Outdated
Comment on lines
369
to
376
| tag: ${{ steps.version.outputs.VERSION }} | ||
| name: Release ${{ steps.version.outputs.VERSION }} | ||
| bodyFile: CHANGELOG.md | ||
| artifacts: "release/*" | ||
| draft: false | ||
| prerelease: ${{ contains(steps.version.outputs.VERSION, '-') }} | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
| generateReleaseNotes: true No newline at end of file |
Contributor
There was a problem hiding this comment.
I think we should add allowUpdates: true here so that this works if someone creates a release through the GitHub UI.
| # Linting | ||
| lint: | ||
| golangci-lint run | ||
| golangci-lint run --tests=false |
Contributor
Author
There was a problem hiding this comment.
No, i meant to add it to our ci so that lint don't check test files. I added --tests=false to all the lint action now.
StrongMonkey
force-pushed
the
add-release-process
branch
from
f9c52f8 to
3309557
Compare
StrongMonkey
force-pushed
the
add-release-process
branch
3 times, most recently
from
02416b4 to
5c3d043
Compare
g-linville
reviewed
Aug 29, 2025
StrongMonkey
force-pushed
the
add-release-process
branch
2 times, most recently
from
7ed13d1 to
375c5d4
Compare
Signed-off-by: Daishan Peng <daishan@acorn.io>
StrongMonkey
force-pushed
the
add-release-process
branch
from
375c5d4 to
a732e4a
Compare
thedadams
approved these changes
Aug 29, 2025
g-linville
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CI to do tagged release for binary and docker images