Creates new term 'level of galvanic skin response' #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #400 Creates new term 'level of galvanic skin response'
There was a problem hiding this comment.
Pull Request Overview
This PR creates a new OBA term for "level of galvanic skin response" (OBA:2090004) to address issue #400. The term follows the entity_attribute DOSDP pattern and is defined as the amount of galvanic skin response.
Key changes:
- Added new term OBA:2090004 with appropriate axioms and annotations
- Imported NCIT:C93039 (Galvanic Skin Response) to support the new term
- Updated version information from 2025-10-07 to 2025-10-22
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/patterns/definitions.owl | Adds the new OBA:2090004 term definition with class declarations, annotations, equivalent classes axiom, and necessary imports; also updates ontology version date |
| src/patterns/data/default/entity_attribute.tsv | Adds the DOSDP pattern template entry for OBA:2090004 linking galvanic skin response to the amount quality |
Comments suppressed due to low confidence (1)
aleixpuigb
commented
Oct 22, 2025
| remove --term PR:000000001 \ | ||
| --term SO:0000252 \ | ||
| --term SO:0000234 \ | ||
| --term SO:0000253 \ |
Collaborator
Author
There was a problem hiding this comment.
As this SO term and the CHEBI term CHEBI:17843 ('transfer RNA') have each other as equivalent class, the CI was failing.
@matentzn is this the correct way to solve the issue?
Contributor
There was a problem hiding this comment.
I am fine with this solution! We might revisit in the far future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #400
Creates new term 'level of galvanic skin response'