fix: avoid drop safety concerns in Subscription.stop
#139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `Subscription.stop` is async but consumes self, it wasn't neccesarily drop safe. If the underlying future was cancelled then `self` would be gone but the message wouldn't neccesarily be send. This would have been handled by the PinnedDrop but I'd rather take the implementation that's in this PR.
obmarg
force-pushed
the
obmarg/qotqoqpxtyxq
branch
from
981133b to
b83c74a
Compare
obmarg
force-pushed
the
obmarg/tnununyylmkl
branch
from
cf6dab8 to
9375de7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
Subscription.stopis async but consumes self, it wasn't neccesarily drop safe. If the underlying future was cancelled thenselfwould be gone but the message wouldn't neccesarily be send.This would have been handled by the PinnedDrop but I'd rather take the implementation that's in this PR.