Fix warnings with FontAwesome5 for web

[soranoba]

I fixed them.

[soranoba]

/home/travis/build/oblador/react-native-vector-icons/lib/create-icon-set-from-fontawesome5.js
  153:17  error  'light' is missing in props validation  react/prop-types
  153:24  error  'solid' is missing in props validation  react/prop-types

Because of the above error, I ran yarn upgrade.

[oblador]

Thanks, deferring to @hampustagerud on this one, but LGTM. Could you revert the change to the yarn.lock file?

[soranoba]

If I do not update yarn.lock, eslint is not pass (the above error will occur).
What should I do?

[hampustagerud]

The fix itself looks fine but upgrading all those packages seems unnecessary to me. Is the warning from the yarn test command? I have tried running it and it passes. There shouldn't be any errors since the properties actually exists in the prop-types object. Can you try removing node_modules and then reinstalling? Or maybe try reverting the yarn.lock changes and see if it passes the CI test?

[hampustagerud]

Guessing there is a problem with eslint on your machine cause I can't seem to be able to reproduce it. Maybe try reinstalling node_modules/?

[soranoba]

If you are using npm, the test will pass.
However, If you are using yarn, the test will not pass.

So, the problem is not machine problem.

[soranoba]

The diff of this library occurs by executing only the yarn command.

[soranoba]

I just updated eslint-plugin-react.

[hampustagerud]

I have changed how propTypes are created which seems to pass the tests better, could you please try it out? We don't have to force people to upgrade the packges if it works and that would be good 🙂

[hampustagerud]

I changed this and now both npm and yarn tests passes, please try 🙂

[hampustagerud]

Still think we can do this without upgrading packages!

[soranoba]

It's wonderful !!

[hampustagerud]

Do you think you could remove the changes to yarn.lock and package.json? I'll merge this first thing in the morning! 🙂

[soranoba]

I think it is no problem 😃