Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tvOS target #446

Merged
merged 1 commit into from
Apr 20, 2017
Merged

Add tvOS target #446

merged 1 commit into from
Apr 20, 2017

Conversation

cmcewen
Copy link
Contributor

@cmcewen cmcewen commented Apr 18, 2017

This is required to use the library on tvOS

@oblador oblador merged commit cd40017 into oblador:master Apr 20, 2017
@oblador
Copy link
Owner

oblador commented Apr 20, 2017

Thanks!

@oblador
Copy link
Owner

oblador commented May 4, 2017

Released in 4.1.0.

oblador added a commit that referenced this pull request May 7, 2017
@oblador
Copy link
Owner

oblador commented May 7, 2017

This caused issues for a lot of people using react-native link, so I've temporarily reverted this until the issue is fixed in core. Feel free to open a new issue/PR tracking this.

@grabbou
Copy link

grabbou commented Jun 28, 2017

I am going to make link work with that particular commit. Will report back.

@oblador
Copy link
Owner

oblador commented Jun 28, 2017

@grabbou Awesome 👏😊

respectTheCode pushed a commit to respectTheCode/react-native-vector-icons that referenced this pull request Mar 14, 2018
@shirakaba
Copy link

@grabbou What's the status on getting link to work with this?

I've wasted half my day on trying to dispel this "Unrecognized font family 'Ionicons'" now, and am resigning to give up on this module.

respectTheCode's recent fork (only 7 commits behind master) restores the commit in question, but the current incarnation of link is not working for it. For convenience, if someone with more insight than me is feeling brave enough to revisit tvOS support:

yarn add https://github.com/respectTheCode/react-native-vector-icons.git

@nic-thomson
Copy link

nic-thomson commented May 3, 2018

@shirakaba
I too had some problems adding a target for tvOS. My problem was that that Xcode was using a separate plist for the tvOS target. This plist is NOT shown in the Xcode project tree, and only referenced in the targets build settings, have a look you may find that the additional fonts are not included in the plist. Adding them to this plist resolved the problem.

I had to look at the simulator files to figure out what was going on.

gtebbutt pushed a commit to gtebbutt/react-native-vector-icons that referenced this pull request Aug 1, 2018
oblador pushed a commit that referenced this pull request Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants