Use unix epoch timestamps #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opayen
pushed a commit
to opayen/react-native-performance
that referenced
this pull request
Sep 16, 2022
This reverts commit 390e91c
oblador
added a commit
that referenced
this pull request
Sep 21, 2022
* Revert "Use unix epoch timestamps (#71)" This reverts commit 390e91c * Update Podfile * Upgrade to React Native 0.68.3 * Use RN's code to get the timestamp * Use monotonic clock in RNPerformance * Update README.md * Cleanup * Remove empty line * Fix yarn.lock * Update lockfiles * Force singular version of node types * Bump TS/typings and skip lib check Co-authored-by: Olivier Payen <olivier.payen@klarna.com> Co-authored-by: Joel Arvidsson <joel.arvidsson@klarna.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In React Native 0.68 the
Performance.now()implementation on both iOS and Android changed to use unix epoch timestamps instead of a monotonic clock in facebook/react-native#32695.This is clearly inferior for the purposes of performance metrics as it risks skewing durations, but it's more important to keep the native marks in sync with the RN implementation which this PR aims to do. This means this is a breaking change only compatible with RN >=0.68.