fix(ios): build failure when using custom native marks#102
Conversation
Build fails on importing `RNPeroformance.h` in Objective-C file, because `chrono` is a part of STL library which cannot be found in plain Objective-C files. The idea of fix is to prevent it to be included in a header. `RNPerformanceEntryWasAddedNotification` declaration and initialization were split to prevent build failure as well.
|
Hi, and thanks for your PR! As this doesn't seem to be an issue for myself or others, I'm curious of your setup. Do you use a very old version of React Native? Are you using native markers along with JS based? |
|
Hey, @oblador! No, I use a pretty recent Here's an example based on a clean RN template: https://github.com/hardworker/react-native-performance-test-app |
|
Hey, @oblador. |
|
This is the error I get when building the app when using custom markers on iOS: [MyApp] Compiling AppDelegate.mm
❌ /Users/name/Developer/MyAppMobile/ios/Pods/Headers/Public/react-native-performance/RNPerformance.h:2:10: 'chrono' file not found (in target 'MyApp' from project 'MyApp')
/Users/name/Developer/MyAppMobile/ios/MyApp/main.m:4:9: note: in file included from /Users/name/Developer/MyAppMobile/ios/MyApp/main.m:4:I applied the changes in this PR and the app builds successfully. I'm on Edit: The issue seems to be fixed by renaming |
Build fails on importing `RNPeroformance.h` in Objective-C file, because `chrono` is a part of STL library which cannot be found in plain Objective-C files. The idea of fix is to prevent it to be included in a header. `RNPerformanceEntryWasAddedNotification` declaration and initialization were split to prevent build failure as well.
Build fails on importing
RNPeroformance.hin Objective-C file, becausechronois a part of STL library which cannot be found in plain Objective-C files. The idea of fix is to prevent it to be included in a header.RNPerformanceEntryWasAddedNotificationdeclaration and initialization were split to prevent build failure as well.