Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I split the index.js file into index.ios.js and index.android.js, and I refactored all the methods of the iOS module (except the ones for Shared Web Credentials) to allow to pass an accessGroup string.
This enables Keychain sharing on iOS, which is very convenient when developing an App Extension, just like in my case where I needed to access the keychain in order to share the login credentials.
Please refer to the links below for more info:
http://evgenii.com/blog/sharing-keychain-in-ios/
http://swiftandpainless.com/ios8-share-extension-with-a-shared-keychain/
We'll also need to update the README if you decide to merge.
Cheers!