Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @storybook/react peer dependencies #509

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

anti-pode
Copy link
Contributor

Resolves peer dependencies issue when using Loki with @storybook/react 8

Copy link

@squidjam squidjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This updates correctly to v.8 of the peer dependency @storybook/react, please approve.

Copy link

@doug-bamber-konvoy doug-bamber-konvoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@squidjam squidjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me

@DILLIR
Copy link

DILLIR commented Jul 21, 2024

Will be this merged soon?

@eborden
Copy link

eborden commented Jul 22, 2024

Any thoughts on when this will merge and get released?

@DimDimShishkov
Copy link

hello, any updates?

Copy link

@DILLIR DILLIR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So close to working with new version, still not merged

@harry-wynnwilliams-ki
Copy link

any updates on this one? 🙏

@squidjam
Copy link

@oblador could you please approve? it's not a big check
Thanks

@oblador oblador merged commit 5926d87 into oblador:master Aug 27, 2024
@DILLIR
Copy link

DILLIR commented Aug 28, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet