Repository navigation
ci(coverage): give the instrumented lane its own per-test budget so the coverage gate can run - #9474
Merged
Merged
Conversation
`vitest.config.mts` sets `testTimeout: 15000`, calibrated for the uninstrumented lane. The coverage lane runs the same files under v8 instrumentation, where the repo-sweeping rows under `scripts/__tests__/` take several times longer. Measured on this tree with the coverage flag set as the only variable: zero of the 146 rows in the two heaviest sweep files exceed 15s uninstrumented, five exceed it instrumented. A timed-out row is not a failed gate, it is no gate. `coverage-report` gates every merge step on `needs.test-coverage.result == 'success'`, so one dead row skips the merge and the thresholds are never evaluated. The uninstrumented lane keeps its 15s budget unchanged, so nothing that guards day-to-day work is relaxed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013VGeMu3p6qEFWR6K6GGLaW
os-try-charles
marked this pull request as ready for review
September 14, 2026 08:24
akarma-synetal
pushed a commit
to akarma-synetal/objectui
that referenced
this pull request
Sep 28, 2026
…ts name 32 objectui issues that answer 404 (objectui#10803, batch 3) (objectstack-ai#10869) Part of objectstack-ai#10803 Clause-②: no Dispatched implementation of the `domain:ui` seat objectstack-ai#2 claim (comment `5860873556`) on objectui#10803, batch 3, session `https://claude.ai/code/session_014mXUNuFomfj24w7s1pZzhN`; patch round 1 applies the seat ruling `5861129870` on the round's two open questions, and patch round 2 applies contract review `5861306588` (two wording fixes and one optional nit) and the ruling's amendment `5861311219`. Citations only: no sentence's claim moves, and every edited pending changeset's frontmatter is byte-identical. The runtime text that moves loses its dead pointer and nothing else: four ADR-0049 tombstone guidance strings and two zod `.describe()` strings in `@object-ui/types`, and the Studio CEL authoring advisory in `@object-ui/app-shell`. The six tests that pin the tombstone text, the two changesets and two `content/docs` pages that quote it follow the changed string, and nothing else in them moves. ## Why `Part of`, not a closing line The card stays open for the other 83 numbers of the family remainder (seat amendment `5860244997`, Q2 = A). ## The seat ruling `5861129870` and its amendment `5861311219`, as applied - **Q1, the tombstone guidance class: a seat variant of option A, as amended.** Each of the four runtime tombstone strings keeps the house `RETIRED (REF) —` shape with `ADR-0049` as the reference, in place of the dead card. The ruling first conditioned `ADR-0049` on the key's TypeScript twin comment naming it: the twins of `TreeViewSchema.data` and `ChartDataSeriesSchema.data` (`data-display.ts`) and of `TextSchema.value` (`layout.ts`) each read "RETIRED (SHA, ADR-0049 enforce-or-remove)", while the twin of `DashboardConfigSchema.aria` is a deletion note on `DashboardConfig` in `designer.ts` that names no ADR, so round 1 shipped `RETIRED —` there. The amendment `5861311219` corrects that proxy: the `aria` retirement is itself ADR-0049 (the comment above `DashboardConfigSchema` in `complex.zod.ts`, its landing commit `e7957ab87`, and the pending `dashboard-config-aria-retired-5852.md` all say so), so `aria`'s error and describe strings also open `RETIRED (ADR-0049) —`. All four now read alike. Everything after the dash is unchanged. No sha enters runtime text. - **Q2, the CEL advisory: A.** The pointer drop in `rowCanonAdvisory` stands, as shipped in round 1. - **Folded (triage item 3):** the bare PR numbers objectstack-ai#5505 and objectstack-ai#5758, see **Mapping** and **Special cases** 4 and 2. - **Review `5861306588`, taken in full:** the objectstack-ai#5738 stand-down 3 sites name the card by role behind the sha (**Special cases** 2); the runtime-strings changeset's second sentence no longer says every pointer is dropped; and, the optional nit, the sweep changeset names the role-named case. - **`main`:** `main` (`fab627ff9`) was merged in during round 1 by a merge commit (`2cb9b253f`), no rebase and no force-push. The branch is 0 commits behind it, so round 2 merged nothing. Every reading below is on the head `dd37e35d2`. ## Premise, re-measured - REST `GET /repos/objectstack-ai/objectui/issues/N` for each of the 32: all 32 answer 404, and a second read of each answers 404 again (32 of 32). `GET .../pulls/N` answers 404 for all 32 too. Lit controls: objectui#10533 and objectui#7714 answer 200. No number was dropped from the batch. - The two folded bare PR numbers, objectstack-ai#5505 and objectstack-ai#5758, answer 404 on both `issues/N` and `pulls/N`. - The same 32 in objectstack all answer 200. Their subjects are unrelated to the objectui sentences (for example objectstack#5425 is the U+0000 finding about `useDatasetFields.ts`, objectstack#5418 the language-menu card). The only objectstack-qualified sites these numbers have in the in-scope classes already spell `objectstack#` (`objectstack#5425` in `useDatasetFields.ts`, `objectstack#5418` twice in `i18n`'s `provider.tsx`, and `objectstack#5505` twice in `components`): live sister citations, untouched. Every other site names an objectui card, confirmed by its landing commit below, so no site is re-qualified. - Every edited changeset is pending: it is present in `.changeset/` on `main`. - Branch point: `a60539b07`. Not a shallow checkout. ## Census (the enumeration pin for this batch) The instrument PR objectui#10854 printed, with this batch's 32 numbers and the two folded ones substituted (REF = a commit): ``` git grep -nE '(objectui#|#|issues/)(3499|3559|4784|5197|5221|5286|5309|5399|5401|5413|5414|5416|5417|5418|5425|5505|5518|5533|5709|5738|5741|5758|5852|5859|6296|6464|6661|6740|6757|6854|6859|6864|6896|6951)([^0-9]|$)' REF -- '.changeset/*.md' 'packages/*/src/**' ':!**/__tests__/**' ':!**/*.test.*' ':!**/*.spec.*' ':!**/test/**' ':!**/tests/**' | grep -v 'objectstack#' | wc -l ``` - REF = `a60539b07` (branch point): **217** lines (216 for the 32 alone: 56 changeset lines in 47 files and 160 src-nontest lines in 77 files; the folded objectstack-ai#5758 adds one line, and objectstack-ai#5505 sits on two lines objectstack-ai#5401 already counts). REF = `fab627ff9` (current `main`): 217. - REF = `dd37e35d2` (this head, `main` merged in): **0**. - This head merged with a fresh `main` (`fab627ff9`, `git merge-tree --write-tree`, clean): **0**. - The instrument's blind spot, measured: its `grep -v 'objectstack#'` drops a whole line that ALSO names an objectstack number. One in-scope line was hidden that way, `ActionRunner`'s `onSuccess` block ("objectui#5221, the console half of objectstack#9566/objectstack-ai#9474"); it is re-pointed here too. Without the filter the instrument reads 5 at this head, all live `objectstack#` lines (the three above and `objectstack#5505` twice). - Lit control, the same printed instrument over live objectui#7714 at this head: 17 lines. Hex-colour false positives (a number followed by a hex letter) at the branch point: 0. - Out of scope, as it stands (the card's instrument with the 34 numbers, unfiltered, whole tree at this head): 283 test lines in 121 files, 4 scripts lines in 2 files, 0 `.github`, 0 governed, and 24 other lines in 20 files (published `CHANGELOG.md` history, `content/docs`, two package READMEs, and `apps/console`; see **Acceptance notes** 3). The test count includes the `@ts-expect-error` comments named in **Acceptance notes** 5. ## Citation form - The 9-character backticked sha of the commit on `main` that landed the change the sentence rests on, as in PRs objectui#10707 / objectstack-ai#10766 / objectstack-ai#10797 / objectstack-ai#10854. All 32 distinct shas below (the two folded numbers reuse two of them) are ancestors of `main` (`git merge-base --is-ancestor`, exit 0 each; control leg: the head of PR objectui#10714 answers exit 1, and a known ancestor `5f789538d` answers exit 0 in the same checkout), and `git rev-parse --short=9` returns the same 9 characters for each. - A changeset's pointer to its OWN card is dropped, not replaced: `@changesets/changelog-git` prefixes each released entry with the hash of the commit that added the file, which is that landing. Where dropping the pointer left a dangling word, the clause was minimally repaired (listed in **Special cases**). - Where the sentence cites a RULING and no single commit is the ruling, the ruling is cited by its date: "the 2026-08-23 ruling" (the dashboard widget-options ruling, option B, recorded in `8d58f46b4`'s message), "the maintainer ruling of 2026-08-31" (the chart `categories` ruling, recorded in `b0d308da9`'s). - Runtime text carries no sha. Inside a zod `.describe()` string and in the author-facing CEL advisory the dead pointer is dropped (amendment `5860244997`, Q1 = A; ruling `5861129870`, Q2 = A). A tombstone guidance string keeps its `RETIRED (REF) —` shape with `ADR-0049` as the reference (ruling `5861129870`, Q1, as amended by `5861311219`). - Where nothing answers, the pointer is dropped and the sentence names the card by role (objectstack-ai#5518 only). ## Mapping (number to resolution) Lines and files are the branch-point census for that number. "Method" is how the landing was found. | dead number | resolution | method | lines / files | evidence | |:--|:--|:--|:--|:--| | objectstack-ai#3499 | `48132f7e6` | `git log --grep` | 1 / 1 | the rc.5 bump; its message lists "`HttpMethodSchema` -> spec's `HttpMethodSubsetSchema` (objectstack#5832, objectui#3499)" | | objectstack-ai#3559 | `fbc23e094` | `git log --grep` | 7 / 3 | "keep a field's own option keys when an action param inherits them (objectstack-ai#3559)"; it added `ActionParamOption` and the `normaliseOptions` preservation | | objectstack-ai#4784 | `833c90047` | `git log --grep` | 1 / 1 | "a 400 FLOW_FAILED or 404 on the flow route is terminal, not retryable"; its body names objectstack-ai#4784 as the card it settles | | objectstack-ai#5197 | `9c60144b5` | `git log --grep` | 4 / 3 | "retire the unreachable id-keyed nav label resolvers (objectstack-ai#5197)" | | objectstack-ai#5221 | `053fdc8f9` | `git log --grep` | 4 / 3 | "read ActionSchema.onSuccess for post-success navigation", "Part of objectstack-ai#5221"; it added `5221-onsuccess-navigation.md` and the console `openIn: 'self'` half | | objectstack-ai#5286 | `38ba3ddf3` | `git log --grep` | 1 / 1 | "API Discovery Storage group reads the canonical `storage` slot first (objectstack-ai#5286)": the alias table the changeset's sentence describes | | objectstack-ai#5309 | `c7a74c80d` | `git log -G` (the only commit adding the citation) | 3 / 2 | "approver membership-tier picker reads the server-published enum; delegated_admin stops rendering (invalid)" | | objectstack-ai#5399 | `5a07e67d9` | `git log --grep` + changeset's adding commit | 2 / 2 | "stop the sparse-predicate warning blaming `hidden: true` (objectstack-ai#5399)" | | objectstack-ai#5401 | `c86185eb5` | `git log --grep` | 3 / 3 | the PR objectstack-ai#5505 squash ("Bind `record` into node-level `visibleWhen`"); its body "flip[s] the objectstack-ai#5401 defect pins" and implements the live successor objectui#5454 | | objectstack-ai#5413 | `688cb93ad` | `git log --grep` | 1 / 1 | "resolve four react-pages.md contradictions toward the framework's sources (objectstack-ai#5413)" | | objectstack-ai#5414 | `77f846a8b` | changeset's adding commit | 11 / 5 | "name the pending approver, not a truncated raw id"; its body names objectstack-ai#5414 as the card it settles and states the confirmed-empty-seat surfacing | | objectstack-ai#5416 | `add10d8f9` | `git log --grep` + changeset's adding commit | 9 / 5 | "Studio metadata forms: no errors before input, translated help text, and a publish button clear of the toast" | | objectstack-ai#5417 | `c40f3b8ca` | `git log --grep` + changeset's adding commit | 4 / 3 | "surface a screen flow's resume result, on both outcomes (objectstack-ai#5417)" | | objectstack-ai#5418 | `7a90afdf9` | changeset's adding commit + `git log -G` | 20 / 16 | "Studio's 新建对象 asks for the record-sharing baseline, and an unauthored one is reported before Publish instead of by it"; it added the ten locale keys and `securityPostureLint.ts` | | objectstack-ai#5425 | `56f4e34c0` | `git log --grep` + changeset's adding commit | 5 / 4 | "one header spelling across the table widget family", "Part of objectstack-ai#5425" | | objectstack-ai#5505 (bare PR number, folded) | `c86185eb5` | the PR's own squash (subject ends "(objectstack-ai#5505)") | 2 / 2 | sits beside `c86185eb5` already, so the pair collapses to the sha. See **Special cases** 4 | | objectstack-ai#5518 | nothing answers | `git log --grep`, `git log -S` on the fallback read | 1 / 1 | the `node.objectName ?? node.object` fallback it asks about is still on `main`; no commit lands it. See **Special cases** 1 | | objectstack-ai#5533 | `2573ff434` | `git log --grep` + changeset's adding commit | 12 / 6 | "Marketplace package detail page states the marketplace is off, instead of red-erroring (objectstack-ai#5533)" | | objectstack-ai#5709 | `8d58f46b4`; "the 2026-08-23 ruling" | `git log --grep` + changeset's adding commit | 8 / 6 | "warn on dashboard widget options keys no renderer consumes (objectstack-ai#5709)"; its body records "Maintainer ruling 2026-08-23 (option B)" | | objectstack-ai#5738 | stand-down 3: the card named by role, behind `702c48a62`; the recipe: `702c48a62` | `git log --grep` | 4 / 3 | `702c48a62` ("write the requiredWhen example in the row-predicate canon (objectstack-ai#5738)") is the Phase-0 corpus-sweep landing and carries the `detectNonCanonicalRowSpelling` recipe, but not the stand-down 3 finding, which was recorded only on the dead card. See **Special cases** 2 | | objectstack-ai#5741 | `83fe6e741` | `git log --grep` + changeset's adding commit | 25 / 13 | "row predicates on runtime record surfaces bind record.* only (objectui#5741)"; "executed as ruled on objectui#5741 (2026-09-02, amended 2026-09-05)" | | objectstack-ai#5758 (bare PR number, folded) | `702c48a62` | the PR's own squash (subject ends "(objectstack-ai#5758)") | 1 / 1 | "PR objectstack-ai#5758's recipe" beside `702c48a62` collapses to the sha. See **Special cases** 2 | | objectstack-ai#5852 | `e7957ab87`; runtime text `RETIRED (ADR-0049) —` | `git log --grep` + changeset's adding commit | 5 / 4 | "retire the designer-surface dashboard aria pair (objectstack-ai#5852)"; it wrote the hand-spelled `z.never({ error })` tombstone | | objectstack-ai#5859 | `41df89320` | changeset's adding commit | 1 / 1 | "retire the orphaned ObjectTrigger and ObjectRelationship exports"; own-card pointer only | | objectstack-ai#6296 | `88b15fddc` | `git log --grep` + changeset's adding commit | 8 / 3 | "caller-supplied subject vocabulary for ConditionBuilder", "Part of objectstack-ai#6296"; it added `subjects` and the per-row quote character | | objectstack-ai#6464 | `830ed5803` | changeset's adding commit | 8 / 6 | "offer approval recall to the submitter only" | | objectstack-ai#6661 | `969ba84f4` | changeset's adding commit | 5 / 5 | "console renderers for `app:launcher` and `nav:menu`" | | objectstack-ai#6740 | `7c9b044f4` | changeset's adding commit | 5 / 5 | "flex declares the containment it renders" | | objectstack-ai#6757 | `f99932a42` | `git log --grep` + changeset's adding commit | 11 / 10 | "render `global:search` and `global:notifications` instead of the placeholder"; its body names objectstack-ai#6757 as the card it settles | | objectstack-ai#6854 | `adb2a86db` | changeset's adding commit | 4 / 3 | "render AppAction.items from its declared type, without the two `as any` reads"; it added the pin `LayoutRenderer.appActionItems-6854.test.tsx` and ran the app-document census the Chinese changeset refers to | | objectstack-ai#6859 | `64d937c53` | `git log --grep` + changeset's adding commit | 5 / 2 | "correct the injected-editor commit justification, and pin what actually happens (objectstack-ai#6859)" | | objectstack-ai#6864 | `503cd8b89` | changeset's adding commit | 5 / 4 | "aggregate()'s spec-shape branch refuses the analytics branch's `filter` / `field` / `function`" | | objectstack-ai#6896 | `b0d308da9`; "the maintainer ruling of 2026-08-31"; runtime text `RETIRED (ADR-0049) —` | `git log --grep` + changeset's adding commit | 18 / 10 | "retire ChartDataSeries.data, correct categories' prose (objectstack-ai#6896)" | | objectstack-ai#6951, ruling A1 (`TextSchema.value`) | `5ad86ddee`; runtime text `RETIRED (ADR-0049) —` | `git log --grep` + changeset's adding commit | part of 16 / 7 | "retire TextSchema.value as an ADR-0049 tombstone (objectui#6951 A1 / objectui#7016)" | | objectstack-ai#6951, ruling B1 (`TreeViewSchema.data`) | `16a725f96`; runtime text `RETIRED (ADR-0049) —` | `git log --grep` + changeset's adding commit | part of 16 / 7 | "retire TreeViewSchema.data as an ADR-0049 tombstone (objectui#6951 B1)" | ## Special cases (the judgement calls) 1. **objectstack-ai#5518, `StudioDesignSurface`'s nav inspector.** "is objectui#5518, deliberately left out of objectstack-ai#4881's scope" becomes "is a follow-up card's question, deliberately left out of objectstack-ai#4881's scope". Nothing lands it (the fallback read is still there) and no successor is recorded in history, so the card is named by role. 2. **objectstack-ai#5738 "stand-down 3", and objectstack-ai#5758.** The finding (RLS and flow conditions are not row surfaces) was recorded on the dead Phase-0 corpus-sweep card, not in a commit. `702c48a62` is that sweep's landing and the squash of PR objectstack-ai#5758, but it is a one-line `plugin-form/README.md` edit that says nothing about a stand-down, so it cannot carry the finding (review `5861306588`). The card is therefore named by role, with the sha only to locate it: "(objectui#5738 stand-down 3)" becomes "(stand-down 3 on the corpus-sweep card behind `702c48a62`)" in the `conditionScope.ts` file docblock and in `7727-conditional-formatting-record-scope.md`, and the `sharing_rule` doc of `CONDITION_SCOPE_BY_METADATA_TYPE` reads "a stand-down 3 surface of the corpus-sweep card behind `702c48a62`". `rowPredicateCanon.ts` is different: "(the objectui#5738 corpus sweep, PR objectstack-ai#5758's recipe)" becomes "(the `702c48a62` corpus sweep's recipe)", and that commit's message does carry the recipe (the `detectNonCanonicalRowSpelling` oracle); the review found it correct. 3. **objectstack-ai#5221, `consoleServerAction.ts`.** "precedence — objectui#5221 escalates it" becomes "precedence — the card behind `053fdc8f9` escalates it": the escalation lived on the card, and no later ruling on that precedence is in history. 4. **objectstack-ai#5401 and objectstack-ai#5505.** In `visibilityDiagnostic.ts`, "(objectui#5401 → objectstack-ai#5454)" becomes "(objectui#5454)": the dead predecessor goes, the live successor the sentence already named stays. In `data-table.tsx` and `5926-empty-action-visible-when.md`, "objectui#5401 / objectstack-ai#5505 closed for `record:alert`" becomes "`c86185eb5` closed for `record:alert`": `c86185eb5` is the squash of PR objectstack-ai#5505, so the card / PR pair is one landing. 5. **"that card" after a re-point.** Where the next words leaned on the dead card, they were repaired minimally: "on the flag that card was not about" becomes "that change was not about" (`MarketplacePackagePage.tsx`, `gate-listlocalinstalls-marketplace-5620.md`); "The card's complaint was" becomes "The complaint it answered was" (`StudioDesignSurface.tsx`); "is that card's to declare, not this one's to guess" becomes ", the caller's to declare, not this list's to guess" (`ConditionBuilder.tsx`'s `REFERENCE_ROOTS`); "belongs to objectui#6296" becomes ", which `88b15fddc` added" (`6293-conditionbuilder-reference-value.md`); "the unstaffed state objectui#5414 asks to surface" becomes "the unstaffed state `77f846a8b` surfaces"; "is not what objectui#5414 reports" becomes "is not what `77f846a8b` fixes". 6. **Rulings by date.** "(objectui#5709 ruling)" becomes "(maintainer ruling 2026-08-23)" in the objectstack-ai#5709 changeset (own card) and "(the 2026-08-23 ruling; ...)" in `validate.ts`; "whose objectui#5709 ruling states the constraint" becomes "whose 2026-08-23 ruling states" in `kanban-quick-add.ts`; "ruled LIVE by objectui#6896 (maintainer ruling 2026-08-31, prose follows machine)" becomes "ruled LIVE by the maintainer ruling of 2026-08-31 (prose follows machine)" in `ChartRenderer.tsx`, and `8650-chart-foreign-dialect-retired.md`'s "ruled live by objectui#6896" becomes "ruled live by the maintainer ruling of 2026-08-31". 7. **"Phase 2" wording.** "the warning objectui#5741 deleted" becomes "the warning Phase 2 (`83fe6e741`) deleted" in `celAuthoring.ts`, so the next sentence's "That ruling" keeps its antecedent; "objectui#5741 Phase 2 retired" becomes "Phase 2 (`83fe6e741`) retired" in `ConditionBuilder.tsx` and `8167-conditionbuilder-mount-scope.md`; `layout.ts`'s "objectui#6951 (maintainer ruling A1, 2026-09-04) decided it" becomes "maintainer ruling A1 (2026-09-04, `5ad86ddee`) decided it". 8. **Own-card pointers that needed a word.** `dashboard-table-header-one-spelling-5425.md`: "the defect class objectui#5425 rules out" becomes "the defect class this change rules out". `6757-global-search-notifications-renderers.md` and the two objectstack-ai#6951 changesets: the parenthesis opened on its own card, so the line break moved with it ("page blocks.", "is RETIRED" then "(maintainer ruling ...)"). `6854-layout-renderer-retired-onclick.md`: "(objectui#6854, maintainer ruling ...)" becomes "(the maintainer ruling ...)". 9. **The runtime strings.** Only the listed text moves in each (RECORD below stands for the interpolated canonical root). | file | member | before | after | |:--|:--|:--|:--| | `types/src/zod/complex.zod.ts` | `DashboardConfigSchema.aria`, `error` | "RETIRED (objectui#5852) — `aria` is no longer part of DashboardConfig; ..." | "RETIRED (ADR-0049) — `aria` is no longer part of DashboardConfig; ..." | | `types/src/zod/complex.zod.ts` | `DashboardConfigSchema.aria`, `.describe()` | "RETIRED (objectui#5852) — the `{ label, description }` spellings ..." | "RETIRED (ADR-0049) — the `{ label, description }` spellings ..." | | `types/src/zod/data-display.zod.ts` | `TreeViewSchema.data` (tombstone) | "RETIRED (objectui#6951) — `data` is no longer part of TreeViewSchema; ..." | "RETIRED (ADR-0049) — `data` is no longer part of TreeViewSchema; ..." | | `types/src/zod/data-display.zod.ts` | `ChartDataSeriesSchema.data` (tombstone) | "RETIRED (objectui#6896) — `ChartDataSeries.data` was never read: ..." | "RETIRED (ADR-0049) — `ChartDataSeries.data` was never read: ..." | | `types/src/zod/layout.zod.ts` | `TextSchema.value` (tombstone) | "RETIRED (objectui#6951) — `value` is no longer part of TextSchema; ..." | "RETIRED (ADR-0049) — `value` is no longer part of TextSchema; ..." | | `types/src/zod/data-display.zod.ts` | `TreeViewSchema.nodes` | "... no presence rule exists — objectui#6951 B1). ... the `data` fallback spelling was retired by objectui#6951 (the registration's ..." | "... no presence rule exists). ... the `data` fallback spelling was retired (the registration's ..." | | `types/src/zod/layout.zod.ts` | `TextSchema.content` | "... its `value` fallback spelling was retired by objectui#6951)" | "... its `value` fallback spelling was retired)" | | `app-shell/src/views/metadata-admin/celAuthoring.ts` | the `metadata-layer-root` advisory in `rowCanonAdvisory` | "... binds the record as RECORD and nothing else (objectui#5741). The CEL scope ..." | "... binds the record as RECORD and nothing else. The CEL scope ..." | 10. **What follows the tombstone strings, and nothing else in it.** The literal anchors on the old text in the six pinning tests: `dashboard-config.test.ts` (`/RETIRED \(objectui#5852\)/` becomes `/^RETIRED \(ADR-0049\) — /`; the "delete the key" remedy anchor stays), `tree-view-data-retired-6951.test.ts` and `text-value-retired-6951.test.ts` (the full `GUIDANCE` literal's opening and the `describeOf` anchor; `PRESCRIPTIVE` stays), `chart-inline-data-retired.test.ts` (three anchors; the `xAxisKey` and chart-level `data` remedy anchors stay), `chart-data-model-7113.test.ts` and `chart-series-keys-7546.test.ts` (one anchor each). The two changeset quotes (`6951-text-value-retired.md`, `6951-tree-view-data-retired.md`, frontmatter byte-identical) and the two `content/docs` quotes (`text.mdx`, `tree-view.mdx`) open `RETIRED (ADR-0049) —`. Per the ruling these follow the changed string; they do not widen the card's classes. No test, doc or changeset quotes either `aria` string (whole-tree search after the amendment: the source line is the only hit). ## Held **By the serial rule: nothing.** The open-PR list was read at the start (11 open) and re-read for each round; at round 2 there are 9 open besides this one and the release PR: objectui#10873, objectstack-ai#10871, objectstack-ai#10870, objectstack-ai#10852, objectstack-ai#10821, objectstack-ai#10780, objectstack-ai#10777, objectstack-ai#10714 and objectstack-ai#10278. In round 1, two of them touched files this PR edits: objectui#10821 (`types/src/objectql.ts`, `types/src/zod/objectql.zod.ts`) and objectui#10714 (`types/src/data-display.ts`, `types/src/layout.ts`, `types/src/zod/data-display.zod.ts`, `types/src/zod/layout.zod.ts`). Each one's hunks (3 lines of context) were mapped onto the head through a line alignment of the PR's merge-base file: **none of the 22 lines this PR changes in those files lies inside, or beside, any hunk.** objectui#10871 (new since) touches `celAuthoring.ts` and `metadata-admin/i18n.ts` in disjoint hunks (review `5861306588`), and no open PR touches a file round 2 edits. Trial merges of each open PR head with this head (`git merge-tree --write-tree`): clean for objectstack-ai#10873, objectstack-ai#10871, objectstack-ai#10870, objectstack-ai#10852, objectstack-ai#10780, objectstack-ai#10777 and objectstack-ai#10714; objectstack-ai#10821 (`24bcb0035`) and objectstack-ai#10278 (`eab4c8e52`) conflict, but each conflicts identically against `main` alone, so the conflicts are not this PR's. PR objectstack-ai#5400 (Version Packages) regenerates and is not a hold. ## Changesets - `.changeset/10803-dead-citation-sweep-third-batch.md`, EMPTY frontmatter: the comment-only edits in 12 released packages; no published behaviour changes through them. Its list of citation forms now ends "or a live successor, and where nothing answers they name the card by role" (the review's optional nit), and it points at the second file for the runtime text. - `.changeset/10803-third-batch-runtime-strings.md`, `'@object-ui/types': patch` and `'@object-ui/app-shell': patch`. Its second sentence now reads "so no dead pointer becomes a commit: tombstones cite `ADR-0049` in its place, and every other pointer is simply dropped" (review `5861306588` fix 2, in the amendment's all-four wording). It names the four tombstones, all now opening `RETIRED (ADR-0049) —` (`TreeViewSchema.data`, `TextSchema.value`, `ChartDataSeriesSchema.data`, and `DashboardConfigSchema.aria`'s error and describe text), with no process clause about a TypeScript twin; then the two describe strings and the advisory. Nothing after a tombstone's dash moves, and no key, path, issue code, accept set, refusal or severity moves. ## Proof of prose-only (C4), against `main` `fab627ff9` - **Source.** Each of the 77 touched non-test `.ts` / `.tsx` files was parsed at `fab627ff9` (the `main` merged in, so the diff is exactly this PR's) and at this head with TypeScript 6.0.3's `createSourceFile` and re-printed by `createPrinter({ removeComments: true })`: 73 of 77 prints are identical, and the other 4 (`celAuthoring.ts`, `complex.zod.ts`, `data-display.zod.ts`, `layout.zod.ts`) are equal after exactly the 9 listed string substitutions are applied to the `main` print (each matched once): the 4 tombstone strings in 5 literals, the 3 describe-string deletions and the advisory's. 0 parse diagnostics. Lit controls on the same instrument: dropping "(ADR-0049)" from the `TextSchema.value` string moves the print; re-spacing a comment does not. - **Changesets.** The frontmatter block of every one of the 47 edited changesets is byte-identical at `fab627ff9` and this head (47 of 47); the overwrite gate below agrees. - **Scope of the diff against `main`:** 134 files, +287 / −237: 47 edited and 2 new changesets, 77 non-test source files, the 6 pinning tests and the 2 `content/docs` pages. ## Gates, on this head `dd37e35d2` Each line is the gate's own verdict and exit code, captured by redirect-then-`$?`. - `node scripts/check-changeset-presence.mjs`, exit 0: "83 source file(s) of 12 released package(s) changed, and this change declares 2 changeset(s): .changeset/10803-dead-citation-sweep-third-batch.md, .changeset/10803-third-batch-runtime-strings.md." (83 = the 77 sources and the 6 tests under `packages/types/src`). - `pnpm changeset:check`, exit 0: "All workspace packages are in the changeset fixed group." / "No changeset declares a `major` bump." - `node scripts/check-changeset-overwrite.mjs` (report-only), exit 0: "2 changeset(s) added, 47 modified, 0 deleted"; `declared at base` equals `declares now` for 47 of 47. - `pnpm check:changeset-claims` (report-only), exit 0: born-false "Every one of those 9 address(es) either names the tree it was read from, or points at a line this change does not move"; self-contradiction "Every package declared across those 45 body(ies) is either not negated ..."; and the standing notice "92 pending changeset(s) describe a file this change touches". Read against the diff: a pending changeset quoting a replaced pointer would itself carry the dead number and so sit in the census; the only pending quotes of the four tombstone strings are the two edited here; and none of the words repaired beyond a pointer (**Special cases** 1, 3 and 5) occurs in any pending changeset. - `pnpm check:control-bytes`, exit 0: "check-control-bytes: OK (scanned 9113 tracked text file(s); skipped 85 binary)." Self-scan of the 134 changed files for C0 / DEL bytes: 0. - Also run: `pnpm check:new-line-citations`, "VERDICT new-cross-file-line-citations: 0 new citation(s), enforcement report-only -> exit 0"; governed-surface predicate over the 134 paths, exit 0, "NOT GOVERNED — 134 path(s) checked against 5 governed surface(s); none matched." (lit control `AGENTS.md`: exit 3). **Tests**, through the shared verify lock (`VERDICT command-exit 0`). Round 2, on this head: the six pinning files (`dashboard-config`, `tree-view-data-retired-6951`, `text-value-retired-6951`, `chart-inline-data-retired`, `chart-data-model-7113`, `chart-series-keys-7546`) and `tombstone-discriminator-agreement-9684`: `Test Files 7 passed (7)`, `Tests 144 passed (144)`. Round 1, on `e4bce25b8` (round 2 changed no other tested string): those seven plus `tree-view-data-optional-6939`, `undeclared-but-consumed-keys-6150`, `zod-mirror-parity`, `layout-default-jsdoc-7361` in `packages/types`, and `celAuthoring.fieldRuleVerdict-9318`, `recordScopeDataRoot-8166`, `ConditionalFormattingEditor` in `packages/app-shell`: `Test Files 14 passed (14)`, `Tests 393 passed (393)`. **Whole-tree search for other verbatim quotes of the four old strings** (tests, docs, examples, skills, apps): every hit is one of the source strings, the six anchors, the two changeset quotes or the two docs quotes, all updated. Remaining mentions of the old prefix are six `@ts-expect-error` comments in `text-value-retired-6951.test.ts` and `tree-view-data-retired-6951.test.ts` that describe the TypeScript face, not the runtime string; left as they are (see **Acceptance notes** 5). **Declared narrowing (per the dispatch: the named checks, not wider sweeps).** NOT MEASURED locally: the full suites and type-check of the 12 touched packages, and eslint. Reason: the comment-stripped syntax tree of 73 of the 77 touched source files is identical to `main` and the other 4 differ only by the listed string-literal edits; every test that quotes a changed string was found by search and run above. CI runs the full farm. ## Acceptance notes 1. **The remainder rides this card, unchanged (seat amendment `5860244997`, Q2 = A).** Of the 115 numbers PR objectui#10854's Acceptance notes item 1 lists, this PR carries the first 30 in ascending order plus objectstack-ai#6896 and objectstack-ai#6951, which that PR's release named. The other **83** are: objectstack-ai#6872 objectstack-ai#6879 objectstack-ai#6882 objectstack-ai#6887 objectstack-ai#6888 objectstack-ai#6889 objectstack-ai#6892 objectstack-ai#6905 objectstack-ai#6907 objectstack-ai#6921 objectstack-ai#6923 objectstack-ai#6924 objectstack-ai#6931 objectstack-ai#6940 objectstack-ai#6942 objectstack-ai#6958 objectstack-ai#6959 objectstack-ai#6962 objectstack-ai#6965 objectstack-ai#7004 objectstack-ai#7008 objectstack-ai#7023 objectstack-ai#7025 objectstack-ai#7036 objectstack-ai#7068 objectstack-ai#7069 objectstack-ai#7077 objectstack-ai#7079 objectstack-ai#7087 objectstack-ai#7088 objectstack-ai#7091 objectstack-ai#7097 objectstack-ai#7108 objectstack-ai#7177 objectstack-ai#7612 objectstack-ai#7620 objectstack-ai#7623 objectstack-ai#7658 objectstack-ai#7666 objectstack-ai#7667 objectstack-ai#7669 objectstack-ai#7678 objectstack-ai#7681 objectstack-ai#7682 objectstack-ai#7703 objectstack-ai#7704 objectstack-ai#7708 objectstack-ai#7804 objectstack-ai#7844 objectstack-ai#7853 objectstack-ai#7869 objectstack-ai#7874 objectstack-ai#7877 objectstack-ai#7926 objectstack-ai#7959 objectstack-ai#7967 objectstack-ai#7979 objectstack-ai#7980 objectstack-ai#8058 objectstack-ai#8060 objectstack-ai#8072 objectstack-ai#8127 objectstack-ai#8137 objectstack-ai#8204 objectstack-ai#8229 objectstack-ai#8248 objectstack-ai#8307 objectstack-ai#8408 objectstack-ai#9231 objectstack-ai#9241 objectstack-ai#9244 objectstack-ai#9365 objectstack-ai#9373 objectstack-ai#9375 objectstack-ai#9542 objectstack-ai#9553 objectstack-ai#9585 objectstack-ai#10117 objectstack-ai#10119 objectstack-ai#10120 objectstack-ai#10129 objectstack-ai#10132 #14026. None of them was touched here. 2. **The census instrument is blind to bare PR numbers, and so is the family list.** PR objectui#10854's census enumerated `objectui#N` and objectui URLs only, so a bare `#N` that answers 404 never entered the 115: this batch found two by reading its own sentences, objectstack-ai#5505 and objectstack-ai#5758, both the PRs whose squashes the sentence already cited, and folded them in (ruling `5861129870`, triage item 3). The printed instrument above counts a bare number only when the batch names it. ⇒ The next batch's census should first enumerate every distinct bare `#N` in the two in-scope classes, read each by REST (`issues/N` and `pulls/N`), and add the 404s to its number list before it counts. Until that is done the family pin is incomplete for bare numbers, and nothing here re-derives how many there are. 3. **Published text outside the two in-scope classes still names some of these numbers**, untouched by scope (another class, which the triage split did not scope here): `apps/console`'s `useApiDiscovery.ts` (non-test source of `@object-ui/console`, bare objectstack-ai#5286, not under `packages/*/src`), the `@object-ui/data-objectstack` README (objectstack-ai#6864) and the `@object-ui/plugin-detail` README (objectstack-ai#6464), `content/docs` (objectstack-ai#6896, and the `text.mdx` / `tree-view.mdx` "Retired" notes that name objectstack-ai#6951; only their verbatim message quotes moved here), and published `CHANGELOG.md` history (never re-addressed). Carrier: none. 4. **Filenames are not citations.** Pending changeset FILENAMES carry several of these numbers; they stay, as in PRs objectui#10707, objectstack-ai#10797 and objectstack-ai#10854. 5. **Test comments left as they are.** `text-value-retired-6951.test.ts` and `tree-view-data-retired-6951.test.ts` each keep three `@ts-expect-error` comments reading "RETIRED (objectui#6951)"; they describe the `?: never` TypeScript face, quote no runtime string, and tests are otherwise out of this card's classes. --- _Generated by [Claude Code](https://claude.ai/code/session_014mXUNuFomfj24w7s1pZzhN)_ --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #9271. ⛔ Deliberately NOT
Fixes— this closes the proximate half only; the structural half named at the bottom stays open on the card.What was measured
⭐ The blind window is 116 consecutive
ci.ymlpush runs onmain— runs 17230 → 17738,2026-09-11T23:17:11Z→2026-09-14T07:09:07Z, 2 days 9 h 42 m.Test (coverage)isfailurein 116 of 116. Last run whose coverage lane was green: run 17227 (a94e4d073, 2026-09-11T21:27:02Z), which also published the onlycoverage-reportartifact in the window.⛔ objectui#8479's 66-run streak is NOT this streak. Population: the 500 most recent
branch=main, event=pushruns of workflow 223145786 (runs 15611 → 17738, from 2026-09-07T06:45Z). It holds 221 successes, the newest being run 17227 — so the 2026-09-07 streak healed and this is a second, later one. ⇒ the card's written re-grade trigger ("longer than roughly a week") does not fire;priority:p2stands on duration.The break in the chain, read rather than inferred
⭐ The blobs are not missing. On red run 17738 all four
coverage-blob-Nartifacts exist and are live (7.8–8.7 MB each); the green run 17227 carries the same four pluscoverage-report.blobs=skippedin the sentinel is the counting step being skipped, not an absent blob.The break is that
coverage-reportgates every step onneeds.test-coverage.result == 'success'. One timed-out row reds a shard, so checkout, download, blob-count and merge are all skipped — and the merge is the only placecoverage.thresholdsis enforced, because the shard legs override all four to0. Verbatim from run 17738:Instrumentation isolated as the single variable
The same-commit CI comparison could never settle this:
test-coverageisif: github.event_name == 'push'andtestisif: github.event_name != 'push', so instrumentation and trigger event are confounded by construction. Isolated locally instead — same tree, same container, same command,--coveragethe only difference:db6aa19a9The five rows that blow the budget under instrumentation are exactly the five CI sites in those files, and the ordering corroborates: the marginal row (15.0 s locally) is the one that fires 11× in CI, while the 24–25 s rows fire 64–94×.
Same instrumented command, same container, two trees, rows paired by name:
check-i18n-dead-keysrows present on BOTH treesa94e4d073(last green)db6aa19a9(today)⇒ the shared rows did not slow down at all. All three of that file's timeout sites are rows that did not exist at the last green run, added 2026-09-12; and the single most frequent site overall,
check-object-metadata-write-doors.test.ts, is an entire file that landed 2026-09-12T04:00Z. The tracked-file corpus grew only 3.2% (7492 → 7733) across the window, nowhere near enough to matter.The repair, and what it does not weaken
A lane-scoped
--testTimeout=60000on the instrumented shard command — 4× the uninstrumented budget, 2.4× the heaviest row observed under instrumentation. ⛔ Not a per-row bump: the wandering site is exactly why it is applied to the lane.vitest.config.mtskeepstestTimeout: 15000, so the uninstrumented lane — the one that actually runs before a merge — is untouched.gates_weakened: NONE.test-coveragehastimeout-minutes: 40against observed shard wall clocks of 698–1053 s.Evidence the gate is restored
⭐ A green shard is not evidence a report was produced, so here is the report and the thresholds. CI cannot host this demonstration — the coverage lane runs only on
pushto[main, develop], never on a PR — so it is reproduced locally over the five CI timeout-site files:--testTimeout=15000--testTimeout=60000The merged report from the passing leg, produced by
ci.yml's own merge command:⭐ Firing control that the thresholds are genuinely enforced and not merely printed — same blobs, same command, floor raised above the measured value:
⛔ The half this PR does NOT fix — it needs a decision above this card
The coverage lane runs only on push to
main/develop. An author adding a 6-second repo-sweep row cannot see this lane before merging; the first signal is after the row is already onmain, on a red that blocks nothing. That is why the class recurs — this file's own comment records objectui#8545 pricing two earlier episodes at 84 and 87 consecutive unevaluated pushes, and this one ran to 116.⇒ A budget alone postpones the next episode, it does not prevent it. Making the lane visible pre-merge is the structural fix, and the card rules out making it blocking — so the fork is the maintainer's, not this PR's.
Verification
pnpm exec vitest run --project unit scripts/__tests__/— 157 files / 4625 tests passed, exit 0 (this is the surface holding every gate that readsci.yml).node scripts/check-changeset-presence.mjs— exit 0, "no changeset is owed".node scripts/check-governed-queue-guard.mjs --test .github/workflows/ci.yml— NOT GOVERNED (control:AGENTS.mdreturns GOVERNED, exit 3).🤖 Generated with Claude Code
https://claude.ai/code/session_013VGeMu3p6qEFWR6K6GGLaW
Generated by Claude Code