Repository navigation
fix(types,fields): correct three false spec-alignment claims and pin the real boundary - #7510
Merged
Merged
Conversation
…the real boundary
Three doc comments asserted that the installed `@objectstack/spec` declares a
key it in fact REFUSES BY NAME. Measured on 17.2.0, each with a control that
accepts the same payload minus the key:
SelectOptionSchema.description unrecognized_keys (shape is exactly
{label,value,color,default,visibleWhen})
FieldSchema.rows unrecognized_keys (all four of
textarea/markdown/html/richtext)
The keys stay declared and stay consumed (objectui#6153 LookupField searches an
option's `description`; objectui#6140 RichTextField reads `rows`). Only the
attribution was wrong, and it mattered: FieldSchema routes a select field's
`options` through the strict option schema, so authoring `description` on an
option fails the WHOLE field with 422 INVALID_METADATA. The comments were
inviting that write; they now name the boundary instead.
A false canonical claim is a planted premise for the next agent — the failure
class scripts/check-spec-symbol-derivation.mjs exists to prevent. It could not
see these: it reads only the comment block attached to a DECLARATION, and
validates a citation only at SYMBOL granularity. Both claims sit on MEMBERS and
dangle at the member (`SelectOptionSchema` is a live export; `.description` is
not a key of it).
No type, schema, export or runtime path changes.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EMrWaQw3XS5DxTHxp4yRyC
Contributor
✅ Console Performance Budget
The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it. 📦 Bundle Size Report
Size Limits
|
os-project-manager
marked this pull request as ready for review
September 3, 2026 15:45
os-project-manager
deleted the
claude/issue-7014-select-option-shapes
branch
September 3, 2026 16:01
This was referenced Sep 3, 2026
baozhoutao
pushed a commit
that referenced
this pull request
Sep 6, 2026
…spec `content/docs/fields/lookup.mdx` told readers that `SelectOptionMetadata`'s option `description` is "aligned with `@objectstack/spec`'s `SelectOptionSchema.description`". Re-measured today against the installed `@objectstack/spec` 17.2.0, that schema declares exactly `color, default, label, value, visibleWhen` and refuses `description` by name with `unrecognized_keys`; `FieldSchema` routes a field's `options` through it, so the sentence was inviting a write that fails the whole field with a 422. The page now carries the same attribution PR #7510 gave the published JSDoc on `SelectOptionMetadata.description`: an objectui-side read-model extension the spec refuses by name, declared because `LookupField` consumes it, and never to be written into an authored object document. The key itself stays declared and stays consumed. The still-unconsumed `.changeset/6140-field-metadata-rows-option-description.md` carried the same false claim on both keys it declares, scheduled to ship into the CHANGELOG. Corrected in place as a deliberate prose correction, which `scripts/check-changeset-overwrite.mjs` documents as its case 2 and reports without failing; every package name the declaration carried at base is unchanged, so nothing is lost from it. Docs and changeset prose only — no type, schema, export or runtime path moves. Settles objectui#7537. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MM7kaS4dPpYHV5BsMyu4tQ
baozhoutao
pushed a commit
that referenced
this pull request
Sep 7, 2026
…in comments (objectui#7995) `check-spec-symbol-derivation` read only the comments of `packages/*/src`, so a false `@objectstack/spec` attribution written as prose in `content/docs/**` was judged by nothing. objectui#7537 is the receipt: PR #7510 corrected three JSDoc copies of one such claim and a fourth copy in `content/docs/fields/lookup.mdx` shipped untouched, because no gate reads it. Rule 4 at member granularity asks only whether a name the prose spells exists in the spec, which needs no declaration, no tie and no claim phrase. So its scan surface widens to `content/docs/**` and the rule itself does not move: the citation grammar is factored into one `memberCitationsIn`, and the TypeScript comment scanner was refactored ONTO it rather than having a second copy written beside it. A comment BLOCK is the scope on one side, a markdown PARAGRAPH on the other; everything that decides a verdict is shared. Census taken BEFORE enforcement, on 411a132 against `@objectstack/spec@17.3.0`: 184 documentation pages, 32 mentioning the spec, 183 raw `Symbol.member` citations, 5 naming a spec export with a knowable member set, 3 surviving proximity and same-sentence, 3 resolving, 0 dangling. Zero corrections, zero waivers, no ledger. Skipping fenced code moves the raw count 183 -> 128 and leaves the judged population identical, so there is no fence rule. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FhBNJcLRZLe8M87VcUgpKr
akarma-synetal
pushed a commit
to akarma-synetal/objectui
that referenced
this pull request
Sep 9, 2026
…spec (objectstack-ai#7994) * docs(fields): attribute option `description` to objectui, not to the spec `content/docs/fields/lookup.mdx` told readers that `SelectOptionMetadata`'s option `description` is "aligned with `@objectstack/spec`'s `SelectOptionSchema.description`". Re-measured today against the installed `@objectstack/spec` 17.2.0, that schema declares exactly `color, default, label, value, visibleWhen` and refuses `description` by name with `unrecognized_keys`; `FieldSchema` routes a field's `options` through it, so the sentence was inviting a write that fails the whole field with a 422. The page now carries the same attribution PR objectstack-ai#7510 gave the published JSDoc on `SelectOptionMetadata.description`: an objectui-side read-model extension the spec refuses by name, declared because `LookupField` consumes it, and never to be written into an authored object document. The key itself stays declared and stays consumed. The still-unconsumed `.changeset/6140-field-metadata-rows-option-description.md` carried the same false claim on both keys it declares, scheduled to ship into the CHANGELOG. Corrected in place as a deliberate prose correction, which `scripts/check-changeset-overwrite.mjs` documents as its case 2 and reports without failing; every package name the declaration carried at base is unchanged, so nothing is lost from it. Docs and changeset prose only — no type, schema, export or runtime path moves. Settles objectui#7537. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MM7kaS4dPpYHV5BsMyu4tQ * docs(fields): drop the version literal from the option `description` note `scripts/__tests__/doc-version-claims.test.ts` refuses a version literal on the surfaces it scans, and the sentence added by the previous commit carried one: "Measured on the installed `@objectstack/spec` 17.2.0". The pin is right — a version frozen in prose is the objectui#3645 shape, where a spec range sat in 36 READMEs across thirteen majors because no review step ever asked whether it was still true. The literal is deleted rather than added to KNOWN_CLAIMS, which is what the pin's own message asks for. The sentence now reads "Measured on the installed `@objectstack/spec`"; the version of that reading lives in the pull request body and on the card, where it is dated and cannot silently go stale. Every other byte of the sentence is unchanged, so the attribution the card asked for is intact. The changeset corrected in the previous commit keeps its literal: the pin's SCAN_ROOTS are content/docs, packages/*/README.md and skills, so `.changeset` is outside its population — and a changeset is a dated release note about a measurement already taken, which is the one place a version literal cannot rot. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MM7kaS4dPpYHV5BsMyu4tQ --------- Co-authored-by: Claude <noreply@anthropic.com>
akarma-synetal
pushed a commit
to akarma-synetal/objectui
that referenced
this pull request
Sep 9, 2026
…in comments (objectui#7995) (objectstack-ai#8370) * fix(gates): judge spec member citations in published prose, not only in comments (objectui#7995) `check-spec-symbol-derivation` read only the comments of `packages/*/src`, so a false `@objectstack/spec` attribution written as prose in `content/docs/**` was judged by nothing. objectui#7537 is the receipt: PR objectstack-ai#7510 corrected three JSDoc copies of one such claim and a fourth copy in `content/docs/fields/lookup.mdx` shipped untouched, because no gate reads it. Rule 4 at member granularity asks only whether a name the prose spells exists in the spec, which needs no declaration, no tie and no claim phrase. So its scan surface widens to `content/docs/**` and the rule itself does not move: the citation grammar is factored into one `memberCitationsIn`, and the TypeScript comment scanner was refactored ONTO it rather than having a second copy written beside it. A comment BLOCK is the scope on one side, a markdown PARAGRAPH on the other; everything that decides a verdict is shared. Census taken BEFORE enforcement, on 411a132 against `@objectstack/spec@17.3.0`: 184 documentation pages, 32 mentioning the spec, 183 raw `Symbol.member` citations, 5 naming a spec export with a knowable member set, 3 surviving proximity and same-sentence, 3 resolving, 0 dangling. Zero corrections, zero waivers, no ledger. Skipping fenced code moves the raw count 183 -> 128 and leaves the judged population identical, so there is no fence rule. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FhBNJcLRZLe8M87VcUgpKr * fix(gates): make the member-citation finding read in both numbers (objectui#7995) The count line read "1 passage cite"; the singular arm now carries the verb. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FhBNJcLRZLe8M87VcUgpKr --------- Co-authored-by: Claude <noreply@anthropic.com>
jinyitao123
referenced
this pull request
in jinyitao123/objectui
Sep 16, 2026
…sserting a refusal the spec no longer performs (#9588) Fixes #7635 Five shipped doc comments assert that `@objectstack/spec` REFUSES `rows` and `options[].description` BY NAME. It **declares** both. This corrects the prose; it changes no runtime behaviour, type surface or export. ## The premise the card was parked on is dead — re-derived, not inherited The card calls itself 「bump-blocked」 and says 「The repo is still on 17.2.0 — so nothing is broken *today*」. Measured on `origin/main`'s `pnpm-lock.yaml`: there is exactly **one** `@objectstack/spec` package entry and it is **17.4.0**; every one of the 29 declared ranges resolves to it. The installed artifact agrees (`node_modules/@objectstack/spec/package.json` = 17.4.0). The bump landed and went past the version the card names, so the false comments are false on `main`, now.⚠️ One correction to the dispatch's own reading: the histogram `24x17.0.0, 2x17.1.0, 1x17.2.0, 1x17.3.0, 7x17.4.0` is the **specifier-range** histogram (what `package.json` files ask for), not resolved versions. No `@objectstack/spec` resolves below 17.4.0. The conclusion is unchanged and strictly stronger. ## What the contract actually holds (measured against installed 17.4.0, not the changelog) | | measured | |---|---| | `SelectOptionSchema` keys | `color, default, description, label, value, visibleWhen` — six, **including `description`** | | option `description` | ACCEPTED as a string; empty string valid; non-string answers `invalid_type` | | field whose `options` carry it | parses whole | | `rows` on textarea/markdown/html/richtext | ACCEPTED, integer `>= 1` (`0` answers `too_small`, `1.5` answers `invalid_type: expected int`) | | `rows` on `text` / `number` | refused — but by a **cross-field refinement** naming the key, ⛔ NOT `unrecognized_keys` | | `icon` / `disabled` on an option | still refused BY NAME — the live half | | `toolbar` / `preview` / `minHeight` / `maxHeight` | still refused BY NAME — the card's fence **holds** | The type-gating nuance is load-bearing and the old prose could not express it: "declared" does not mean "declared everywhere", and the refusal for the wrong field type arrives through a different channel than the one the old comments named. ## The census — the card's "three comments" is not right Re-derived from PRs #7510 / #7520 rather than trusted: - **#7510** rewrote **three** docblocks, all in `packages/types/src/field-types.ts` (`MarkdownFieldMetadata.rows`, `HtmlFieldMetadata.rows`, `SelectOptionMetadata.description`) plus the `LookupField.optionDescription.test.tsx` header. **All four are false today.** - **#7520** rewrote **one** comment, in `packages/app-shell/src/views/DashboardView.tsx` — about `title`, not about either of this card's keys. ⛔ I did not touch it, for two measured reasons: `DashboardSchema` **still** refuses root `title` by name at 17.4.0 (so the claim is true), and #7520's text no longer exists anyway — objectui#7509 replaced it wholesale when it retired the legacy `title` read. ⇒ the real count is **four** false sites from those two PRs, not three, and the third PR-#7520 site is **not** one of them. Two further sites in the same family were falsified by the repair itself and are fixed here: the `SelectOptionMetadata` interface docblock (which listed `description` among the by-name refusals) and the `RichtextFieldMetadata` cross-reference registered on the card by comment `5576403316`. Plus `packages/types/src/select-option.ts`, named by the pin's own header. ## ⭐ A gate DOES read these sites — the card's framing is out of date The card says 「Nothing goes red」 and blames `check:spec-symbols`. That specific claim is **correct** — I ran it, it is green, and its member rule passes precisely because these citations now name keys the symbol *does* declare. But `check:installed-pin-claims` (`scripts/check-installed-spec-pin-claims.mjs`, objectui#8924) landed **after this card was filed** and it reads two of these very sites — it had them ledgered as known-stale debt, with reasons written in anticipation of this repair (*"re-parse the schema before moving the number"*). Repairing the prose made it go **red**, by design: ``` FAIL LEDGER is stale: packages/fields/src/widgets/LookupField.optionDescription.test.tsx no longer carries a drifting @objectstack/spec 17.2.0 claim. Delete the entry in the same change that repaired the site. FAIL LEDGER is stale: packages/types/src/field-types.ts ... ``` Both entries are deleted here, as that gate's both-direction ratchet requires. Taking Zone 3's *"if a comment can be replaced by something a gate CAN read, that is better than better prose"* literally, the two repaired claims are written as **single-line** claims about the installed pin, which is the shape the gate recognises. They therefore moved out of the ledger and into the checked population — `23 -> 25 at the pin`, `52 -> 50 ledger entries`, `stale 45 -> 43`. They now go red at the next bump instead of quietly lying. The other three sit on facts no instrument reads, and say so rather than reading as live (AGENTS.md #9). ## ⭐ An unreleased changeset would have shipped the same falsehood `check:changeset-claims` flagged that `.changeset/7014-select-option-spec-claim-correction.md` — PR #7510's own changeset, still **pending** — names a file this change edits. Reading the paragraph as that gate asks: its dated 17.2.0 measurements are fine, but its present-tense guidance is now false and harmful — it tells authors that writing `description` on an option *"makes `PUT /api/v1/meta/object/:name` fail the **whole field** with a 422"*, and that the comments *"now say these are objectui-side read-model extensions that must never reach authored object metadata"*. That body publishes **verbatim into the CHANGELOG at the next release** — the same release as this change's own entry, which says the opposite. Corrected in place, frontmatter untouched, per the precedent that gate names; `check:changeset-overwrite` records the deliberate modification (report-only, its case 2). This is the only site where the defect would have escaped the repo. ## Gates Hand-derived from this repo's `package.json` and `.github/workflows/` — `dispatch-gates.mjs` **refuses** for objectui paths by design (it reads the objectstack tree), as the dispatch predicted. Exit codes captured to a file before reading, never through a pipe. | gate | exit | verdict line | |---|---|---| | `check:installed-pin-claims` | 0 | `80 recognised claim site(s) - 25 at the pin, 50 ledger entr(ies)` | | `check:spec-symbols` | 0 | `nothing cites a key its spec symbol does not declare` | | `check:changeset-presence` | 0 | `4 source file(s) of 2 released package(s) ... declares 1 changeset(s)` | | `check:changeset-claims` | 0 | report-only; its one finding is answered above | | `check:changeset-overwrite` | 0 | records the deliberate #7014 correction (report-only) | | `check:control-bytes` | 0 | `scanned 7739 tracked text file(s)` | | `check:new-line-citations` | 0 | `0 new citation(s)` | | `check:comment-mask-corpus` | 0 | 1 pre-existing disagreement, within the ceiling objectui#7882 holds open — not from this diff | | tests | 0 | `Test Files 193 passed (193) / Tests 4561 passed (4561)` | | `type-check` (`types`, `fields`) | 0 | both `Done` | Tests cover `packages/types/`, the `LookupField` site, and `scripts/__tests__/check-installed-spec-pin-claims.test.ts` — owed separately because this diff edits that gate script. Run from the repo **root** (`pnpm exec vitest run <paths>`); the `pnpm --filter PKG exec vitest` form is refused by the #3378 guard and is a false green. Heavy runs went through the shared verify lock. `type-check` first failed with `TS2307` on an unbuilt dependency closure — built `@object-ui/fields^...` / `@object-ui/types^...`, then both passed. Verified the repair reaches the **published** surface: after `pnpm --filter @object-ui/types run build`, `dist/field-types.d.ts` carries the corrected sentence and no `dist/*.d.ts` still says `REFUSES \`rows\` BY NAME`. The two surviving `NOT a spec key` strings in `dist/select-option.d.ts` are the `icon` / `disabled` docblocks, which I measured as genuinely still refused. ## Acceptance notes - ⛔ `packages/types/src/data-display.ts` — out of surface (batch sibling objectui#9256). Not reached; no comment repair led there. - ⛔ No runtime, type-surface or export change. Every assertion in the repaired files passes unchanged before and after — which is the point: nothing mechanical was watching these sentences, and that is why they rotted. - `.changeset/` was in surface because published bytes move: docblocks under `packages/types/src` ship in `dist/*.d.ts`. - Out-of-scope findings (for the seat to file) are enumerated in the `os-dev-report` comment on #7635. --- 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01XeoGH6X7MtfbjcRDscyXi1 --- _Generated by [Claude Code](https://claude.ai/code/session_01XeoGH6X7MtfbjcRDscyXi1)_ Co-authored-by: Claude <noreply@anthropic.com>
akarma-synetal
pushed a commit
to akarma-synetal/objectui
that referenced
this pull request
Sep 28, 2026
…cks name ten objectui issues that answer 404 (objectui#10771) (objectstack-ai#10797) Fixes objectstack-ai#10771 Clause-②: no Dispatched implementation of the `domain:ui` seat objectstack-ai#1 claim (comment `5856991289`) on objectui#10771, session `https://claude.ai/code/session_01DuWo5bdP9SdVebamn99GGk`. Citations only: no sentence's claim moves, no code or type token moves, and every edited pending changeset's frontmatter is byte-identical. The one site round 1 left open, the runtime message string in `assertObjectMetadataWritable`, was repaired in a patch round (commit `c050ffe05`) under the seat surface amendment (comment `5857374350` on objectui#10771), so this PR closes the card. ## Premise, re-measured - REST `GET /repos/objectstack-ai/objectui/issues/N`: all ten (objectstack-ai#5793, objectstack-ai#6943, objectstack-ai#7014, objectstack-ai#7627, objectstack-ai#7638, objectstack-ai#7753, objectstack-ai#7791, objectstack-ai#7878, objectstack-ai#8057, objectstack-ai#9230) answer 404. Lit control: objectui#10533 answers 200. - Census instrument: `git grep -nE` over the tree for `(objectui#|#|issues/)` followed by one of the ten and a non-digit, each hit classified by its path (changeset = `.changeset/`; src-nontest = `packages/*/src/` minus `.test.`, `.spec.`, `__tests__/`, `test/`, `tests/`). Lit control, same instrument over objectstack-ai#7632 and objectstack-ai#7714: 64 lines, 5 of them changeset and 20 src-nontest. No hit is a hex colour (the same pattern followed by a hex letter: 0). - At the merge base `dac022c4e`: 204 lines. 20 changeset lines in 17 files, 38 src-nontest lines in 17 files, and out of scope 81 test, 28 scripts, 6 `.github`, 1 governed, 30 other. The card's "20 pending changesets" is 20 lines in 17 files, the same population the PM counted as 17 files. The card's own base `63835d998f` reads the same 20 / 17 / 38 / 17. - All 17 changesets are still pending: no `CHANGELOG.md` names any of the ten (control: `packages/core/CHANGELOG.md` carries 140 `objectui#` mentions). ## Citation form - The replacement is the 9-character backticked sha of the commit on `main` that landed the change the sentence rests on, the PR objectui#10707 / objectui#10766 form. Commits, not PRs: PR 7637 (the objectstack-ai#7627 landing) answers 404 itself. Every replacement sha is an ancestor of the base (`git merge-base --is-ancestor`, exit 0 for each, which proves itself) and `git rev-parse --short=9` returns the same 9 characters for each. - **A changeset's pointer to its OWN issue is dropped, not replaced.** `.changeset/config.json` names `@changesets/cli/changelog`, whose `dist/changelog.mjs` re-exports `@changesets/changelog-git`, and that generator prefixes every released entry with `changeset.commit.slice(0, 7)`, the commit that added the file. The landing sha is therefore already on the released line. PR objectui#10707 did the same for its two retirement changesets. Where a changeset cites ANOTHER change, the landing sha replaces the number. - The dated-note form is not used: no edited sentence became false, only its pointer died. This is the prose-only correction the triage also allows. - Source docblocks cite the landing sha at every site, including sites the landing commit itself wrote: a source comment carries no automatic hash the way a released changeset entry does. ## Number to landing commit | dead number | landing commit | evidence | |:--|:--|:--| | objectstack-ai#5793 | `111741454` | "gate @objectstack/spec range floors against published symbols" (PR 6076). It added `.changeset/5793-spec-range-floors.md` (`git log --diff-filter=A`) and `scripts/check-spec-range-floors.mjs`, whose remedy text the 7122 changeset quotes. | | objectstack-ai#6943 | `39d69ad53` | "exclude tooling DIRECTORIES from the emitting program, not just the `*.test.*` name" (PR 7213). It added `.changeset/6943-fields-tooling-dirs-out-of-emit.md`. | | objectstack-ai#7014, the convergence (Q1) | `98d4108a2` | "converge the two named select-option types on one spec-derived base" (PR 7538). It added `packages/types/src/select-option.ts` and the `SelectOptionBase` export, and `.changeset/7014-q1-tier1-select-option-convergence.md`. | | objectstack-ai#7014, the empty label (Q2) | `f0f774b0d` | "keep an emptied picklist option Label as `label: ""`" (PR 7536). It wrote the `patchOptions` comment and added `.changeset/7014-q2-option-label-empty-string.md`. | | objectstack-ai#7014, the claim correction | `0e3b3be09` | "correct three false spec-alignment claims and pin the real boundary" (PR 7510). It added `select-option-spec-extension-7014.test.ts` and `.changeset/7014-select-option-spec-claim-correction.md`. | | objectstack-ai#7627 | `b041b9c0c` | "one shared record-source object-name reader, six plugins delegate" (PR 7637, which answers 404). Its message settles objectui#7627 by name and records the `persistLayoutKey` exclusion and the `useSettledSchema` doc change; its second commit pins the two off-contract tails. | | objectstack-ai#7638 | `2ce2612df` | "the record-page URL follows the record source, not the top-level key" (PR 7648). It added `.changeset/7638-navigation-url-follows-record-source.md`. | | objectstack-ai#7791 | `223b1e4a3` | "root the capability spec-parity pin at the file, not the cwd" (PR 7796). It added `.changeset/7791-specparity-cwd-root.md`. | | objectstack-ai#8057 | `9073cf018` | "hold a server refusal against the draft slice it named" (PR 8675). Its message names `ResourceEditPage` as the third writer neither of objectui#7714's guards reached, and describes the measured wedge and the auto-save path the comments describe. `9662aca56` (the write-doors commit) only records the reproduction, and is the landing of `8676-object-metadata-write-doors.md` itself, so it is not used. | | objectstack-ai#9230 | `20b507aff` | "render a picklist option value when its label is blank" (PR 9258). It added `.changeset/9230-picklist-blank-option-label.md`. | objectstack-ai#7753 and objectstack-ai#7878 have no site in either in-scope class. ## Site by site 57 lines at 56 anchors: 20 changeset lines and 37 source lines (the `navigation-overlay.tsx` row covers two). Each row quotes the changed text, comment markers stripped and wrapped lines joined. | file | number | before | after | |:--|:--|:--|:--| | `.changeset/5793-spec-range-floors.md` | objectstack-ai#5793 | `output re-exports (objectui#5793).` | `output re-exports.` | | `.changeset/6140-field-metadata-rows-option-description.md` | objectstack-ai#7014 | `Same correction as objectui#7014 / PR objectstack-ai#7510 made` | `` Same correction as `0e3b3be09` (PR objectstack-ai#7510) made `` | | `.changeset/6361-spec-floor-17-2-0.md` | objectstack-ai#5793 | `on the reasoning objectui#5793 used for the same remediation on` | `` on the reasoning `111741454` used for the same remediation on `` | | `.changeset/6943-fields-tooling-dirs-out-of-emit.md` | objectstack-ai#6943 | `` in the published tarball (objectui#6943). `packages/fields/tsconfig.json` now excludes `` | `` in the published tarball. `packages/fields/tsconfig.json` now excludes `` | | `.changeset/7014-q1-tier1-select-option-convergence.md` | objectstack-ai#7014 | `onto one spec-derived base (objectui#7014, Q1).` | `onto one spec-derived base.` | | `.changeset/7014-q2-option-label-empty-string.md` | objectstack-ai#7014 | `API refuses (objectui#7014 Q2).` | `API refuses.` | | `.changeset/7014-select-option-spec-claim-correction.md` | objectstack-ai#7014 | `real boundary (objectui#7014).` | `real boundary.` | | `.changeset/7122-spec-17-3-0-parity-reconciliation.md` | objectstack-ai#5793 | `the claim is what is wrong", objectui#5793).` | `` the claim is what is wrong", `111741454`). `` | | `.changeset/7212-published-tsconfig-tooling-exclude-ratchet.md` | objectstack-ai#6943 | `` statement imports `vitest`) and objectui#6943 (the same package as the first `` | `` statement imports `vitest`) and `39d69ad53` (the same package as the first `` | | `.changeset/7627-shared-record-source-reader.md` | objectstack-ai#7627 | `object is this block bound to" (objectui#7627).` | `object is this block bound to".` | | `.changeset/7632-shared-record-source-config.md` | objectstack-ai#7627 | `` It is the PRODUCER whose output the objectui#7627 reader `resolveRecordSourceObjectName` consumes `` | `` It is the PRODUCER whose output the reader `resolveRecordSourceObjectName` (`b041b9c0c`) consumes `` | | `.changeset/7632-shared-record-source-config.md` | objectstack-ai#7627 | `the same way objectui#7627 left the off-contract` | `` the same way `b041b9c0c` left the off-contract `` | | `.changeset/7638-navigation-url-follows-record-source.md` | objectstack-ai#7638 | `` `ObjectTree` and `ObjectCalendar` (objectui#7638). `` | `` `ObjectTree` and `ObjectCalendar`. `` | | `.changeset/7638-navigation-url-follows-record-source.md` | objectstack-ai#7627 | `the same conservatism objectui#7627 applied when it published the` | `` the same conservatism `b041b9c0c` applied when it published the `` | | `.changeset/7791-specparity-cwd-root.md` | objectstack-ai#7791 | `` package-level `test` script (objectui#7791). Nothing ships `` | `` package-level `test` script. Nothing ships `` | | `.changeset/7799-cwd-rooted-package-tests.md` | objectstack-ai#7791 | `copying the precedent landed for objectui#7791, so every` | `` copying the precedent landed in `223b1e4a3`, so every `` | | `.changeset/8632-malformed-picklist-option-loud.md` | objectstack-ai#7014 | `` for an option with no `label` key (objectui#7014), and the editor's own `` | `` for an option with no `label` key (`f0f774b0d`), and the editor's own `` | | `.changeset/8676-object-metadata-write-doors.md` | objectstack-ai#8057 | `writers it knew of. objectui#8057 reproduced the identical defect on a third; a sweep found nine more.` | `` writers it knew of. The identical defect was then reproduced on a third (fixed in `9073cf018`); a sweep found nine more. `` | | `.changeset/9230-picklist-blank-option-label.md` | objectstack-ai#9230 | `instead of a blank row (objectui#9230).` | `instead of a blank row.` | | `.changeset/9230-picklist-blank-option-label.md` | objectstack-ai#7014 | `deliberately (objectui#7014 Q2, pinned).` | `` deliberately (`f0f774b0d`, pinned). `` | | `app-shell/src/views/metadata-admin/ResourceEditPage.tsx` | objectstack-ai#8057 | `slices its issue paths named (objectui#8057).` | `` slices its issue paths named (`9073cf018`). `` | | `app-shell/src/views/metadata-admin/ResourceEditPage.tsx` | objectstack-ai#8057 | `⭐ THE BOUNDARY, stated so a later reader can apply it (objectui#8057).` | `` ⭐ THE BOUNDARY, stated so a later reader can apply it (`9073cf018`). `` | | `app-shell/src/views/metadata-admin/ResourceEditPage.tsx` | objectstack-ai#8057 | `unreachable. What ended with objectui#8057 is only the client's habit of` | `` unreachable. What ended with `9073cf018` is only the client's habit of `` | | `app-shell/src/views/metadata-admin/ResourceEditPage.tsx` | objectstack-ai#8057 | `The measured wedge (objectui#8057) is an author who adds a Lookup field` | `` The measured wedge (`9073cf018`) is an author who adds a Lookup field `` | | `app-shell/src/views/metadata-admin/ResourceEditPage.tsx` | objectstack-ai#8057 | `unrelated edit (objectui#8057). Paths that do not localise are` | `` unrelated edit (`9073cf018`). Paths that do not localise are `` | | `app-shell/src/views/metadata-admin/ResourceEditPage.tsx` | objectstack-ai#8057 | `The timer is the door the objectui#8057 wedge actually came through: it` | `` The timer is the door the wedge (`9073cf018`) actually came through: it `` | | `app-shell/src/views/metadata-admin/ResourceEditPage.tsx` | objectstack-ai#8057 | `` (objectui#8057). `issues` — the live client Zod pass `` | `` (`9073cf018`). `issues` — the live client Zod pass `` | | `app-shell/src/views/metadata-admin/inspectors/ObjectFieldInspector.tsx` | objectstack-ai#7014 | `cannot carry — the declared-but-not-carried divergence objectui#7014 exists to remove.` | `` cannot carry — the declared-but-not-carried divergence the select-option convergence (`98d4108a2`) set out to remove. `` | | `app-shell/src/views/metadata-admin/inspectors/ObjectFieldInspector.tsx` | objectstack-ai#7014 | `` it, which is the objectui#7014 Q2 ruling: `''` is what the Label box has `` | `` it, which is the ruling `f0f774b0d` landed: `''` is what the Label box has `` | | `app-shell/src/views/metadata-admin/inspectors/ObjectFieldInspector.tsx` | objectstack-ai#7014 | `with nothing on screen explaining why (objectui#7014 Q2).` | `` with nothing on screen explaining why (`f0f774b0d`). `` | | `components/src/custom/navigation-overlay.tsx` | objectstack-ai#7627, objectstack-ai#7638 | `` (objectui#7627), and never a bare top-level `schema.objectName` in its place (objectui#7638). `` | `` (`b041b9c0c`), and never a bare top-level `schema.objectName` in its place (`2ce2612df`). `` | | `core/src/evaluator/optionRules.ts` | objectstack-ai#9230 | `when the label is blank (objectui#9230).` | `` when the label is blank (`20b507aff`). `` | | `core/src/evaluator/optionRules.ts` | objectstack-ai#7014 | `under the objectui#7014 Q2 ruling, and a pin` | `` under the ruling `f0f774b0d` landed, and a pin `` | | `core/src/index.ts` | objectstack-ai#7627 | `` them together. `resolveRecordSourceObjectName` (objectui#7627) is the READER `` | `` them together. `resolveRecordSourceObjectName` (`b041b9c0c`) is the READER `` | | `core/src/utils/record-source.ts` | objectstack-ai#7627 | `The object a view block is bound to, resolved ONCE for the whole renderer (objectui#7627).` | `` The object a view block is bound to, resolved ONCE for the whole renderer (`b041b9c0c`). `` | | `core/src/utils/record-source.ts` | objectstack-ai#7627 | `{@link resolveRecordSourceObjectName} (the objectui#7627 reader) consumes;` | `` {@link resolveRecordSourceObjectName} (the reader `b041b9c0c` published) consumes; `` | | `data-objectstack/src/object-metadata-write-guard.ts` | objectstack-ai#8057 | `` conversion (`toFieldsMap`). objectui#8057 then reproduced the very failure the ruling was written against, on a THIRD writer neither conversion covers, in that card's own required dogfood. objectui#8676 swept and found nine more. `` | `` conversion (`toFieldsMap`). The very failure the ruling was written against was then reproduced on a THIRD writer neither conversion covers, in that card's own required dogfood (fixed in `9073cf018`). objectui#8676 swept and found nine more. `` | | `data-objectstack/src/object-metadata-write-guard.ts` | objectstack-ai#8057 | `in objectui#8057. It throws; the caller surfaces the message.` | `` in `9073cf018`. It throws; the caller surfaces the message. `` | | `plugin-calendar/src/ObjectCalendar.tsx` | objectstack-ai#7638 | `The record-page URL follows the RECORD SOURCE (objectui#7638): the very` | `` The record-page URL follows the RECORD SOURCE (`2ce2612df`): the very `` | | `plugin-gantt/src/ObjectGantt.tsx` | objectstack-ai#7627 | `` inverted order relative to `resource` above is not the drift objectui#7627 `` | `` inverted order relative to `resource` above is not the drift `b041b9c0c` `` | | `plugin-gantt/src/ObjectGantt.tsx` | objectstack-ai#7627 | `separate, user-visible change, so the ruling on objectui#7627 excluded this` | `` separate, user-visible change, so `b041b9c0c` excluded this `` | | `plugin-map/src/ObjectMap.tsx` | objectstack-ai#7627 | `` NOT a delegation site for `resolveRecordSourceObjectName` (objectui#7627): `` | `` NOT a delegation site for `resolveRecordSourceObjectName` (`b041b9c0c`): `` | | `plugin-map/src/ObjectMap.tsx` | objectstack-ai#7627 | `` it names one, else the schema's own `objectName` (objectui#7627, the `` | `` it names one, else the schema's own `objectName` (`b041b9c0c`, the `` | | `plugin-tree/src/ObjectTree.tsx` | objectstack-ai#7627 | `` NOT a delegation site for `resolveRecordSourceObjectName` (objectui#7627): `` | `` NOT a delegation site for `resolveRecordSourceObjectName` (`b041b9c0c`): `` | | `plugin-tree/src/ObjectTree.tsx` | objectstack-ai#7638 | `` bare top-level key (objectui#7638). objectui#6939 published `objectName` `` | `` bare top-level key (`2ce2612df`). objectui#6939 published `objectName` `` | | `react/src/hooks/useNavigationOverlay.ts` | objectstack-ai#7638 | `contain (objectui#7638).` | `` contain (`2ce2612df`). `` | | `react/src/hooks/useNavigationOverlay.ts` | objectstack-ai#7627 | `(objectui#7627) — as the example does.` | `` (`b041b9c0c`) — as the example does. `` | | `react/src/hooks/useSettledSchema.ts` | objectstack-ai#7627 | `plugins each carried their own copy and had drifted, which is the whole of objectui#7627. Choosing` | `` plugins each carried their own copy and had drifted, which is the whole of what `b041b9c0c` collapsed. Choosing `` | | `types/src/field-types.ts` | objectstack-ai#7014 | `⛔ This reverses what this docblock asserted between objectui#7014 and objectui#7635: at 17.2.0` | `` ⛔ This reverses what this docblock asserted between `0e3b3be09` and objectui#7635: at 17.2.0 `` | | `types/src/field-types.ts` | objectstack-ai#7014 | `(objectui#7014, corrected for the 17.3.0 boundary by objectui#7635).` | `` (`0e3b3be09`, corrected for the 17.3.0 boundary by objectui#7635). `` | | `types/src/field-types.ts` | objectstack-ai#7014 | `Select option — the OBJECT-METADATA face of the one select-option contract (objectui#7014).` | `` Select option — the OBJECT-METADATA face of the one select-option contract (`98d4108a2`). `` | | `types/src/field-types.ts` | objectstack-ai#7014 | `⛔ This reverses what this docblock asserted between objectui#7014 and objectui#7635, when` | `` ⛔ This reverses what this docblock asserted between `0e3b3be09` and objectui#7635, when `` | | `types/src/field-types.ts` | objectstack-ai#7014 | `` `__tests__/select-option-spec-extension-7014.test.ts` (objectui#7014). `` | `` `__tests__/select-option-spec-extension-7014.test.ts` (`0e3b3be09`). `` | | `types/src/form.ts` | objectstack-ai#7014 | `Select option — the SDUI FORM face of the one select-option contract (objectui#7014).` | `` Select option — the SDUI FORM face of the one select-option contract (`98d4108a2`). `` | | `types/src/index.ts` | objectstack-ai#7014 | `both, so a consumer that wants to name it can (objectui#7014).` | `` both, so a consumer that wants to name it can (`98d4108a2`). `` | | `types/src/select-option.ts` | objectstack-ai#7014 | `` `SelectOption` (`@objectstack/spec/data`), with every divergence written out (objectui#7014). `` | `` `SelectOption` (`@objectstack/spec/data`), with every divergence written out (`98d4108a2`). `` | ## The runtime string (patch round) `assertObjectMetadataWritable`'s thrown message now ends "(objectui#7714). " where it ended "(objectui#7714, objectui#8057). ". The dead pointer is dropped, not replaced by a sha, because a runtime reader has no repository to resolve one against (the PR objectui#10707 precedent). The change is declared by `.changeset/10771-write-guard-message-citation.md` (`@object-ui/data-objectstack`: patch), and `10771-dead-citation-sweep.md` gains one sentence pointing at it. Nothing pins the string: `git grep` of the pointer fragments hits only the source line, and no test regex names the dead number. ## Gates, patch round, on the head `c050ffe05` - `node scripts/check-changeset-presence.mjs`, exit 0: "17 source file(s) of 10 released package(s) changed, and this change declares 2 changeset(s): .changeset/10771-dead-citation-sweep.md, .changeset/10771-write-guard-message-citation.md." - `pnpm changeset:check`, exit 0 (no `major`); `node scripts/check-changeset-overwrite.mjs` (report-only), exit 0: "2 changeset(s) added, 17 modified, 0 deleted". - `pnpm check:pending-changeset-literals`, `check:control-bytes`, `check:new-line-citations`, `check:spec-symbols`, `check:installed-pin-claims`, `check:metadata-write-doors`: exit 0 each. - Through the shared verify lock (`VERDICT command-exit 0`): the `@object-ui/data-objectstack` dependency-closure build, its own build and `type-check`, and a repo-root vitest run over `packages/data-objectstack/`, the guard's app-shell callers and the three script suites that read the guard or `.changeset/**`: `Test Files 83 passed (83)`, `Tests 1109 passed (1109)`. - `dist`: the new message is in `dist/index.js` and `dist/index.cjs`; the old pointer text is in 0 files. - Re-count, same census instrument: in scope at `c050ffe05` = 0 changeset lines, 0 src-nontest lines (before the patch round: 0 and 1). Lit control objectstack-ai#7632 / objectstack-ai#7714 on the same head: 65 lines, 6 changeset, 20 src-nontest. ## Gates, on the head `9b99096b6` Each line is the gate's own verdict and its exit code, captured by redirect-then-`$?`. - `node scripts/check-changeset-presence.mjs`, exit 0: "17 source file(s) of 10 released package(s) changed, and this change declares 1 changeset(s): .changeset/10771-dead-citation-sweep.md. Every one of them has an EMPTY frontmatter". Before that changeset was added it exited 1 ("17 source file(s) of 10 released package(s) changed, and this change adds no changeset"), so a comment-only `src` edit does trip it, and a modified changeset does not count as a declaration. - `pnpm changeset:check`, exit 0: "No changeset declares a `major` bump." - `node scripts/check-changeset-overwrite.mjs` (report-only), exit 0: "1 changeset(s) added, 17 modified, 0 deleted", and for all 17 `declared at base` equals `declares now`. - `pnpm check:changeset-claims` (report-only), exit 0: 19 pending changesets name a file this PR touches. Read against the diff: none of the 19 quotes any removed comment text (each removed line's first 40 characters, 36 lines, 0 hits; control: `resolveRecordSourceConfig` hits `7313-object-calendar-record-source.md` twice) and none cites the ten. - `pnpm check:pending-changeset-literals`, exit 0: "No test source names a pending changeset." - `pnpm check:control-bytes`, exit 0: "check-control-bytes: OK (scanned 8988 tracked text file(s); skipped 85 binary)." - `pnpm check:new-line-citations`, exit 0: "VERDICT new-cross-file-line-citations: 0 new citation(s), enforcement report-only -> exit 0". - `pnpm check:spec-symbols`, exit 0: "spec member citations: 1410 sources + 184 documentation pages; nothing cites a key its spec symbol does not declare." - `pnpm check:installed-pin-claims`, exit 0: "OK". `pnpm check:metadata-write-doors`, exit 0: "OK 17 metadata write door(s) derived". `pnpm check:comment-mask-corpus`, exit 0: the standing report only (1 file, `apps/console/src/pages/DocsIndex.tsx`, not touched here). - **Comment-only, measured.** Each touched source file parsed with TypeScript's `createSourceFile` and re-printed by `createPrinter({ removeComments: true })`, type syntax kept: the sha256 is identical before and after for all 17 files, with 0 parse diagnostics. Lit control on the same instrument: dropping ", objectui#8057" from the write guard's string literal moves the hash; rewording a comment in the same file does not. - Tests, from the repo root through the shared verify lock (`VERDICT command-exit 0` each): `pnpm exec vitest run packages/types/` gives `Test Files 247 passed (247)`, `Tests 5345 passed (5345)`. A second run of 49 files: every test file that names a touched source file and reads the file system (the source-text pins, among them `useNavigationOverlay.docExampleRecordSource-7638.test.ts`, `ObjectMap.catalogRecordSource-6939.test.tsx` and `calendarUnionReads-8651.test.tsx`), the `.changeset/**` and `packages/**` readers `node scripts/markdown-test-inputs.mjs --list` names, and the changeset, comment-mask, citation and write-door gates' own suites. Result: `Test Files 49 passed (49)`, `Tests 2669 passed (2669)`. - `pnpm --filter @object-ui/types type-check` (`tsc --noEmit && tsc -p tsconfig.examples.json && tsc -p tsconfig.test.json`), exit 0. - `@object-ui/types` built (`pnpm --filter @object-ui/types build`, exit 0, "130 emitted files verified"). Its `dist` holds 0 files naming any of the ten; `98d4108a2` is in `field-types.d.ts`, `form.d.ts` and `select-option.d.ts`, so these docblocks do ship. Control: the untouched `objectui#7635` is still in two `.d.ts` files. - eslint, narrowed and declared. Population: the 17 touched source files, each linted through the repo's `eslint.config.js` (17 results returned, none reported as ignored). Counts from `--no-inline-config --format json`: 17 files, 4 errors, 251 warnings. The same 17 files at the base, through `--stdin`: 4 errors, 251 warnings. The 4 errors are the base's own, on the same code lines (`react-hooks/static-components` three times in `ResourceEditPage.tsx`, `no-restricted-imports` once in `types/src/index.ts`). Invariance: `eslint.config.js` enables no type-aware linting (no `projectService`, no `project` parser option, no type-checked preset), so a comment diff cannot move another file's verdict. **Declared narrowing.** NOT MEASURED locally: the full test suites and `type-check` of the other nine packages (`app-shell`, `components`, `core`, `data-objectstack`, `plugin-calendar`, `plugin-gantt`, `plugin-map`, `plugin-tree`, `react`). Reason: the comment-stripped syntax tree of every touched file is identical, so only a test that reads source TEXT can move, and those ran above. CI runs the full farm. ## Serial The branch merged `main` at `dac022c4e` before this PR opened, and again at `6cf599985` in the patch round (merge `566aac876`, no conflicts); merges only, no rebase. `git diff --stat` from the claim-time base to that commit over the 35 touched paths is empty. The one in-flight overlap the claim named, objectui#5157 in `ObjectMap.tsx`, is region-disjoint: this PR changes two comment lines above `resolveRecordSourceObjectName`'s call and nothing in the `safeParse` region. `.changeset/5793-spec-range-floors.md` is also in the release PR objectui#5400, which regenerates itself. ## Acceptance notes 1. **The same defect with other numbers, in the same files (not widened; filed by the seat as the family card objectui#10803).** The 34 in-scope files cite 318 distinct issue numbers. REST reads each: 296 answer 200 and 22 answer 404. Eight of the 22 are this card's numbers. The other 14 are objectstack-ai#5489, objectstack-ai#5498, objectstack-ai#5853, objectstack-ai#6938, objectstack-ai#6939, objectstack-ai#6950, objectstack-ai#7070, objectstack-ai#7071, objectstack-ai#7628, objectstack-ai#7632, objectstack-ai#7635, objectstack-ai#7688, objectstack-ai#9318 and objectstack-ai#9473. The census instrument above, over those 14 at the base: 67 changeset lines in 48 files and 164 src-nontest lines in 54 files (467 lines in all). Some sit in sentences this PR edits: objectstack-ai#7635 beside three of the `field-types.ts` docblocks and in `7014-select-option-spec-claim-correction.md`, objectstack-ai#6939 in the map, tree, calendar and core sites, and objectstack-ai#7632 in `core/src/index.ts`. Their landing commits were not all mapped; one that was, for a patch round: objectstack-ai#7635 is `544ecba84` (PR 9588, whose message settles it by name). Pending changeset FILENAMES carry 11 of the 14 (`ls .changeset`; six filenames carry `6939` alone), and a filename is not a citation, so a sweep of this family leaves filenames alone, as PR objectui#10707 did. 2. **Out-of-scope count, as it stands** (unchanged by this PR, instrument above, at the head): 81 test, 28 scripts, 6 `.github`, 1 governed, 30 other. In scope, at the patch-round head `c050ffe05`: 0 changeset lines, 0 src-nontest lines. 3. **The one judgement call in the mapping:** the `ObjectFieldInspector.tsx` sentence "the declared-but-not-carried divergence objectui#7014 exists to remove" names the card's aim, not one landing. It now cites the convergence commit `98d4108a2`, and "exists to" becomes "set out to", because a commit is a past act. 4. **Commit trailer:** the first commit, `60576722d`, carries a model-named `Co-Authored-By` trailer. The dispatch contract asks for model-free trailers. It was not rewritten, because this repo bans force-push. The later commits are model-free, and a squash merge folds all of them into this body. --- _Generated by [Claude Code](https://claude.ai/code/session_01DuWo5bdP9SdVebamn99GGk)_ --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #7014
Clause-②: no— no type, schema, export or runtime path changes. Justification in the claim comment on #7014.The card's structural diagnosis is stale — corrected here
#7014 says the gate is blind because "both rules skip any declaration without an
exportmodifier (hasExportModifier, applied once per scanner)". On today'smain(a27d153c2) that is no longer true. Both halves of the filter were removed in objectui#6291;hasExportModifiersurvives atscripts/check-spec-symbol-derivation.mjs:980with zero call sites, andscanFilecarries the literal comment// No export filter (objectui#6291).The card's conclusion is correct and survives — the class really is invisible to its own gate. It is invisible for three different, still-live reasons, set out in the report and summarised at the bottom of this body.
What this PR fixes
Three doc comments asserted the installed
@objectstack/specdeclares a key that it in fact refuses by name. Measured on@objectstack/spec@17.2.0, each paired with a control that accepts the same payload minus the key:packages/types/src/field-types.tsSelectOptionMetadata.description@objectstack/specSelectOptionSchema.description"REJECT unrecognized_keys(description); controlACCEPTpackages/types/src/field-types.tsMarkdownFieldMetadata.rows@objectstack/specFieldSchema.rows(a positive integer, authorable on exactly the multiline editor types)"REJECT unrecognized_keys(rows)on all four of textarea/markdown/html/richtext; controlACCEPTpackages/types/src/field-types.tsHtmlFieldMetadata.rows@objectstack/specFieldSchema.rowsdeclares it for the multiline editor types"packages/fields/src/widgets/LookupField.optionDescription.test.tsx@objectstack/spec'sSelectOptionSchema.description"SelectOptionSchemais.strict()over exactly{label, value, color, default, visibleWhen}— five keys, nodescription, noicon, nodisabled.The keys stay declared and stay consumed.
LookupFieldgenuinely searches an option'sdescription(objectui#6153) andRichTextFieldgenuinely readsrows(objectui#6140). Only the attribution was wrong — and it mattered in a specific way:FieldSchemaroutes a select field'soptionsthrough the strict option schema, so authoringdescriptionon an option fails the whole field:That is the same failure class already documented in
MetadataService.tsforindexed/referenceTo/formula— a designer-authored key that makesPUT /api/v1/meta/object/:namefail 422INVALID_METADATA. The comments were inviting exactly that write; they now name the boundary instead.A false canonical claim is not stale documentation — it is a planted premise for the next agent, which is the whole failure class
check-spec-symbol-derivation.mjsexists to prevent.New pin
packages/types/src/__tests__/select-option-spec-extension-7014.test.ts(15 tests) asserts the spec's option key set and each by-name refusal, every one paired with an accepting control. If the spec ever adoptsdescription/icon/disabled, the claim re-opens loudly instead of silently becoming true.Verification — all readings at head
71e7e5dbTest Files 1 passed (1)/Tests 15 passed (15)field-metadata-rows-option-description-6140,select-option-spec-parity,bulk-action-param-options,LookupField.optionDescription)Test Files 5 passed (5)/Tests 36 passed (36)type-check(@object-ui/types,@object-ui/fields)lint(both changed packages, in full)911 problems (0 errors, 911 warnings), all pre-existingcheck:spec-symbols✅ spec symbol derivation: 1344 files scanned against 4959 spec export names; 18 declared dialects, 14 untriaged collisions in 7 packages./✅ spec alignment claims: 2 declared deliberate copies, 19 unbacked claims in 5 packages.check:control-bytes✅ check-control-bytes: OK (scanned 6196 tracked text file(s); skipped 85 binary).check:changeset-presence✅ 3 source file(s) of 2 released package(s) changed, and this change declares 1 changeset(s)check:changeset-no-major✅ No changeset declares amajorbump.check:dist-completeness✓ dist completeness: 7 package(s) complete (522 emitted files verified); 5 not built yet, 2 type-check-onlycheck:readme-exportsits type entry ./dist/index.d.ts is not on disk -- run pnpm build first. Needs a full 40-package build; unrelated to this diff, which touches no README and no export.Reverse verification. Implementation committed first, then the pin mutated into the world the old comments asserted — key set widened to include
description, and the refusal loop repointed atcolor(a key the spec accepts). Mutation proven on disk in both directions (injected text present ×2, removed text absent ×2, blob11a1a4bf→697a2bad). Result:Tests 2 failed | 11 passed (13)— exactly the two mutated assertions red, all 11 controls green including the wholerowsblock. Restored undertrap … EXIT INT TERMwithgit checkout HEAD -- <abs path>, and proven by state: worktree blob back to11a1a4bf= HEAD blob,git diff HEADempty,git statusclean.Which tsc leg sees the pin — measured with
--listFiles:tsc --noEmit→ 0 hits;tsc -p tsconfig.test.json→ 1 hit. The package'stype-checkscript runstsc --noEmit && tsc -p tsconfig.test.json, so CI runs both legs and the pin is inside the checked program. (The edited source filefield-types.tsis in both.)Lint narrowing, declared. Rather than the repo-wide
pnpm lint, both changed packages were linted in full — broader than the changed files, narrower than the repo. The narrowing is safe because ESLint here is not type-aware: noprojectServiceand noparserOptions.projectanywhere ineslint.config.js, so this diff cannot move the verdict on any file it does not touch. ESLint's own count over the 3 changed files: 3 linted, 0 errors, 7 warnings.check:spec-symbolsprints byte-identical output before and after this change (verified bydiff). That is the finding, not a pass. This PR removes three real false claims and the gate cannot tell. Reporting it as a green gate would be the exact failure the card warns about.It cannot see them for three independent, still-live reasons:
attachedDoc(stmt, text)). All three claims sit on members.SelectOptionMetadata's own docblock is just/** Select option */.aligns with. The real comment says bare "Aligns" — measured:findClaim(...)returnsnullon the actual text, and returns a claim on the same text with "with" inserted.SelectOptionSchemais a live spec export, so the dangling-citation precision rule (objectui#4607) does not fire, although.descriptionis not a key of it.Sizing for the ruling, since #7014's 47-vs-18 figure refers to the already-shipped export widening: a member-granularity citation check over the tree finds 3 genuinely dangling member citations — the two fixed here plus
DashboardSchema.title, filed as #7509 — once Zod's own method surface (.safeParse,.parse,.shape) is excluded, which is 22 of the 27 raw hits. Three, not thirty. Whether to build that check is a decision for the seat and is not taken in this PR.Not in this PR, on purpose
ObjectFieldInspector'spatchOptionswrites an option with nolabelwhen the label is empty (if (o.label) out.label = o.label), while the spec requireslabel. Real defect on an authoring surface, but narrowing it is a contract decision — escalated, not guessed.🤖 Generated with Claude Code
https://claude.ai/code/session_01EMrWaQw3XS5DxTHxp4yRyC
Generated by Claude Code