Repository navigation
test(test-support): one enum-options walk for the top-level reader family (#6924) - #7024
Merged
Merged
Conversation
…mily (#6924) 17 hand-written `(Schema as { options?: readonly string[] }).options` casts across 16 spec-parity test files in 11 workspace packages read `.options` straight off a node that IS the enum. The cast is unchecked: an enum that acquires a wrapper, or a Zod build that moves `.options`, yields `undefined` and the derived vocabulary silently becomes the empty set. `@object-ui/test-support` already carried the wrapper walk, behind a signature this family could not use: `shapeEnumOptions(schema, key)` opens with `resolvePropsShape` and then indexes `shape[key]`, so a bare enum has no shape to resolve and no key to index. That is a missing ENTRY POINT, not a missing reader. So the walk is exported as `enumOptions(node)` and `shapeEnumOptions` delegates to it -- one walk, two entry points, no second copy. Verdict preservation measured, not assumed: against the installed pin, all 23 readings return the identical array in the identical order before and after. `palette-discussion-alias.test.tsx` gains the non-vacuity assertion the reader's docblock makes every caller owe; the other 15 files already carried one. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013hfmP9hoMd3dJwTh85J4yB
github-actions
Bot
added
documentation
Contributor
✅ Console Performance Budget
The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it. 📦 Bundle Size Report
Size Limits
|
Append-collision with PR #7022 (`refactor(test-support): one shared home for the Zod wrapper-key list`), which landed on main after this branch was cut and touches the same package barrel and README. Both sides kept, in two files: - `packages/test-support/src/index.ts` -- exports BOTH #7022's `ZOD_WRAPPER_KEYS` (with its docblock) and this branch's `enumOptions, shapeEnumOptions`. - `packages/test-support/README.md` -- this branch's rewritten `spec-enum-options.ts` entry (two exports, one walk) AND #7022's two `zod-wrapper-keys` entries, in main's ordering. One sentence of this branch's text was corrected rather than kept verbatim: it said the wrapper-key walk is "NOT confined here yet and still hand-copied", which #7022 made false. The merged sentence carries #7022's fact (the wrapper-key list is now shared as DATA) and this branch's remaining half (array-element unwrapping is still hand-copied). `pnpm-lock.yaml` auto-merged; `pnpm install` left it unchanged, so it needed no regeneration and none was hand-written. No behaviour from either side was dropped or altered. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013hfmP9hoMd3dJwTh85J4yB
Contributor
Author
|
os-dev-report Conflict against Two files, both append-collisions with PR #7022, both sides kept.
export { enumOptions, shapeEnumOptions } from './spec-enum-options';
/* ...#7022's docblock... */
export { ZOD_WRAPPER_KEYS } from './zod-wrapper-keys';
One sentence was corrected rather than kept verbatim, and it is worth naming because it is the one place a "keep both sides" resolution would have produced a false statement. This branch's text said the other censused reader classes, "array-element unwrapping, the wrapper-key walk — are NOT confined here yet and are still hand-copied". #7022 made the wrapper-key half false. The merged sentence carries #7022's fact and this branch's surviving half:
Re-run on the merge commit (root-relative vitest only):
Diffs above were computed from the merge-base, never two-dot: Still draft; not marked ready, no auto-merge, not merged. No scope was added while in there — resolution only. Generated by Claude Code |
Contributor
✅ Console Performance Budget
The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it. 📦 Bundle Size Report
Size Limits
|
akarma-synetal
pushed a commit
to akarma-synetal/objectui
that referenced
this pull request
Sep 1, 2026
…the shared reader (objectstack-ai#7025) (objectstack-ai#7057) 9 spec-parity test files in 7 packages cast an enum node NON-optionally to an options-bearing shape and read `.options` straight off it -- the SIXTH spelling of the Zod-internals reader hazard objectui#5872 catalogues, and the one objectui#6924's instrument (`options?:`) structurally cannot see. They converge onto `@object-ui/test-support`'s `enumOptions(node)`, the walk PR objectstack-ai#7024 exported for objectui#6924's family. The decisive difference from that family is the FAILURE MODE, and it decides the shape of every conversion here. objectstack-ai#6924's sites guarded with `Array.isArray(raw) ? [...raw] : []`, so a failed cast went quietly empty. These sites spread the cast result directly, so a failed cast THROWS. `enumOptions` deliberately answers `[]` rather than raising, so a bare conversion would have downgraded a loud throw into a silent empty vocabulary -- turning this population into objectstack-ai#6924's, backwards. Every site therefore keeps its own non-vacuity duty: - 7 module-scope reads gain a throwing wrapper, modelled on the two sites that already solved this in PR objectstack-ai#7024 (`types/spec-derived-unions.test.ts` and `examples/schema-catalog/.../component-fixture-declared-keys.test.ts`); - 2 in-test reads (`plugin-grid/spec-symbol-batch7`, `types/spec-subschema-parity`) already carried an explicit non-vacuity assertion, which is the sanctioned alternative, so they keep theirs. The four `expandableFamily.identity-*` files are textually identical across four packages -- objectstack-ai#5872 class (1)'s sharpest shape, where a reviewer diffing one copy cannot see that the other three did not move -- and were converted as one unit. Verdict preservation measured, not assumed: all 9 readings return the identical array in the identical order before and after (FieldType n=49, ColumnSummarySchema n=11) against the installed pin. The retired spelling is deliberately not quoted in the new comments: the card's enumeration instrument is a grep for it, and a comment carrying the literal text would make every future re-derivation read a false positive. Out of scope, measured and left alone: `types/spec-subschema-parity.test.ts:161` casts to an `unwrap().def.options` shape -- a further spelling, and a objectstack-ai#5872 class (2)/(4) shape rather than this one. Claude-Session: https://claude.ai/code/session_013hfmP9hoMd3dJwTh85J4yB Co-authored-by: Claude <noreply@anthropic.com>
akarma-synetal
pushed a commit
to akarma-synetal/objectui
that referenced
this pull request
Sep 28, 2026
…ts name 30 objectui issues that answer 404 (objectui#10803, batch 4) (objectstack-ai#10875) Part of objectstack-ai#10803 Clause-②: no Dispatched implementation of the `domain:ui` seat 2 claim (comment `5861571015`) on objectui#10803, batch 4, session `https://claude.ai/code/session_014mXUNuFomfj24w7s1pZzhN`. Citations only: no sentence's claim moves, and every edited pending changeset's frontmatter is byte-identical. The runtime text that moves loses its dead pointer and nothing else: the legacy `ActionSchema` `onSuccess` / `onFailure` tombstone guidance strings open `RETIRED (ADR-0049) —` (ruling `5861129870` as amended by `5861311219`), and two `DataTableSchema` zod `.describe()` strings drop their pointer (amendment `5860244997`, Q1 = A), all in `@object-ui/types`. The one test that pins the tombstone strings verbatim follows them, and nothing else in it moves. **Patch round 1** answers contract review `5861897723` (FAIL on `d21aeb0f6`) under seat ruling `5861900779` (route a: tests that pin changed comment text follow it, anchor only). `Test (shard 6/8)` was red on `layout-default-jsdoc-7361`, whose `TextSchema.variant` pin anchored on `6942`. The round does four things: - Three comment-text anchors follow the re-pointed text: the one in `layout-default-jsdoc-7361` and two in `cellClassNameCensusProse-6921`. - The `MarkdownSchema` docblock stops crediting `8063bcbdc` with retirements it never touched (**Special cases** 9). - The `7004-cli-root-path-line.md` remnant "(the mechanical half)" goes. - `main` (`de1b879a6`) is merged in by a merge commit (`ae0b81089`), with no rebase and no force-push. The round's anchor sweep (**Special cases** 10) shows those three pins are the only anchors on changed text. ## Why `Part of`, not a closing line The card stays open for the other 53 numbers of the family remainder (seat amendment `5860244997`, Q2 = A), listed in **Acceptance notes** 1, and for the bare-number 404s the C0 census below found. ## Premise, re-measured - REST `GET /repos/objectstack-ai/objectui/issues/N` for each of the 30: all 30 answer 404, and a second read of each answers 404 again (30 of 30). `GET .../pulls/N` answers 404 for all 30 too. Lit controls: objectui#10533 and objectui#7714 answer 200. No number was dropped from the batch. - The same 30 in objectstack all answer 200, with subjects unrelated to the objectui sentences (for example objectstack#6882 is an `examples/app-todo` trigger finding, while the objectui sentences are about `DataTableSchema.renderCellEditor`). Two exceptions were read, not guessed: - `objectstack#6888` already appears on 5 in-scope lines (`i18n.ts`, `ActionDefaultInspector.tsx`, `ActionPreview.tsx`, `block-config.ts`, `action-bar.tsx`), each about the `global_nav` retirement, which is objectstack#6888's own subject. They are live sister citations, untouched. - `UnpublishedAppBar.tsx` wrote "framework PR objectstack-ai#6942" bare. objectstack#6942 is the pull request "the ADR-0045 publish gate gets its own machine-managed key — `app.hidden` goes back to meaning navigation", exactly the `_unpublished` / `hidden` split that heading describes. It is re-qualified to `objectstack#6942` (Zone 1 item 5). - Every other site names an objectui card or pull request, confirmed by its landing commit below. - Every edited changeset is pending: it is present in `.changeset/` on `main`. - Branch point: `e32dae160`. `main` was merged in at `de1b879a6` in patch round 1 (merge commit `ae0b81089`). Not a shallow checkout. ## C0: the bare-number census (measurement only; PR objectui#10869 Acceptance note 2) The instrument, over the two in-scope classes at the branch point (a `#` not preceded by a word character, `#`, `&`, `/`, `.` or `-`, so `objectui#N`, `objectstack#N`, `cloud#N`, `hotcrm#N` and every other `word#N` are excluded, as is a `#N` inside a URL): ``` git grep -hoP '(?:^|(?<=[^\w#&/.\-]))#\d+(?![0-9A-Za-z_])' e32dae1 -- '.changeset/*.md' 'packages/*/src/**' ':!**/__tests__/**' ':!**/*.test.*' ':!**/*.spec.*' ':!**/test/**' ':!**/tests/**' | sort -u | wc -l ``` - **1002 distinct bare numbers.** That is over 600, so by the order's budget only the **980** at or below 10900 were read (replace the final `wc -l` with `tr -d '#' | awk '$1+0 <= 10900' | wc -l` to reproduce 980). The 22 above 10900 were NOT read. - Each of the 980 was read once with REST `GET .../issues/N`: **955 answer 200 and 25 answer 404.** Each of the 25 was read a second time and answered 404 again (25 of 25), and `GET .../pulls/N` answers 404 for all 25. - Lit control on the same instrument: objectstack-ai#5026, objectstack-ai#6905 and objectstack-ai#3720 are all in its output at the branch point. At this head none of the eight batch numbers it found bare remains. - The 25, with site counts (lines / files, at the branch point): - **This batch's own numbers (8), all fixed here:** objectstack-ai#6882 (5 / 2), objectstack-ai#6905 (7 / 2), objectstack-ai#6907 (5 / 1), objectstack-ai#6942 (1 / 1, the objectstack pull request above, re-qualified), objectstack-ai#6959 (1 / 1), objectstack-ai#6962 (1 / 1), objectstack-ai#7036 (8 / 1), objectstack-ai#7087 (2 / 2). The printed census below already counts a bare `#N` for these. - **Already on the family list (3), for their own batches:** objectstack-ai#7620 (2 / 2), objectstack-ai#7678 (3 / 3), objectstack-ai#7853 (1 / 1). - **New to the family (11), for later batches:** objectstack-ai#3720 (5 / 3), objectstack-ai#5420 (1 / 1), objectstack-ai#5503 (1 / 1), objectstack-ai#5506 (1 / 1), objectstack-ai#5737 (4 / 4), objectstack-ai#6467 (1 / 1), objectstack-ai#6936 (1 / 1), objectstack-ai#6945 (1 / 1), objectstack-ai#7622 (1 / 1), objectstack-ai#7662 (1 / 1), objectstack-ai#7684 (2 / 2). - **Not citations (3):** `#0` (257 / 187, the `#0` of "AGENTS.md #0.1"), `#000` (2 / 2) and `#000000` (10 / 6), which are CSS colours. - **Folded here: none.** No C0 404 outside this batch's 30 sits in a sentence this batch edits: none of the 11 new numbers, nor any of the other 53 family numbers, occurs in any hunk of this diff (3 lines of context). - The 200 set is not a citation census: many bare numbers are decision-batch, summons or commandment numbers, or React error codes, that happen to name a live issue. ## Census (the enumeration pin for this batch) The instrument PR objectui#10854 printed and PR objectui#10869 reused, with this batch's 30 numbers substituted (REF = a commit or tree): ``` git grep -nE '(objectui#|#|issues/)(6872|6879|6882|6887|6888|6889|6892|6905|6907|6921|6923|6924|6931|6940|6942|6958|6959|6962|6965|7004|7008|7023|7025|7036|7068|7069|7077|7079|7087|7088)([^0-9]|$)' REF -- '.changeset/*.md' 'packages/*/src/**' ':!**/__tests__/**' ':!**/*.test.*' ':!**/*.spec.*' ':!**/test/**' ':!**/tests/**' | grep -v 'objectstack#' | wc -l ``` - REF = `e32dae160` (branch point): **170** lines, 48 changeset lines in 38 files and 122 src lines in 45 files. REF = `de1b879a6` (the `main` merged in): 170. REF = `c6678b1bd` (`main` at the round's final read): 170. - REF = `ae0b81089` (this head, `de1b879a6` merged in): **0**. Round 0's head `d21aeb0f6` also read 0. - This head merged with a fresh `main` (`c6678b1bd`, `git merge-tree --write-tree`, clean, tree `e109a3bd0`): **0**. - **The instrument's blind spot, as batch 3 measured it.** Its `grep -v 'objectstack#'` drops a whole line that also names an objectstack number. Three in-scope lines were hidden that way, each naming objectui#6965 beside objectstack#9343: in `10039-publish-drafts-advisories.md`, `6965-batch-publish-advisories.md` and `render-publish-advisory-findings-5026.md`. They are re-pointed here too, so the batch's true base population is 173 lines (51 changeset lines in 40 files, 122 src lines in 45 files). Without the filter the instrument reads 178 at the branch point and **7** at this head, all live: the five `objectstack#6888` lines, `objectstack#6942` in `UnpublishedAppBar.tsx`, and the same spelling in the new sweep changeset. - Other spellings at this head: a search for the 30 numbers with no `#` finds only filenames (`action-callback-retired-7068.test.ts`, `data-table-declared-keys-6882.test.ts` and the like) and two SVG path coordinates. Hex-colour false positives (a number followed by a hex letter) at the branch point: 0. - Lit control, the same printed instrument over live objectui#7714 at this head: 17 lines. - **Out of scope, as it stands** (the instrument with the 30 numbers, unfiltered, whole tree at this head): 226 test lines in 96 files (`scripts/__tests__` included), 22 scripts lines in 5 files, 0 `.github`, 0 governed, and 18 other lines in 10 files: published `CHANGELOG.md` history, three `content/docs` lines, and four lines of the private `@object-ui/test-support` README. See **Acceptance notes** 3. ## Citation form - The 9-character backticked sha of the commit on `main` that landed the change the sentence rests on, as in PRs objectui#10707 / objectstack-ai#10766 / objectstack-ai#10797 / objectstack-ai#10854 / objectstack-ai#10869. All 24 distinct shas below are ancestors of `main`: `git merge-base --is-ancestor`, exit 0 each. Control leg in the same checkout: the head of PR objectui#10714 (`d2afdb6bf`) answers exit 1, and a known ancestor, `5f789538d`, answers exit 0. `git rev-parse --short=9` returns the same 9 characters for each. - A changeset's pointer to its OWN card is dropped, not replaced: `@changesets/changelog-git` prefixes each released entry with the hash of the commit that added the file, which is that landing. Where dropping the pointer left a dangling word, the clause was minimally repaired (**Special cases** 5). - Where the sentence rests on a RULING, the ruling is cited by its date, next to the sha that carried it out where one exists (**Special cases** 4). - Where a dead card sits beside a live pull request that IS its landing, the dead card is dropped and the live pointer stays (**Special cases** 1), as batch 3 dropped the dead predecessor in "(objectui#5401 → objectstack-ai#5454)". - Where the claim lived only on the dead card (a finding, a triage, a deferral, a quoted ruling), the sha only locates the card: "the card behind SHA" (**Special cases** 3). This is review `5861306588`'s lesson: a sha must carry what the sentence cites it for. - Where nothing answers, the pointer is dropped and the sentence names the card by role (objectstack-ai#7023 only). - Runtime text carries no sha: see **Special cases** 7. ## Mapping (number to resolution) Lines / files are the branch-point census for that number (a line naming two batch numbers counts for each, and the three hidden objectstack-ai#6965 lines are included). "Method" is how the landing was found. The last column is why that commit carries what the sentence cites it for. | dead number | resolution | method | lines / files | why the commit carries it | |:--|:--|:--|:--|:--| | objectstack-ai#6872 | own-card pointer dropped (landing `d9a0490b7`) | changeset's adding commit | 1 / 1 | the only site is the objectstack-ai#6872 changeset's own pointer | | objectstack-ai#6879 | `3619792bf` | changeset's adding commit, `git log --grep` | 1 / 1 | it curates `box` into `PUBLIC_BLOCKS`, the list the comment sits in | | objectstack-ai#6882 | `bf97b98c8` | changeset's adding commit | 20 / 7 | it declares `renderCellEditor` and schema-level `cellClassName` on `DataTableSchema`, adds the `Equal` exact-shape pin, and corrects `cellClassName`'s reach to the three utility cells | | objectstack-ai#6887 | `5c09cca27` | changeset's adding commit | 1 / 1 | it derives metadata-viewer's option shape from the spec's `SelectOption` with the `Omit` the comment names | | objectstack-ai#6888 | `320374d2a` | changeset's adding commit | 9 / 7 | it keys `LocationField`'s residue refusal and the two coordinate nouns into the locale packs | | objectstack-ai#6889 | `f75810e7c` | changeset's adding commit, `git log -S` | 8 / 1 | it parses a dropped-fields entry's `fields` and `object` instead of asserting them, the gate the comments describe | | objectstack-ai#6892 | own-card pointers dropped (landings `8d40c18a7`, `951fa8e0d`) | changesets' adding commits | 2 / 2 | both sites are slice changesets' pointers to their own card | | objectstack-ai#6905 (a pull request) | `85f6a6097` | `git log --grep`: its squash subject ends "(objectstack-ai#6905)" | 8 / 2 | it judges gantt dates by TYPE before `new Date`, the "objectstack-ai#6781 type rule" the sentences name | | objectstack-ai#6907 | `7fc5c3c12` | changeset's adding commit, `git log -S` | 7 / 2 | it spells a refused gantt date by a rule, and its changeset records the measured throwing-getter crash | | objectstack-ai#6921 | `4eb665bcf` | changeset's adding commit, `git log --grep` | 2 / 2 | it pins, in the rendered DOM, which body cells schema-level `cellClassName` reaches | | objectstack-ai#6923 | `d3bf4fa6f`; "the 2026-08-31 ruling" | changeset's adding commit, `git log --grep` | 5 / 4 | it gives the wrapper-key list its build-free JSON home "per the 2026-08-31 ruling on objectui#6923" | | objectstack-ai#6924 | `78e98bf44`; PR objectstack-ai#7024 kept | changeset's adding commit, `git log --grep` | 5 / 3 | it adds the one enum-options walk for the top-level reader family | | objectstack-ai#6931 | `8063bcbdc` | changeset's adding commit, `git log -S` | 8 / 5 | it converts the remaining eleven tombstones, `confirm` and the menu divider `type` included, to `retirementTombstone()`. At the `MarkdownSchema` site, which `8063bcbdc` never touched (`446d93d4e` retired those keys), it is cited only as the commit that made that spelling uniform: see **Special cases** 9 | | objectstack-ai#6940 | pointers dropped (landing `0c386dd7f`) | changeset's adding commit | 2 / 2 | the only sites are its own changeset's pointer and a `.describe()` string | | objectstack-ai#6942 | `57f9b077b`; one site re-qualified to objectstack#6942 | `git log --grep`; REST for the sister PR | 6 / 4 | it makes `ui:text` honour the published `variant` enum, with a node that omits the key left without a typography class | | objectstack-ai#6958 | `6a449fc49` | changeset's adding commit | 6 / 5 | it clears a field its own `visibleWhen` hides | | objectstack-ai#6959 | `c0c436db8` | changeset's adding commit | 2 / 1 | it keeps the find-call gate and adds a second one, and records the trap that a mock call is one resolution ahead of its value | | objectstack-ai#6962 | `7b433197d` | changeset's adding commit | 3 / 2 | it removes `publishDraft`'s envelope unwrap after measuring the route at the producer | | objectstack-ai#6965 | `ce986aafc`; PR objectui#10038 kept at three sites | changeset's adding commit, `git log --grep`; its body names the card it settles | 21 / 9 | it routes "publish whole app" through the advisory seam, adds `publishPackageDrafts`, and writes the "Corrected before release" note | | objectstack-ai#7004 | `85b495795` (root Path line); `a5d55472b` (arm selection) | both changesets' adding commits | 7 / 4 | the first gives a root-level issue a Path line; the second prints the arm the document selected, per the 2026-09-02 ruling | | objectstack-ai#7008 | `f08bcd9af` | changeset's adding commit | 15 / 11 | it makes `FieldEditWidget` deliver the declared NON-DOM block through `toHostProps`, and corrects `RequiredFieldsDialog` | | objectstack-ai#7023 | nothing answers: the card named by role | `git log --grep` finds only `d88e20f55`, the objectstack-ai#4895 retirement it dissolved into | 1 / 1 | see **Special cases** 3 | | objectstack-ai#7025 | own-card pointer dropped (landing `14884620e`) | changeset's adding commit | 1 / 1 | the only site is its own changeset's pointer | | objectstack-ai#7036 | `869b876c8` | `git log -S` on the timeline renderer | 11 / 1 | it scopes the speller's totality claim, and refuses a `catch` because it would substitute `an object` for a failure | | objectstack-ai#7068 | `6bca0e4e8`; runtime text `RETIRED (ADR-0049) —` | changeset's adding commit | 8 / 3 | it retires the callback pair as ADR-0049 tombstones and deletes `ActionCallback` / `ActionCallbackSchema` | | objectstack-ai#7069 | `2760075ff` | changeset's adding commit | 3 / 3 | it adds the fifth parity ledger that watches the mirror-wider-than-declared direction | | objectstack-ai#7077 | own-card pointer dropped (landing `00d3f09c5`) | changeset's adding commit | 1 / 1 | the only site is its own changeset's pointer | | objectstack-ai#7079 | own-card pointer dropped (landing `ab7dc31ce`) | changeset's adding commit | 1 / 1 | the only site is its own changeset's pointer | | objectstack-ai#7087 | `c93b4d5f3` | changeset's adding commit | 8 / 6 | it drops the 18 `disabled?: boolean` narrowings, adds the twin-symmetry pin, and keeps the six independent `boolean` declarations | | objectstack-ai#7088 | `c1fe272ad` | changeset's adding commit | 4 / 3 | it corrects `BaseSchema.hidden`'s JSDoc to the single hide path and records the synonymy | ## Special cases (the judgement calls) 1. **A dead card beside its own live landing.** - "objectui#6965 / PR objectui#10038" (`AiChatPage.tsx`, `PendingDraftsBar.tsx`, `StudioDesignSurface.tsx`) becomes "PR objectui#10038". PR objectui#10038 answers 200 and is the landing of `ce986aafc`, so the dead half goes and the live half stays. - `7025-nonoptional-enum-cast.md`: "the same walk objectui#6924 converged the optional-cast family onto in PR objectstack-ai#7024" becomes "the same walk PR objectstack-ai#7024 converged the optional-cast family onto". PR objectstack-ai#7024 answers 200 and is `78e98bf44`'s pull request. 2. **The sister-repo number.** In `UnpublishedAppBar.tsx`, "(objectstack#4829 A1, framework PR objectstack-ai#6942)" becomes "(objectstack#4829 A1, framework PR objectstack#6942)". See **Premise**. 3. **The card named by role.** - **objectstack-ai#7023**, in `4895-retire-block-schema-family.md`: "and objectui#7023 — the narrower validator-only fix — dissolves into this retirement" becomes "and the separate card for the narrower validator-only fix dissolves into this retirement". That card never landed on its own. - **"The card behind SHA"**, where the sentence rests on something that lived only on the card: - `6755-field-diagnostics-i18n.md`: "objectui#6888 carries it" becomes "The card behind `320374d2a` carries it". Carrying a pending item is the card's act. - `data-objectstack` `index.ts`: "Unlike objectui#6889's exotic case" becomes "Unlike the exotic case on the card behind `f75810e7c`". The exotic case is not in the commit. - `toHostProps.ts`: "the specific mistake objectui#7008's ruling fences off" becomes "the specific mistake the ruling on the card behind `f08bcd9af` fences off". The quoted ruling text is the card's, not the commit's. - `zod-wrapper-keys.ts`: "the wall objectui#6923 was filed to get a ruling on" becomes "the wall the card behind `d3bf4fa6f` was filed to get a ruling on". - `base.zod.ts`: "objectui#7069 called this repo's systematic producer" becomes "the card behind `2760075ff` called this repo's systematic producer". The commit's own diff attributes that phrase to the card. - The timeline renderer names objectstack-ai#7036's deferral, triage and "1 of 6" trade. These become "the file surface the card behind `869b876c8` deferred", "the triage of the card behind `869b876c8`" and "the card behind `869b876c8` was stopped from making". None of the three is in the commit. 4. **Rulings by date.** - `union-arm-diagnostics.ts`: "the 2026-09-02 ruling on objectui#7004 asks for" becomes "the 2026-09-02 ruling `a5d55472b` implements asks for". - `validate.ts`: "The ARM-SELECTION half of objectui#7004 landed on the 2026-09-02 maintainer ruling" becomes "The ARM-SELECTION half (`a5d55472b`) landed on the 2026-09-02 maintainer ruling". - `7201-schema-slot-census-gate.md`: "across objectui#6882, the ruling that expired both holds" becomes "across the 2026-08-30 ruling that expired both holds (`bf97b98c8`)". - `7687-combobox-option-disabled.md`: "by the objectui#7087 twin-symmetry ruling" becomes "by the 2026-09-01 twin-symmetry ruling, `c93b4d5f3`". - `defaults-table-scan.ts`: "the one objectui#6923 already ruled for exactly that wall" becomes "the one the 2026-08-31 ruling (`d3bf4fa6f`) already set for exactly that wall". 5. **Own-card pointers that needed a word.** - `6931-tombstone-guidance-remainder.md` and `6888-location-residue-refusal-keyed.md`: the pointer sat on its own line, so the period moved up with it. - `7087-disabled-twin-symmetry.md`: the parenthesis opened on the dead card, so the line break moved with it. - `7004-cli-root-path-line.md`: "(objectui#7004, mechanical half)" is dropped, so the sentence ends "sits at the document root." (patch round 1 took the review's nit), and "left open on objectui#7004 for a maintainer ruling" becomes "left open for a maintainer ruling". - `shared-zod-wrapper-keys-6923.md`: "objectui#6923: the Zod wrapper-key list" becomes "The Zod wrapper-key list". - `vi-mock-inherit-slice2.md` and `slice3.md`: "(objectui#6892 slice 2)" becomes "(slice 2)", and likewise for slice 3. 6. **The totality sequence in the timeline renderer.** "(objectstack-ai#6759 -> objectstack-ai#6905 -> objectstack-ai#6907 -> objectstack-ai#7027)" becomes "(objectstack-ai#6759 -> `85f6a6097` -> `7fc5c3c12` -> objectstack-ai#7027)", and likewise with "-> objectstack-ai#7036" as `869b876c8`. objectstack-ai#6759 and objectstack-ai#7027 answer 200 and stay. objectstack-ai#6905 was the pull request whose squash is `85f6a6097`. "⚠️ objectui#7036 — READ THE TWO PARAGRAPHS" becomes "⚠️ `869b876c8` — READ…", and the "see the objectui#7036 note below" that points at it follows. 7. **The runtime strings.** Only the listed text moves in each. | file | member | before | after | |:--|:--|:--|:--| | `types/src/zod/crud.zod.ts` | `ActionSchema.onSuccess` (tombstone) | "RETIRED (objectui#7068) — `onSuccess` is no longer part of this legacy ActionSchema; ..." | "RETIRED (ADR-0049) — `onSuccess` is no longer part of this legacy ActionSchema; ..." | | `types/src/zod/crud.zod.ts` | `ActionSchema.onFailure` (tombstone) | "RETIRED (objectui#7068) — `onFailure` is no longer part of this legacy ActionSchema; ..." | "RETIRED (ADR-0049) — `onFailure` is no longer part of this legacy ActionSchema; ..." | | `types/src/zod/data-display.zod.ts` | `DataTableSchema.rowActions` `.describe()` | "... mirrors the boolean the renderer truthiness-tests (objectui#6940)" | "... mirrors the boolean the renderer truthiness-tests" | | `types/src/zod/data-display.zod.ts` | `DataTableSchema.cellClassName` `.describe()` | "... so row density has to be set on both (objectui#6882)" | "... so row density has to be set on both" | **The ADR-0049 condition, measured from the retirement itself** (Zone 1 item 4): - the zod comment above the two keys opens "ADR-0049 RETIREMENT TOMBSTONES"; - its landing commit `6bca0e4e8` writes them as tombstones, not deletions, and adds the pending `action-callback-retired-7068.md`, which says "ADR-0049 enforce-or-remove"; - each string already ends "Retired under ADR-0049 enforce-or-remove". Both open `RETIRED (ADR-0049) —`. Their TypeScript twins in `crud.ts` read "RETIRED (`6bca0e4e8`, ADR-0049 enforce-or-remove)", the batch 3 twin form. 8. **What follows the strings, and nothing else in it.** `action-callback-retired-7068.test.ts` pins both guidance strings as full literals (`ON_SUCCESS_GUIDANCE`, `ON_FAILURE_GUIDANCE`), and their openings follow. Its test names and four `@ts-expect-error` comments still read "RETIRED (objectui#7068)". They describe the `?: never` TypeScript face, quote no runtime string, and are out of the card's classes (**Acceptance notes** 3). No test, doc or changeset quotes either `.describe()` string: a whole-tree search for each old string returns only the source line. - Patch round 1: three pins quoted re-pointed COMMENT text, and they follow it, anchor only (ruling `5861900779`, route a). - `layout-default-jsdoc-7361.test.ts`: `toContain('6942')` becomes `toContain('57f9b077b')` (the `TextSchema.variant` docblock). - `cellClassNameCensusProse-6921.test.ts`: `toMatch(/objectui#6882|objectstack-ai#6882/)` becomes `toMatch(/bf97b98c8/)` (the `cellClassName` census entry). - The same file: `toMatch(/REDUNDANT since objectui#6882/)` becomes a match on "REDUNDANT since `bf97b98c8`" (the holds-member docblock). - Their titles, messages and comments stay as they are. 9. **The `MarkdownSchema` docblock (patch round 1, review `5861897723`).** Round 0 wrote "Both refuse BY NAME through `retirementTombstone()` (`8063bcbdc`), with the remedy in the message". `8063bcbdc` never touched `MarkdownSchema`; `446d93d4e` retired `sanitize` / `components`. So the sha did not carry what it was cited for, the objectstack-ai#5738 class. It now reads "through `retirementTombstone()`, the spelling `8063bcbdc` made uniform, with the remedy in the message". That commit's own subject says the remaining tombstones carry their remediation text. The edit is a comment, and the file's C4 print is unchanged by it. 10. **The anchor sweep that closes the gap (patch round 1).** - **Instrument:** every string, template, numeric and regex literal in all 3814 test and script files under `packages/` and `scripts/`, enumerated with `git ls-tree` at this head and parsed with TypeScript. - **Test applied to each literal:** does its occurrence count DROP between `main` and this head in any of the 90 files this PR changes? Raw text and a comment-flattened form are both checked. - **Specific anchors found** (a batch number, a changed phrase, or a pattern keyed to them), after reading every hit against the file it sits in: - the three pins above; - `tombstone-discriminator-agreement-9684`'s /RETIRED \(objectui#/ note search, which reads only `mobile.ts` and is untouched by this PR. - **Everything else:** generic tokens (whitespace, punctuation, `objectui#` spellings in ledger checks over the tests' own data, digit and letter classes), none of them an assertion over text this PR changed. - **Round 0's quote search** covered runtime strings only. That is the gap this sweep closes. ## Held **By the serial rule: nothing.** Round 0's list: objectui#10873, objectstack-ai#10871, objectstack-ai#10870, objectstack-ai#10852, objectstack-ai#10821, objectstack-ai#10780, objectstack-ai#10777, objectstack-ai#10714, objectstack-ai#10278 and objectstack-ai#5400. Since then objectstack-ai#10873, objectstack-ai#10871, objectstack-ai#10870 and objectstack-ai#10821 have merged. objectstack-ai#10870 touched `base.zod.ts` in a region apart from this PR's line, and the merge with it is clean. - Re-read before the round-1 push: 11 open. Besides this PR they are objectui#10880, objectstack-ai#10879, objectstack-ai#10878, objectstack-ai#10876, objectstack-ai#10852, objectstack-ai#10780, objectstack-ai#10777, objectstack-ai#10714, objectstack-ai#10278 and the release PR objectstack-ai#5400. - Four of them hold files this PR edits: - objectui#10879: `types/src/zod/data-display.zod.ts`; - objectui#10878: `data-objectstack/src/index.ts` and `plugin-grid/src/ObjectGrid.tsx`; - objectui#10714: `types/src/data-display.ts`, `types/src/layout.ts` and `types/src/zod/data-display.zod.ts`; - objectui#10278: `plugin-grid/src/ObjectGrid.tsx`. - Each one's hunks were read against its merge-base, with 3 lines of context. **None of the 29 lines this PR changes in those files appears inside or beside any of their hunks.** - Trial merges of each open PR head with this head (`git merge-tree --write-tree`) are clean for objectstack-ai#10880, objectstack-ai#10879, objectstack-ai#10878, objectstack-ai#10876, objectstack-ai#10852, objectstack-ai#10780, objectstack-ai#10777 and objectstack-ai#10714. - objectstack-ai#10278 (`eab4c8e52`) conflicts in `ObjectGrid.tsx`, but it conflicts identically against `main` alone: one conflict hunk in its own page-size region either way. - PR objectstack-ai#5400 (Version Packages) regenerates and is not a hold. ## Changesets - `.changeset/10803-dead-citation-sweep-fourth-batch.md`, EMPTY frontmatter: the comment-only edits in 12 released packages and the private `@object-ui/test-support`. No published behaviour changes through them. It points at the second file for the runtime text. - `.changeset/10803-fourth-batch-runtime-strings.md`, `'@object-ui/types': patch`: the two tombstones open `RETIRED (ADR-0049) —` with everything after the dash unchanged, and the two describe strings lose their pointer. No key, path, issue code, accept set, refusal or severity moves. ## Proof of prose-only (C4), against the merged `main` `de1b879a6` - **Source.** Each of the 48 touched `.ts` / `.tsx` files was parsed at `de1b879a6` and at this head with TypeScript 6.0.3's `createSourceFile` and re-printed by `createPrinter({ removeComments: true })`. The 48 are the 45 non-test sources and three tests: the one pinning the strings, and the two whose comment-text anchors follow. - 43 of 48 prints are identical. That includes all 45 non-test sources except `crud.zod.ts` and `data-display.zod.ts`, whose `MarkdownSchema` comment edit moves nothing. - The other 5 are equal once exactly the 9 listed substitutions are applied to the `main` print, each matched once: - `crud.zod.ts`: the two tombstone strings; - `data-display.zod.ts`: the two describe-string deletions; - `action-callback-retired-7068.test.ts`: the same two tombstone strings; - `layout-default-jsdoc-7361.test.ts`: the one anchor; - `cellClassNameCensusProse-6921.test.ts`: the two anchors. - 0 parse diagnostics. - Lit controls on the same instrument: dropping "(ADR-0049)" from the `onSuccess` string moves the print; re-spacing the "ADR-0049 RETIREMENT TOMBSTONES" comment does not. - **Changesets.** The frontmatter block of every one of the 40 edited changesets is byte-identical at `de1b879a6` and this head (40 of 40, by md5). The overwrite gate below agrees. - **Scope of the diff against the merged `main`:** 90 files, +227 / −184: 40 edited and 2 new changesets, 45 non-test source files, and 3 tests. ## Gates, on this head `ae0b81089` Each line is the gate's own verdict and exit code, captured by redirect-then-`$?`. - `node scripts/check-changeset-presence.mjs`, exit 0: "44 source file(s) of 12 released package(s) changed, and this change declares 2 changeset(s): .changeset/10803-dead-citation-sweep-fourth-batch.md, .changeset/10803-fourth-batch-runtime-strings.md." (44 = the 41 released sources and the 3 tests under released packages' `src/`; the four `test-support` files sit under a package changesets ignores.) - `pnpm changeset:check`, exit 0: "All workspace packages are in the changeset fixed group." / "No changeset declares a `major` bump." - `node scripts/check-changeset-overwrite.mjs` (report-only), exit 0: "2 changeset(s) added, 40 modified, 0 deleted". `declared at base` equals `declares now` for 40 of 40. - `pnpm check:changeset-claims` (report-only), exit 0: - born-false: "Every one of those 1 address(es) either names the tree it was read from, or points at a line this change does not move"; - self-contradiction: "Every package declared across those 30 body(ies) is either not negated in its own prose, or negated only in an ASPECT of it that may legitimately hold still"; - the standing notice "83 pending changeset(s) describe a file this change touches". - Read against the diff: a pending changeset quoting a replaced pointer would itself carry the dead number and so sit in the census. No pending changeset quotes either tombstone string or either describe string; the one textual hit, "truthiness-tests" in `6940-rowactions-boolean-mirror.md`, is prose, not a quote. - `pnpm check:control-bytes`, exit 0: "check-control-bytes: OK (scanned 9125 tracked text file(s); skipped 85 binary)." - `pnpm check:new-line-citations`, exit 0: "VERDICT new-cross-file-line-citations: 0 new citation(s), enforcement report-only -> exit 0". - Also run: the governed-surface predicate over the 90 paths, exit 0: "NOT GOVERNED — 90 path(s) checked against 5 governed surface(s); none matched." (lit control `AGENTS.md`: exit 3). **Tests**, through the shared verify lock. - **Red, reproduced first.** - `layout-default-jsdoc-7361` on `d21aeb0f6` itself gives `VERDICT command-exit 1`, `Tests 1 failed | 74 passed (75)`: "expected '/**\n * Text variant/style. …' to contain '6942'". - `cellClassNameCensusProse-6921`: its `d21aeb0f6` copy was checked out over this tree and run. `ObjectGrid.tsx` and the census changesets it reads are identical at `d21aeb0f6` and here. Result: `Tests 2 failed | 3 passed (5)`, on `/objectui#6882|objectstack-ai#6882/` and `/REDUNDANT since objectui#6882/`. The file was then restored with `git checkout HEAD --`, checked by blob hash against `HEAD`, and `git diff HEAD` came back empty. - **Green, on this head `ae0b81089`:** `layout-default-jsdoc-7361`, `cellClassNameCensusProse-6921`, `action-callback-retired-7068`, `data-table-declared-keys-6882`, `tombstone-discriminator-agreement-9684` and `zod-mirror-parity` give `Test Files 6 passed (6)`, `Tests 181 passed (181)`. - The run was the last part of the locked batch, so its exit is the one the lock's `VERDICT batch-last-exit 0` reports. **Declared narrowing (per the dispatch: the named checks, not wider sweeps).** NOT MEASURED locally: the full suites and type-check of the 12 touched packages, and eslint. Reason: the comment-stripped syntax tree of 43 of the 48 touched files is identical to `main`, and the other 5 differ only by the listed literal edits. Every test that anchors on a changed string or comment was found by the anchor sweep (**Special cases** 10) and run above. CI runs the full farm. ## Acceptance notes 1. **The remainder rides this card, unchanged (seat amendment `5860244997`, Q2 = A).** Of the 83 numbers PR objectui#10869's Acceptance notes item 1 lists, this PR carries the first 30 in ascending order. The other **53** are: objectstack-ai#7091 objectstack-ai#7097 objectstack-ai#7108 objectstack-ai#7177 objectstack-ai#7612 objectstack-ai#7620 objectstack-ai#7623 objectstack-ai#7658 objectstack-ai#7666 objectstack-ai#7667 objectstack-ai#7669 objectstack-ai#7678 objectstack-ai#7681 objectstack-ai#7682 objectstack-ai#7703 objectstack-ai#7704 objectstack-ai#7708 objectstack-ai#7804 objectstack-ai#7844 objectstack-ai#7853 objectstack-ai#7869 objectstack-ai#7874 objectstack-ai#7877 objectstack-ai#7926 objectstack-ai#7959 objectstack-ai#7967 objectstack-ai#7979 objectstack-ai#7980 objectstack-ai#8058 objectstack-ai#8060 objectstack-ai#8072 objectstack-ai#8127 objectstack-ai#8137 objectstack-ai#8204 objectstack-ai#8229 objectstack-ai#8248 objectstack-ai#8307 objectstack-ai#8408 objectstack-ai#9231 objectstack-ai#9241 objectstack-ai#9244 objectstack-ai#9365 objectstack-ai#9373 objectstack-ai#9375 objectstack-ai#9542 objectstack-ai#9553 objectstack-ai#9585 objectstack-ai#10117 objectstack-ai#10119 objectstack-ai#10120 objectstack-ai#10129 objectstack-ai#10132 #14026. None of them occurs in any hunk of this diff. 2. **The C0 bare-number 404s, for later batches** (sites at `e32dae160`, lines / files): - **New to the family:** objectstack-ai#3720 (5 / 3), objectstack-ai#5420 (1 / 1), objectstack-ai#5503 (1 / 1), objectstack-ai#5506 (1 / 1), objectstack-ai#5737 (4 / 4), objectstack-ai#6467 (1 / 1), objectstack-ai#6936 (1 / 1), objectstack-ai#6945 (1 / 1), objectstack-ai#7622 (1 / 1), objectstack-ai#7662 (1 / 1), objectstack-ai#7684 (2 / 2). - objectstack-ai#5737, objectstack-ai#6945, objectstack-ai#7622, objectstack-ai#7662 and objectstack-ai#7684 are written "PR #N". A later batch can look for each one's squash commit, as batch 3 did for objectstack-ai#5505 and objectstack-ai#5758. - The objectstack-ai#3720 sites are in `ObjectGrid.tsx`, `rowCrudAffordances.ts` and `ListView.tsx`. `ObjectGrid.tsx` is also held by open PR objectui#10278. - **Already on the family list:** objectstack-ai#7620, objectstack-ai#7678 and objectstack-ai#7853. They have bare sites too, which the printed instrument counts. - **Not read:** the 22 distinct bare numbers above 10900 (budget). Nothing here re-derives whether any of them is dead. 3. **Published or shipped text outside the two in-scope classes still names some of these numbers.** It is untouched by scope, as another class the triage split did not scope here: - `content/docs`: `enhanced-actions.mdx` and `schema-overview.md` say the callbacks were "RETIRED (objectui#7068)" in prose, not as verbatim quotes of the runtime string; `plugin-form.mdx` names objectui#6958. - The private `@object-ui/test-support` README names objectui#6923 and objectstack-ai#6924. - Published `CHANGELOG.md` history, which is never re-addressed. It includes a bare "framework PR objectstack-ai#6942" in `@object-ui/app-shell`'s. - In tests: `action-callback-retired-7068.test.ts`'s test names and four `@ts-expect-error` comments reading "RETIRED (objectui#7068)"; `layout-default-jsdoc-7361.test.ts`'s header-table comment naming objectui#6942; and the test names and comments in `cellClassNameCensusProse-6921.test.ts` that name objectstack-ai#6882. Only anchors moved (ruling `5861900779`). - Carrier: none. 4. **Filenames are not citations.** Pending changeset and test FILENAMES carry several of these numbers. They stay, as in PRs objectui#10707, objectstack-ai#10797, objectstack-ai#10854 and objectstack-ai#10869. --- _Generated by [Claude Code](https://claude.ai/code/session_014mXUNuFomfj24w7s1pZzhN)_ --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6924
17 hand-written
(Schema as { options?: readonly string[] }).optionscasts across16 test files in 11 workspace packages read
.optionsstraight off a node thatIS the enum. The cast is unchecked: an enum that acquires a wrapper, or a Zod build
that moves
.options, yieldsundefined, the derived vocabulary silently becomesthe empty set, and every assertion built on it passes over nothing.
The shape, and why it is not a fifth approach
The triage ruling required reading #5872's current conclusion first and not
inventing a fifth way. #5872 class (1) landed a shared reader,
packages/test-support/src/spec-enum-options.ts. Reading it on disk: it alreadywalks the wrapper chain, already accepts
unwrap()/def.innerType/_def.innerType, and its loop checksnode.optionsbefore unwrapping — so itanswers a bare enum correctly the moment it is handed one.
The one thing it could not do for this family is reach the node: it opens with
resolvePropsShape(schema)and then indexesshape[key], so given a node that isalready the enum there is no shape to resolve and no key to index, and it
returns
[].That is a missing entry point, not a missing reader. So:
shapeEnumOptionsnow delegates — its body isresolvePropsShapeplus onecall. There is exactly one wrapper walk in the repository, and a new pin
(
the two entry points are one walk) fails if that stops being true; the wrapperfixtures alone would keep passing against a second copy.
The enumeration, re-derived
Instrument:
grep -rn 'options?: readonly string\[\]' --include='*.ts' --include='*.tsx'over the whole tree, not just
packages/, onorigin/main@501041f97.16 call-site files / 17 occurrences, plus the reader module itself (17 paths
matched in total).
The card said 15 files under
packages/. That count is right forpackages/;the 16th,
examples/schema-catalog/test/component-fixture-declared-keys.test.ts,is outside it and was missed by a
packages/-scoped grep.plugin-reportcarries two occurrences in one file, which is where the card's "2 sites" for that
package comes from.
Every one of the 16 is a test file. No production module reads the vocabulary
this way.
packages/fields' site isFieldEditWidget.test.ts:111, a differentfile from
FieldEditWidget.tsx.Non-vacuity: measured, and the card's expectation was wrong
The card says "nothing in this family is known to carry such an assertion — that is
the first thing a round on this card should measure". Measured: 16 of 17
occurrences already carried one, in three shapes.
examples/schema-catalog/.../component-fixture-declared-keys.test.tsnot an enum-bearing fieldapp-shell/.../color-variant-field.test.tsxit('reads a non-empty enum from the spec')app-shell/.../previews/__tests__/block-config.test.tsit('reads a non-empty enum from the spec')app-shell/.../previews/__tests__/palette-discussion-alias.test.tsxtoContaincomponents/__tests__/toaster-position-spec-parity.test.tsxit('reads a non-empty enum from the spec')components/notifications/__tests__/notification-surfaces.test.tsx.not.toEqual([])inside the coverage testfields/FieldEditWidget.test.tsit('reads a non-empty enum from the spec')plugin-charts/__tests__/chart-type-spec-parity.test.tsxit('reads a non-empty enum from the spec')plugin-dashboard/__tests__/DatasetWidget.colorVariant.test.tsxit('reads a non-empty enum from the spec')plugin-dashboard/__tests__/pivot-aggregation-spec-parity.test.tsxit('reads a non-empty enum from the spec')plugin-dashboard/__tests__/widget-dispatch-spec-parity.test.tsit('reads a non-empty enum from the spec')plugin-detail/__tests__/inlineEditTypeCoverage.test.tsxit('reads a non-empty enum from the spec')plugin-grid/__tests__/summary-spec-parity.test.tsit('reads a non-empty enum from the spec')plugin-report/__tests__/report-spec-parity.test.tsx(chart)it('reads a non-empty enum from the spec')plugin-report/__tests__/report-spec-parity.test.tsx(report)it('reads a non-empty enum from the spec')react/hooks/__tests__/animation-notification-spec-parity.test.tsxassertParitytypes/__tests__/spec-derived-unions.test.tsoptionsOfthrows on emptyThe one gap,
palette-discussion-alias.test.tsx, gains the named assertion here.It was not silent before — its
toContainprobes would red on an empty list —but they say "the spec dropped this member", which sends the next reader to the
contract instead of to the reader.
This is worth recording because it changes the card's risk framing without
changing its premise: the duplication was real, the silent-emptying was already
guarded almost everywhere.
Verdict preservation: measured, not assumed
A throwaway suite reproduced the exact hand-written reading each site carried on
501041f97and compared it toenumOptions(node)for the same node —23 readings, all IDENTICAL, same members, same order, all non-empty (so the
equality cannot pass by both sides being
[]). Examples:The measurement suite is deleted, not shipped — the same disposition #5872 class (1)
took. What ships instead is the permanent pin that the two entry points agree.
Ablation: an empty reader reds every converted site
Forced
enumOptionstoreturn []on top of the landed commit, then ran all 16converted files. Mutation proved on disk before the run (injected-marker count 1,
worktree blob hash moved off the HEAD blob); restore proved after (hash back to
the HEAD blob,
git diff HEADempty, marker count 0); the script carries atrap ... EXIT INT TERMrestore with an absolute repo path. No build leg is owed:@object-ui/test-supporthas nodist, and both itsexportsmap and the rootvitest alias point at
src/, so the mutated source IS what every suite loads.Result: 16 of 16 files fail loudly. 15 fail on assertions (41 failing tests);
component-fixture-declared-keys.test.tsfails at collection, because its readerthrows at module scope. Zero silently-green suites. This is the assertion the
card asked for: the family cannot go quietly permissive.
What changed, per site
Converted, all 16:
examples/schema-catalog/test/component-fixture-declared-keys.test.ts,app-shellcolor-variant-field / block-config / palette-discussion-alias,componentstoaster-position / notification-surfaces,fieldsFieldEditWidget,plugin-chartschart-type,plugin-dashboardDatasetWidget.colorVariant /pivot-aggregation / widget-dispatch,
plugin-detailinlineEditTypeCoverage,plugin-gridsummary,plugin-reportreport-spec-parity (both),reactanimation-notification,
typesspec-derived-unions.Exclusions: none. Every site the instrument found is converted.
Two sites keep a local wrapper around the shared reader rather than replacing
their behaviour:
types/spec-derived-unions.test.ts:optionsOfandschema-catalog:enumOptionsOfboth throw on an unreadable enum. The walk movesto the shared reader; the throw stays, because the reader deliberately answers
[]and the throw is those files' non-vacuity duty.
Six packages gain the
"@object-ui/test-support": "workspace:*"devDependency edgethe README's convention requires:
plugin-charts,plugin-dashboard,plugin-grid,plugin-report,react,types. Nodependenciesand no published type moved;packages/types' change is confined to its test file and a devDependency.Checks run, all on
7663a4892pnpm exec vitest runover test-support, types, schema-catalog, plugin-list, plugin-timeline, components, fields, react, plugin-charts, plugin-report, plugin-grid, plugin-dashboard, plugin-detail, app-shell (2 shards)pnpm exec vitest run scripts/Test Files 90 passed (90)/Tests 2572 passed (2572)turbo run type-checkover the 11 affected packagesTasks: 41 successful, 41 totalturbo run lint(whole farm, plain form)Tasks: 47 successful, 47 total, 0 errorsnode scripts/check-changeset-presence.mjs15 source file(s) of 10 released package(s) changed, and this change declares 1 changeset(s)node scripts/check-control-bytes.mjsOK (scanned 5818 tracked text file(s))pnpm check:phantom-depsEvery in-scope import is declared by the package that publishes it.pnpm check:self-importNo package names itself inside its own src/.pnpm check:readme-exports(afterturbo run build)OK (386 self-imports judged, 386 real, 0 fabricated)pnpm check:spec-symbols1325 files scanned, 0 untriaged collisionsnode scripts/check-type-check-coverage.mjs45/46 via type-check,41/41 packages compile their testsnode scripts/check-lint-coverage.mjs46/46 packages linted, 0 with outstanding errorspnpm check:vi-mock-specifiers,check:vi-mock-inheritnode scripts/check-pre-install-import-graph.mjspnpm check:side-effects-array,check:entry-guard,check:esm-specifierspackages/types'type-checkwas confirmed to actually read the edited file:tsc -p tsconfig.test.json --listFileslists bothspec-derived-unions.test.tsand
test-support/src/spec-enum-options.ts. A "typecheck is clean" that excludedthem would have said nothing.
One transient red is worth recording so nobody re-finds it:
scripts/__tests__/check-sdui-registration-pins.test.tsfails only while a localturbo run buildoutput is on disk — it then derivespackages/app-shell/dist/console/connect/ConnectAgentWidget.jswhere it expects thesrc/path. Withpackages/*/distremoved it passes 11/11, and this branch toucheszero files under
app-shell/src/console/. Pre-existing environment sensitivity, notthis diff.
Out of scope, filed separately
A sibling family turned up that this card's instrument does not select: 9 sites
spelling the cast non-optionally (
as { options: readonly string[] }), so afailed cast spreads
undefinedand throws rather than going quietly empty. Differentfailure class, same hand-copied reader; recorded rather than folded in, and the
follow-up card names them. Not addressed here; #6924 is the quiet-permissive half.
Generated by Claude Code