Skip to content

fix(app-shell): the metadata-admin designer's own i18n table uses the typographic ellipsis (#4377) - #4385

Merged
yinlianghui merged 1 commit into
mainfrom
claude/issue-4377-designer-table-ellipsis
Aug 12, 2026
Merged

yinlianghui merged 1 commit into
mainfrom
claude/issue-4377-designer-table-ellipsis

Conversation

@yinlianghui

@yinlianghui yinlianghui commented Aug 12, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes #4377

The metadata-admin designer does not read the ten locale packs — it carries its own flat en/zh table — so objectui#3878, which converged those packs on the typographic ellipsis U+2026 per the consistency pass on objectstack#6015, left it behind. The designer renders inside the console shell, so its Select... sat on screen beside the packs' Select….

Entry count: 10 — the card's table was exhaustive

Swept the whole file for ASCII ... in values, not just the five keys the card names:

$ grep -c '\.\.\.' packages/app-shell/src/views/metadata-admin/i18n.ts
10

All ten are the card's five keys in each of the two blocks — engine.form.select, engine.form.selectObjectDots, engine.form.addObjects, engine.form.selectFieldDots, engine.form.addFields. No sixth key, and no mid-sentence occurrence. After the change the only ... left in the file are the two inside the new header note, where the rejected form is quoted deliberately.

For scale: the file already held 126 values using …, so the ten were a genuine minority pocket rather than a table-wide convention.

Before / after

-  'engine.form.select': 'Select...',
+  'engine.form.select': 'Select…',
   'engine.form.selectEllipsis': 'Select…',
...
-  'engine.form.selectObjectDots': '选择对象...',
-  'engine.form.addObjects': '添加对象...',
+  'engine.form.selectObjectDots': '选择对象…',
+  'engine.form.addObjects': '添加对象…',

Pin sweep: zero tests to move

Measured before editing, over packages/, apps/, examples/, scripts/:

$ git grep -n "Select\.\.\.\|请选择\.\.\.\|选择对象\.\.\.\|添加对象\.\.\.\|选择字段\.\.\.\|添加字段\.\.\.\|Select object\.\.\.\|Add objects\.\.\.\|Select field\.\.\.\|Add fields\.\.\."

Ten hits were the table itself. The other three hits are not pins on these values and are untouched here:

  • packages/components/src/custom/action-param-dialog.tsx:198 — an independent hardcoded 'Select...' fallback placeholder in a different package (filed, see below).
  • packages/components/src/__tests__/action-param-label-association.test.tsx:22 — a comment describing that component's accessible name, not this table.
  • examples/schema-catalog/src/schemas/components-form-select/with-placeholder.json — an example schema's own placeholder value.

A looser sweep for getByText / getByPlaceholderText near these keys found nothing either. pins_moved: 0, measured rather than assumed.

The header note, and why no gate

The five keys' only consumers are widgets.tsx:396 and widgets.tsx:527; the convention is now recorded in the table's header, citing objectstack#6015, objectui#3878 and packages/i18n/src/__tests__/ellipsis-glyph-3878.test.ts — whose own header already records that it scans the ten packs by design and so cannot reach this table. Per the card's costing, which the dispatch accepted, generalising that pin to a second table shape (flat Record of dotted keys, en and zh in one file, no ten-pack parity) is more machinery than the defect is worth. No pin was added.

Verification

command result
pnpm exec vitest run packages/app-shell/src/views/metadata-admin/ --maxWorkers=2 144 files passed, 1511 passed / 1 skipped
tsc --noEmit -p tsconfig.json (app-shell) exit 0
tsc -p tsconfig.test.json (app-shell) exit 0
pnpm exec eslint on the touched file exit 0
node scripts/check-control-bytes.mjs OK, 4089 files scanned
node scripts/check-changeset-presence.mjs OK, 1 changeset declared
node scripts/check-changeset-no-major.mjs OK

Both type-checks first failed with TS2307 Cannot find module in a fresh worktree; that is the build-closure trap, not this change — pnpm --filter '@object-ui/app-shell^...' build first, then both are clean.

Changeset: patch for @object-ui/app-shell (user-visible copy), never major.

Filed, not fixed here


Generated by Claude Code

)

The metadata-admin designer carries its own flat en/zh table rather than
reading the ten locale packs, so #3878 -- which converged those packs on
U+2026 per the consistency pass on objectstack#6015 -- left it behind.
Ten values across five keys still ended in three ASCII full stops, and
the designer renders inside the console shell, so `Select...` sat on
screen beside the packs' `Select...` in its typographic form.

All ten now use U+2026. The table's header records the convention and
why it is held by a note rather than a gate: `ellipsis-glyph-3878.test.ts`
scans the ten packs by design, and generalising it to this second table
shape was costed as more machinery than the defect is worth.

Fixes #4377
@vercel

vercel Bot commented Aug 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectui Ignored Ignored Aug 12, 2026 12:36am

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Main entry (gzip) 24.7 KB 350 KB
Entry file index-WJhhCOX7.js —
Status PASS —

📦 Bundle Size Report

Package Size Gzipped
app-shell (index.js) 9.56KB 3.59KB
app-shell (runtime-config.js) 7.42KB 2.32KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 8.92KB 3.41KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 1.17KB 0.53KB
auth (AuthProvider.js) 22.10KB 4.37KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.13KB 5.39KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.64KB 2.21KB
auth (SocialSignInButtons.js) 9.60KB 3.89KB
auth (UserMenu.js) 3.40KB 1.22KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 35.76KB 9.11KB
auth (createAuthenticatedFetch.js) 4.37KB 1.69KB
auth (index.js) 2.35KB 1.07KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 4.91KB 0.87KB
auth (useIsWorkspaceAdmin.js) 1.61KB 0.85KB
collaboration (CommentThread.js) 26.07KB 7.56KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.49KB 2.64KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.65KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.05KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 489.12KB 108.41KB
core (index.js) 2.99KB 1.14KB
create-plugin (index.js) 10.08KB 3.26KB
data-objectstack (index.js) 151.72KB 40.42KB
fields (index.js) 228.37KB 56.62KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (currency.js) 1.22KB 0.64KB
i18n (i18n.js) 4.32KB 1.77KB
i18n (index.js) 3.35KB 1.38KB
i18n (pickLocalized.js) 3.69KB 1.73KB
i18n (provider.js) 23.12KB 7.62KB
i18n (useDisplayLocale.js) 2.33KB 1.20KB
i18n (useObjectLabel.js) 27.59KB 6.63KB
i18n (useSafeTranslation.js) 7.77KB 3.13KB
layout (index.js) 38.98KB 10.85KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.74KB
mobile (index.js) 1.50KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.71KB 0.42KB
mobile (useResponsiveConfig.js) 1.36KB 0.63KB
mobile (useSpecGesture.js) 4.32KB 1.64KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 8.75KB 3.06KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 3.67KB 1.12KB
permissions (evaluator.js) 4.41KB 1.44KB
permissions (index.js) 0.91KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.52KB
permissions (usePermissions.js) 1.55KB 0.71KB
plugin-ai (index.js) 15.71KB 3.79KB
plugin-calendar (index.js) 45.23KB 12.45KB
plugin-charts (index.js) 62.18KB 17.67KB
plugin-chatbot (index.js) 180.33KB 42.79KB
plugin-dashboard (index.js) 121.60KB 31.63KB
plugin-designer (index.js) 210.91KB 42.67KB
plugin-detail (index.js) 239.00KB 59.76KB
plugin-editor (index.js) 2.46KB 1.10KB
plugin-form (index.js) 114.58KB 27.68KB
plugin-gantt (index.js) 164.14KB 39.98KB
plugin-grid (index.js) 188.00KB 49.93KB
plugin-kanban (index.js) 48.60KB 13.41KB
plugin-list (index.js) 110.10KB 26.74KB
plugin-map (index.js) 18.05KB 5.80KB
plugin-markdown (index.js) 13.72KB 4.69KB
plugin-report (index.js) 40.60KB 10.58KB
plugin-timeline (index.js) 26.21KB 7.52KB
plugin-tree (index.js) 8.50KB 2.88KB
plugin-view (index.js) 84.03KB 20.55KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.71KB 3.53KB
providers (index.js) 0.44KB 0.22KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.67KB 2.37KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 23.71KB 7.96KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 1.23KB 0.66KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (codegen.js) 4.09KB 1.74KB
sdui-parser (index.js) 4.47KB 2.03KB
sdui-parser (parse.js) 10.04KB 2.82KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 4.69KB 1.48KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.87KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (http-retry.js) 4.32KB 2.02KB
types (index.js) 3.05KB 1.52KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 2.59KB 1.31KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 5.05KB 1.93KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 0.20KB 0.18KB
types (ui-action.js) 3.40KB 1.71KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

Copy link
Copy Markdown
Collaborator Author

ACCEPT — PM 复核 (session session_017Qqyix2QcnpUC9XeYVDzx3), closes #4377.

Flipping ready + arming auto-merge.


Generated by Claude Code

@yinlianghui
yinlianghui marked this pull request as ready for review August 12, 2026 00:58
@yinlianghui
yinlianghui added this pull request to the merge queue Aug 12, 2026
Merged via the queue into main with commit b318273 Aug 12, 2026
21 checks passed
@yinlianghui
yinlianghui deleted the claude/issue-4377-designer-table-ellipsis branch August 12, 2026 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants