Repository navigation
docs(ci): 删除未钉住的 .github/WORKFLOWS.md 副本清单,真内容并入 pinned 的 ci-cd-pipeline.md (#3724) - #3745
Merged
Merged
Conversation
…y, move what was true into the pinned guide page (#3724) `.github/WORKFLOWS.md` was a second, hand-maintained workflow inventory that nothing pinned and nothing linked to. Measured at origin/main it documented 5 workflows that do not exist (changeset-check, codeql, deploy-docs, pr-checks, size-check) and omitted 9 that do, `lint.yml` — a real PR gate — among them. That is objectui#3212 verbatim, on a page no test could see. Deleted rather than re-pinned: an unpinned duplicate inventory is a drift generator by construction, and content/docs/guide/ci-cd-pipeline.md already tracks .github/workflows/ in both directions. Audited the deleted page and moved only what is true and was absent from the guide page: - Lockfile merge driver: the .gitattributes half and the add-it-to-a-new-workflow half existed nowhere else. Its workflow list had drifted in BOTH copies — the guide named changeset-release + dependabot-auto-merge, the deleted page named changeset-release + changelog; all three carry the step. Pinned in both directions so the moved list cannot drift a third time. - stale.yml exempt labels: the guide stated one merged list that was wrong for both resources. Issues and PRs have separate, non-overlapping lists. - An "If it fails" note for the console bundle budget, the one true piece of failure guidance the deleted page carried. - An explicit denial of the fictional changeset gate and its `skip-changeset` label (verified: no such workflow has ever existed, and the repository has no such label), mirroring the size-check precedent. Dropped as false or duplicative: the codeql / pr-checks / deploy-docs / size-check / changeset-check sections, an "Issue & PR Templates" section describing templates .github/ does not contain, a CodeQL badge, the labeler label enumeration (drift-prone restatement of .github/labeler.yml), generic best-practices/troubleshooting/maintenance prose, and an unowned "Future Enhancements" wishlist. Fixes #3724
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3724
前提复核(在
origin/main@8ad6070fb重新测量)正文的 5/9 两份清单逐项成立,无偏移。按
**File**: ...yml条目机械比对.github/workflows/(现存 16 个 workflow):changeset-check.yml、codeql.yml、deploy-docs.yml、pr-checks.yml、size-check.ymlchangeset-guard.yml、check-links.yml、control-bytes.yml、cross-repo-issue-closer.yml、docs-links.yml、live-e2e.yml、lint.yml、performance-budget.yml、shadcn-check.ymlskip-changesetlabel 也复核了:不存在(labels API 返回 not found);全仓git grep skip-changeset只命中被删的那一页自身两行。两名当中只有dependencies真实存在,由 auto-labeler 打,没有任何门禁读它。裁决执行:路由 1(删除)
按 #3261 仓规,一份没有钉住的手工副本清单按构造就是漂移生成器 ——
content/docs/guide/ci-cd-pipeline.md已经把.github/workflows/双向钉死,副本继承不到其中任何一条,却读起来一样权威。所以是删,不是再加一道棘轮。入链引用:零。
git grep -i 'WORKFLOWS\.md'全仓(含docs/、apps/site、skills/、脚本、workflow YAML)无命中;check-doc-links.mjs的SCAN_ROOTS也不含.github/,所以这一页既没人链、它自己的外链也从来没被检查过。删除对 check-doc-links 零影响(已实测,7 个 scan root 全绿)。从被删页搬走了什么(真且 guide 页缺)
## Lockfile Merge Driver).gitattributes那一半、以及「新 workflow 怎么加这一步」那一半,全仓别处都没有。而且这条声明在两份副本里都是错的:guide 页写changeset-release.yml+dependabot-auto-merge.yml,被删页写changeset-release.yml+changelog.yml—— 实测三个都带这一步,各漏一个,且两边都没有任何检查。stale.yml豁免 labelpinned, security, critical, in-progress),对 issue 和 PR 两边都错。实测两份列表分开设置且互不包含:issue 是pinned, security, critical, bug, enhancement;PR 是pinned, security, in-progress, blocked。被删页的 issue 那一份是对的。**If it fails:**(control-bytes 与 docs-links 两段都有)。丢掉了什么(假的或纯重复)
size-check.yml)、Changeset Check。.github/下既没有ISSUE_TEMPLATE/也没有pull_request_template.md,那节描述的 bug report / feature request / config 三个模板和 PR checklist 一个都不存在。(这不是缺陷,只是文档凭空描述;随页面一起消失,未另开 issue。).github/labeler.yml的会漂移的转述,且已经漏了designer/data-adapter/breaking-change/plugin)、dependabot.yml配置转述、泛化的 Best Practices / Troubleshooting / Maintenance、没有归属的 Future Enhancements 愿望清单、Resources 链接堆。CONTRIBUTING.md的 “When to Create a Changeset”(含 DON'T 列表),那才是真指引 —— 被删页的错在把它包装成一道可以用 label 跳过的门禁。钉子:只为搬过来的内容加,双向
把一份已经漂移过的手工列表搬进无钉散文,等于换个地方重建漂移生成器,与本次裁决自身的理由相矛盾。所以新增两条(
scripts/__tests__/ci-cd-pipeline-doc.test.ts):lockfile merge driver—— 表格 ↔ 真正配置了merge.pnpm-merge的 workflow 集合,双向;外加.gitattributes那一半仍然为真(否则页面在描述一个没人调用的驱动)。keeps this page as the only workflow inventory—— 断言.github/WORKFLOWS.md不复活。范围已在注释里写明其边界:它只钉住那一个曾存在的路径,换个名字的新清单绕得过去;真正的持久保护是「加 workflow 本来就必须改 guide 页」,所以第二份页面挣不到任何东西。反向验证(5 项,方向均先判后跑)
.github/WORKFLOWS.mdkeeps this page as the only workflow inventorychangelog.yml行...have no row: - changelog.ymlci.yml...do NOT configure merge.pnpm-merge: - ci.yml.gitattributes删merge=pnpm-mergeno longer routes pnpm-lock.yaml through the pnpm-merge driver### Changeset Check (changeset-check.yml)标题documents changeset-check.yml, which is not in .github/workflows/每次都是
1 failed | 17 passed,还原后18 passed。门禁实测
未跑 prettier(AGENTS.md §195:本仓无格式化门禁,全局 prettier 默认配置会对逐字节等于
main的文件报红)。Changeset
不带。 纯文档 + 钉测试改动,不碰任何
packages/源码。查了origin/main最近 40 个提交里的 16 个docs(...)提交,16/16 都没有 changeset,先例一致。Generated by Claude Code