fix(auth): login silent-failure UX — SSO pending states, redirect-URL contract, OAuth callback error banner (#2458 item 1) by os-zhuang · Pull Request #2468 · objectstack-ai/objectui

os-zhuang · 2026-07-13T20:54:55Z

Fixes item 1 (🔴 登录提交"无声失败") of #2458.

Ownership verdict

The login surface is objectui-owned — the console SPA (apps/console + @object-ui/auth) serves /_console/login on both the cloud (:4900) and every env host; framework's better-auth server side behaves as designed with one exception (below). Live re-investigation on the run-stack rig found:

The email/password submit already had a pending state, inline error banner, and post-login OAuth continuation (followOauthAuthorize, fix(auth): cloud login SPA follows the oauth2/authorize redirect (env→cloud SSO) #2008) — these were live-verified working. Part of what the three test sessions saw was a stale served console bundle (the rig node-resolves @objectstack/console to framework/packages/console/dist, bypassing run-stack's overlay) plus click/typing automation artifacts.
One genuine silent dead-end was reproduced on current code: when the OAuth hand-off's signed params / state go stale (10-min exp, single-use state — easy in a slow real-world session), the cloud still issues a code, the env callback rejects with state_mismatch, and better-auth's default error redirect (/?error=state_mismatch) loses its query on the root→console hop. The user who just typed a correct password lands on a silent login form — exactly the reported symptom (the env and cloud login forms are visually identical).
The SSO/provider buttons ("Continue with ObjectStack") had no pending state, and a provider sign-in that resolved without a redirect URL was a silent no-op.

Changes

SocialSignInButtons: pending spinner + disabled while signInWithProvider is in flight, double-click guard, inline failure surfacing (button re-enables only on failure — success ends in navigation).
createAuthClient.signInWithProvider: throws when the server response carries no redirect URL (both oidc and social paths) instead of resolving silently.
LoginForm "Sign in with SSO": pending state on the raw /sign-in/sso fetch.
LoginPage: renders ?error= / ?error_description= (better-auth OAuth callback failure codes) as a visible AuthErrorBanner — zh/en strings added (auth.login.errors.oauthCallbackFailed).
Paired framework PR (objectstack-ai/framework — plugin-auth onAPIError.errorURL → /_console/login) makes the server land callback errors where this banner is. The banner is inert until that merges; merge this UI PR first.

Verification (live browser on the run-stack rig, fixed bundle overlaid)

Proof	Result
(a) wrong password	inline 邮箱或密码错误 banner, button re-enabled ✅
(b) correct password, plain login	redirects to console home ✅
(c) env → Continue with ObjectStack → cloud login (signed OAuth params) → 登录	full hand-off completes, lands signed-in on the env ✅
(d) backend stopped, submit	visible inline "Failed to fetch", button re-enabled — not console-only ✅
`?error=state_mismatch` on login	visible banner: 单点登录未能完成——登录链接已过期或已被使用… (state_mismatch) ✅

Scoped tests: packages/auth (LoginForm / SocialSignInButtons / createAuthClient) + apps/console LoginPage banner — 53 tests green.

🤖 Generated with Claude Code

… contract, OAuth callback error banner (#2458 item 1) Three UI gaps let a login "succeed" or fail with zero feedback: - SocialSignInButtons: provider buttons ("Continue with ObjectStack") had no pending state and swallowed a sign-in call that resolved without navigating. Buttons now disable + spin while in flight, block double-clicks, and surface failures inline. - createAuthClient.signInWithProvider: resolving without a redirect URL (oidc + social paths) was a silent no-op — now throws so callers can render the error. - LoginForm "Sign in with SSO": raw fetch had no pending state — added. - LoginPage: a failed OAuth callback (expired/replayed state, IdP error) redirects back to the login page with ?error=<code>; the page now renders it as a visible banner instead of a silent login form. Paired framework change points better-auth onAPIError.errorURL at /_console/login so the code survives the redirect (today it dies on the root redirect: the env callback 302s to /?error=state_mismatch and the root→console hop drops the query). Live-verified on the run-stack rig (cloud 4900 / env 5900): wrong-password inline error, plain login redirect, full env→SSO→cloud→env OAuth hand-off, and the state_mismatch silent dead-end reproduced then surfaced. Refs #2458 (item 1) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

vercel · 2026-07-13T20:55:01Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Jul 13, 2026 8:55pm

github-actions · 2026-07-13T20:58:35Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	26.6 KB	350 KB
Entry file	`index-DsjafD1l.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	7.84KB	2.85KB
app-shell (runtime-config.js)	7.56KB	2.37KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	7.57KB	2.97KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	21.70KB	4.21KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.12KB	3.41KB
auth (LoginForm.js)	17.12KB	5.00KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.63KB	2.15KB
auth (SocialSignInButtons.js)	9.60KB	3.89KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	30.17KB	7.28KB
auth (createAuthenticatedFetch.js)	3.93KB	1.55KB
auth (index.js)	1.83KB	0.79KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.86KB	0.85KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	18.38KB	4.49KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	3.65KB	1.42KB
collaboration (PresenceProvider.js)	2.42KB	0.96KB
collaboration (index.js)	1.25KB	0.53KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	441.58KB	95.30KB
core (index.js)	1.65KB	0.59KB
create-plugin (index.js)	9.28KB	2.98KB
data-objectstack (index.js)	113.70KB	28.15KB
fields (index.js)	202.54KB	49.50KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.46KB	0.96KB
i18n (pickLocalized.js)	1.31KB	0.67KB
i18n (provider.js)	5.37KB	1.72KB
i18n (useObjectLabel.js)	21.15KB	4.68KB
i18n (useSafeTranslation.js)	2.68KB	0.98KB
layout (index.js)	38.45KB	10.67KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	4.42KB	1.27KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	1.77KB	0.77KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	5.09KB	1.84KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.46KB	1.03KB
permissions (evaluator.js)	4.00KB	1.23KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.50KB	0.70KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	45.12KB	12.34KB
plugin-charts (index.js)	46.31KB	13.06KB
plugin-chatbot (index.js)	176.18KB	42.05KB
plugin-dashboard (index.js)	108.35KB	26.87KB
plugin-designer (index.js)	213.94KB	43.03KB
plugin-detail (index.js)	210.10KB	50.68KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	104.26KB	25.24KB
plugin-gantt (index.js)	141.17KB	35.08KB
plugin-grid (index.js)	171.84KB	45.38KB
plugin-kanban (index.js)	48.16KB	12.94KB
plugin-list (index.js)	98.52KB	23.24KB
plugin-map (index.js)	16.80KB	5.24KB
plugin-markdown (index.js)	13.65KB	4.67KB
plugin-report (index.js)	37.82KB	9.96KB
plugin-timeline (index.js)	25.37KB	7.20KB
plugin-tree (index.js)	8.21KB	2.76KB
plugin-view (index.js)	85.51KB	20.81KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.55KB	0.67KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	3.19KB	1.38KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	18.23KB	5.97KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	0.79KB	0.43KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	2.16KB	0.94KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
tenant (TenantContext.js)	0.31KB	0.25KB
tenant (TenantGuard.js)	1.04KB	0.43KB
tenant (TenantProvider.js)	2.76KB	0.98KB
tenant (TenantScopedQuery.js)	0.77KB	0.44KB
tenant (index.js)	0.75KB	0.38KB
tenant (resolver.js)	2.64KB	0.76KB
tenant (useTenant.js)	0.50KB	0.32KB
tenant (useTenantBranding.js)	0.62KB	0.39KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	0.77KB	0.41KB
types (disclosure.js)	0.20KB	0.18KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (index.js)	1.54KB	0.68KB
types (layout.js)	0.20KB	0.18KB
types (mobile.js)	0.20KB	0.18KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.26KB	1.96KB
types (tenant.js)	0.20KB	0.18KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	0.75KB	0.46KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

github-actions Bot added apps tests labels Jul 13, 2026

os-zhuang mentioned this pull request Jul 13, 2026

fix(plugin-auth): land OAuth callback errors on the console login page (objectui#2458 item 1) objectstack-ai/objectstack#2888

Merged

os-zhuang merged commit 42f6e13 into main Jul 13, 2026
10 checks passed

os-zhuang deleted the claude/interesting-northcutt-6970a3 branch July 13, 2026 20:56

os-zhuang mentioned this pull request Jul 14, 2026

console-ai UX:三轮真实浏览器魔法流程测试的体验问题清单(登录无声失败/agent 蓝图感知/转介等待/i18n 混杂等) #2458

Closed

Navigation Menu

Repository navigation

fix(auth): login silent-failure UX — SSO pending states, redirect-URL contract, OAuth callback error banner (#2458 item 1) - #2468

fix(auth): login silent-failure UX — SSO pending states, redirect-URL contract, OAuth callback error banner (#2458 item 1)#2468
os-zhuang merged 1 commit into
mainfrom
claude/interesting-northcutt-6970a3

os-zhuang commented Jul 13, 2026

Uh oh!

vercel Bot commented Jul 13, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jul 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

os-zhuang commented Jul 13, 2026

Ownership verdict

Changes

Verification (live browser on the run-stack rig, fixed bundle overlaid)

Uh oh!

vercel Bot commented Jul 13, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jul 13, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant