Skip to content

Remove invalid CSS cross-import in fields package - #244

Merged
hotlong merged 2 commits into
copilot/develop-field-type-componentsfrom
copilot/update-action-job-step
Jan 28, 2026
Merged

hotlong merged 2 commits into
copilot/develop-field-type-componentsfrom
copilot/update-action-job-step

Conversation

Copilot AI commented Jan 28, 2026 •

Copy link
Copy Markdown
Contributor

Build failed when the fields package attempted to import @object-ui/components/style.css. During Vite build, the import resolved to the non-existent source path /packages/components/src/style.css instead of the published export.

Changes

  • Removed packages/fields/src/index.css containing @import '@object-ui/components/style.css'
  • Removed CSS import from packages/fields/src/index.tsx

Library packages should not cross-import CSS - consuming applications import styles directly via published package exports. This aligns with patterns used elsewhere in the monorepo (components, runner, etc.).

Original prompt

引用: https://github.com/objectstack-ai/objectui/actions/runs/21423409974/job/61687618812#step:8:1


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@vercel

vercel Bot commented Jan 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
objectui-crm-app Ready Ready Preview, Comment Jan 28, 2026 3:32am
objectui-site Ready Ready Preview, Comment Jan 28, 2026 3:32am

Request Review

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot AI changed the title [WIP] Update action job step for better clarity Remove invalid CSS cross-import in fields package Jan 28, 2026
Copilot AI requested a review from hotlong January 28, 2026 03:34
@hotlong
hotlong marked this pull request as ready for review January 28, 2026 03:37
Copilot AI review requested due to automatic review settings January 28, 2026 03:37
@hotlong
hotlong merged commit e4c0585 into copilot/develop-field-type-components Jan 28, 2026
7 checks passed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a build failure in the @object-ui/fields package by removing an invalid CSS cross-import. The build was failing because @import '@object-ui/components/style.css' resolved to a non-existent source path during Vite build rather than the published package export.

Changes:

  • Removed packages/fields/src/index.css containing the problematic CSS cross-import
  • Removed the CSS import statement from packages/fields/src/index.tsx

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/fields/src/index.css Deleted file containing invalid CSS cross-import to @object-ui/components
packages/fields/src/index.tsx Removed import of index.css to eliminate dependency on deleted file

This branch was successfully deployed

2 active deployments
Preview – objectui-site — 8437af06 Deployed Jan 28, 2026 by vercel[bot]
Preview – objectui-crm-app — 8437af06 Deployed Jan 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants