Repository navigation
feat(app-shell,console,types)!: adopt @objectstack/spec 13 — Permission Model v2 (ADR-0090) UI fallout - #2369
Merged
Merged
Conversation
…on Model v2 (ADR-0090) UI fallout Bump every workspace @objectstack/spec dep to ^13.0.0 and fix the v2 fallout: position replaces role in the draft-validation loader map (#2365), Studio previews, fallback schemas, i18n labels and the console System hub; the profile concept (D2) is fully removed from loaders, anchors, samples and the permission-set viewer badge; the OWD control drops the dead read/read_write/full alias normalization (D4) and the fully-public unset warning (unset now defaults to private, D1). Also exports SubmitBehavior from @object-ui/types — defined but missing from the public surface, which broke @object-ui/plugin-form's re-export on any uncached build. Closes #2365 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
7 of 13 tasks
…es (ADR-0090) Object Settings sharing card gains the externalSharingModel select (portal/partner baseline) with an inline wider-than-internal warning mirroring the D7 publish lint's ordering (private < public_read < public_read_write). The permission matrix shows each object's OWD pair as row badges — authored values or the D1 fail-closed 'Private (default)' — so grant edits carry their record-reach context. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Author
|
Pushed a second commit extending the PR with the two remaining pure-UI items from framework#2696's ObjectUI follow-ups:
Tests: 1168/1168 app-shell tests green (new coverage: dial render/patch/clear, wider-warning on/off, per-row badge presence incl. the no-Ext case); console build green. Not included (blocked on framework surfaces, flagged on the tracking issue): the |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps every workspace
@objectstack/specdependency^12.3.0→^13.0.0(the ADR-0090 Permission Model v2 major, already on npm) and fixes all UI fallout in one sweep. Closes #2365; resolves the objectui follow-ups tracked in objectstack-ai/objectstack#2696.Why
objectui only passed CI because its dependency tree still resolved spec 12.3.0 (
^12.xcan't reach the v2 major). Anything vendoring framework HEAD (proaero-erp, the framework console build) hitRoleSchema does not existat build time. The rename wave is deliberate and alias-free (launch window), so the fix is adoption, not compat.Changes
roleloader →position→PositionSchema([HIGH PRIORITY] fix(metadata-admin): RoleSchema → PositionSchema in clientValidation.ts (ADR-0090 D3) #2365); deadprofileloader removed (D2)RolePreview→ flatPositionPreview(no hierarchy breadcrumb — positions are deliberately flat; no Profile copy). Legacyrole/profilekeys stay registered so pre-v2 backends still renderread/read_write/fullalias normalization removed (D4: spec rejects at authoring); amber "records are fully public" unset warning replaced — unset now defaults to Private (D1) and the copy (en/zh) says sorolefallback schema → flatposition;isProfiledropped from the permission create-anchor (would 422 against spec 13 authoring) and samples; permission viewer profile badge removedRole/角色→Position/岗位;profilelabel removed; Access-pillar heading "Permission sets / Profiles" → "Permission sets"; sharing hint/desc rewritten to positions vocabularysys_role→sys_position(counts + object def; the routed page was already orphaned)SubmitBehavior(defined but missing from the public surface; brokeplugin-form's re-export on any uncached build)ObjectRequiredPermissionsSchema, so the toggle correctly shows)Intentionally unchanged: flow designer approval assignee
rolekind — spec 13 keeps it as the sole D3 exception (better-authsys_member.roleorg-membership tier, seeapproval.zod.ts).Testing
turbo build --filter=@object-ui/app-shell...and--filter=@object-ui/console --filter=@object-ui/sitegreen against spec 13.0.0🤖 Generated with Claude Code