Skip to content

feat(app-shell,plugin-view,plugin-form): record task flows as derived overlays + return invariants (framework#2604 Step 2) - #2256

Merged
os-zhuang merged 3 commits into
mainfrom
feat/record-flow-surface-2604
Jul 5, 2026
Merged

os-zhuang merged 3 commits into
mainfrom
feat/record-flow-surface-2604

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

概述

framework#2604 的 Step 2(objectui 侧)。设计结论见 issue 评论(objectstack-ai/objectstack#2604 (comment));spec 侧单源派生 deriveRecordFlowSurface 在 framework#2622(本 PR 用 plugin-view 本地镜像,沿用 #2578 先例,spec 发版后一起换回 import)。

一句话:查看是"状态"可路由,新建/编辑是"任务"一律 overlay;取消回原地分毫不动,编辑保存不挪人,新建保存落到新记录,子表任务永不离开父详情。

变更

plugin-view

app-shell — 记录表单 URL 契约

  • create/edit overlay 全面 URL 驱动:?form=new / ?form=<id>(打开压一条 history → 浏览器 Back = 关 overlay,列表滚动/筛选原样;deep link / 刷新可重开)。字段多的对象经派生得到 modalSize:'full';轻对象保持既有 auto 尺寸。editMode:'page' 逃生门不动。
  • 保存不变式:编辑保存 → 原地 refetch(refreshKey);新建保存 → 进新记录详情(轻对象 = 列表之上的 drawer ?recordId=,列表上下文天然保留;重对象 = 详情路由),replace:true 让 Back 跳过临时表单态(resolvePostCreateTarget 纯函数 + 单测)。
  • 子表(D3):related-list 的 New/行 Edit 不再 navigate() 到整页路由,改为推 ?form=…&formObject=<child>&formLink=<fk>:<parentId> —— 复用同一个全局 overlay:父记录预填(链接在 URL 里,刷新也不丢)、按子对象派生尺寸、保存后父详情路由/数据原地不动,仅子表经 related-changed 事件 refetch;Back 关 overlay 回父详情。

plugin-form

  • ModalForm 把 initialValues/initialData 转发进 master-detail(subforms)分支 —— 此前带行项目的子对象(如 invoice)会静默丢掉父预填。

浏览器端到端验证(showcase,console dev :5180 + 全新后端)

  • ✅ 列表→New(field_zoo 57 字段):全屏 modal(1368px=95vw、双列、textarea 整行);Esc/Back → 列表原样、参数清除
  • ✅ 列表→New(product 11 字段):auto 尺寸 modal;保存 → ?recordId=… drawer 盖在原列表上 + 成功 toast
  • ✅ 详情→Edit(整页路由):?form=<id> 全屏 modal;保存 → 回详情视图,改名即时可见
  • ✅ 父详情(account)→ 子表 New contact:overlay 打开、Northwind 父链接预填可见;保存 → 父路由不动、子表出现新 contact;Back 关 overlay
  • ✅ 脏表单守卫:有输入时 Esc 弹确认(ModalForm 既有 confirmOnDiscard)

单测:4 个包 160 文件 / 1357 全绿;turbo type-check 30/30。

已知边界(既有缺陷,另行立 issue)

详情页 tab 条(PageTabsRenderer)是非受控 defaultValue,任何 URL 参数变化引发的子树重挂载都会把 tab 重置回 Details —— 包括本 PR 的 overlay 参数,也包括早已存在的 ?recordId= drawer、?palette=1 等。可持续修复是 tab 状态 URL 化(ADR-0054 C3),不在本 PR 范围。

Refs framework#2604 · framework#2622 · framework#2578

🤖 Generated with Claude Code

https://claude.ai/code/session_019zKcAtbtxuF9SXYgSzjk9v


Generated by Claude Code

claude added 3 commits July 5, 2026 05:17
…ys with return invariants (#2604)

framework#2604 Step 2 (design in the issue thread; spec helper in
framework#2622):

- plugin-view: mirror deriveRecordFlowSurface (same consolidation TODO as
  the #2578 deriveRecordSurface mirror) + first unit tests for the whole
  recordSurface mirror.
- app-shell create/edit: the global record form overlay is now URL-driven
  (?form=new / ?form=<id>) — browser Back closes the overlay instead of
  abandoning the origin route; field-heavy objects get modalSize 'full'
  from the flow-surface derivation. editMode:'page' opt-in unchanged.
- Save invariant: edit never navigates (origin refetches in place via
  refreshKey); create lands on the new record's detail on ITS derived
  surface — drawer over the still-intact list for light objects, detail
  route for heavy ones (resolvePostCreateTarget, unit-tested); replace:true
  so Back skips the transient form entry.
- Subtable (related list) child create/edit: overlay over the parent detail
  (never a route) — parent scroll/tab preserved, subtable refetches via
  notifyRelatedChanged on save; create pre-links the parent through
  initialValues[relationshipField]; overlay sizes to the CHILD object;
  ?childForm=1 marker makes Back close the overlay (payload stays in state
  so a refresh can never create an unlinked child).
- Dirty guard: ModalForm's existing confirmOnDiscard covers Esc/X/backdrop
  on all of the above.

Type-check 30/30 green; vitest 160 files / 1357 tests green (app-shell,
plugin-form, plugin-detail, plugin-view).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019zKcAtbtxuF9SXYgSzjk9v
… record-form overlay via URL params (#2604)

Browser dogfood of the first cut surfaced two defects; both fixed by
moving the child task into the record-form URL contract instead of
mounting a second ModalForm inside the detail page's renderer tree
(which never committed its overlay):

- AppContent record-form URL contract extended: ?formObject=<child>
  overrides the route object for the overlay; ?formLink=field:id
  pre-links the parent on create (refresh-safe — a reloaded child
  create is STILL parent-linked). The bridge's related-list New/Edit
  now just pushes these params; Back closes the overlay.
- Child save must not go through crud_success: its refreshKey bump
  remounts the whole RecordDetailView and resets the active tab. Child
  saves now only toast + notifyRelatedChanged (subtable refetches via
  the existing related-changed listener) + strip the form params — the
  parent route, scroll and data stay untouched.
- ModalForm: forward initialValues/initialData into the MasterDetailForm
  (subforms) branch — the parent pre-link was silently dropped for
  children with inline line items (e.g. invoice).

Browser-verified end to end on showcase (5180 console + fresh backend):
heavy create full-screen modal ?form=new, Esc/Back restore the intact
list; light create-save lands on the detail drawer over the list;
detail edit full modal saves back to the refetched view; account →
contact child create pre-linked (Northwind chip), saves without leaving
the parent route, subtable shows the child, Back closes the overlay.
Dirty-guard alertdialog confirmed on Esc with typed input.

Known boundary (pre-existing, filed separately): the detail page's tab
strip is uncontrolled (PageTabsRenderer defaultValue), so ANY URL-param
change that remounts the subtree resets it to Details — including
opening/closing this overlay and the pre-existing ?recordId drawer.
Durable fix is URL-driven tab state.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019zKcAtbtxuF9SXYgSzjk9v
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019zKcAtbtxuF9SXYgSzjk9v
@vercel

vercel Bot commented Jul 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectui Ignored Ignored Jul 5, 2026 6:20am

Request Review

@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Main entry (gzip) 59.5 KB 350 KB
Entry file index-CcGTtkDI.js —
Status PASS —

📦 Bundle Size Report

Package Size Gzipped
app-shell (index.js) 7.51KB 2.72KB
app-shell (runtime-config.js) 4.72KB 1.69KB
app-shell (types.js) 0.01KB 0.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 1.17KB 0.53KB
auth (AuthProvider.js) 18.34KB 3.80KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 4.79KB 1.88KB
auth (LoginForm.js) 9.55KB 3.36KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.63KB 2.15KB
auth (SocialSignInButtons.js) 8.89KB 3.61KB
auth (UserMenu.js) 3.40KB 1.22KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 26.07KB 6.30KB
auth (createAuthenticatedFetch.js) 3.93KB 1.55KB
auth (index.js) 1.75KB 0.76KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 4.29KB 0.82KB
auth (useIsWorkspaceAdmin.js) 1.61KB 0.85KB
collaboration (CommentThread.js) 18.38KB 4.49KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 3.65KB 1.42KB
collaboration (PresenceProvider.js) 2.42KB 0.96KB
collaboration (index.js) 1.25KB 0.53KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 437.03KB 93.90KB
core (index.js) 1.65KB 0.59KB
create-plugin (index.js) 9.28KB 2.98KB
data-objectstack (index.js) 109.66KB 27.05KB
fields (index.js) 185.40KB 45.26KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (currency.js) 1.22KB 0.64KB
i18n (i18n.js) 4.32KB 1.77KB
i18n (index.js) 2.46KB 0.96KB
i18n (pickLocalized.js) 1.31KB 0.67KB
i18n (provider.js) 5.37KB 1.72KB
i18n (useObjectLabel.js) 21.15KB 4.68KB
i18n (useSafeTranslation.js) 2.68KB 0.98KB
layout (index.js) 36.53KB 10.09KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.74KB
mobile (index.js) 1.50KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 4.42KB 1.27KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.71KB 0.42KB
mobile (useResponsiveConfig.js) 1.36KB 0.63KB
mobile (useSpecGesture.js) 1.77KB 0.77KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 5.09KB 1.84KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 3.46KB 1.03KB
permissions (evaluator.js) 4.00KB 1.23KB
permissions (index.js) 0.91KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.52KB
permissions (usePermissions.js) 1.50KB 0.70KB
plugin-ai (index.js) 15.71KB 3.79KB
plugin-calendar (index.js) 45.10KB 12.33KB
plugin-charts (index.js) 46.18KB 13.02KB
plugin-chatbot (index.js) 173.06KB 41.28KB
plugin-dashboard (index.js) 108.28KB 26.86KB
plugin-designer (index.js) 213.56KB 42.96KB
plugin-detail (index.js) 203.15KB 48.93KB
plugin-editor (index.js) 2.46KB 1.10KB
plugin-form (index.js) 102.48KB 24.90KB
plugin-gantt (index.js) 136.67KB 33.88KB
plugin-grid (index.js) 165.48KB 43.77KB
plugin-kanban (index.js) 48.15KB 12.94KB
plugin-list (index.js) 97.89KB 23.09KB
plugin-map (index.js) 16.78KB 5.23KB
plugin-markdown (index.js) 13.65KB 4.67KB
plugin-report (index.js) 37.83KB 9.97KB
plugin-timeline (index.js) 25.37KB 7.20KB
plugin-tree (index.js) 8.21KB 2.76KB
plugin-view (index.js) 85.78KB 20.89KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.55KB 0.67KB
providers (UploadProvider.js) 11.71KB 3.53KB
providers (index.js) 0.44KB 0.22KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 3.19KB 1.38KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 18.23KB 5.97KB
react (index.js) 0.76KB 0.42KB
sdui-parser (codegen.js) 4.09KB 1.74KB
sdui-parser (index.js) 2.16KB 0.94KB
sdui-parser (parse.js) 10.04KB 2.82KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 4.69KB 1.48KB
tenant (TenantContext.js) 0.31KB 0.25KB
tenant (TenantGuard.js) 1.04KB 0.43KB
tenant (TenantProvider.js) 2.76KB 0.98KB
tenant (TenantScopedQuery.js) 0.77KB 0.44KB
tenant (index.js) 0.75KB 0.38KB
tenant (resolver.js) 2.64KB 0.76KB
tenant (useTenant.js) 0.50KB 0.32KB
tenant (useTenantBranding.js) 0.62KB 0.39KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 0.77KB 0.41KB
types (disclosure.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (index.js) 1.54KB 0.68KB
types (layout.js) 0.20KB 0.18KB
types (mobile.js) 0.20KB 0.18KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 5.26KB 1.96KB
types (tenant.js) 0.20KB 0.18KB
types (theme.js) 0.20KB 0.18KB
types (ui-action.js) 0.75KB 0.46KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang marked this pull request as ready for review July 5, 2026 06:26
@os-zhuang
os-zhuang merged commit 6c1ad9e into main Jul 5, 2026
10 checks passed
@os-zhuang
os-zhuang deleted the feat/record-flow-surface-2604 branch July 5, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants