Skip to content

fix(console): unwrap ExpandedViewItem envelope in FormPage internal loader - #2209

Merged
os-zhuang merged 2 commits into
mainfrom
fix/formpage-unwrap-expanded-view
Jul 4, 2026
Merged

fix(console): unwrap ExpandedViewItem envelope in FormPage internal loader#2209
os-zhuang merged 2 commits into
mainfrom
fix/formpage-unwrap-expanded-view

Conversation

@baozhoutao

@baozhoutao baozhoutao commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Closes #2208

问题(HMR console 5181 + framework 3777 实测)

内部表单路由 /forms/<view> 全部渲染成零字段 + 裸 Submit,且点击 Submit 会发空 POST /data/<object> 并误报成功。

根因:GET /meta/view/<name> 返回的是展平 ExpandedViewItem 信封 —— { name, object, viewKind, label, config: { type, data, sections } },真正的表单 spec 在 config 里;但 loadInternalForm 读的是 item?.spec ?? item 顶层的 sections/label(信封上没有)→ buildSections 得到空数组。label 同理显示裸视图名。

另外无 viewKind 校验:list 视图进这条路由照样渲染空表单(framework#2554 key 冲突把 action target 解析到 list 视图时的表现)。

修复

  • 提取纯函数 resolveInternalForm(name, viewBody):
    • 依次解包 { item } 包装、ExpandedViewItem 信封(config 才是 FormViewSpec)、legacy { item: { spec } } / 裸 spec 三种形状;
    • label 回退链:信封 label → config.label → 视图名;
    • object 解析:信封顶层 object → config.data.object → spec.object(裸 legacy spec 以前拿不到 object 直接报错,现在从 data 绑定解析);
    • viewKind 存在且非 'form' 时抛出可操作的错误("View X is a list view, not a form view — check the action or link that targets it"),不再空表单假成功。
  • loadInternalForm 改用该函数,其余(objectSchema 拉取、提交)不变。

测试

  • FormPage.test.ts 新增 6 个 resolveInternalForm 用例(payload 取自 live server 实测响应):信封解包、{item} 包装、label 回退、list 视图报错、裸 legacy spec、{item:{spec}} 包装。
  • @object-ui/console 套件:5129 pass;唯一失败是 packages/core 的 DATEFORMAT 时区敏感测试,干净 main 上同样失败(本地非 UTC 时区所致),与本 PR 无关。
  • pnpm --filter "@object-ui/console..." build 全绿(含 tsc)。

Co-Authored-By: Claude noreply@anthropic.com

@vercel

vercel Bot commented Jul 4, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectui Ignored Ignored Jul 4, 2026 3:41am

Request Review

@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Main entry (gzip) 59.4 KB 350 KB
Entry file index-31BcKWNA.js —
Status PASS —

📦 Bundle Size Report

Package Size Gzipped
app-shell (index.js) 7.51KB 2.72KB
app-shell (runtime-config.js) 4.72KB 1.69KB
app-shell (types.js) 0.01KB 0.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 1.17KB 0.53KB
auth (AuthProvider.js) 17.90KB 3.67KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 4.79KB 1.88KB
auth (LoginForm.js) 9.55KB 3.36KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.63KB 2.15KB
auth (SocialSignInButtons.js) 8.89KB 3.61KB
auth (UserMenu.js) 3.40KB 1.22KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 26.07KB 6.30KB
auth (createAuthenticatedFetch.js) 3.93KB 1.55KB
auth (index.js) 1.75KB 0.76KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 4.29KB 0.82KB
auth (useIsWorkspaceAdmin.js) 1.61KB 0.85KB
collaboration (CommentThread.js) 18.38KB 4.49KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 3.65KB 1.42KB
collaboration (PresenceProvider.js) 2.42KB 0.96KB
collaboration (index.js) 1.25KB 0.53KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 435.62KB 93.55KB
core (index.js) 1.65KB 0.59KB
create-plugin (index.js) 9.28KB 2.98KB
data-objectstack (index.js) 109.24KB 26.96KB
fields (index.js) 184.84KB 45.12KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (currency.js) 1.22KB 0.64KB
i18n (i18n.js) 4.32KB 1.77KB
i18n (index.js) 2.46KB 0.96KB
i18n (pickLocalized.js) 1.31KB 0.67KB
i18n (provider.js) 5.37KB 1.72KB
i18n (useObjectLabel.js) 21.15KB 4.68KB
i18n (useSafeTranslation.js) 2.68KB 0.98KB
layout (index.js) 36.30KB 10.04KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.74KB
mobile (index.js) 1.50KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 4.42KB 1.27KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.71KB 0.42KB
mobile (useResponsiveConfig.js) 1.36KB 0.63KB
mobile (useSpecGesture.js) 1.77KB 0.77KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 5.09KB 1.84KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 3.46KB 1.03KB
permissions (evaluator.js) 4.00KB 1.23KB
permissions (index.js) 0.91KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.52KB
permissions (usePermissions.js) 1.50KB 0.70KB
plugin-ai (index.js) 15.71KB 3.79KB
plugin-calendar (index.js) 45.10KB 12.33KB
plugin-charts (index.js) 46.11KB 12.99KB
plugin-chatbot (index.js) 172.75KB 41.13KB
plugin-dashboard (index.js) 108.28KB 26.86KB
plugin-designer (index.js) 213.48KB 42.95KB
plugin-detail (index.js) 201.40KB 48.47KB
plugin-editor (index.js) 2.46KB 1.10KB
plugin-form (index.js) 99.18KB 24.14KB
plugin-gantt (index.js) 136.67KB 33.88KB
plugin-grid (index.js) 165.48KB 43.77KB
plugin-kanban (index.js) 48.15KB 12.94KB
plugin-list (index.js) 97.89KB 23.09KB
plugin-map (index.js) 16.02KB 4.98KB
plugin-markdown (index.js) 13.65KB 4.67KB
plugin-report (index.js) 37.83KB 9.97KB
plugin-timeline (index.js) 25.37KB 7.20KB
plugin-tree (index.js) 8.21KB 2.76KB
plugin-view (index.js) 84.50KB 20.37KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.55KB 0.67KB
providers (UploadProvider.js) 11.71KB 3.53KB
providers (index.js) 0.44KB 0.22KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 3.19KB 1.38KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 18.23KB 5.97KB
react (index.js) 0.76KB 0.42KB
sdui-parser (codegen.js) 4.09KB 1.74KB
sdui-parser (index.js) 2.16KB 0.94KB
sdui-parser (parse.js) 10.04KB 2.82KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 4.69KB 1.48KB
tenant (TenantContext.js) 0.31KB 0.25KB
tenant (TenantGuard.js) 1.04KB 0.43KB
tenant (TenantProvider.js) 2.76KB 0.98KB
tenant (TenantScopedQuery.js) 0.77KB 0.44KB
tenant (index.js) 0.75KB 0.38KB
tenant (resolver.js) 2.64KB 0.76KB
tenant (useTenant.js) 0.50KB 0.32KB
tenant (useTenantBranding.js) 0.62KB 0.39KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 0.77KB 0.41KB
types (disclosure.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (index.js) 1.54KB 0.68KB
types (layout.js) 0.20KB 0.18KB
types (mobile.js) 0.20KB 0.18KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 5.26KB 1.96KB
types (tenant.js) 0.20KB 0.18KB
types (theme.js) 0.20KB 0.18KB
types (ui-action.js) 0.75KB 0.46KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@baozhoutao

baozhoutao commented Jul 4, 2026

Copy link
Copy Markdown
Contributor Author

追加一笔加固(8c68ee7):对着被 framework#2555 污染的真实服务器实测发现,runtime 个性化 overlay 行返回的是顶层展开的 raw config(type:'grid'、无 viewKind、无 config 信封),原来的 envelope-only guard 拦不住,空表单假成功会复现。现在 viewKind 在任何形态下都读取,且裸 spec 的可视化类型不在表单类型集合内时同样报错。实测:/forms/showcase_task.tabbed 渲染 3 分组 12 控件正常,/forms/showcase_task.default(污染的 grid 行)显示明确错误。24/24 单测通过。

@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Main entry (gzip) 59.5 KB 350 KB
Entry file index-Dn82Zhai.js —
Status PASS —

📦 Bundle Size Report

Package Size Gzipped
app-shell (index.js) 7.51KB 2.72KB
app-shell (runtime-config.js) 4.72KB 1.69KB
app-shell (types.js) 0.01KB 0.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 1.17KB 0.53KB
auth (AuthProvider.js) 17.90KB 3.67KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 4.79KB 1.88KB
auth (LoginForm.js) 9.55KB 3.36KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.63KB 2.15KB
auth (SocialSignInButtons.js) 8.89KB 3.61KB
auth (UserMenu.js) 3.40KB 1.22KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 26.07KB 6.30KB
auth (createAuthenticatedFetch.js) 3.93KB 1.55KB
auth (index.js) 1.75KB 0.76KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 4.29KB 0.82KB
auth (useIsWorkspaceAdmin.js) 1.61KB 0.85KB
collaboration (CommentThread.js) 18.38KB 4.49KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 3.65KB 1.42KB
collaboration (PresenceProvider.js) 2.42KB 0.96KB
collaboration (index.js) 1.25KB 0.53KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 435.62KB 93.55KB
core (index.js) 1.65KB 0.59KB
create-plugin (index.js) 9.28KB 2.98KB
data-objectstack (index.js) 109.24KB 26.96KB
fields (index.js) 184.84KB 45.12KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (currency.js) 1.22KB 0.64KB
i18n (i18n.js) 4.32KB 1.77KB
i18n (index.js) 2.46KB 0.96KB
i18n (pickLocalized.js) 1.31KB 0.67KB
i18n (provider.js) 5.37KB 1.72KB
i18n (useObjectLabel.js) 21.15KB 4.68KB
i18n (useSafeTranslation.js) 2.68KB 0.98KB
layout (index.js) 36.30KB 10.04KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.74KB
mobile (index.js) 1.50KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 4.42KB 1.27KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.71KB 0.42KB
mobile (useResponsiveConfig.js) 1.36KB 0.63KB
mobile (useSpecGesture.js) 1.77KB 0.77KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 5.09KB 1.84KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 3.46KB 1.03KB
permissions (evaluator.js) 4.00KB 1.23KB
permissions (index.js) 0.91KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.52KB
permissions (usePermissions.js) 1.50KB 0.70KB
plugin-ai (index.js) 15.71KB 3.79KB
plugin-calendar (index.js) 45.10KB 12.33KB
plugin-charts (index.js) 46.11KB 12.99KB
plugin-chatbot (index.js) 172.75KB 41.13KB
plugin-dashboard (index.js) 108.28KB 26.86KB
plugin-designer (index.js) 213.48KB 42.95KB
plugin-detail (index.js) 201.40KB 48.47KB
plugin-editor (index.js) 2.46KB 1.10KB
plugin-form (index.js) 99.18KB 24.14KB
plugin-gantt (index.js) 136.67KB 33.88KB
plugin-grid (index.js) 165.48KB 43.77KB
plugin-kanban (index.js) 48.15KB 12.94KB
plugin-list (index.js) 97.89KB 23.09KB
plugin-map (index.js) 16.02KB 4.98KB
plugin-markdown (index.js) 13.65KB 4.67KB
plugin-report (index.js) 37.83KB 9.97KB
plugin-timeline (index.js) 25.37KB 7.20KB
plugin-tree (index.js) 8.21KB 2.76KB
plugin-view (index.js) 84.50KB 20.37KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.55KB 0.67KB
providers (UploadProvider.js) 11.71KB 3.53KB
providers (index.js) 0.44KB 0.22KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 3.19KB 1.38KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 18.23KB 5.97KB
react (index.js) 0.76KB 0.42KB
sdui-parser (codegen.js) 4.09KB 1.74KB
sdui-parser (index.js) 2.16KB 0.94KB
sdui-parser (parse.js) 10.04KB 2.82KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 4.69KB 1.48KB
tenant (TenantContext.js) 0.31KB 0.25KB
tenant (TenantGuard.js) 1.04KB 0.43KB
tenant (TenantProvider.js) 2.76KB 0.98KB
tenant (TenantScopedQuery.js) 0.77KB 0.44KB
tenant (index.js) 0.75KB 0.38KB
tenant (resolver.js) 2.64KB 0.76KB
tenant (useTenant.js) 0.50KB 0.32KB
tenant (useTenantBranding.js) 0.62KB 0.39KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 0.77KB 0.41KB
types (disclosure.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (index.js) 1.54KB 0.68KB
types (layout.js) 0.20KB 0.18KB
types (mobile.js) 0.20KB 0.18KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 5.26KB 1.96KB
types (tenant.js) 0.20KB 0.18KB
types (theme.js) 0.20KB 0.18KB
types (ui-action.js) 0.75KB 0.46KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang merged commit a4ccd4d into main Jul 4, 2026
10 checks passed
@os-zhuang
os-zhuang deleted the fix/formpage-unwrap-expanded-view branch July 4, 2026 04:51
baozhoutao and others added 2 commits July 4, 2026 11:33
@baozhoutao @claude
fix(console): unwrap ExpandedViewItem envelope in FormPage internal l…
f2dd092 
…oader

GET /meta/view/<name> returns the flattened ExpandedViewItem shape
{ name, object, viewKind, label, config: { type, data, sections } } —
but loadInternalForm read sections/label off the envelope itself, so
every internal form rendered zero fields plus a bare Submit button
whose submit "succeeded" (an empty POST /data/<object>).

- extract resolveInternalForm(): unwraps { item } wrappers, the
  ExpandedViewItem envelope, and legacy bare/{ item: { spec } } shapes;
  label falls back envelope.label -> config.label -> view name; the
  object target resolves from the envelope or the config data binding.
- reject non-form views (viewKind !== 'form') with an actionable error
  instead of rendering the empty-form false positive — the failure mode
  a list view reaching /forms/... produced (framework#2554 fallout).
- 6 new pure-function tests, payload mirroring the live server response.

Closes #2208

Co-Authored-By: Claude <noreply@anthropic.com>
@baozhoutao @claude
fix(console): reject flattened list-view bodies in resolveInternalForm
8c68ee7 
Live repro against a #2555-polluted server: the runtime personalization
overlay row comes back as a top-level raw config (type:'grid', no
viewKind, no config envelope), so the envelope-only guard let it through
and the empty-form false positive returned. Read viewKind wherever it
sits and reject bare specs whose visualization type is not a form type.

Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

apps tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FormPage internal mode renders zero fields: ExpandedViewItem config not unwrapped, no viewKind guard (forms route black screen)

2 participants

@baozhoutao @os-zhuang