Repository navigation
feat(studio): package-first create flow — prompt/redirect to a writable base (ADR-0070 D3) - #1970
Merged
Merged
Conversation
…le base (ADR-0070 D3) ResourceListPage create gate, package-scope helpers + tests, writable_package_required error surfacing in ResourceEditPage, exported CreatePackageDialog. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
os-zhuang
pushed a commit
that referenced
this pull request
Sep 5, 2026
…omation v1 cannot build The fourth edit-mode start chip — shown when the maker is bound to an existing app (`?package=`) — asked for 「加一个自动化 —— 审批、状态流转或通知」. Approval, status flow and notification are all refused by ADR-0112 v1 (cloud#1956 / PR #1970), and the measured behaviour on the sibling chip family was not a refusal but a silent degrade into a view, so the product recommended an automation and would have handed back a page. Rewording it was not available: a field, a view or a dashboard duplicates one of the three chips beside it. Product ruling (epic cloud#1955): replace it with sample data. The three surviving chips all add STRUCTURE; what an app that already has objects most often lacks is DATA, and `seed` is on v1's authoring whitelist (`V1_METADATA_TYPES`, commented "sample data"). `console.ai.suggestions.editApp.addAutomation` is now `addSampleData` in all ten packs and in the call-site `defaultValue` fallback, which is a second copy of the same string. A REVERT note beside the keys in every pack and at the call site names ADR-0112 v2 as where this chip's automation wording returns, and the retired sentence for each pack is kept verbatim in the new guard suite. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
akarma-synetal
pushed a commit
to akarma-synetal/objectui
that referenced
this pull request
Sep 9, 2026
…omation v1 cannot build (objectstack-ai#7766) The fourth edit-mode start chip — shown when the maker is bound to an existing app (`?package=`) — asked for 「加一个自动化 —— 审批、状态流转或通知」. Approval, status flow and notification are all refused by ADR-0112 v1 (cloud#1956 / PR objectstack-ai#1970), and the measured behaviour on the sibling chip family was not a refusal but a silent degrade into a view, so the product recommended an automation and would have handed back a page. Rewording it was not available: a field, a view or a dashboard duplicates one of the three chips beside it. Product ruling (epic cloud#1955): replace it with sample data. The three surviving chips all add STRUCTURE; what an app that already has objects most often lacks is DATA, and `seed` is on v1's authoring whitelist (`V1_METADATA_TYPES`, commented "sample data"). `console.ai.suggestions.editApp.addAutomation` is now `addSampleData` in all ten packs and in the call-site `defaultValue` fallback, which is a second copy of the same string. A REVERT note beside the keys in every pack and at the call site names ADR-0112 v2 as where this chip's automation wording returns, and the retired sentence for each pack is kept verbatim in the new guard suite. Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Implements ADR-0070 D3 (select-or-create-a-base-first) on the Studio (human) surface.
ResourceListPage.handleCreate): when no writable base exists → open the create-base dialog; when the active scope is Local/none but bases exist → create into the first base; otherwise proceed. Both "New" buttons route through it.isLocalScope()+writableBaseOptions()(excludes thesys_metadatasentinel andsystem/cloudpackages) + unit tests.writable_package_required(422) renders as an actionable toast inResourceEditPage(before the generic field-validation branch).CreatePackageDialogis exported fromPackagesPagefor reuse.Why
Pairs with the kernel enforcement (framework ADR-0070 D1/D2) so a user authoring in Studio never orphans a new item or lands it in a read-only code package. See
docs/adr/0070-package-first-authoring.md.Verification
@object-ui/app-shell:tscclean; 418 metadata-admin tests + 4 newpackage-scopetests green.StudioHomePagequick-create + browser dogfood of the full create→base→publish→still-editable flow.🤖 Generated with Claude Code