Skip to content

feat(studio): package-first create flow — prompt/redirect to a writable base (ADR-0070 D3) - #1970

Merged
os-zhuang merged 1 commit into
mainfrom
feat/adr-0070-pkgfirst-studio
Jun 24, 2026
Merged

os-zhuang merged 1 commit into
mainfrom
feat/adr-0070-pkgfirst-studio

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

What

Implements ADR-0070 D3 (select-or-create-a-base-first) on the Studio (human) surface.

  • Create gate (ResourceListPage.handleCreate): when no writable base exists → open the create-base dialog; when the active scope is Local/none but bases exist → create into the first base; otherwise proceed. Both "New" buttons route through it.
  • package-scope helpers: isLocalScope() + writableBaseOptions() (excludes the sys_metadata sentinel and system/cloud packages) + unit tests.
  • Error surfacing: the kernel's writable_package_required (422) renders as an actionable toast in ResourceEditPage (before the generic field-validation branch).
  • CreatePackageDialog is exported from PackagesPage for reuse.

Why

Pairs with the kernel enforcement (framework ADR-0070 D1/D2) so a user authoring in Studio never orphans a new item or lands it in a read-only code package. See docs/adr/0070-package-first-authoring.md.

Verification

  • @object-ui/app-shell: tsc clean; 418 metadata-admin tests + 4 new package-scope tests green.
  • Follow-up (tracked): same gate on StudioHomePage quick-create + browser dogfood of the full create→base→publish→still-editable flow.

🤖 Generated with Claude Code

…le base (ADR-0070 D3)

ResourceListPage create gate, package-scope helpers + tests, writable_package_required
error surfacing in ResourceEditPage, exported CreatePackageDialog.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@vercel

vercel Bot commented Jun 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectui Ignored Ignored Jun 24, 2026 1:13pm

Request Review

@github-actions github-actions Bot added the tests label Jun 24, 2026
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Main entry (gzip) 58.8 KB 350 KB
Entry file index-CtcE5PFl.js —
Status PASS —

📦 Bundle Size Report

Package Size Gzipped
app-shell (index.js) 6.59KB 2.34KB
app-shell (runtime-config.js) 4.72KB 1.69KB
app-shell (types.js) 0.01KB 0.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 1.17KB 0.53KB
auth (AuthProvider.js) 17.16KB 3.44KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 4.79KB 1.88KB
auth (LoginForm.js) 5.11KB 1.92KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.63KB 2.15KB
auth (SocialSignInButtons.js) 8.89KB 3.61KB
auth (UserMenu.js) 3.40KB 1.22KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 24.74KB 6.00KB
auth (createAuthenticatedFetch.js) 3.33KB 1.32KB
auth (index.js) 1.75KB 0.76KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 4.01KB 0.79KB
auth (useIsWorkspaceAdmin.js) 1.28KB 0.70KB
collaboration (CommentThread.js) 18.38KB 4.49KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 3.65KB 1.42KB
collaboration (PresenceProvider.js) 2.42KB 0.96KB
collaboration (index.js) 1.25KB 0.53KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 418.42KB 89.09KB
core (index.js) 1.52KB 0.55KB
create-plugin (index.js) 9.28KB 2.98KB
data-objectstack (index.js) 99.69KB 24.89KB
fields (index.js) 166.21KB 40.08KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (currency.js) 1.22KB 0.64KB
i18n (i18n.js) 4.32KB 1.77KB
i18n (index.js) 2.46KB 0.96KB
i18n (pickLocalized.js) 1.31KB 0.67KB
i18n (provider.js) 5.37KB 1.72KB
i18n (useObjectLabel.js) 21.15KB 4.68KB
i18n (useSafeTranslation.js) 2.68KB 0.98KB
layout (index.js) 36.30KB 10.04KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.74KB
mobile (index.js) 1.50KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 4.42KB 1.27KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.71KB 0.42KB
mobile (useResponsiveConfig.js) 1.36KB 0.63KB
mobile (useSpecGesture.js) 1.77KB 0.77KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 5.09KB 1.84KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 3.46KB 1.03KB
permissions (evaluator.js) 4.00KB 1.23KB
permissions (index.js) 0.91KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.52KB
permissions (usePermissions.js) 1.50KB 0.70KB
plugin-ai (index.js) 15.71KB 3.79KB
plugin-calendar (index.js) 45.98KB 12.65KB
plugin-charts (index.js) 45.46KB 12.78KB
plugin-chatbot (index.js) 153.41KB 37.19KB
plugin-dashboard (index.js) 107.36KB 26.65KB
plugin-designer (index.js) 213.42KB 42.94KB
plugin-detail (index.js) 195.59KB 47.19KB
plugin-editor (index.js) 2.38KB 1.06KB
plugin-form (index.js) 93.23KB 22.71KB
plugin-gantt (index.js) 133.11KB 32.92KB
plugin-grid (index.js) 115.41KB 31.01KB
plugin-kanban (index.js) 48.82KB 13.13KB
plugin-list (index.js) 94.53KB 22.32KB
plugin-map (index.js) 16.02KB 4.98KB
plugin-markdown (index.js) 13.58KB 4.64KB
plugin-report (index.js) 37.83KB 9.97KB
plugin-timeline (index.js) 25.37KB 7.20KB
plugin-tree (index.js) 8.04KB 2.70KB
plugin-view (index.js) 84.45KB 20.36KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.55KB 0.67KB
providers (UploadProvider.js) 11.71KB 3.53KB
providers (index.js) 0.44KB 0.22KB
providers (types.js) 0.01KB 0.04KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 18.23KB 5.97KB
react (index.js) 0.76KB 0.42KB
tenant (TenantContext.js) 0.31KB 0.25KB
tenant (TenantGuard.js) 1.04KB 0.43KB
tenant (TenantProvider.js) 2.76KB 0.98KB
tenant (TenantScopedQuery.js) 0.77KB 0.44KB
tenant (index.js) 0.75KB 0.38KB
tenant (resolver.js) 2.64KB 0.76KB
tenant (useTenant.js) 0.50KB 0.32KB
tenant (useTenantBranding.js) 0.62KB 0.39KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 0.77KB 0.41KB
types (disclosure.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (index.js) 1.54KB 0.68KB
types (layout.js) 0.20KB 0.18KB
types (mobile.js) 0.20KB 0.18KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 5.26KB 1.96KB
types (tenant.js) 0.20KB 0.18KB
types (theme.js) 0.20KB 0.18KB
types (ui-action.js) 0.75KB 0.46KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang merged commit 4b1cb7a into main Jun 24, 2026
10 checks passed
@os-zhuang
os-zhuang deleted the feat/adr-0070-pkgfirst-studio branch June 24, 2026 13:20
os-zhuang pushed a commit that referenced this pull request Sep 5, 2026
…omation v1 cannot build

The fourth edit-mode start chip — shown when the maker is bound to an existing
app (`?package=`) — asked for 「加一个自动化 —— 审批、状态流转或通知」. Approval,
status flow and notification are all refused by ADR-0112 v1 (cloud#1956 /
PR #1970), and the measured behaviour on the sibling chip family was not a
refusal but a silent degrade into a view, so the product recommended an
automation and would have handed back a page.

Rewording it was not available: a field, a view or a dashboard duplicates one
of the three chips beside it. Product ruling (epic cloud#1955): replace it with
sample data. The three surviving chips all add STRUCTURE; what an app that
already has objects most often lacks is DATA, and `seed` is on v1's authoring
whitelist (`V1_METADATA_TYPES`, commented "sample data").

`console.ai.suggestions.editApp.addAutomation` is now `addSampleData` in all ten
packs and in the call-site `defaultValue` fallback, which is a second copy of
the same string. A REVERT note beside the keys in every pack and at the call
site names ADR-0112 v2 as where this chip's automation wording returns, and the
retired sentence for each pack is kept verbatim in the new guard suite.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
akarma-synetal pushed a commit to akarma-synetal/objectui that referenced this pull request Sep 9, 2026
…omation v1 cannot build (objectstack-ai#7766)

The fourth edit-mode start chip — shown when the maker is bound to an existing
app (`?package=`) — asked for 「加一个自动化 —— 审批、状态流转或通知」. Approval,
status flow and notification are all refused by ADR-0112 v1 (cloud#1956 /
PR objectstack-ai#1970), and the measured behaviour on the sibling chip family was not a
refusal but a silent degrade into a view, so the product recommended an
automation and would have handed back a page.

Rewording it was not available: a field, a view or a dashboard duplicates one
of the three chips beside it. Product ruling (epic cloud#1955): replace it with
sample data. The three surviving chips all add STRUCTURE; what an app that
already has objects most often lacks is DATA, and `seed` is on v1's authoring
whitelist (`V1_METADATA_TYPES`, commented "sample data").

`console.ai.suggestions.editApp.addAutomation` is now `addSampleData` in all ten
packs and in the call-site `defaultValue` fallback, which is a second copy of
the same string. A REVERT note beside the keys in every pack and at the call
site names ADR-0112 v2 as where this chip's automation wording returns, and the
retired sentence for each pack is kept verbatim in the new guard suite.

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant