Repository navigation
revert(plugin-list): roll back objectui#11999 so the console's eager closure is under its ceiling again (objectui#12007) - #12009
Merged
Conversation
…and the user-filter chips ask the field read (objectui#11984) (#11999)" This reverts commit aa67386. The eager closure crossed its ceiling when this commit merged behind aaba865 in one merge-queue run. aaba865 fits alone and stays; this commit is rolled back alone, with no ceiling raise. Claude-Session: https://claude.ai/code/session_01MgfduSkFrfM3eorB3UGfAU Co-authored-by: Claude <noreply@anthropic.com>
…ld-list read The revert removes the pending objectui#11984 declaration together with the change it described; this declares the rollback itself. Claude-Session: https://claude.ai/code/session_01MgfduSkFrfM3eorB3UGfAU Co-authored-by: Claude <noreply@anthropic.com>
Contributor
✅ Console Performance Budget
The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it. 📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12007
Clause-②: no — it restores
packages/plugin-listbyte for byte to its state ataaba8655a; no export, prop, type member or accepted input changes.What
Reverts
aa67386a5(PR objectui#11999, the toolbar field-list read of objectui#11984) alone, as onegit revertcommit, plus one changeset.aaba8655a, the repeater half of objectui#11880) stays: it fits under the ceiling alone.scripts/check-eager-closure-budget.mjsis untouched;MAX_EAGER_CLOSURE_GZIP_BYTESstill reads 3,391,484.6056819248step 1 on objectui#11942).Files
packages/plugin-list/src/ListView.tsx: restored. Its blob equalsgit rev-parse aaba8655a:packages/plugin-list/src/ListView.tsx(6acc4893d2e2).packages/plugin-list/src/__tests__/ListView.fieldListRead-11984.test.tsx: removed (absent at HEAD, as ataaba8655a)..changeset/11984-toolbar-field-lists-read.md: removed, together with the change it declared..changeset/12007-revert-toolbar-field-list-read.md: added,@object-ui/plugin-listpatch, one sentence declaring the rollback.git diff --name-status aaba8655a HEADnames exactly one path: the new changeset.Verification, at HEAD
3605d3aa2apps/console,CI=true pnpm exec vite build):dist/eager-closure.jsoneagerGzipBytesis 3,391,417, under the 3,391,484 ceiling by 67 B.pnpm check:eager-closureprints "✅ Console eager closure is 3311.9 KB gzipped across 336 of 2458 chunks (budget: 3312.0 KB, headroom: 0.1 KB)." Outside.changeset/the tree is identical toaaba8655a's, so this is that tree's reading.pnpm exec vitest run) over the 100plugin-listtest files namingListView,canReadField,hiddenFields,rowColororGroupingEditor, pluscolumn-identity.ratchet.test.tsandone-authority-per-exported-name-6273.test.ts:Test Files 102 passed (102),Tests 1117 passed (1117).pnpm --filter @object-ui/plugin-list type-check, with its dependency closure built first: exit 0 (tsc --noEmit && tsc -p tsconfig.test.json).node scripts/check-changeset-presence.mjs: "✅ 2 source file(s) of 1 released package(s) changed, and this change declares 1 changeset(s)".node scripts/check-changeset-no-major.mjs: "✅ No changeset declares amajorbump."node scripts/check-changeset-overwrite.mjs: exit 0 (report-only). It reports the deleted.changeset/11984-toolbar-field-lists-read.mdwith "GONE from the declaration: @object-ui/plugin-list". That deletion is the intent: the declared change leaves with it, and the new changeset declares the rollback.pnpm check:control-bytes,pnpm check:changeset-claims,pnpm check:pending-changeset-literals: pass.pnpm lintand the full test farm. Both are CI's.The pin on objectui#12007 is this PR's own
Bundle Analysisreading at or under 3312.0 KB, then a green pushBundle Analysisonmain.Acceptance notes
OS_CHANGESET_OVERWRITE_ENFORCE=1,check-changeset-overwriteexits 1 on this diff but still prints its "Report-only: this gate does not fail the build" paragraph. CI does not set the switch, so the path is dormant. Noted, not filed; no carrier.Session:
https://claude.ai/code/session_01MgfduSkFrfM3eorB3UGfAUGenerated by Claude Code