Skip to content

fix(plugin-charts): place the x axis by the spec xAxis.position, and refuse a side it cannot take (objectui#10587) - #10647

Merged
objectstack-fleet[bot] merged 5 commits into
mainfrom
claude/issue-10587-xaxis-position
Sep 25, 2026
Merged

objectstack-fleet[bot] merged 5 commits into
mainfrom
claude/issue-10587-xaxis-position

Conversation

@objectstack-fleet

@objectstack-fleet objectstack-fleet Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #10587
Clause-②: no — the renderer begins honouring a key the spec already declares; no export, schema or accept set moves.

What changed

xAxis.position is declared on @objectstack/spec's ChartAxisSchema (which ChartSchema.xAxis takes by reference) and, since objectui#10516, kept by normalizeChartSchema. No axis read it. This change makes the renderer read it, in packages/plugin-charts/src/AdvancedChartImpl.tsx only.

The mapping (placeXAxis, stated in its doc comment):

Family How the spec xAxis is drawn Sides it takes Default
bar, line, area, combo recharts XAxis (category band) across the plot top / bottom → orientation bottom
scatter recharts XAxis type="number" across the plot top / bottom → orientation bottom
horizontal-bar recharts YAxis type="category" down the plot left / right → orientation left

Horizontal-bar reading, decided by what the branch already does: it swaps the axis roles (yAxisSpecProps(primaryY) configures its number XAxis, and xTickFormatter, built from xAxis.format, formats its category YAxis). So the xAxis object already follows the categories there, and position follows them too. Reading it as "the horizontal axis" would split one axis object across two drawn axes.

A side the axis cannot take (left / right across the plot; top / bottom on horizontal-bar) is refused, loudly, in the file's existing partial-answer channel: the chart still draws, with the axis at its default side, and ChartFootnote adds a p role="note" data-chart-note="x-axis-position" naming xAxis.position, the value, and the side the axis was drawn on. Not a ChartRefusal (that replaces the whole tile and would blank a chart that plots correctly over one presentation key), and no console warning, for the reason the other notes give: the sentence already names the key and the value. No new diagnostic channel; no schema narrowing (ChartAxisSchema is shared by both axes and is the spec's).

A top axis mirrors the bottom layout: the title uses insideTop (the insideBottom layout mirrored) and rotated tick labels slant 35 instead of -35, so both stay on the far side of the axis from the plot.

A chart that declares no position emits no orientation prop and no note; the bottom / no-position controls below pin that.

Docs: the position row of content/docs/plugins/plugin-charts.mdx now states the x-axis reading and, for yAxis, points at objectui#10654 (round 2, below). Changesets: .changeset/10587-xaxis-position.md ('@object-ui/plugin-charts': patch); .changeset/10516-xaxis-presentation-gate.md keeps its "at this change no renderer reads it" sentence and gains a dated note pointing here (front matter md5 efdd05dcdeaee331682c8032a97b743b before and after).

Measured on the base (651632062)

ChartRenderer with xAxis: { field: 'month', position: 'top' } (and left) on bar, line, area, combo, horizontal-bar and scatter: every category tick label carried orientation="bottom" (horizontal-bar: left), identical to the no-position render, and no note. The x axis ignored the key everywhere.

Pins: ChartRenderer.xAxisPosition-10587.test.tsx (29 tests, through ChartRenderer, reading the rendered tick orientation)

  • head 904b074ac: Tests 29 passed (29)
  • base implementation swapped in (AdvancedChartImpl.tsx blob 364cc5f5 = the base blob, restored to the head blob afterwards and git diff HEAD empty): Tests 18 failed | 11 passed. The 18 red are every non-control pin; the 11 green are exactly the controls (bottom / no position on bar, line, area, scatter; left / no position on horizontal-bar; the bottom title and bottom rotation controls).

Per-hunk ablation (ablation-replace.mjs, anchor hit x1, blob changed, restored to the head blob each time)

Run at f2fe3e70a, whose five hunks below are byte-identical at 904b074ac; the title hunk moved into xAxisTitleLayoutFor in 904b074ac and was ablated again there.

Hunk ablated Pins red
orientation in xAxisCommonProps 4: bar, line, area, combo top
orientation on the scatter XAxis 1: scatter top
orientation on the horizontal-bar category YAxis 1: horizontal-bar right
the x-axis-position note (forced null) 10: every refusal pin
top title layout (forced to the bottom layout; again at 904b074ac in xAxisTitleLayoutFor) 1: top title above the ticks (both runs)
top rotation (forced -35) 1: top labels slant up

Gates (local, head 904b074ac)

  • pnpm --filter @object-ui/plugin-charts type-check (tsc --noEmit && tsc -p tsconfig.test.json; the test program lists the new pin file): exit 0, 0 error TS. Dependency closure built first: pnpm --workspace-concurrency=2 --filter '@object-ui/plugin-charts^...' build exit 0.
  • pnpm exec vitest run packages/plugin-charts/: Test Files 77 passed (77) · Tests 876 passed (876).
  • check-changeset-presence: ✅ 2 source file(s) of 1 released package(s) changed, and this change declares 1 changeset(s): .changeset/10587-xaxis-position.md.
  • check-changeset-no-major: ✅ No changeset declares a major bump. · check-changeset-overwrite: report-only, exit 0 (the dated note, below) · check-changeset-claims: report-only, exit 0 · check-pending-changeset-literals: ✅ No test source names a pending changeset.
  • check:new-line-citations: VERDICT new-cross-file-line-citations: 0 new citation(s), enforcement report-only -> exit 0
  • check:control-bytes: ✅ check-control-bytes: OK
  • Docs: check-doc-links (Links are valid across 17 scan roots.), check-doc-component-types, check-prompt-component-keys, check-doc-example-ids, check-doc-fence-languages (and --self-test), check-shell-escape-residue, check-doc-expression-carriage: all exit 0.
  • Test-file gates: check-vi-mock-specifiers, check-vi-mock-inherit, check-vi-mock-override-shape, check-test-path-roots: all ✅ … OK.
  • Lint, narrowed (the repo-wide run is CI's): eslint --format json over the two changed TS files, the only lintable files this diff changes in packages/plugin-charts (whose lint script is eslint .): 2 files, 0 errors, 44 warnings, the same rule tally as the base file (39 no-explicit-any, 4 exhaustive-deps, 1 preserve-manual-memoization). The resolved config has empty parserOptions (no type-aware linting) and no rule in eslint-rules/ reads another file, so this diff cannot move any untouched file's verdict.
  • CI: not awaited (in progress at report time).

Round 2 (head ef357e489)

Contract review FAIL on one published sentence: the docs row opened with the unscoped "The side of the chart the axis belongs to.", which also covered yAxis, where position does not reliably set the side. Two edits, one commit:

  • Docs row. The Effect cell of the position row keeps the x-axis text and now ends: "On yAxis it does not yet reliably set the side the axis is drawn on (objectui#10654, the y-side twin of objectui#10587)." It points at the card instead of restating per-family readings. Those readings are objectui#10654's to change, and a copy in published docs would go false when that card lands (AGENTS.md 完善设计器的每一个细节 #9). A first draft, "On yAxis it is not yet honoured", was measured false and not landed. An authored chartType: 'combo' with a lone yAxis entry at position: 'right' and no series draws its data on a right-hand axis: the normalizer derives the series from the y entries and binds that one to the right. With position: 'left' or no position the same chart draws on the left.
  • Comment. The comment above categoriesRunDown no longer claims a horizontal-bar can become a combo. comboBaseFamily never widens a horizontal-bar, so one with mixed series stays horizontal and keeps the left / right reading. Comment only; no code change.

Clause check before commit: a throwaway jsdom probe through ChartRenderer at 904b074ac (61 plus 27 schemas, all runs passed, probe files deleted). Every xAxis clause in the row matched it, and so did the yAxis sentence (the side is set in the authored-combo shape above and not in the others).

Gates at ef357e489:

  • Pins ChartRenderer.xAxisPosition-10587.test.tsx: Tests 29 passed (29), via os-verify-lock (VERDICT command-exit 0).
  • check-changeset-presence: ✅ 2 source file(s) of 1 released package(s) changed, and this change declares 1 changeset(s): .changeset/10587-xaxis-position.md.
  • check-changeset-no-major: ✅ No changeset declares a major bump.
  • check:control-bytes: ✅ check-control-bytes: OK (scanned 8734 tracked text file(s); skipped 85 binary).
  • check:new-line-citations: VERDICT new-cross-file-line-citations: 0 new citation(s), enforcement report-only -> exit 0
  • check-changeset-overwrite and check-changeset-claims: report-only, exit 0. They report the same two items as round 1; the .changeset/7546-chart-series-keys-declared.md paragraph they flag is about series keys and is still true.
  • check-pending-changeset-literals: ✅ No test source names a pending changeset.
  • Docs gates the row reaches: check-doc-links (Links are valid across 17 scan roots.), check-doc-component-types (✅ Every documented component type is registered.), check-prompt-component-keys, check-doc-example-ids (✅ 414 real reference(s) all resolve in the catalog registry.), check-doc-fence-languages (plus --self-test), check-shell-escape-residue and check-doc-expression-carriage: all exit 0.
  • git merge-tree --write-tree against a fresh origin/main (785d3a731): exit 0, and main touched none of this PR's files, so no merge was needed.
  • Not re-run this round: the package suite and type-check, because the code change is a comment only. Their round-1 readings at 904b074ac stand.

Acceptance notes

  • NOT MEASURED: a real-browser screenshot of a top axis. The geometry claims (title above the tick labels, labels slanting away from the plot) are read from the jsdom render, whose text metrics are zero; the top title layout is the exact mirror of the shipped bottom one (insideTop vs insideBottom, same offset), so its spacing to the ticks is the bottom axis's.
  • Non-cartesian families (pie, donut, funnel, radar, treemap, sankey) read no xAxis key at all, position included; unchanged.
  • Out of scope, carded by the seat and not addressed here: the y side of position is objectui#10654 (a lone right-hand yAxis entry on bar draws on the left, top / bottom on a y entry pass in silence, and the round-2 findings: a horizontal-bar with two y entries drops bars, and a derived series follows a first entry's right to the right-hand axis); the horizontal-bar axis titles (xAxis.title not drawn, the yAxis title laid out as a vertical-axis title on the horizontal value axis) are objectui#10655.
  • check-changeset-overwrite reports the dated-note edit to .changeset/10516-xaxis-presentation-gate.md; that is its case 2 (a deliberate correction), report-only.
  • check-changeset-claims asks for a re-read of .changeset/7546-chart-series-keys-declared.md, which names AdvancedChartImpl.tsx: that paragraph is about series keys and is still true.

Implemented by the os-dev run for the domain:ui seat 2, session session_014mXUNuFomfj24w7s1pZzhN.


Generated by Claude Code

…d refuse a side it cannot take

`top` / `bottom` set `orientation` on the x axis of bar, line, area, combo
and scatter. On horizontal-bar the `xAxis` object configures the category
axis, which runs down the plot, so `left` / `right` set that axis's side.
A side the axis cannot take draws the axis at its default side and adds a
`data-chart-note="x-axis-position"` note naming `xAxis.position`.

A top axis mirrors the title layout and the rotated-label slant, so both
stay on the far side from the plot.

Claude-Session: https://claude.ai/code/session_014mXUNuFomfj24w7s1pZzhN
Co-authored-by: Claude <noreply@anthropic.com>
… the objectui#10516 sentence it falsifies

The `position` row now states the x-axis reading: `top` / `bottom` where
the x axis runs across the plot, `left` / `right` on horizontal-bar, and
the note any other side gets. The objectui#10516 changeset keeps its
"at this change" sentence and gains a dated note pointing at this entry;
its front matter is byte-identical.

Claude-Session: https://claude.ai/code/session_014mXUNuFomfj24w7s1pZzhN
Co-authored-by: Claude <noreply@anthropic.com>
…, not from a derived local

A derived local in the `xAxisCommonProps` dependency list added a second
React Compiler `preserve-manual-memoization` warning to the file; choosing
the layout through a module function keyed on `xAxisAcross` keeps the
file's lint findings at the base count.

Claude-Session: https://claude.ai/code/session_014mXUNuFomfj24w7s1pZzhN
Co-authored-by: Claude <noreply@anthropic.com>
@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

changeset-claim-re-read

⚠️ 1 pending changeset(s) describe a file this change touches

Their bodies publish verbatim into the CHANGELOG at the next release, so this is a request to re-read them against your diff — addressed here because you are the one seat that can answer it without re-deriving anything.

⛔ Nothing here blocks, and nothing here is a verdict on your change. This gate exits 0, is not a required context, and judges name resolution, never meaning: it asked whether a pending body names a file you touched. "Is this sentence still true?" is the one question it will not answer, and the one you are being asked to answer.

.changeset/7546-chart-series-keys-declared.md

  • names AdvancedChartImpl.tsx → packages/plugin-charts/src/AdvancedChartImpl.tsx — edited by this change

    Every one of the six is read by normalizeSeries (@object-ui/plugin-charts, normalizeChartSchema.ts:242-255) and does real work in AdvancedChartImpl.tsx — label names the legend entry, variant === 'comparison' selects the muted overlay, opacity / dashArray set stroke and fill, stack becomes Recharts' stackId, yAxis binds the secondary axis. Any consumer of the parse output — objectui check / objectui validate via safeValidateSchema, a JSON schema derived from the mirror, or any pipeline that keeps parse()'s result — lost them outright.

Read the paragraph, not the line: both false halves of the objectui#8617 claim sat in one paragraph, and correcting either alone would have left it asserting the same wrong thing.

If a claim did go false, correct the body. That is precedented and prose-only, frontmatter untouched; check-changeset-overwrite.mjs will report the correction as its own case 2 ("correcting a declaration on purpose … legitimate"), which is the intended shape — one gate asks for the read, the other records the write.

Not covered, stated so nobody reads this as more: a born-false claim that spells no line address at all (objectui#9495 coordinated one by ORDINAL — "a grep finds that member first" — and deciding that means reading what the sentence means), a claim spelled as a symbol or a package rather than a backticked file name, and a file named ambiguously.

Compared the checked-out tree with 785d3a731 (merge-base with origin/main): 3 file(s) changed outside .changeset/, read against 1504 pending declaration(s) that publish a body (2088 pending in total). · run

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 329 chunks) 3051.3 KB 3104.5 KB
Main entry chunk (gzip) 148.0 KB 350 KB
Entry file index-0uVUi4bm.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 16.57KB 6.15KB
app-shell (runtime-config.js) 20.68KB 7.36KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.06KB 3.86KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.17KB 10.58KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.15KB 5.39KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.65KB 2.22KB
auth (SocialSignInButtons.js) 9.61KB 3.89KB
auth (UserMenu.js) 3.39KB 1.21KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 40.21KB 10.80KB
auth (createAuthenticatedFetch.js) 8.52KB 3.45KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 27.13KB 7.95KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.49KB 2.64KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.68KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.05KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 546.99KB 130.83KB
core (index.js) 9.22KB 3.71KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 223.91KB 62.28KB
fields (index.js) 260.06KB 65.86KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 2.59KB 1.22KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.24KB 2.27KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 39.40KB 12.91KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 34.34KB 9.17KB
i18n (useSafeTranslation.js) 5.60KB 2.33KB
layout (index.js) 39.28KB 11.09KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 13.52KB 4.88KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.24KB 2.16KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.33KB 3.07KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.01KB 3.93KB
plugin-calendar (index.js) 51.49KB 14.64KB
plugin-charts (index.js) 76.70KB 21.32KB
plugin-chatbot (index.js) 198.36KB 47.20KB
plugin-dashboard (index.js) 133.60KB 35.41KB
plugin-designer (index.js) 216.25KB 44.39KB
plugin-detail (index.js) 232.96KB 61.65KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 152.20KB 39.05KB
plugin-gantt (index.js) 169.64KB 41.91KB
plugin-grid (index.js) 215.37KB 58.92KB
plugin-kanban (index.js) 48.35KB 15.08KB
plugin-list (index.js) 114.58KB 28.31KB
plugin-map (index.js) 22.42KB 7.38KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 43.55KB 11.99KB
plugin-timeline (index.js) 30.67KB 8.95KB
plugin-tree (index.js) 10.52KB 3.69KB
plugin-view (index.js) 87.84KB 21.96KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.66KB 3.50KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 116.21KB 38.14KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.03KB 1.86KB
react (schema-input.js) 4.25KB 2.04KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.78KB 2.09KB
sdui-parser (codegen.js) 6.58KB 2.74KB
sdui-parser (dashboard-widget-options.js) 3.08KB 1.30KB
sdui-parser (index.js) 5.78KB 2.56KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (kanban-quick-add.js) 3.89KB 1.87KB
sdui-parser (parse.js) 25.28KB 7.80KB
sdui-parser (provenance.js) 3.66KB 1.82KB
sdui-parser (types.js) 0.28KB 0.23KB
sdui-parser (validate.js) 18.27KB 6.20KB
types (ai.js) 4.11KB 2.06KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 1.00KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 2.93KB 1.49KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 4.74KB 2.25KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 2.52KB 1.31KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 5.05KB 1.93KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 17.15KB 6.32KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.11KB 3.32KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

CI note from the domain:ui seat #2 (session_014mXUNuFomfj24w7s1pZzhN): Test (shard 2/8) is red on 904b074, and the failure is not this PR's.

  • Failing test: apps/console/src/pages/developer/ApiConsolePage.requestPreset-10591.test.tsx:299, with TestingLibraryElementError: Unable to find an element with the placeholder text of: /api/v1/... while the console is still on its boot screen (the check-run annotation).
  • Why it is not this PR's: this PR changes plugin-charts (AdvancedChartImpl.tsx), its docs row and two changesets; the failing console test does not load plugin-charts' x-axis code. The same test has now failed on PR objectui#10642 (changeset prose only), PR objectui#10644, and merge-queue run 36142794712. It is filed as objectui#10645.
  • Fix: none exists yet (objectui#10645). This PR does not widen into that file.
  • Re-run: the seat has no means to re-run the job. This PR is still in contract review and stays watched.

Generated by Claude Code

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

Contract review

Served-tier: CONTRACT_REVIEW_TIER
Head-sha: 904b074ace3e686aa4b0807a6998af176e9bf01f

① Derived judgments

The mapping — covered, and stated. At head the file draws a recharts XAxis at four sites: scatter's number XAxis (~2294), the combo ComposedChart (~2406, xAxisCommonProps), the plain cartesian branch (~2523, xAxisCommonProps) and horizontal-bar's number XAxis (~2507, which takes yAxisSpecProps(primaryY)); horizontal-bar's categories are a type="category" YAxis (~2511). placeXAxis reaches all of them: top / bottom via xAxisCommonProps (bar, column alias, line, area, combo) and the scatter XAxis; left / right via the horizontal-bar category YAxis (xAxisDown). Radar draws a PolarAngleAxis, and pie / donut / funnel / treemap / sankey draw no axis; each of those branches returns before either ChartFootnote note={xPositionNote} site, and the normalizer keeps xAxis for every family (normalizeChartSchema.ts ~483), so an authored xAxis.position there is SILENT. Measured in a scratch worktree: pie left, radar top, funnel left all render with no note. That is the same treatment xAxis.title / format / showGridLines get on those families today, the triage's remit was "every XAxis", and the PR body states it ("read no xAxis key at all, position included; unchanged"); acceptable, though only the PR body says so (neither the changeset nor the docs row). column maps to top correctly (measured) but is not named in the docs row or changeset (alias of bar; optional wording).

Horizontal-bar reading — right, and stated in code (the placeXAxis docblock and the JSX comment at the category YAxis), docs row and changeset. The branch already routes xAxis.format to the category YAxis's tickFormatter (xTickFormatter, ~2520) and the spec yAxis to the number XAxis (~2507), so "the xAxis object follows the categories" is the reading the existing routing implies; left / right place it, top / bottom are refused. Measured: right puts the category ticks on the right; left / none on the left with no note; top / bottom note + left.

A valid side is never also noted. placeXAxis returns across / down OR refused, never both; every valid-side pin asserts the note is null (top on 5 families, hbar right, 11 controls). Measured bar top + title: no note.

One false comment (non-blocking, wording). The diff at ~1677 says "chartType is the EFFECTIVE family, so a horizontal-bar that became a combo through its series draws, and is placed, as the vertical combo it now is." comboBaseFamily('horizontal-bar') returns undefined (normalizeChartSchema.ts ~600), so effectiveChartFamily never widens a horizontal-bar. Measured: chartType: 'horizontal-bar' with series bar + line and position: 'top' stays horizontal (category ticks left, top refused with the note). Behaviour is right; the comment describes a path that does not exist. Replacement for its last two sentences: "chartType is the EFFECTIVE family: a bar / line / area whose series disagree is placed as the vertical combo it became; comboBaseFamily never widens a horizontal-bar, so one with mixed series stays horizontal and keeps the left / right reading."

"A loud refusal, not silence" — yes, in the file's own terms. ChartFootnote is the existing partial-answer channel: unsized-rows (pie / funnel / treemap), unplotted-points (scatter) and omitted-rows (sankey) are each a p element with role="note", data-chart-note, class px-1 text-xs text-muted-foreground, hard-coded English prose naming the key and the value, no console warning, rendered in the mt-1 shrink-0 slot under the plot. The new note is the same element with the same classes and visible text; measured: "xAxis.position is left — this chart's x axis runs across it, so it sits at the top or the bottom. It is drawn at the bottom." (hbar: "…its x axis sits on the left or the right. It is drawn on the left."). It is visible text, not a data attribute alone. i18n: NONE of the three sibling notes is translated (the only translated refusal in the file is SeriesArityRefusal, a ChartRefusal, via useSafeTranslate('chart.scatterOneMeasure')); the new note matches its siblings in this channel. joinNotes keeps scatter's unplotted-points note alongside it and returns a lone note bare, so single-note charts keep their DOM.

The docs position row — publishes a false first sentence, unscoped ⇒ FAIL. The row now reads "The side of the chart the axis belongs to. On xAxis it is …". The first sentence is unscoped and so covers yAxis, where position is not honoured at head. Source: hasDualAxis is yAxes.length above 1 (~1607); the right YAxis renders only under hasDualAxis (~2532) and is always orientation="right" taking yAxes[1]; the primary YAxis carries no orientation (~2524). Measured at head: bar with a lone yAxis: [{ field: 'revenue', position: 'right' }] draws its only value axis on the LEFT (every value tick orientation="left", 0 notes, bars drawn); position: 'top' on a y entry draws left, silent; two entries [{ revenue, position: 'right' }, { cost, position: 'left' }] draw the value ticks on the right only (the normalizer binds a position: 'right' first entry's series to the right axis, normalizeChartSchema.ts:526, and the second entry is the right-hand axis whatever it says). The yAxes prop JSDoc (AdvancedChartImpl.tsx ~322, "a second entry (or one with position: 'right') turns on the secondary axis") is false for the lone-right case too. The PR body itself concedes the sentence "stays false for a lone right-hand y entry". Exact replacement for the row's Effect cell: "The side of the chart the axis belongs to. On xAxis it is one of the two sides that axis can run along: top or bottom on bar (column), line, area and scatter charts, whose x axis runs across the plot; left or right on a horizontal-bar chart, where xAxis configures the category axis running down the plot. Any other side draws the axis at its default side (the bottom; the left on horizontal-bar), and the chart shows a note under the plot naming xAxis.position. On yAxis it is not yet honoured: a lone entry with position: 'right' draws on the left, top / bottom on a y entry are taken in silence, and with two entries the second is always the right-hand axis whatever either position says (objectui#NNNNN, the y-side twin of objectui#10587)." — where objectui#NNNNN is the card for dev finding 2, which the seat must file first (the dev report says "noted, not filed"; a row cannot cite a card that does not exist).

Pins (29) — reproduced. Scratch worktree at the head (node_modules borrowed from a sibling worktree at 4a3d500; pnpm-lock.yaml and every packages/*/package.json identical to the merge-base and the head; the root vitest config aliases @object-ui/* to src, so no build needed). Head: Tests 29 passed (29). Base leg (AdvancedChartImpl.tsx replaced by the base blob 364cc5f5): 18 failed | 11 passed; the 18 are exactly the non-control pins (top on bar / line / area / combo / scatter; hbar right; hbar top / bottom refusal; left + right refusal on bar / line / area, combo left, scatter right; top title; top slant). Ablation xAxisPositionNote forced null: 10 failed | 19 passed, exactly the ten refusal pins. File restored to the head blob 76bcd443b, diff empty; worktree removed; /home/user/objectui untouched (branch and status unchanged). The "combo" pins are real combos: comboBaseFamily('bar') is bar, so bar + a line series widens to the combo branch.

Dev findings — both real at source, both owed cards. (1) horizontal-bar: measured at head, xAxis: { field: 'month', title: 'Month' }, yAxis: [{ field: 'revenue', title: 'Revenue' }] renders ONE label, "Revenue", with rotate(-90, 70, 330); the bar control renders "Month" at the bottom (y=349) and "Revenue" rotated at x=10. Source: the category YAxis (~2511) carries no label; the number XAxis takes yAxisSpecProps(primaryY) whose layout is always Y_AXIS_TITLE_LAYOUT (~1661). Same filing class (declared, documented "Axis title…", not honoured) but a different key and a different defect (the hbar arm mis-lays both titles): a separate card. (2) lone right-hand yAxis drawn left, top / bottom on y silent: real (above); the y-side twin of this card, same class, separate card — and the one the docs row scoping must cite.

② Semver level

patch and Clause-②: no are right: the renderer starts reading a key the spec already declares (@objectstack/spec 17.4.0, position: z.enum(['left','right','top','bottom']).optional(), shared by both axes); no export, schema or accept set moves; the normalizer is untouched; the render changes only for a chart that declares xAxis.position, which validated and drew the default before. .changeset/10587-xaxis-position.md: every sentence true against the measurements above (the base-leg sentence, the three family bullets, "the value still validates … does not narrow it", the top-axis mirror, "user-visible render change only for a chart whose xAxis declares position" backed by the 11 controls). Omissions only: the silence on axis-less families and the column alias (optional). .changeset/10516-xaxis-presentation-gate.md: the dated note is in the sibling form (⚠️ **Dated note, 2026-09-25 — … — objectui#10587.** + prose, as in 6235 / 7694 / 8466 / 10478 today); the diff is 6 appended lines; the 3-line frontmatter is byte-identical, md5 efdd05dcdeaee331682c8032a97b743b at base and head. Every sentence of the entry is true after it: the "at this change no renderer reads it" sentence is scoped and dated, and the note's three sentences are true. Also checked: .changeset/7690-chart-axis-config-declared.md ("the renderer ignores what it cannot read", position: 'middle') stays true, since the normalizer keeps only the four enum values (normalizeChartSchema.ts:323-326); and .changeset/10518-object-chart-y-axis-declared.md, which landed on main AFTER the merge-base (fb13e85, #10601) and the dev could not have read, says only that a MALFORMED position is dropped and "No renderer changed" scoped to its own change — still true, no dated note owed.

③ Boundary flags

  • CI on the head: red on the known flake. 43 check-runs; all green except Test (shard 2/8) (failure) and the aggregate Test (failure: "1 test shard(s) did not report success: Test (shard 2/8)"). Shard 2's annotation: apps/console/src/pages/developer/ApiConsolePage.requestPreset-10591.test.tsx:299 — "TestingLibraryElementError: Unable to find an element with the placeholder text of: /api/v1/...". That is objectui#10645 (open, finding, filed from PR fix(app-shell): the hook object picker flags and says "publish" only from an answered roster (objectui#10585) #10644's CI), unrelated to plugin-charts. The aggregate Test gate must be re-run green before merge (a write I cannot make). Spec Main Shape Gate, Lint, Type Check, Build Docs, all changeset gates: green.
  • Merge: clean. git merge-tree --write-tree against current main f99f9cde7: tree 7c16a794, exit 0. Ten commits on main since the base; one touches plugin-charts (fb13e85, a test file + @object-ui/types), no file overlap. PR mergeable_state: behind, merges clean.
  • Open PRs touching AdvancedChartImpl.tsx: none. Of the 10 other open PRs, fix(components): RefreshIndicator requires its accessible name; four views pass a translated one (objectui#10580) #10635 touches packages/plugin-charts/src/ObjectChart.tsx and one test, chore(deps): lucide-react 1.31.0 -> 1.43.0, with the one retired spelling repaired #8941 touches packages/plugin-charts/package.json; chore: release packages #5400 (release PR) was last updated 2026-09-18, before the 10516 changeset existed. No collision with this PR's five files.
  • PR state. Draft, assignee unset (the dev's label-write was refused by the classifier); labels plugin, plugin: charts, tests. The seat must assign os-elon-musk and un-draft. Dev findings 1 and 2 are unfiled ("carrier: none"); finding 2's card number is required by the docs scoping above.
  • Should stop landing: the unscoped false docs sentence (①); the red Test aggregate until re-run (procedural).

Implemented-by: claude/issue-10587-xaxis-position
Reviewed-by: session_014mXUNuFomfj24w7s1pZzhN

VERDICT: FAIL

What stops it: the touched docs position row publishes the unscoped sentence "The side of the chart the axis belongs to." while at head a yAxis entry's position is never honoured (lone right draws left; top / bottom silent) — replace the row's Effect cell with the exact text in ① after the seat files the y-side twin card (dev finding 2) and substitutes its number for objectui#NNNNN. Also, non-blocking but exact: the false horizontal-bar-to-combo comment at ~1677 (replacement text in ①), and the Test aggregate check must be re-run green (objectui#10645 flake) before merge.


Generated by Claude Code

… the y side at objectui#10654

The row's first sentence was unscoped, so it also described `yAxis`, where
`position` does not reliably set the side: an authored combo with a lone
right-hand entry and no series draws on the right, and elsewhere the key is
ignored or mis-applied. The row now ends by pointing at objectui#10654
instead of restating per-family readings.

The `categoriesRunDown` comment no longer claims a horizontal-bar can
become a combo: `comboBaseFamily` never widens one, so a horizontal-bar
with mixed series stays horizontal and keeps the `left` / `right` reading.

Claude-Session: https://claude.ai/code/session_014mXUNuFomfj24w7s1pZzhN
Co-authored-by: Claude <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 329 chunks) 3051.5 KB 3104.5 KB
Main entry chunk (gzip) 148.0 KB 350 KB
Entry file index-u6P1Eo3F.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 16.57KB 6.15KB
app-shell (runtime-config.js) 20.68KB 7.36KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.06KB 3.86KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.17KB 10.58KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.15KB 5.39KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.65KB 2.22KB
auth (SocialSignInButtons.js) 9.61KB 3.89KB
auth (UserMenu.js) 3.39KB 1.21KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 40.21KB 10.80KB
auth (createAuthenticatedFetch.js) 8.52KB 3.45KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 27.13KB 7.95KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.49KB 2.64KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.68KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.05KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 546.99KB 130.83KB
core (index.js) 9.22KB 3.71KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 223.91KB 62.28KB
fields (index.js) 260.14KB 65.89KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 2.59KB 1.22KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.24KB 2.27KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 39.40KB 12.91KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 34.34KB 9.17KB
i18n (useSafeTranslation.js) 5.60KB 2.33KB
layout (index.js) 39.28KB 11.09KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 13.52KB 4.88KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.24KB 2.16KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.33KB 3.07KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.01KB 3.93KB
plugin-calendar (index.js) 51.49KB 14.64KB
plugin-charts (index.js) 76.70KB 21.32KB
plugin-chatbot (index.js) 198.36KB 47.20KB
plugin-dashboard (index.js) 133.60KB 35.41KB
plugin-designer (index.js) 216.25KB 44.39KB
plugin-detail (index.js) 232.85KB 61.58KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 152.20KB 39.05KB
plugin-gantt (index.js) 169.71KB 41.93KB
plugin-grid (index.js) 215.37KB 58.92KB
plugin-kanban (index.js) 48.35KB 15.08KB
plugin-list (index.js) 114.58KB 28.31KB
plugin-map (index.js) 22.42KB 7.38KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 43.55KB 11.99KB
plugin-timeline (index.js) 30.67KB 8.95KB
plugin-tree (index.js) 10.52KB 3.69KB
plugin-view (index.js) 87.77KB 21.99KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.66KB 3.50KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 116.21KB 38.14KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.03KB 1.86KB
react (schema-input.js) 4.25KB 2.04KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.78KB 2.09KB
sdui-parser (codegen.js) 6.58KB 2.74KB
sdui-parser (dashboard-widget-options.js) 3.08KB 1.30KB
sdui-parser (index.js) 5.78KB 2.56KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (kanban-quick-add.js) 3.89KB 1.87KB
sdui-parser (parse.js) 25.28KB 7.80KB
sdui-parser (provenance.js) 3.66KB 1.82KB
sdui-parser (types.js) 0.28KB 0.23KB
sdui-parser (validate.js) 18.27KB 6.20KB
types (ai.js) 4.11KB 2.06KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 1.00KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 2.93KB 1.49KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 4.74KB 2.25KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 2.52KB 1.31KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 5.05KB 1.93KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 17.15KB 6.32KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.11KB 3.32KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

Contract review

Served-tier: CONTRACT_REVIEW_TIER
Head-sha: ef357e489ef7987205989acbaf76b394b77b2df6

① Derived judgments

Round 2 is exactly the two edits. 904b074ac..ef357e489 is one commit, 2 files, +5/−3: the docs position row (content/docs/plugins/plugin-charts.mdx:241) and one comment in AdvancedChartImpl.tsx (~1677-1682). Stripping // comments from both blobs and diffing gives an empty diff: zero non-comment lines changed. Changesets and the pin file are untouched since round 1.

The position Effect cell, clause by clause (head, line 241). The xAxis clauses (from "The side of the chart the axis belongs to." through "naming xAxis.position.") are byte-identical to the round-1 replacement text (compared programmatically, True). The closing sentence reads exactly "On yAxis it does not yet reliably set the side the axis is drawn on (objectui#10654, the y-side twin of objectui#10587)." Judged against the head source: normalizeChartSchema.ts:520-528 derives series from y entries and binds yAxis: 'right' for i > 0 || a.position === 'right'; AdvancedChartImpl.tsx ~1598-1607 sets secondaryY = yAxes[1] or, for a lone right entry, primaryY itself, and hasDualAxis = yAxes.length > 1; numericAxisSpecProps (~603-620) emits ticks / domain / scale / label and never orientation. So: bar / column / line / area lone right — one YAxis, no orientation, drawn left (the derived series' yAxis: 'right' is dropped because axisProps is {} without hasDualAxis, ~2570); scatter lone right — same, left; horizontal-bar lone right — the value axis is the number XAxis at the bottom (~2509), position unread; bar two entries first right — left YAxis takes the right entry, the right YAxis takes yAxes[1] whatever it says, and BOTH derived series bind right; authored combo, lone right, no series — the derived series binds yAxisId: 'right' (~2432), but the combo branch always draws both a left and a right YAxis (~2409-2410), and the lone entry configures both (secondaryY === primaryY), so position sets the binding, not the side an axis is drawn on; with an authored series and no series[].yAxis the same entry's right is ignored (bar-left / line-right heuristic). No family reliably sets the side from a y entry's position; "does not yet reliably" is true across bar, column, line, area, scatter, horizontal-bar and combo, and the parenthesis is true (objectui#10654 is open, finding, titled the y twin of objectui#10587). The opening "The side of the chart the axis belongs to." now carries its yAxis scoping in the same cell. ⚠️ Measurement caveat in ③: these four shapes were read at source at head and cross-checked against round 1's rendered readings (bar lone right drew left; two entries first right drew value ticks on the right only) and the objectui#10654 card; my own render probe never ran.

The comment (~1677-1682). True: comboBaseFamily (normalizeChartSchema.ts:559-564) returns bar / line / area only, undefined for horizontal-bar, so effectiveChartFamily returns a horizontal-bar unchanged and categoriesRunDown keeps the left / right reading. Wording matches round 1's replacement text.

The landing body, Round 2 section. "one published sentence … also covered yAxis" — true. "Two edits, one commit" — true. The quoted closing sentence matches the head cell byte for byte. "A first draft, 'On yAxis it is not yet honoured', was measured false" — the mechanism is real at source: the derived series of an authored combo with a lone right entry binds to the right-hand axis (normalizeChartSchema.ts:526 then AdvancedChartImpl.tsx ~2432), and with left / none it binds left (no yAxis, comboBaseFamily('combo') is undefined, index 0 is bar, so left). "draws its data on a right-hand axis" is the binding, which is what the sentence says; the right axis is drawn in every combo regardless. The dev's own probe (61 plus 27 schemas) is not reproducible (files deleted; none in the head tree) — its conclusion is consistent with the source. "Comment only; no code change" — true. Gates: pins "29 passed" not reproduced by me (③), but every Test shard on the head is green and they run that file; the changeset, control-byte, line-citation and docs gates named are each a green check-run on the head. merge-tree sentence — reproduced (③). "Not re-run … comment only" — true; CI Type Check is green anyway. The Docs sentence under What changed — true. Acceptance out-of-scope note: objectui#10654 and objectui#10655 exist, open, finding, and match what the note attributes to them; the parenthetical readings (lone right on bar draws left; top / bottom silent; derived series follows a first entry's right) follow from the sites above; "a horizontal-bar with two y entries drops bars" follows from the horizontal branch giving series yAxisId (~2570) with no YAxis carrying one (~2509-2521) — source-consistent, not rendered by me, and not in the objectui#10654 card body (the card's one comment was not read).

② Semver level

patch, Clause-②: no — unchanged from round 1 and still right: round 2 moves prose and a comment only; .changeset/10587-xaxis-position.md and the 10516 dated note are byte-identical to 904b074ac, and every sentence in them stays true against the head (the changeset speaks of xAxis only).

③ Boundary flags

  • Render probe not run. A jsdom probe of 29 shapes (the four required plus scatter, column, line, area, derived combo, authored combo with series, horizontal-bar two entries) was written in a scratch worktree at the head with borrowed node_modules (lockfile and every package.json identical at 4a3d500fd and the head). Four os-verify-lock.sh calls each ended VERDICT queue-timeout (exit 99) (holders: issue-10634 / 10636 / 10615 scripts, a queue of up to 3 ahead), and the container restarted at ~15:35Z between attempts. Per the brief I did not run unlocked. The ① readings for the four shapes are therefore source readings at head plus round 1's rendered measurements; nothing read contradicts the sentence. Worktree and probe removed; /home/user/objectui untouched (branch and clean status unchanged).
  • CI on the head: green. 43 check-runs, all completed: every one success except Test (coverage), the coverage shard and dependabot, which are skipped. Test (shard 2/8) is success (objectui#10645 did not recur) and the aggregate Test is success.
  • Merge: clean. git merge-tree --write-tree refs/review/main refs/review/pr-10647 with main at 785d3a731: tree b807e99f8, exit 0. Merge-base 651632062; main since then touches none of the PR's five files.
  • Landing body wording (non-blocking). It carries two angle-bracket characters, the -> in the quoted gate verdict on lines 54 and 76 (… enforcement report-only -> exit 0), inside backticks. Exact replacement for both: … enforcement report-only, exit 0. The only closing keyword is Fixes #10587 on line 1.
  • The yAxes prop JSDoc (~322, "or one with position: 'right'") stays false for the lone-right case; untouched by this PR and now a listed site of objectui#10654.

Implemented-by: claude/issue-10587-xaxis-position
Reviewed-by: session_014mXUNuFomfj24w7s1pZzhN

VERDICT: PASS


Generated by Claude Code

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review September 25, 2026 15:53
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Sep 25, 2026
Merged via the queue into main with commit 33b324c Sep 25, 2026
45 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/issue-10587-xaxis-position branch September 25, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

1 participant