Skip to content

feat(components)!: action values ride properties.params; params is only the input list (#10289) - #10460

Merged
objectstack-fleet[bot] merged 3 commits into
mainfrom
claude/issue-10289-action-params-properties
Sep 25, 2026
Merged

objectstack-fleet[bot] merged 3 commits into
mainfrom
claude/issue-10289-action-params-properties

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Fixes #10289
Clause-②: yes

What this does

This implements ruling A on the card (comment 5825589480, maintainer 「批 #224 同意」): an action's params is only the ActionParam[] inputs list. A node's static execution values ride properties.params.

  • action:button and action:icon read static values only from the node's properties.params. They forward those values to the runner as ActionDef.params, which is where navigate_create / navigate_edit read objectName / recordId.
  • A node-level params object is not read. It is ignored, and a development build logs one warning per action ([action:button] action "X" carries an OBJECT under node-level params; it is ignored ...). The warning names properties.params, and bodyExtra for an api payload. It is silent in production. The precedent is the dev-only, warn-once console.warn that auto-trigger.ts and core actionKeys.ts use.
  • A node-level params array still works as the input list and is forwarded as actionParams. action:icon used to forward any params raw; it now routes through the same paramsPayload as action:button. The runner already treated an array params as actionParams, so the input path behaves as before.
  • The two channels are independent. An action:bar member, which is mounted without SchemaRenderer, can carry inputs in params and values in properties.params, and both are forwarded.
  • The renderer reads schema.properties.params itself instead of the hoisted schema.params. SchemaRenderer copies properties.params onto the node, and action:bar members skip that hoist. An identity check tells a hoisted copy apart from a node-level object. The helper is packages/components/src/renderers/action/static-params.ts.

Docs: content/docs/guide/record-edit-modes.md and the @object-ui/app-shell README now teach properties.params in both examples. They say that a node-level params object is ignored, and how to migrate. The README also had a stale claim that templates inside params are not evaluated, which objectui#10282 had already made false. That claim is replaced.

Census (taken on the base 0348bc9f1, before the change)

Instrument: a one-off scanner run over every tracked file (CHANGELOGs excluded). It walks every JSON document for a params key holding a plain object, and it matches params followed by an object literal in ts/tsx/js/mjs/md/mdx/yaml text. Each text hit was then classified by hand. Nothing re-derives this reading; it is a historical measurement, not a live count.

Authors of a node-level params object on an action:button / action:icon node: 13.

where sites disposition
content/docs/guide/record-edit-modes.md 2 migrated
packages/app-shell/README.md 2 migrated
app-shell AppContent.tsx, the navigate_* handler comment 2 migrated
action-bodyShape-forward.test.tsx (action:button) 3 migrated
action-forward-precedence.test.tsx (the shared fixture) 1 migrated
action-params-templates-7867.test.tsx 3 2 migrated; CASE A flipped to pin the object form as not read
  • JSON metadata under examples/, apps/ and schema-catalog: 0. The JSON walk found no params object anywhere.
  • Published skills/: 0. Its one action params is the ActionParam[] form, in skills/objectui/rules/protocol.md. No governed file is touched.
  • Stored metadata outside this repo (sys_metadata rows): NOT MEASURED, because this repo cannot read it.
  • .changeset/7867-action-params-templates.md (pending) shows one node-level example. It is another card's changeset and was not edited. The new changeset says that the form is no longer read.
  • The other text hits are the runner's own ActionDef.params (the values channel that handlers and hosts build in code), query params, nav-item params, i18n label params and similar. None of them is an authored action node.

Readers, and a premise correction

  • The authored-node readers of the object form were the paramsPayload non-array branch in action:button, and action:icon's raw params forward. Both are moved.
  • app-shell recordFormNavigation.ts (action.params?.recordId / objectName) and useObjectActions.ts read the runner's ActionDef.params. They do not read the authored node. Core declares that key as the values map (params?: Record string-to-any), and action:button now fills it from properties.params. They cannot read properties.params themselves, because the handler receives an ActionDef, which has no properties. So they keep their reads. Only their docs changed: the NavigationActionDef docblock and the AppContent comment now describe the channel and teach properties.params. The card's list of these two files as object-form readers was half right: the keys they read are the right ones, but on the runner layer.

Boundary: surfaces left unchanged here

These also forward a non-array params as values, but they are spec action entries, not SDUI nodes. They have no properties bag, and another ruling governs them:

  • element:button's inline action;
  • action:group / action:menu items;
  • page:header's dispatchHeaderAction.

For a type: 'api' action, the objectstack#5777 ruling keeps the runner reading an object params as the payload for one version window, with a dev warning, removed at 18. Spec already refuses the object form at the authoring door, and the ADR-0087 conversion rewrites it to bodyExtra. Retiring these surfaces now would pre-empt that window, so they are listed rather than changed.

Tests

New pin file packages/components/src/renderers/action/__tests__/action-params-properties-10289.test.tsx (21 tests). It covers action:button and action:icon, each on both mounts (direct registry mount and through SchemaRenderer), and pins the following:

  • values come from properties.params;
  • a node-level object is not read as values, and the warning fires once and names properties.params;
  • properties.params wins over a node-level object;
  • the ActionParam[] path still arrives as actionParams;
  • both channels together;
  • the warning is once per action, not per click, and silent in production.

Union at c3aff649a (final HEAD), all run from the repo root:

  • packages/components/src/renderers/action/, the bodyShape / bodyExtra / element:button 8071 / page-header-actions suites, app-shell recordFormNavigation.test.ts, and scripts/__tests__/ for doc-expression-carriage and both action-forward-parity suites: 32 files, 548 tests passed.
  • @object-ui/components type-check (tsc --noEmit && tsc -p tsconfig.test.json, which includes the tests): green at c3aff649a.
  • @object-ui/app-shell type-check: green at 5f7cb6fc5. Only comments and docs changed in app-shell after that.

Ablation

Each leg ran through ablation-replace.mjs. The anchor was proven to land (anchor 1 to 0, blob changed), and the restore was proven on disk (blob equal to HEAD, git diff HEAD empty). These tests import the renderers by relative path, so the mutated source is what runs. The direction was predicted before each run.

  1. action:button values read reverted to the old params: schema.params: 10 red. That is button direct-mount properties, both not-read pins, direct-mount wins, the production pin, the 3 bodyShape wire pins, 7867 CASE A, and precedence's carried values. The SchemaRenderer-mount "reads from properties.params" pin stays green, as predicted, because the hoist puts the same object on schema.params.
  2. action:icon back to a raw params forward: 8 red. That is the icon properties, not-read (both mounts), wins, input list (both mounts), both-channels, and the precedence carried-values pins.
  3. The dev warning deleted: 5 red. That is the four once-warning pins and the per-action memo pin.

Gates run locally

  • Green: check:action-forward-parity, check:handler-key-reads, check:changeset-claims, check:pending-changeset-literals, changeset:check, check:control-bytes, check:new-line-citations (0 new), check:doc-types, check:doc-fences, check:doc-example-ids, check:doc-example-readers, check:unreferenced-sources, check:spec-symbols, check:component-surface-parity, check:test-path-roots, check:action-ref-convention, check-changeset-presence, check-doc-links, check-doc-expression-carriage (report-only).
  • ESLint on the 9 changed ts/tsx files: 0 errors. The warnings are the files' existing no-explicit-any / react-refresh warnings.
  • check-governed-queue-guard --test on the 12 changed paths: NOT GOVERNED.
  • NOT MEASURED: check:readme-exports, because it needs every package's dist/*.d.ts and the README edit adds no import. Also NOT MEASURED: check:sdui-registration-pins, because it needs a console build and no registration changed. Both are left to CI.
  • packages/types was not touched, so the Spec Main Shape Gate type-check does not apply.

Acceptance notes

  • SchemaRenderer still evaluates a node-level params bag (carrier 1 of objectui#10282). No in-tree renderer reads that value any more, so the evaluation is dead work, and the unevaluated-expression diagnostic can still name a leaf inside it. @object-ui/react was left unchanged to keep this PR to the renderers the ruling names. A follow-up can drop carrier 1 there.
  • Under SchemaRenderer, the properties hoist copies properties.params over a node-level params. So one node cannot carry both an input list (node-level) and values (properties.params) on that path; the values win. Nothing in the repo authors both, and base behaved the same way. Directly mounted action:bar members get both.
  • The guide now says the diagnostic reports an unresolvable template under properties.params.recordId. The 7867 pin now asserts that exact path.
  • feat(react): an action's params values are templates, evaluated where properties are #10282's changeset (pending) shows the node-level form; see the census.

Attribution: this change was written in session https://claude.ai/code/session_01877XiBYSaRCk2CU7cMSg3S.


Generated by Claude Code

…y the input list

objectui#10289 ruling A. action:button and action:icon read static
execution values from properties.params and forward them as the
runner's params. A node-level params OBJECT is ignored with a dev-mode
warning; an ActionParam[] params still routes to actionParams. The
guide, the app-shell README and the navigate_* handler comments now
teach properties.params.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01877XiBYSaRCk2CU7cMSg3S
@github-actions

Copy link
Copy Markdown
Contributor

changeset-claim-re-read

⚠️ 3 pending changeset(s) describe a file this change touches

Their bodies publish verbatim into the CHANGELOG at the next release, so this is a request to re-read them against your diff — addressed here because you are the one seat that can answer it without re-deriving anything.

⛔ Nothing here blocks, and nothing here is a verdict on your change. This gate exits 0, is not a required context, and judges name resolution, never meaning: it asked whether a pending body names a file you touched. "Is this sentence still true?" is the one question it will not answer, and the one you are being asked to answer.

.changeset/6306-action-icon-type-resolution.md

  • names action-button.tsx → packages/components/src/renderers/action/action-button.tsx — edited by this change

    Scope is this one renderer. type: schema appears in exactly two files under renderers/action/ — action-button.tsx (already correct) and action-icon.tsx; action:group and action:menu compose their members differently and are untouched.

  • names action-icon.tsx → packages/components/src/renderers/action/action-icon.tsx — edited by this change

    Scope is this one renderer. type: schema appears in exactly two files under renderers/action/ — action-button.tsx (already correct) and action-icon.tsx; action:group and action:menu compose their members differently and are untouched.

.changeset/6515-record-form-current-user-normaliser.md

  • names console/AppContent.tsx → packages/app-shell/src/console/AppContent.tsx — edited by this change

    The normaliser moved from console/AppContent.tsx to providers/expressionUser.ts, beside the ExpressionProvider it feeds. That move is what made the fix available: RecordFormPage is lazy()-loaded BY AppContent, so importing the normaliser from its old home would have put a static edge from the split chunk back into the module it was split out of. Both console/AppContent.js and the package entry re-export the name, so buildExpressionUser is published exactly as before.

.changeset/6559-expression-user-input-contract.md

  • names console/AppContent.tsx → packages/app-shell/src/console/AppContent.tsx — edited by this change

    NO RUNTIME BEHAVIOUR MOVES. All four in-repo production call sites pass useAuth().user, typed AuthUser | null, and type cleanly unchanged — two in console/AppContent.tsx, one in views/RecordFormPage.tsx, one in apps/console's InternalFormRoute.tsx. The body is byte-equivalent: the same keys, the same ?? defaults, the same anonymous branch. ⛔ No consumer-side fallback was added; id: u.id ?? null remains the rejected shape (triage ruling 2026-08-26), because a lenient default in the consumer is what AGENTS.md #0.1 forbids and it silently equates "signed in, no id" with "signed out".

Read the paragraph, not the line: both false halves of the objectui#8617 claim sat in one paragraph, and correcting either alone would have left it asserting the same wrong thing.

If a claim did go false, correct the body. That is precedented and prose-only, frontmatter untouched; check-changeset-overwrite.mjs will report the correction as its own case 2 ("correcting a declaration on purpose … legitimate"), which is the intended shape — one gate asks for the read, the other records the write.

Not covered, stated so nobody reads this as more: a born-false claim that spells no line address at all (objectui#9495 coordinated one by ORDINAL — "a grep finds that member first" — and deciding that means reading what the sentence means), a claim spelled as a symbol or a package rather than a backticked file name, and a file named ambiguously.

Compared the checked-out tree with 061f5e829 (merge-base with origin/main): 11 file(s) changed outside .changeset/, read against 1391 pending declaration(s) that publish a body (1969 pending in total). · run

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 329 chunks) 3044.7 KB 3104.5 KB
Main entry chunk (gzip) 148.0 KB 350 KB
Entry file index-NRkYzXHq.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 16.68KB 6.20KB
app-shell (runtime-config.js) 20.68KB 7.36KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.06KB 3.86KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.18KB 10.59KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.15KB 5.39KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.65KB 2.22KB
auth (SocialSignInButtons.js) 9.61KB 3.89KB
auth (UserMenu.js) 3.41KB 1.23KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 40.21KB 10.80KB
auth (createAuthenticatedFetch.js) 8.52KB 3.45KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 27.13KB 7.95KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.49KB 2.64KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.68KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.05KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 544.08KB 129.99KB
core (index.js) 9.22KB 3.71KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 223.86KB 62.25KB
fields (index.js) 256.84KB 65.07KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 1.22KB 0.64KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.24KB 2.27KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 39.40KB 12.91KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 34.34KB 9.17KB
i18n (useSafeTranslation.js) 5.60KB 2.33KB
layout (index.js) 39.28KB 11.09KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 13.52KB 4.88KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.24KB 2.16KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.39KB 3.10KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.01KB 3.93KB
plugin-calendar (index.js) 51.22KB 14.56KB
plugin-charts (index.js) 74.76KB 20.82KB
plugin-chatbot (index.js) 198.27KB 47.18KB
plugin-dashboard (index.js) 133.59KB 35.39KB
plugin-designer (index.js) 216.12KB 44.37KB
plugin-detail (index.js) 231.66KB 61.23KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 146.34KB 37.47KB
plugin-gantt (index.js) 168.25KB 41.46KB
plugin-grid (index.js) 215.43KB 58.90KB
plugin-kanban (index.js) 49.30KB 15.39KB
plugin-list (index.js) 114.37KB 28.24KB
plugin-map (index.js) 21.83KB 7.07KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 43.55KB 11.99KB
plugin-timeline (index.js) 30.64KB 8.94KB
plugin-tree (index.js) 10.52KB 3.69KB
plugin-view (index.js) 87.90KB 21.97KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.66KB 3.50KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 114.58KB 37.60KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.03KB 1.86KB
react (schema-input.js) 4.25KB 2.04KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.78KB 2.09KB
sdui-parser (codegen.js) 6.58KB 2.74KB
sdui-parser (dashboard-widget-options.js) 3.08KB 1.30KB
sdui-parser (index.js) 5.78KB 2.56KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (kanban-quick-add.js) 3.89KB 1.87KB
sdui-parser (parse.js) 25.28KB 7.80KB
sdui-parser (provenance.js) 3.66KB 1.82KB
sdui-parser (types.js) 0.28KB 0.23KB
sdui-parser (validate.js) 18.27KB 6.20KB
types (ai.js) 4.11KB 2.06KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 1.00KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 2.93KB 1.49KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 4.74KB 2.25KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 5.05KB 1.93KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 17.15KB 6.32KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.11KB 3.32KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

Contract review

Served-tier: CONTRACT_REVIEW_TIER
Head-sha: c3aff649a6e57e4e5900a9737e2531a7b98b7cfa

① Contract correctness. The ruling is batch #224 item 4, letter A.

  • (a) Where values come from. action:button and action:icon read static values only from properties.params, via readStaticParamValues in static-params.ts, and forward them as the runner's ActionDef.params.
    • A node-level object params is never returned. It warns once per action, and stays silent in production.
    • An ActionParam[] params still routes to actionParams.
    • The identity check is sound: SchemaRenderer hoists properties.params by reference, so no false warning fires. The action:bar no-hoist path reads the same bag.
    • ⛔ params never carries two shapes, and ⛔ no new value-bag key is declared. Both rules are respected.
  • (b) Premise correction, verified. recordFormNavigation.ts and useObjectActions.ts read the runner's ActionDef.params (core ActionRunner.ts:274, the values map). Handlers never see properties. Full trace: authored node → SchemaRenderer evaluates properties.params → readStaticParamValues → execute({ params }) → navigate_*. An authored node-level object on action:button/action:icon no longer reaches the handlers on either mount path, which is the ruling's intent.
    • Residual, named and not a defect: element:button inline actions, action:group, action:menu, page:header and MetadataTypeActions still forward an object params. These are spec action entries, refused at the authoring door. The objectstack#5777 window covers type: 'api' until 18. The non-api residual is filed as objectui#10462, to close with the objectstack#5777 removal.
  • (c) Census, confirmed independently. There are 13 object-form authors: 12 migrated to properties.params and 1 (7867 CASE A) that pins the object form as not read. A JSON walk of every tracked *.json found 0. skills/ carries only the ActionParam[] form.
  • (d) The guide. record-edit-modes.md teaches properties.params in both examples, names the diagnostic path, and carries the migration ⚠️. The app-shell README matches.

② Tests.

  • action-params-properties-10289.test.tsx has 21 tests across button/icon × direct/SchemaRenderer mounts.
  • The reviewer's own ablation, reverting the button's non-array branch, gave 9 failed / 23 passed across the 10289, 7867 and bodyShape suites. The source was restored and git diff is empty.
  • The changeset is minor for @object-ui/components and @object-ui/app-shell. It states the break, the migration and the census count of 13.

③ Blast radius, measured in a detached worktree at head:

  • 28 files / 404 tests pass (the action renderers, bodyShape, element-button, recordFormNavigation and useObjectActions).
  • @object-ui/components and @object-ui/app-shell type-check exit 0.
  • Acceptance notes stand:
    • SchemaRenderer carrier 1 still evaluates an unread node-level params bag, which is dead work;
    • one node cannot carry both an input list and values under the hoist, the same as base.

Implemented-by: claude/issue-10289-action-params-properties
Reviewed-by: session_01877XiBYSaRCk2CU7cMSg3S
VERDICT: PASS

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review September 25, 2026 03:26
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Sep 25, 2026
Merged via the queue into main with commit 808f339 Sep 25, 2026
45 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/issue-10289-action-params-properties branch September 25, 2026 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

1 participant