Skip to content

fix(app-shell): the screen-flow runner applies the app's flows translation overlay - #10234

Merged
objectstack-fleet[bot] merged 2 commits into
mainfrom
claude/issue-5920-flow-runner-translation-overlay
Sep 24, 2026
Merged

fix(app-shell): the screen-flow runner applies the app's flows translation overlay#10234
objectstack-fleet[bot] merged 2 commits into
mainfrom
claude/issue-5920-flow-runner-translation-overlay

Conversation

@objectstack-fleet

@objectstack-fleet objectstack-fleet Bot commented Sep 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #5920
Clause-②: no

The screen-flow runner now draws a paused screen's heading and each field's label / placeholder from the app's TranslationData.flows bundle. This is the runner half of objectstack#11287, applied client-side per the side pick recorded on the card.

What changed

  • packages/app-shell/src/views/FlowRunner.tsx is the one producer of every runtime screen-flow dialog. All three hosts mount this component: useConsoleActionRuntime, RecordDetailView and the developer Flow Runs page. ScreenView is unchanged and receives the localized screen.
    • The heading goes through the spec's resolveFlowScreenTitle(bundle, flowName, screen).
    • Each field's copy goes through the spec's FLOW_SCREEN_FIELD_COPY_KEYS, which is imported and never retyped. The field-copy address is typed by the spec's TranslationData, so if the spec renames the path, type-check fails here.
    • Each key falls back to the authored string independently. The missing-required toast now names fields the way they are drawn.
  • Bundle channel: the one the console already uses. I18nProvider's loadLanguage passes the payload through transformSpecTranslations, which forwards flows unchanged under the app namespace of the i18next resource tree. The runner reads that group back for the active language with getResourceBundle. There is no second loader and no new fetch.
  • Dispatch mechanism assumption 2, answered: the runner holds only the wire ScreenSpec (state.screen / the resume payload) and never the flow document, so translateFlow upstream is not an option here. The spec also exports no per-field resolver, so the runner mirrors the spec's non-empty-string rule for the field keys.
  • packages/app-shell/package.json: the @objectstack/spec floor moves from ^17.0.0 to ^17.3.0. pnpm-lock.yaml changes by that one specifier: line; resolution stays at 17.4.0. This is outside the claimed file surface, and required: the new runtime imports first ship in 17.3.0. Measured with the registry loader in scripts/check-spec-range-floors.mjs itself: ./system in 17.0.0, 17.1.0 and 17.2.0 exports neither resolveFlowScreenTitle nor FLOW_SCREEN_FIELD_COPY_KEYS. The positive control, TranslationBundle and TranslationData, is present in all five 17.x releases, and lowestSatisfyingVersion returns 17.3.0. Leaving the floor at ^17.0.0 would publish a range that admits three releases this package cannot load against (the objectui#5793 ruling: floors track reality).
  • One changeset (patch).

Deliberately not changed:

  • the screen description: it is outside the spec's flows face, and an off-spec description in a bundle is ignored (pinned);
  • the runner chrome;
  • FlowSchema.successMessage.

No export is added or changed, and FlowRunner's props are unchanged.

Pins: packages/app-shell/src/views/__tests__/FlowRunner.flowsTranslation-5920.test.tsx

Each pin loads the bundle the way the console does (spec payload, then transformSpecTranslations, then addResourceBundle) under the real I18nProvider.

  1. A zh-CN bundle with flows entries gives a translated heading, field label and placeholder, and the authored English is gone.
  2. The missing-required toast names the translated label.
  3. en, with the zh-CN bundle loaded, gives the authored copy unchanged.
  4. zh-CN with no app bundle gives the authored copy unchanged.
  5. A field the bundle does not carry keeps its authored label and placeholder.
  6. Fallback works per key within one entry: a label-only entry keeps the authored placeholder, and an entry with no title keeps the authored heading.
  7. An off-spec description in the bundle is NOT drawn, and the dialog's accessible description stays authored. The translated heading on the same screen shows that the bundle is being read.

Ablation

The fix was committed first (577fa817). The ablation went through ablation-replace.mjs in WRAP mode with an automatic restore.

  • Mutation: anchor const shown = localizeScreen(...) → const shown = screen;. Anchor count went 1 → 0, replacement count 0 → 1, and the blob changed 9c48baa8a47e → b37d27312868.
  • Result: 4 red, 3 green.
    • Red: pin 1, pin 2 (the toast read 请填写以下必填字段：Opportunity Name, i.e. zh chrome around the English field name), pin 6 (at its translated-label assertion) and pin 7 (at its translated-heading control).
    • Green: pins 3, 4 and 5, the fallback pins.
  • Restore: the blob matches HEAD (9c48baa8a47e) and git diff HEAD is empty. The restore-leg run gives 7/7 green.
  • No dist/ sits in the resolution path. The test imports ../FlowRunner from source, and the mutated file is not a build input of anything the test reads, so neither leg needed a rebuild.

Verification at HEAD 577fa817

Heavy runs went through the shared verify lock, from the repo root.

Tests and type-check:

  • pnpm exec vitest run on the new pin file: 7/7.
  • Every app-shell test that names FlowRunner / ScreenView / ScreenPreview / flowResponse, plus packages/app-shell/src/views/__tests__/, useConsoleActionRuntime*, flow-envelope.ratchet, spec-symbol-parity and the console FlowRunsPage test: 31 files / 351 tests passed.
  • The 27 RecordDetailView.* host tests plus two flow-launch tests: 29 files / 224 tests passed.
  • pnpm --filter @object-ui/app-shell type-check exits 0, after building the @object-ui/app-shell^... closure. --listFilesOnly shows both FlowRunner.tsx and the new test are inside it.

Gates, all exit 0:

  • check:control-bytes, check:new-line-citations (0 new), check-changeset-presence, check-changeset-no-major, check-changeset-fixed and check-changeset-overwrite;
  • check:i18n-keys and check:i18n-drift;
  • check:spec-symbols and check:installed-pin-claims;
  • check:lockfile-integrity and check:lockfile-dedupe;
  • check:phantom-deps, check:unused-deps, check:self-import, check:esm-specifiers and check:unreferenced-sources;
  • check:vi-mock-specifiers, check:vi-mock-inherit and check:vi-mock-override-shape;
  • check:test-path-roots, check-type-check-coverage, check-lint-coverage and check-pre-install-import-graph;
  • check:handler-key-reads and check:metadata-write-doors;
  • check:changeset-claims (report-only). It names four pending changesets that mention pnpm-lock.yaml or packages/app-shell/package.json. I read each paragraph, and this diff falsifies none of them.

ESLint: run with --no-inline-config on the two changed source files (2 files in the --format json output). It found 0 errors and 4 warnings, and the same 4 rules fire on the base file (no-explicit-any ×3, set-state-in-effect). The config enables no type-aware linting, so this diff cannot change a verdict on any untouched file.

NOT MEASURED locally:

  • the full app-shell suite: 747 files, over the 10-minute foreground cap. It belongs to CI's four test shards.
  • check:spec-floors: it needs the whole workspace built (release and nightly lane). Its registry loader was run directly, as described above.
  • check:eager-closure and check:node-esm-load: they need the console build. @objectstack/spec/system is already reached today through metadata-form-i18n, and the console's vendor-objectstack group folds every spec module into one eager chunk, so the expected delta is two small functions.

description measurement (feeds the widen-or-not ruling)

  • Drawn every time it is non-empty. FlowRunner renders ScreenSpec.description as Radix DialogDescription inside DialogHeader, directly under the heading and above any alert and the fields. It uses text-sm text-muted-foreground, against the heading's text-lg font-semibold, with no truncation. It is also the dialog's accessible description, announced on open (pin 7 asserts this). The Studio ScreenPreview draws it too.
  • Authored use. I read all 6 screen nodes in the objectstack examples at c164186. 4 of the 6 author a description: all three app-crm crm_convert_lead_wizard screens, and the app-todo success_screen.
    • 2 of those 4 are message-only screens (screen_already_converted, success_screen), where the description is the whole body under the heading.
    • The other 2 are the instruction line above an object-form step.
  • One of the four is a template: Task "{subject}" created successfully!. The executor interpolates description on the server, and the wire carries neither the template nor the variables. A client-side overlay therefore cannot translate it without losing the per-run value. Widening the face to cover description would need the overlay applied server-side, before interpolation.
  • Net effect today: on notice and confirmation screens, a zh-CN user now reads a translated heading above an English sentence.

Ledger evidence (for the objectstack spec seat; the PM relays it, so nothing is posted on objectstack#11287 from here)

  • flows › children.screens: backed by this PR once it lands and ships. The reader is FlowRunner (localizeScreen via resolveFlowScreenTitle plus FLOW_SCREEN_FIELD_COPY_KEYS), pinned by the test file above. The row's authorHint names config.title, fields[].label and fields[].placeholder, and all three are now read. A title that falls back to the node label is covered by the same key.
  • flows › children.label: NOT backed. Nothing in objectui draws flows.FLOW.label. The dialog heading is the screen heading, and the completion toast names the flow's machine name (chrome, out of scope). This row stays planned.

Acceptance notes

  • Boundary of the client-side pick: a translated heading is drawn exactly as the bundle wrote it, so a {var} token inside it renders literally, because the wire title is already interpolated. 0 of 6 example headings carry a token today. This is recorded in the FlowRunner header.
  • Loader edge, outside this card (reported to the seat, not filed here): the console's loadLanguage transforms a spec payload only when isSpecTranslationData sees an object entry with fields. Otherwise the payload loads un-namespaced and no client resolver reads it. A named probe showed this: with the zh-CN payload objects.crm_lead.label only, useObjectLabel().objectLabel draws Lead, while the same payload with one field label draws 线索. A bundle that carries only flows would be dropped the same way.
  • No README or guide change. No document describes the runtime flow runner or the client translation scopes today; the changeset carries the user-facing description.

Generated by Claude Code

@claude
fix(app-shell): the screen-flow runner applies the app's flows tran…
577fa81 
…slation overlay

FlowRunner drew a paused screen's heading and field labels/placeholders
verbatim off the wire, so an app's `TranslationData.flows` copy reached no
screen in any locale. The runner now overlays it: the heading through the
spec's `resolveFlowScreenTitle`, the per-field copy through the spec's
`FLOW_SCREEN_FIELD_COPY_KEYS` (imported, never retyped), each key falling
back to the authored string on its own. The bundle is read out of the
i18next resource tree the console already loads for the active language.

Screen `description`, the runner chrome and `successMessage` stay
untranslated, per the spec's flows face and the recorded rulings.

The package's `@objectstack/spec` floor moves to ^17.3.0, the first release
exporting the resolver family.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BA3nKVUwKQJf8DBxrSVtNC
@github-actions

github-actions Bot commented Sep 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

changeset-claim-re-read

⚠️ 4 pending changeset(s) describe a file this change touches

Their bodies publish verbatim into the CHANGELOG at the next release, so this is a request to re-read them against your diff — addressed here because you are the one seat that can answer it without re-deriving anything.

⛔ Nothing here blocks, and nothing here is a verdict on your change. This gate exits 0, is not a required context, and judges name resolution, never meaning: it asked whether a pending body names a file you touched. "Is this sentence still true?" is the one question it will not answer, and the one you are being asked to answer.

.changeset/5793-spec-range-floors.md

  • names pnpm-lock.yaml → pnpm-lock.yaml — edited by this change

    Nothing a consumer installs today changes: normal resolution already picks the newest 17.x, and pnpm-lock.yaml still resolves 17.2.0 on this edge after the bump. The change is to the declared floor only, which is why it is scored patch rather than minor — the same reasoning objectui#5753 used for the other direction on this dependency.

.changeset/6361-spec-floor-17-2-0.md

  • names pnpm-lock.yaml → pnpm-lock.yaml — edited by this change

    Nothing a consumer installs today changes: normal resolution already picks the newest 17.x, and pnpm-lock.yaml still resolves 17.2.0 on both edges after the bump — only the recorded specifier: moves. No source and no behaviour changes, which is why this is scored patch, on the reasoning objectui#5793 used for the same remediation on @object-ui/plugin-detail.

.changeset/6776-metadata-admin-lazy-registration.md

  • names packages/app-shell/package.json → packages/app-shell/package.json — edited by this change

    • packages/app-shell/package.json's sideEffects array now names views/metadata-admin/register-builtins (the new leaf that performs the five registrations) instead of views/metadata-admin/index. The five registrations still run at package load, bare-imported by the package entry, so nothing a consumer could observe changes — but the array is a contract every consumer's bundler reads, so the swap is stated here rather than left to a diff. - The package barrel's 25 metadata-admin runtime re-exports (and 11 type-only ones) now point at their leaf modules. Same names, same types. They are unreachable from outside the package by any other path — exports is root-only — so no import an out-of-package consumer can write is affected.

.changeset/7122-objectstack-family-17-3-0.md

  • names pnpm-lock.yaml → pnpm-lock.yaml — edited by this change

    @objectstack/client, core, formula and lint each pin @objectstack/spec EXACTLY, so resolving the spec alone to 17.3.0 left the console bundling TWO copies of it. Moving the family with it in pnpm-lock.yaml collapses the duplicate; every declared range already admitted 17.3.0, so no manifest moved.

Read the paragraph, not the line: both false halves of the objectui#8617 claim sat in one paragraph, and correcting either alone would have left it asserting the same wrong thing.

If a claim did go false, correct the body. That is precedented and prose-only, frontmatter untouched; check-changeset-overwrite.mjs will report the correction as its own case 2 ("correcting a declaration on purpose … legitimate"), which is the intended shape — one gate asks for the read, the other records the write.

Not covered, stated so nobody reads this as more: a born-false claim that spells no line address at all (objectui#9495 coordinated one by ORDINAL — "a grep finds that member first" — and deciding that means reading what the sentence means), a claim spelled as a symbol or a package rather than a backticked file name, and a file named ambiguously.

Compared the checked-out tree with f4f1f4552 (merge-base with origin/main): 4 file(s) changed outside .changeset/, read against 1263 pending declaration(s) that publish a body (1831 pending in total). · run

@github-actions

github-actions Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 329 chunks) 3035.3 KB 3104.5 KB
Main entry chunk (gzip) 147.5 KB 350 KB
Entry file index-D_ZLj0b0.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.

📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 16.68KB 6.20KB
app-shell (runtime-config.js) 20.68KB 7.36KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.06KB 3.86KB
auth (ActiveOrganizationStorage.js) 25.05KB 9.16KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.18KB 10.59KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.15KB 5.39KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.65KB 2.22KB
auth (SocialSignInButtons.js) 9.61KB 3.89KB
auth (UserMenu.js) 3.41KB 1.23KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 40.21KB 10.80KB
auth (createAuthenticatedFetch.js) 8.46KB 3.43KB
auth (index.js) 3.19KB 1.44KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 26.08KB 7.56KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.49KB 2.64KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.68KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.05KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 546.84KB 130.95KB
core (index.js) 8.94KB 3.59KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 222.47KB 61.83KB
fields (index.js) 252.81KB 63.78KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 1.22KB 0.64KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.22KB 2.26KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 33.36KB 10.88KB
i18n (useDisplayLocale.js) 2.85KB 1.45KB
i18n (useObjectLabel.js) 34.34KB 9.17KB
i18n (useSafeTranslation.js) 5.60KB 2.33KB
layout (index.js) 39.02KB 11.00KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 13.52KB 4.88KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.24KB 2.16KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.39KB 3.10KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 14.81KB 3.63KB
plugin-calendar (index.js) 51.44KB 14.62KB
plugin-charts (index.js) 71.73KB 20.08KB
plugin-chatbot (index.js) 198.20KB 47.14KB
plugin-dashboard (index.js) 132.96KB 35.17KB
plugin-designer (index.js) 215.94KB 44.33KB
plugin-detail (index.js) 257.23KB 66.93KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 143.93KB 36.81KB
plugin-gantt (index.js) 167.99KB 41.37KB
plugin-grid (index.js) 214.64KB 58.59KB
plugin-kanban (index.js) 48.71KB 15.17KB
plugin-list (index.js) 113.53KB 27.99KB
plugin-map (index.js) 21.74KB 7.07KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 43.49KB 11.97KB
plugin-timeline (index.js) 30.68KB 8.95KB
plugin-tree (index.js) 10.58KB 3.72KB
plugin-view (index.js) 85.18KB 21.05KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.66KB 3.50KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 106.60KB 35.16KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.63KB 2.18KB
react (schema-input.js) 4.25KB 2.04KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.38KB 1.98KB
sdui-parser (codegen.js) 6.58KB 2.74KB
sdui-parser (dashboard-widget-options.js) 3.08KB 1.30KB
sdui-parser (index.js) 5.74KB 2.54KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (kanban-quick-add.js) 3.89KB 1.87KB
sdui-parser (parse.js) 25.28KB 7.80KB
sdui-parser (provenance.js) 3.66KB 1.82KB
sdui-parser (types.js) 0.28KB 0.23KB
sdui-parser (validate.js) 15.71KB 5.30KB
types (ai.js) 4.11KB 2.06KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 1.00KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 2.93KB 1.49KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 4.74KB 2.25KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 5.05KB 1.93KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 17.15KB 6.32KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.11KB 3.32KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@objectstack-fleet

objectstack-fleet Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor Author

Contract review

Served-tier: CONTRACT_REVIEW_TIER
Head-sha: 577fa817

Rendered by an isolated review subagent spawned by this seat. It was fed only the card, the PR, the two trees and the spec resolver source. Its served tier was checked by this seat against the stamp in its transcript. Adopted by this seat.

① Derived judgments

  • Public surface: nothing added or changed.
    • packages/app-shell/src/index.ts is not in the diff. exports (., ./styles.css), main / module / types / files / sideEffects / peerDependencies are unchanged.
    • FlowRunnerProps and ScreenFlowState are byte-identical.
    • Every new symbol in FlowRunner.tsx is module-private: activeFlowsBundle, overlayFieldCopy, localizeScreen and three local types.
    • The only manifest change is the dependencies floor @objectstack/spec ^17.0.0 → ^17.3.0. That is not a peer range and not an exports change. RIGHT.
  • The overlay is correct.
    • The heading goes through resolveFlowScreenTitle with the wire ScreenSpec. Its FlowScreenLike parameter is { nodeId; title?; … }, verified in the published 17.3.0 / 17.4.0 dist/system/index.d.mts. The lookup is flows[flowName].screens[nodeId].title, falling back to the literal title.
    • Fields are addressed by ScreenFieldSpec.name, over the imported FLOW_SCREEN_FIELD_COPY_KEYS (['label','placeholder']). A key is replaced only by a non-empty string, one key at a time.
    • With no bundle, the screen passes through by identity. RIGHT.
    • ⚠️ Nit, not blocking: the header says the resolvers are asked "with no fallback chain". At 17.3.0, the floor now admitted, a chain-less caller defaults to ["en"] (17.4.0 defaults to []). The behaviour is still right at every admitted version, because the bundle handed over is single-keyed ({ [language]: … }), so no second locale can match.
  • A fresh shown object each render breaks nothing.
    • ScreenView holds no memo or effect keyed on screen, and ObjectForm stays keyed by nodeId.
    • initialScreenValues reads the payload, and values are keyed by field name.
    • The missing-required check and the render read the same shown, whose name / type / required / visibleWhen / defaultValue / options are the payload's. So the enforced set equals the drawn set. RIGHT.
  • The run is driven by the payload: resumeWith, idVariable, isObjectFormScreen and setScreen(outcome.screen) all read the wire screen. RIGHT.
  • description, the chrome and successMessage are untouched. Pin (7) asserts that the accessible description stays authored beside a translated heading. RIGHT.
  • activeFlowsBundle is safe when the provider is absent, when a namespace has no flows, and on non-object values. With a same-named flow in several namespaces, the first in insertion order wins: deterministic, and it does not arise in the console, which has one app namespace per language. The loader edge (a payload with no objects.*.fields loads un-namespaced) is pre-existing and correctly reported out.

② Semver level

'@object-ui/app-shell': patch is RIGHT. It fixes a declared-but-unhonoured contract, and Clause-②: no holds. The narrowed floor sits in dependencies, which is not one of check-changeset-presence.mjs's publish-contract fields. Repo precedent scores exactly this remediation patch (5793-spec-range-floors.md, 6361-spec-floor-17-2-0.md).

Prose, sentence by sentence: TRUE.

  • "had no reader anywhere in the shipped platform": zero call sites in objectui main. In objectstack the only importer is the CLI's skeleton writer. translateFlow is absent from METADATA_DOCUMENT_TRANSLATORS.
  • "nothing new is fetched" and "renders exactly as before" match the diff.
  • "^17.0.0 admitted three releases that do not": verified against the registry tarballs. resolveFlowScreenTitle and FLOW_SCREEN_FIELD_COPY_KEYS occur 0 times in 17.0.0, 17.1.0 and 17.2.0, and are present in 17.3.0 and 17.4.0. The controls are present in all five.

Nothing to quote.

③ Boundary flags

  • Acceptance notes: the {var} boundary, the loader edge and "no README" are all read correctly.
  • File-surface deviation: required. Both new imports are runtime imports that first ship in 17.3.0. The lockfile diff is one importer specifier line, with the resolution unchanged at 17.4.0. Lockfile Integrity and Dedupe are green.
  • Fixes #5920: correct. The description measurement is present in the report and the PR body. ⚠️ The ledger-flip relay to the objectstack spec seat is owed by the landing seat at merge; Fixes does not perform it.
  • Clause-②: no: TRUE, measured.
  • Check-runs on 577fa817: 45, all terminal.
    • 41 green and 3 skipped by design.
    • 1 red, Spec Main Shape Gate: 21 TS2345 ZodSafeParseResult annotations on the three untouched test files, against objectstack 3b5607019f6b, and zero on any file this PR touches. That is the objectui#10229 drift, ⛔ not this PR's.

Implemented-by: claude/issue-5920-flow-runner-translation-overlay
Reviewed-by: session_01BA3nKVUwKQJf8DBxrSVtNC

VERDICT: PASS

Landing: draft until Spec Main Shape Gate is green (objectui#10229). Then: ready → auto-merge.

This was referenced Sep 24, 2026
Closed
Closed
Closed
Closed
@github-actions

github-actions Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 329 chunks) 3035.3 KB 3104.5 KB
Main entry chunk (gzip) 147.5 KB 350 KB
Entry file index-D_ZLj0b0.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.

📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 16.68KB 6.20KB
app-shell (runtime-config.js) 20.68KB 7.36KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.06KB 3.86KB
auth (ActiveOrganizationStorage.js) 25.05KB 9.16KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.18KB 10.59KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.15KB 5.39KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.65KB 2.22KB
auth (SocialSignInButtons.js) 9.61KB 3.89KB
auth (UserMenu.js) 3.41KB 1.23KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 40.21KB 10.80KB
auth (createAuthenticatedFetch.js) 8.46KB 3.43KB
auth (index.js) 3.19KB 1.44KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 26.08KB 7.56KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.49KB 2.64KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.68KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.05KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 546.84KB 130.95KB
core (index.js) 8.94KB 3.59KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 222.47KB 61.83KB
fields (index.js) 252.81KB 63.78KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 1.22KB 0.64KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.22KB 2.26KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 33.36KB 10.88KB
i18n (useDisplayLocale.js) 2.85KB 1.45KB
i18n (useObjectLabel.js) 34.34KB 9.17KB
i18n (useSafeTranslation.js) 5.60KB 2.33KB
layout (index.js) 39.02KB 11.00KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 13.52KB 4.88KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.24KB 2.16KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.39KB 3.10KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 14.81KB 3.63KB
plugin-calendar (index.js) 51.44KB 14.62KB
plugin-charts (index.js) 71.73KB 20.08KB
plugin-chatbot (index.js) 198.20KB 47.14KB
plugin-dashboard (index.js) 132.96KB 35.17KB
plugin-designer (index.js) 215.94KB 44.33KB
plugin-detail (index.js) 257.23KB 66.93KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 143.93KB 36.81KB
plugin-gantt (index.js) 167.99KB 41.37KB
plugin-grid (index.js) 214.64KB 58.59KB
plugin-kanban (index.js) 48.71KB 15.17KB
plugin-list (index.js) 113.53KB 27.99KB
plugin-map (index.js) 21.74KB 7.07KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 43.49KB 11.97KB
plugin-timeline (index.js) 30.68KB 8.95KB
plugin-tree (index.js) 10.58KB 3.72KB
plugin-view (index.js) 85.18KB 21.05KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.66KB 3.50KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 106.60KB 35.16KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.63KB 2.18KB
react (schema-input.js) 4.25KB 2.04KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.38KB 1.98KB
sdui-parser (codegen.js) 6.58KB 2.74KB
sdui-parser (dashboard-widget-options.js) 3.08KB 1.30KB
sdui-parser (index.js) 5.74KB 2.54KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (kanban-quick-add.js) 3.89KB 1.87KB
sdui-parser (parse.js) 25.28KB 7.80KB
sdui-parser (provenance.js) 3.66KB 1.82KB
sdui-parser (types.js) 0.28KB 0.23KB
sdui-parser (validate.js) 15.71KB 5.30KB
types (ai.js) 4.11KB 2.06KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 1.00KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 2.93KB 1.49KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 4.74KB 2.25KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 5.05KB 1.93KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 17.15KB 6.32KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.11KB 3.32KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review September 24, 2026 12:43
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Sep 24, 2026
This was referenced Sep 24, 2026
Closed
Closed
Merged via the queue into main with commit 5d895c1 Sep 24, 2026
47 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/issue-5920-flow-runner-translation-overlay branch September 24, 2026 13:04
@objectstack-fleet objectstack-fleet Bot mentioned this pull request Sep 24, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dependencies package: app-shell tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Screen-flow runner applies the flows translation overlay — the runner half of objectstack#11287 (client-side pick)

1 participant

@claude