finding(plugin-kanban): the card's OWN picklist branch never reaches the cell renderer, so an empty array still paints an empty coloured badge pill #8489

Activity

1. os-justin

   added

   bugSomething isn't workingSomething isn't working

   plugin

   plugin: kanban

   pm:queue

   finding

   priority:p2

   domain:uiobjectui ui stream: fix lands on the published library or apps — objectui execution seatobjectui ui stream: fix lands on the published library or apps — objectui execution seat

   pm:dispatched

   and removed

   pm:queue

   on Sep 8, 2026
2. os-justin

   self-assigned this

   on Sep 9, 2026
3. os-justin commented on Sep 9, 2026

   

   os-justin

   on Sep 9, 2026 – with Claude

   CollaboratorAuthor

   More actions

   Claim: session session_01YBWFb5YgMU5dw8p2VKj16S · branch claude/issue-8489-kanban-empty-badge-label

   PM dispatch (domain:ui seat). The assignee and this comment are set by the PM on the dev's behalf — the dev inherits both, posts no second claim, and ⛔ never writes the assignee field.

   Why this one is dispatched straight

   No ruling is open. An empty, fully-styled coloured pill is not a defensible rendering of anything, the card measured it by rendering rather than by reading, and it names the repair shape itself:

   Fixing it means the kanban's own guard learning what SelectCellRenderer's did — or, better, the picklist branch declining to push a badge whose resolved label is empty.

   ⭐ Take the second. It is strictly narrower, it needs no knowledge of what an "empty value" is, and it closes the second half too (below). ⛔ If your measurement says otherwise, report it — but do not reimplement an emptiness judgement inside ObjectKanban when the question at that point is only "is there a label to draw?"

   ⭐ The second half is the real scope, and it is independent of arrays

   any value that resolves to an empty label — an option whose declared label is the empty string, a stored value that stringifies to nothing — produces the same empty pill. The array case is simply the one that is easy to hit.

   ⇒ a fix that special-cases [] leaves the defect standing and will read as complete. ⚠️ The discriminating pin is a non-array value that resolves to an empty label, not the empty array. Build the fixture that way and the array case comes along for free; build it the other way round and it does not.

   What the card established — re-derive, but do not re-litigate

   packages/plugin-kanban/src/ObjectKanban.tsx:604 opens the explicit-card-field loop with if (raw == null || raw === '') continue; — [] passes that guard — and four lines later forks on isPicklist, which is true for any field carrying declared options. That branch never calls getCellRenderer, so objectui#8481's renderer fix cannot reach it: it resolves a label and colour itself and pushes a plain object onto cardBadges.

   Measured by rendering a real board with objectui#8481 applied: tags (declares options) → an indigo pill with zero children; topics (no options) and owners → the shared No value affordance. ⇒ ⭐ the broken one is the most commonly authored shape, because a picklist that declares its options is the normal case.

   ⚠️ Line numbers are from 7cf6f38fb. Re-locate by content and report what you found — objectui#8665 and objectui#8703 were each half or wholly falsified tonight because a source reading was taken for a behavioural one. The rendering measurement here is sound; the addresses are not facts.

   Evidence bar

   1. ⭐ Leg 1: render the board today and show the empty pill — both for [] and for a non-array value resolving to an empty label. ⛔ Reproduce before repairing.
   2. the fix draws no badge for either, while every populated badge is byte-identical to today;
   3. ⭐ non-regression, derived from the plausible wrong fix: "drop any badge whose label is falsy" would also drop a legitimately authored '0' label, and "drop empty arrays" leaves the second half standing. Pin a '0'-labelled option rendering normally, and pin the empty-label case separately.
   4. caricature both ways: "never push a badge" and "always push a badge" — both must redden loudly.

   ⚠️ An assertion never observed to fail has not been tested. Every pin must be observed red under leg 3 or leg 4.

   • ⚠️ ⭐ Assert the badge's absence at the DOM, not at cardBadges. A pin on the array is one refactor away from meaning nothing, and the defect is what the card draws.
   • ⚠️ queryByText('') will not do what you want, and queryByText throws on multiple matches as well as none. Count nodes at a stable selector — and ⚠️ verify each selector matches exactly one node per badge: .rounded-full matches TWO nodes per avatar elsewhere in this repo (Radix Avatar.Root and AvatarFallback), which objectui#8596's census never noticed because it navigated with querySelector instead of counting.
   • Ablation: mutate a READ SITE (never a pin), from a committed tree, trap on EXIT/INT/TERM with absolute paths, proving the mutation on disk in both directions (anchor counts AND git hash-object vs the HEAD blob) plus a line-total gate; restore by state (git diff HEAD empty; git checkout HEAD -- ABSOLUTE_PATH, never the bare form). A void leg is VOID, not green; a leg that lands but does not discriminate is NEGATIVE, not void — report it as negative.
   • ⚠️ git checkout HEAD -- PATH destroys uncommitted work in that path without a word. Commit your own edits first — that cost a redo on PR test(plugin-map,plugin-timeline): pin what these two contractEnvelope-6839 waits were standing on #8713 tonight.
   • LEG D: per-test classification from vitest's JSON reporter, ⛔ never the text reporter. Count death strings separately.

   Scope

   • ⛔ ObjectKanban's badge branch only. Do not touch @object-ui/fields' renderers — objectui#8481 owns those and its fix is landed.
   • ⚠️ objectui#8534 (KanbanImpl mirrors its columns prop into state and repaints one frame of empty columns) is the same package, a different defect, and not dispatched. ⛔ Do not fold it in; if your fixture trips over it, say so.
   • ⚠️ DOM shapes in your report should be spelled in words, not written literally — tag-shaped fragments are eaten from GitHub bodies even inside backticks. The card does this deliberately.

   objectui traps (measured, carry them)

   • Run vitest from the repo root with paths. Guard objectui#3378 refuses pnpm --filter PKG exec vitest run FILE; cd packages/X && pnpm exec vitest silently re-roots onto apps/console. ⛔ --no-inline-config is an objectstack convention and manufactures errors here CI does not have.
   • ⚠️ happy-dom reports clientWidth: 0 and never fires container-size effects; RTL's asyncWrapper drains one macrotask before returning, so a setTimeout(…, 0) deferral sits inside its own drain window (use 50ms if you need one).
   • ⚠️ Type-check with the dependency closure built; an unbuilt tree gives TS2307 for every workspace import — a PRECONDITION, recorded NOT MEASURED.
   • ⚠️ .at(-1) is TS2550 in packages inheriting the root lib: ["ES2020"] (objectui#8691); jest-dom matchers are typed program-wide by whichever file imports them (objectui#8722) — ⚠️ so a matcher that compiles in your package may do so only because another file imports jest-dom.
   • ⚠️ search_issues returns false zeros here and REST /search/issues has answered 403 including its control. Declare your channel and whether its control fired; ⛔ if neither works, report rather than filing blind.
   • skip-changeset is a phantom label; the real exemption is an empty-frontmatter changeset — get the gate's own verdict line.

   Collisions

   ⚠️ Check the merge queue before branching: git ls-remote --heads origin 'gh-readonly-queue/*' — a pr-<N>-<sha> branch means that PR is queued and building. ⛔ Nothing queued touches plugin-kanban; keep it that way and stop and report if your change reaches a queued PR's files.

   ---

   Generated by Claude Code
4. os-justin commented on Sep 9, 2026

   

   os-justin

   on Sep 9, 2026 – with Claude

   CollaboratorAuthor

   More actions

   os-dev-report

   {
     "issue": 8489,
     "status": "done",
     "branch": "claude/issue-8489-kanban-empty-badge-label",
     "pr": "https://github.com/objectstack-ai/objectui/pull/8733",
     "premise_still_valid": true,
     "summary": "Re-located by content on 5ece49bbc: the card's addresses were exact and nothing had moved — the guard at line 604, the isPicklist fork at 605-609, the badge push at 629. Both cardBadges.push sites in ObjectKanban.tsx now decline a badge whose RESOLVED LABEL is empty (the ruling's shape, not an emptiness judgement about the value): the dispatched explicit-cardFields picklist branch, and — declared as a bounded same-class in-place fix — the legacy semantic-field heuristic that runs when a board authors no cardFields, which resolves its label identically, had the identical defect (reproduced), and would have left the pill drawable from one branch away. The comparison is against the empty string, not falsiness, so a '0' label keeps rendering. ONE SUB-PREMISE OF THE CARD IS CORRECTED, measured not read: an option whose declared label is the empty string cannot on its own produce an empty label, because `opt?.label || String(raw)` falls back to the stringified value, and the i18n hop cannot introduce one either — useObjectLabel's resolve() rejects a translation equal to the empty string and returns its fallback. The empty label therefore always arrives via String(raw), by either the empty array or a non-array value that stringifies to nothing; the card's central finding (the empty pill, and the second half being independent of arrays) is confirmed by rendering and unaffected. objectui#8534 was not folded in and the fixture did not trip over it; @object-ui/fields is untouched. The assignee field was already set by the PM and was never written by me.",
     "tests": "All measurements at HEAD 6e3b9ffe5 (BASE 5ece49bbc). Run from the repo root with paths, per the objectui guard. LEG 1 (reproduce before repairing), packages/plugin-kanban/src/ObjectKanban.emptyBadgeLabel.test.tsx on the unrepaired tree: 4 failed / 5 passed; each failure printed the pill that must not exist — a lone division element carrying the badge primitive's base classes (inline-flex, items-center, whitespace-nowrap, rounded-full, border, px-2.5, py-0.5) plus the indigo colour set, with NO children and no text between its tags. Reproduced for BOTH shapes (empty array; non-array value stringifying to nothing) on BOTH branches. LEG 2 (after repair): that file 9/9 passed; whole package 35 files / 232 tests passed; adjacent kanban consumers (plugin-view, app-shell, plugin-list, types) 5 files / 192 passed. Byte identity is measured, not assumed: POPULATED_BADGE_HTML and LEGACY_POPULATED_BADGE_HTML are the outer markup of the four populated pills CAPTURED FROM A PRE-REPAIR RUN, and the suite compares post-repair markup against those captured strings. ABLATION — every leg mutates a READ SITE (the new guard), never a pin, from a committed tree, under trap on EXIT/INT/TERM with absolute paths; each proves the mutation on disk in both directions (anchor counts AND git hash-object vs the HEAD blob ef675ce63) plus a line-total gate, and restores BY STATE (git diff HEAD clean and blob back to ef675ce63) — restore verified by observing state, never by an exit code. Per-test classification from vitest's JSON reporter, suite-level death strings counted separately (0 in every leg). LEG 3a 'drop any badge whose label is falsy': mutation LANDED (blob a191ed9e5, anchors flipped, line-delta 0) but 9/9 passed => reported as NEGATIVE, not green and not void. Cause, measured: at this site `!label` and `label === ''` are behaviourally EQUIVALENT, because `opt?.label || String(raw)` lets no falsy label through, so the only falsy label reachable at the push is the empty string; the 'plausible wrong fix' is not in fact wrong here. `=== ''` kept as the intent-revealing spelling; the '0' pin is observed red under leg 4a instead. LEG 3b 'drop empty arrays only' (blob 5c2e1b03b): 7 passed / 2 FAILED — both NON-ARRAY pins red, both array pins green. This is the discriminating leg and it confirms the fixture is built the right way round: a fix special-cased on the empty array would have read as complete. LEG 4a caricature 'never push a badge' (blob e304b5935): 4 passed / 5 FAILED — both census pins, both byte-identity pins, and the '0' pin. LEG 4b caricature 'always push a badge', both guards deleted, line-total gate -2 (blob 5e74b058c): 5 passed / 4 FAILED — all four absence pins. ALL NINE PINS OBSERVED RED under leg 3 or leg 4; no leg was void. DOM DISCIPLINE: counts taken from rendered nodes scoped per card via SortableCard's own accessible-name handle (list-item role plus aria-label of the card title); queryByText with an empty string cannot express 'no pill' and throws on multiple matches as well as none, so pins COUNT nodes at a selector, and the selector is PROVED to match exactly one node per badge by a census case asserting the populated card's badge-text list — it uses the badge primitive's base classes (inline-flex and whitespace-nowrap with rounded-full), which the two avatar nodes that make a bare rounded-full count double in this repo do not carry. GATES: pnpm --filter @object-ui/plugin-kanban type-check exit 0 WITH THE DEPENDENCY CLOSURE BUILT FIRST (pnpm --workspace-concurrency=2 --filter '@object-ui/plugin-kanban^...' build, exit 0) — and the new test file is genuinely IN that program, proved with --listFiles (absent from the main tsc program, present in tsconfig.test.json's, and type-check runs both). eslint . over the WHOLE repo: 4594 files, 0 errors, 12400 pre-existing warnings — the full population, so no narrowing was needed and none is declared; the two changed files carry 0 errors (7 and 29 no-explicit-any warnings, the same class and convention as their sibling test files). check-changeset-presence.mjs verdict line: 'declares 1 changeset(s)'. check-changeset-no-major.mjs: 'No changeset declares a major bump.' check-control-bytes.mjs: OK over 6919 tracked text files, plus a manual control-character grep over the three changed files (no hits). check-governed-queue-guard.mjs --test: 'NOT GOVERNED — ordinary route'. skip-changeset was NOT applied — it is a phantom label in this repo and a real patch changeset is declared instead.",
     "mcp_calls": "0 — no MCP GitHub calls this run; the session's repo-scoped REST probe answered 200, so issue body, comments, PR files, open-PR list, PR create and the report comment all went over REST, and branch/queue reads over git.",
     "open_questions": [],
     "out_of_scope_findings": []
   }

   ---

   Generated by Claude Code
5. os-justin commented on Sep 9, 2026

   

   os-justin

   on Sep 9, 2026 – with Claude

   CollaboratorAuthor

   More actions

   Contract review — accepted. PR #8733 is out of draft and armed. No open questions to rule on.

   ⭐ A second push site the card did not name

   both cardBadges.push sites now decline a badge whose resolved label is empty: the dispatched explicit-cardFields picklist branch, and — as a bounded same-class in-place fix — the legacy semantic-field heuristic that runs when a board authors no cardFields, which resolves its label identically, had the identical defect (reproduced), and would have left the pill drawable from one branch away.

   ⇒ fixing only the dispatched branch would have shipped a repair that looks complete and leaves the defect reachable on the default path — a board that authors no cardFields is not an edge case. Correctly folded in rather than filed: same class, same file, same resolution, and the fix is the same one line of intent.

   ⭐⭐ A sub-premise of the card corrected — and it was a route I put in the dispatch

   The card listed two routes to an empty label, and my claim comment repeated them. Measured:

   an option whose declared label is the empty string cannot on its own produce an empty label, because opt?.label || String(raw) falls back to the stringified value — and the i18n hop cannot introduce one either: useObjectLabel's resolve() rejects a translation equal to the empty string and returns its fallback.

   ⇒ the empty label always arrives via String(raw), so there is exactly one route, not two. ⭐ I asked for a pin on a case that cannot occur; a dev who wrote it would have shipped a test that can never fail — which is this session's own headline defect, in a pin I specified. Measuring the route instead of pinning it is the right handling, and the card's central finding is untouched: the empty pill and the array-independence of the second half are both confirmed by rendering.

   ⭐⭐⭐ LEG 3a: my "plausible wrong fix" is not wrong here, and that is reported as NEGATIVE

   'drop any badge whose label is falsy': mutation LANDED (blob changed, anchors flipped, line-delta 0) but 9/9 passed ⇒ reported as NEGATIVE — not green, and not void. Cause, measured: at this site !label and label === '' are behaviourally equivalent, because opt?.label || String(raw) lets no falsy label through, so the only falsy label reachable at the push IS the empty string. "The 'plausible wrong fix' is not in fact wrong here."

   I derived that axis and demanded a '0' pin against it. It does not discriminate — and rather than quietly dropping the leg or reporting a false green, the report names it negative, explains why, keeps === '' as the intent-revealing spelling, and gets the '0' pin observed red under leg 4a instead.

   ⚠️ That is the third non-regression axis of mine measured and found not to hold tonight, and the third time a dev has said so instead of manufacturing agreement. ⭐ The axis was still worth stating — it is what produced the measurement that the two spellings are equivalent here, which is a fact about this call site nobody had.

   ⭐ LEG 3b is the discriminating leg, and it vindicates the fixture instruction

   'drop empty arrays only': 7 passed / 2 FAILED — both NON-ARRAY pins red, both array pins green.

   ⇒ exactly the outcome the dispatch was built around: "a fix special-cased on the empty array would have read as complete." The fixture is built the right way round, and this leg is the proof rather than the claim.

   All nine pins observed red under leg 3 or leg 4, no void legs, and byte identity measured rather than asserted — POPULATED_BADGE_HTML captured from a pre-repair run and compared against post-repair markup. A "nothing else moved" claim backed by bytes from before the change is the strongest available form.

   ⭐ The selector hazard was applied and then refined

   I warned that .rounded-full matches two nodes per avatar in this repo. The response is better than compliance:

   the selector is PROVED to match exactly one node per badge by a census case asserting the populated card's badge-text list — it uses the badge primitive's base classes (inline-flex and whitespace-nowrap with rounded-full), which the two avatar nodes that make a bare rounded-full count double do not carry.

   ⇒ the hazard is not avoided by hoping, it is excluded by construction and asserted. Counts are scoped per card through SortableCard's own accessible-name handle, and queryByText('') is correctly identified as unable to express "no pill" at all.

   Gates

   eslint . over the whole repo (4594 files, 0 errors) ⇒ no narrowing needed and none declared — the honest form when the full population is affordable. Type-check with the dependency closure built first, and the new test file proved in the program by --listFiles (absent from the main tsc program, present in tsconfig.test.json's, and type-check runs both) — an excluded test file would have been NOT MEASURED, not a pass. Control bytes scanned by the gate and by hand over the three changed files.

   ⭐ And a real patch changeset rather than an empty-frontmatter one, correctly: this changes what a published package renders. skip-changeset not applied — phantom label. 0 MCP calls.

   ⛔ objectui#8534 not folded in and the fixture did not trip over it; @object-ui/fields untouched.

   ---

   Generated by Claude Code
6. os-justin

   closed this as completedin #8733on Sep 9, 2026