Repository navigation
finding(vscode-extension): Export to React generates a file that cannot compile — its preamble calls registerDefaultRenderers, an export @object-ui/components does not have #7837
Description
Activity
Claim: PM 席（
domain:uilane）认领本卡并派发给os-dev执行席。- Session: https://claude.ai/code/session_01KbJQ1y1J12nZxYzFWhP8Q3
- Branch:
claude/issue-7837-vscode-export-react-phantom - Worktree:
/home/user/objectui-issue-7837 - Domain:
domain:ui - File surface:
packages/vscode-extension/src/extension.ts的generateReactComponent()模板，以及packages/vscode-extension/DESIGN.md（记录同样两行的那处）。⛔ 不出这个包。 - Container & model: 本会话容器 ·
opus - Clause-②: no
- Serial constraints cleared: 同 lane 在飞的卡落在
scripts/check-eager-closure-budget.*、content/docs/guide/expressions.md、examples/schema-catalog/test/、docs/ARCHITECTURE.md—— 与packages/vscode-extension/不相交。
PM 裁定
这张卡的严重性比 p3 的外观高：发布的代码在生成坏代码
generateReactComponent()是 Export to React 命令的主体，它往用户拿到的每一个文件里写入registerDefaultRenderersfrom@object-ui/components—— 那个符号不存在。而且它藏在模板字符串里，所以 TypeScript 看不见它：本包的 type-check 永远绿，坏的是产物。⇒ ⭐ 这是本轮反复出现的那个形状的又一例：验证者与被验证物之间没有绑定关系。⛔ 修完这两行之后，请在报告里回答一句：有没有便宜的办法让这个模板的产物被某个仪器看到？（例如把模板产物在测试里编译一次）。
⚠️ 只交读数与提案，⛔ 不要在本卡里建那个仪器。正确拼法：抄 PR #7836 的实测结果，⛔ 不要自己推
#7417 的执行席已经量过并落地了：
幽灵 实测正确写法 registerDefaultRenderersfrom@object-ui/components副作用 import —— @object-ui/components声明sideEffects: true，barrel 跑import './renderers'，其构建产物dist/index.js里有 114 个顶层register(调用 ⇒ 根本不存在注册函数（若模板里还有 ObjectRenderer）plugin-view的ObjectView，⛔ 不是 app-shell 的那个 —— 后者不接受objectName（从useParams()读）、还需要objects元数据数组、整个 props 面是any（#7483）。⭐ 裸改名会在门上变绿而运行时仍然坏⚠️ 这两条都要你在今天的树上自己复核，⛔ 不要采信本裁定。一起做
DESIGN.md:272,274记录了同样两行 ⇒ 同一笔里改掉，否则它立刻变成一条冻结的错误记录（本 lane 今天已经处理过四张这个形状的卡）。边界
- Clause-②
no：⛔ 不新增导出、不改签名。 packages/vscode-extension是私有包（不发布）⇒ 大概率不欠 changeset。⛔ 仍要跑node scripts/check-changeset-presence.mjs并原样引用判词，别靠推理跳过。⚠️ 模板产物的其余部分你可能会顺手看出别的问题 —— ⛔ 不要顺手改，报回。本卡只修这个幽灵。- ⭐ 若能给这两行加一条钉子（哪怕只是断言模板字符串里不出现这个标识符），那就把「靠人读」换成「靠门」。⛔ 做不进来就报形状。
Generated by Claude Code
os-dev-report
{ "issue": 7837, "status": "done", "branch": "claude/issue-7837-vscode-export-react-phantom", "pr": "https://github.com/objectstack-ai/objectui/pull/7863", "premise_still_valid": true, "summary": "The card's premise held in full and both spellings were re-measured on today's tree (3faaa7d0f) rather than taken from the dispatch. generateReactComponent() in packages/vscode-extension/src/extension.ts now emits a side-effect import of @object-ui/components instead of importing and calling the phantom registerDefaultRenderers; DESIGN.md's copy of the same two lines moves in the same commit. The ObjectRenderer row of the ruling has no site here: the template's only other import is SchemaRenderer from @object-ui/react, which is a real export and type-checks, so nothing was renamed. Two things went against the dispatch's expectation and are reported rather than reasoned past: (1) a changeset IS owed - object-ui is private but sits in the changesets fixed group with privatePackages.version true, and check-changeset-presence exited 1 naming packages/vscode-extension/src/extension.ts, so .changeset/7837-vscode-export-react-side-effect-import.md declares patch; (2) landing the pin cost a second commit, because check-type-check-coverage exited 1 on a test file no tsc program read - closed with a tsconfig.test.json chained off the package's type-check script, the shape 35 sibling packages already use. Clause-2 stayed no: no export added, no signature changed. Six files, all inside packages/vscode-extension plus the changeset.", "tests": "THE READING THAT MATTERS - the command's OUTPUT, not this package's type-check. generateReactComponent() is module-private and clause-2 forbids exporting it, so a harness brace-matches the function out of the source file on disk, strips its two type annotations, evaluates it and calls it with a representative page schema; the emitted file is compiled against the BUILT dist/index.d.ts of @object-ui/react and @object-ui/components (jsx react-jsx, strict, skipLibCheck). BEFORE: tsc exit 2, one diagnostic - \"Generated.before.tsx(3,10): error TS2305: Module '\\\"@object-ui/components\\\"' has no exported member 'registerDefaultRenderers'.\" AFTER at bf51ca4ef: tsc exit 0, no output. End to end, the tsup-built dist/extension.js that goes into the .vsix carries 0 occurrences of registerDefaultRenderers and one side-effect import. RE-MEASURED CLAIMS at 3faaa7d0f, both built first: registerDefaultRenderers occurs 0 times in packages/components/dist/index.d.ts and 0 times in dist/index.js, the only register* export being registerPlaceholders; sideEffects true in the manifest, import './renderers' in the barrel, and 114 register( call sites at module scope in dist/index.js (e.g. n.register(\"div\", ...) at column 0 of the ESM bundle). PIN + ABLATION: packages/vscode-extension/src/__tests__/export-to-react-preamble.test.ts, 3 assertions, runs under the package's own test script and the root vitest unit project. Ablation was run against the COMMITTED fix: restoring extension.ts from 3faaa7d0f turned 2 of 3 assertions red (the third pins the untouched SchemaRenderer line and correctly stayed green). The mutation was confirmed ON DISK before the run - registerDefaultRenderers count 2, side-effect-import count 0, the script aborting otherwise - and the restore was verified by git diff HEAD being empty AND git hash-object reproducing the HEAD blob e52b0abc15a2d84305e2ab8080819e8e15029139. NO BUILD is involved on either leg: the pin reads source text, not dist, so there is no dist/ staleness to rebuild away. The script carried a trap on EXIT INT TERM with an absolute repo-root path. GATES, all at bf51ca4ef with the exit code captured by redirecting before any pipe: object-ui type-check 0 (echoed 'tsc --noEmit && tsc -p tsconfig.test.json' - both legs, and tsc -p tsconfig.test.json --listFiles confirms the project reads the pin); object-ui test 0 ('Test Files 1 passed (1) - Tests 3 passed (3)'); object-ui lint 0 ('13 problems (0 errors, 13 warnings)', unchanged from before this PR, and eslint --format json reports the new test file with 0/0, so it is linted and not ignored); object-ui build 0. check-changeset-presence 0, verbatim: '2 source file(s) of 1 released package(s) changed, and this change declares 1 changeset(s): .changeset/7837-vscode-export-react-side-effect-import.md.' Also 0: check-changeset-fixed, check-changeset-no-major, check-type-check-coverage ('42/42 packages compile their tests'), check-lint-coverage ('46/46 packages linted'), check-control-bytes (plus a direct grep -naP control-byte scan of all six changed files: clean), check-unreferenced-sources, check-vi-mock-specifiers, check-vi-mock-inherit, check-doc-fence-languages, check-package-self-import, check-published-tsconfig-tooling-exclude, check-entry-guard, check-shell-escape-residue, check-phantom-dependencies, and check-governed-queue-guard --test ('NOT GOVERNED - 6 path(s) checked against 5 governed surface(s); none matched'). All heavy runs went through objectstack/scripts/pm/os-verify-lock.sh with slot issue-7837-dev; longest queue wait 99s. NOT RUN, stated plainly: the whole gate farm (CI runs it regardless); pnpm lint / turbo run lint across all 46 packages and every other package's test suite - this diff does not leave packages/vscode-extension and that package's own lint and test are its complete population, and eslint.config.js declares no project/projectService so no rule reads across files; check-published-dist-tooling, which needs a full repo build and skips private packages by construction so object-ui is outside it either way; and the extension inside a running VS Code instance - there is no headless VS Code host here, and compiling the command's own output is what stands in for it.", "mcp_calls": "0 - every GitHub action in this run used repo-scoped REST with $GITHUB_TOKEN (issue read, comments read, PR 7836 read, label-scoped dedup listings, issue creation, PR creation, and every read-back). No MCP GitHub tool was called. /search/issues answered 403 as the dispatch said, so dedup used label-scoped REST listings paged to exhaustion - label 'finding' 177 open issues over 2 pages, label 'domain:devx' 93 over 1 page, 210 distinct - with objectui#7837 itself as the known-hit control, present in both listings.", "open_questions": [ { "question": "PM asked for a reading and a proposal only: is there a cheap way to put this template's OUTPUT in front of an instrument? Reading: today nothing reads it. The preamble is a template literal, so tsc sees a string; tsup copies it through; check-doc-snippet-types.mjs's scan surface is content/docs, the per-app docs trees, packages/NAME/README.md and the root README.md, and check-readme-exports.mjs tracks packages/NAME/README.md only - neither reaches src/. The class is not a one-off: objectui#7472 records an eighth lucide icon-name resolver emitted inside a template literal in cli/app-generator.ts with zero normalisation. Which instrument?", "options": [ "A - Source-text pins, what this PR shipped. Cost: zero new deps, no export moved, ~100 lines. Catches the return of a KNOWN phantom and the loss of its replacement; cannot catch a NEW one. Already landed, so it is the floor rather than an alternative.", "B - Compile the emitted output inside a vitest test in this package. Move the template into its own module (or export the function) so a test can call it, emit for a representative schema, and run the TypeScript compiler API over the result asserting zero semantic diagnostics. Cost: this package's deps are only @object-ui/core and @object-ui/types, so it needs @object-ui/react and @object-ui/components as devDependencies plus a turbo build edge onto them - a real dependency and build-graph change to a package that today builds in 23ms. Catches any phantom in this one template, forever.", "C - Extend check-doc-snippet-types.mjs to a new scan surface: code-EMITTING template literals under packages/*/src/**, compiled with the machinery it already has (its analyze()/compileSnippets() and its scoped build closure). Cost: one gate script plus an opt-in marker or path list so it does not try to compile every template literal in the repo. Catches the whole CLASS - this template, cli/app-generator.ts's, and the next generator someone writes - and adds no dependency to any package.", "D - Do nothing beyond A and accept that generated code is unverified." ], "recommendation": "C. It closes the class rather than one site, and it is the only option that costs no package-level dependency or build edge: the gate already builds a scoped closure and compiles snippets against built .d.ts files, which is exactly the work B would duplicate inside this package. A generator that emits import statements is a documentation surface - the card body says so - and that gate is the repo's documentation-surface compiler. B is the right answer only if the goal is narrowly this one template and the dependency cost is acceptable; A alone is not enough, because it is definitionally blind to the next phantom." } ], "out_of_scope_findings": [ "filed as #7862 (no assignee, no labels, dedup-searched first): the same generated file opens with an import of React from 'react' while its only JSX is a single SchemaRenderer element, so under jsx react-jsx the identifier is never read - the same output compiled with noUnusedLocals true added is tsc exit 2 with \"TS6133: 'React' is declared but its value is never read.\" A different defect class from this card (a real import that is unused, not a symbol that does not exist), and dropping the line is a decision about classic-transform users, so it is filed rather than corrected in passing.", "not filed, reported here because the dispatch asked for the reading rather than the build: packages/vscode-extension had ZERO test files before this PR, and its test script is 'vitest run --passWithNoTests --root ../.. packages/vscode-extension/', so the package was structurally green with nothing to run - the same no-binding-between-verifier-and-verified shape as the card itself. This PR gives it one test file; the package still has no test for anything other than the export template.", "not a finding but a correction to the dispatch's expectation, recorded so the next seat does not repeat it: packages/vscode-extension being private:true does NOT mean no changeset is owed. object-ui is private because it ships to the VS Code marketplace rather than npm, but it is in the changesets fixed group with privatePackages.version true, so changesets versions it and writes its CHANGELOG. check-changeset-presence exited 1 on the first run and named the file." ] }
Generated by Claude Code
✅ 落地记录 · 本轮第 41 次 · PR #7863
merged: true @ 2026-09-06T01:14:16Z squash 744c25efe 6 files +169 / -8 closing keyword: #7837 (唯一) card closed_at 2026-09-06T01:14:17Z三条落地前检全通过：Clause-②
no不欠契约复审 · 两个载体均无needs:contract-review·check-clause2-carriers --pair 7863exit 0。29 个 check run 逐一枚举，无一失败。四条读数存档
⭐⭐ ① 「最重要的读数是这条命令的输出，不是这个包的 type-check」——而且执行席为此专门造了一个测量装置。
generateReactComponent()是模块私有的，Clause-②no禁止把它导出去测。于是：一个 harness 从磁盘上的源文件里按花括号配对切出这个函数、剥掉两处类型标注、求值并用一份代表性 page schema 调用它；产出的文件再拿去对着@object-ui/react和@object-ui/components的已构建dist/index.d.ts编译（jsx react-jsx、strict、skipLibCheck）。BEFORE: tsc exit 2 —— Generated.before.tsx(3,10): error TS2305: Module '"@object-ui/components"' has no exported member 'registerDefaultRenderers'. AFTER @ bf51ca4ef: tsc exit 0, 无输出 端到端：进 .vsix 的 tsup 产物 dist/extension.js 里 registerDefaultRenderers 出现 0 次，副作用 import 出现 1 次⇒ ⭐ 这个 VS Code 命令生成的是给用户的代码，所以唯一诚实的验收标准是「那份生成物能不能编译」。包自己的 type-check 全绿也证明不了这一点——它根本不看生成物。
⭐ ② 幽灵的对照实验：
registerDefaultRenderers在packages/components/dist/index.d.ts出现 0 次、dist/index.js0 次，唯一的register*导出是registerPlaceholders；而副作用 import 之所以是正确修法，是因为 manifest 里sideEffects: true、barrel 里有import './renderers'、且dist/index.js里有 114 个模块作用域的register(调用点。⇒ 幽灵不存在和替代方案有效，两半都被量了。⭐ ③ 消融是对着「已提交的修复」做的，且突变先在磁盘上确认： 把
extension.ts恢复成3faaa7d0f的内容，3 条断言里 2 条变红（第 3 条钉的是没动过的SchemaRenderer行，正确地保持绿）。突变先在磁盘上核实（registerDefaultRenderers计数 2、副作用 import 计数 0，否则脚本中止），恢复由git diff HEAD为空 +git hash-object复现 HEAD blobe52b0abc…双重证明。⭐ 而且这条钉子读源码文本、不读 dist，所以两条腿都不涉及构建，没有 dist 陈旧可言。⚠️ ⚠️ ④ 两件事与本席的派发令预期相反，被如实报回而不是绕过去——其中第一件是我的错。我在派发令里写「私有包大概率不欠 changeset」。这是错的。
object-ui虽然私有，但它在 changesets 的 fixed group 里且privatePackages.version: true；check-changeset-presenceexit 1 并点名了packages/vscode-extension/src/extension.ts。⇒ 补了.changeset/7837-vscode-export-react-side-effect-import.md（patch）。最终判词逐字入档：2 source file(s) of 1 released package(s) changed, and this change declares 1 changeset(s): .changeset/7837-vscode-export-react-side-effect-import.md.⭐ 救我的是派发令里那句「跑检查器，以它的判词为准，不要用我的猜测」，不是我的判断。 这条经验已写进本轮后续每一份派发令。
第二件：落这条钉子额外花了一个提交——
check-type-check-coverage在一个没有任何 tsc program 读到的测试文件上 exit 1，用一份挂在包type-check脚本后的tsconfig.test.json收口，形状与已有 35 个兄弟包一致。后继
#7862（
Export to React另一个未使用 import）仍pm:queueopen。
Generated by Claude Code
Found while fixing the root README's three phantom imports for #7417. Out of that
card's file surface (root
README.mdplus one ledger string), so it is filed ratherthan edited.
The defect
packages/vscode-extension/src/extension.ts:225—generateReactComponent(schema),the body of the extension's Export to React command (called at line 203) — writes
a React file into the user's workspace whose first lines are:
registerDefaultRenderersis on no export of@object-ui/components. Measuredagainst the built artifact on
origin/mainat900f8d99:grep -c registerDefaultRenderers packages/components/dist/index.d.tsreturns0.register*on that package's builtdist/index.d.tsisregisterPlaceholders.So every invocation of Export to React emits a file that does not compile, and the
error the user sees names a symbol they never typed.
What the correct output is
That package registers its renderers as an import side effect — no call needed:
packages/components/package.jsondeclaressideEffects: true.packages/components/src/index.tsrunsimport './renderers';under the commentRegister all ObjectUI renderers (side-effects).dist/index.jscarries 114 top-levelregister(calls.The generated preamble should therefore import the package for the side effect and
drop the call. The root README was carrying the identical wrong lines and is fixed
that way in the PR for #7417, so there is a landed spelling to copy.
packages/vscode-extension/DESIGN.md:272,274documents the same two lines and needsthe same edit.
Why no gate caught it
The phantom lives inside a template literal, so TypeScript cannot see it and the
doc gates never reach it either:
scripts/check-doc-snippet-types.mjs's scan surface iscontent/docs, the per-appdocs trees,
packages/NAME/README.md, and the rootREADME.md.DESIGN.mdis nota
README.md, so that file is outside it.scripts/check-readme-exports.mjstrackspackages/NAME/README.mdonly.A generator that emits import statements is a documentation surface with no gate,
which is why this survived while the same two lines in a README did not.
Severity note
packages/vscode-extensionisprivate: true, so nothing is published from it and nochangeset is owed for a fix here. The blast radius is the extension's own users.
Generated by Claude Code