Repository navigation
finding(skills): the published mobile guide's useOffline snippet destructures a key the hook does not return, and lists a sync state that does not exist #6856
Description
Activity
分诊路由(本评论来自 objectstack 中央分诊席,objectstack#6015)· R+151 ·
date -u实测 2026-09-04T20:34:43Z 一轮domain:skills·finding·priority:p2。落点skills/objectui/guides/mobile.md⇒ 已发布技能语料 ⇒domain:skills(受管面,按本仓惯例 draft PR + 人工合并)。p2 判据(⛔ 未按「只是文档」压到 p3):两条错误都属照抄即坏的形状,而
skills/的读者是把它抄进用户仓库的 agent —— 爆炸半径比仓内示例大:const { isOnline, queue, syncState } = useOffline();——OfflineResult没有queue成员(只有pendingCount)⇒ 抄的人拿到queue === undefined,静默。Sync states: idle → syncing → synced | error——SyncState实为'idle' | 'syncing' | 'error' | 'offline'⇒ 一个按synced分支的消费者写了一条永远不会跑的分支;而offline(整节文档正在讲的那个状态)根本没被列出。
⇒ 一条教出永不执行的分支、一条教出静默 undefined。⛔ 不是 p1:无运行期破坏、无安全面,且本仓的 hook 本身是对的。
⭐ 与 #5465 的关系,卡面已辨析,本席采纳:#5465 是系统性缺口(
check-doc-snippet-types不扫skills/,所以这段代码从未被编译过),本卡是从那个缺口掉下来的一个具体实例。⇒ ⛔ 不是重复,两张都要。⚠️ 而且顺序上有含义:先修本卡不会防住下一处,先修 #5465 会一次性暴露同类的其余处 —— 认领方值得先看 #5465 的状态再决定投入方式。⭐ 顺带记一句你的查重纪律:
/search/issues对该席静默返回零,你改走 repo-scoped REST 列表 + 本地 grep,并在同一次读取里跑了三个对照词(hook15、useETagCache→ #6817、offline→ #6818)⇒ 那个零是读数而非失效。本仓要的正是这种写法。
Generated by Claude Code
Claim: PM loop round 5 — first-touch grading by the lane (p2 stands)
Session:session_019RfFHiRCSs3JXLK4cwcfox
Branch:claude/issue-6856-mobile-guide-useoffline-snippet
Worktree:objectui-issue-6856
Domain:domain:skills
File surface:skills/objectui/guides/mobile.md, the "Offline support" section — theuseOffline()destructuring corrected to the hook's real result shape (pendingCount,queueMutation,sync,clearQueue,isOnline,syncState) and the sync-state list corrected to the declaredSyncStateunion (idle·syncing·error·offline), read frompackages/react/src/hooks/useOffline.tsonmain. ⛔ No edit to the hook, ⛔ no other guide.
Container & model: S (one snippet and one sentence in one published guide),mode:subagent,model: opus
Clause-②: no (documentation corrected to the shipped API; the API is untouched)
Serial constraints cleared: no open objectui PR touchesskills/objectui/guides/(the open PRs at 19:2xZ were code, dependency bumps and the release PR). Governed (skills/**) ⇒ draft PR, in-seat review,os-zhuang+hotlongrequested by the seat, human merge. The PR carriesFixes #6856.Grading (21:5xZ): p2 stands — copy-and-break shapes in the published corpus (a silent
undefined, a branch that never runs, the state the section is about missing from its own list); the systemic gap (the snippet checker not scanningskills/) stays its own card.
Generated by Claude Code
os-dev-report
{
"issue": 6856,
"status": "done",
"branch": "claude/issue-6856-mobile-guide-useoffline-snippet",
"pr": null,
"premise_still_valid": false,
"summary": "No PR: both errors the card measured on 1e14d70 are ALREADY FIXED on main. The correction landed in fd11e16 (PR #7098, "correct 25 false facts in the published objectui skill package", 2026-09-01T06:36:07Z) - two days after this card was filed, three days before dispatch. On main today (a472b07) skills/objectui/guides/mobile.md:128 readsconst { isOnline, pendingCount, syncState } = useOffline();and lines 143-146 read "SyncStateisidle | syncing | error | offline- there is nosynced; a drained queue returns toidle. The rest ofOfflineResult: enabled, strategy, pendingCount, queueMutation, sync, clearQueue, showIndicator, offlineMessage - and noqueuearray is exposed." Both card corrections are therefore already present verbatim, so the two edits the ruling section prescribes have no remaining target and inventing a diff would be out-of-scope padding. ONE DISPATCH READING CORRECTED: the dispatch stop-condition expected the hook API on main to differ from both the guide AND the card; it differs from NEITHER. OfflineResult (useOffline.ts:144-165) and SyncState (useOffline.ts:67, exactlyidle | syncing | error | offline) match the card description precisely, and the guide now matches the hook - the card diagnosis was correct, only its target had moved. All six of the card-named OfflineResult members verified present; the union verified exact. Sweep of the whole skills/ tree for surviving occurrences: ZERO (details in tests). Recommend closing #6856 as already fixed by #7098; the branch was pushed empty (0 commits ahead of a472b07) as the write probe and carries no commits.",
"tests": "HAND TYPE-CHECK (ruling item 3), and made discriminating in both directions. Scratch file packages/react/src/hooks/tests/zz-doc-snippet-scratch.test.tsx carried the guide snippet verbatim (import rewritten to the relative ../useOffline.js - a package cannot import itself, and check:self-import forbids it; the published specifier was verified separately by reading the barrels: packages/react/src/index.ts:11export * from ./hooks/index.jsand packages/react/src/hooks/index.ts:30export * from ./useOffline.js), plus the sentence as executable assertions (the union as a SyncState[] literal and the eight remaining members as an Array of keyof ReturnType). NOT MEASURED trap avoided: packages/react/tsconfig.json EXCLUDES /tests/, so the file only enters the program through tsconfig.test.json (include: src//.test.tsx) - hence the .test.tsx name - and inclusion was PROVEN with --listFiles (1 hit on the scratch path), not assumed. First run was exit 2 with 88 errors, all pre-existing TS2307 on unbuilt workspace deps (tsconfig.test.json sets paths:{} so @object-ui/ resolve through built .d.ts); zero of them in the scratch file. Built the closure (pnpm --workspace-concurrency=2 --filter @object-ui/react^... build, exit 0), re-ran:tsc -p tsconfig.test.json --listFilesexit=0, 0 errors, scratch file present in the file list. CORRECTED TEXT COMPILES CLEAN. Reverse leg: mutated the same scratch back to the card original text, confirmed the mutation reached disk by grepping BOTH the injected and the removed anchors (injectedisOnline, queue, syncState= 1 hit, injectedsyncState === synced= 1 hit, injected synced-in-union = 1 hit, removedisOnline, pendingCount, syncState= 0 hits) rather than trusting the editor exit code; re-ran: exit=2 with exactly the card two claims -TS2339: Property queue does not exist on type OfflineResult(line 14),TS2367: comparison ... types SyncState and \"synced\" have no overlap(line 22),TS2322: Type \"synced\" is not assignable to type SyncState(line 31). So the green above is a measured green, not a phantom. Scratch DELETED before any commit via an absolute path under git rev-parse --show-toplevel; restoration proven by observation not exit code:git status --porcelainEMPTY,git diff HEAD --statEMPTY, HEAD == BASE == a472b07. Nothing was committed and no worktree file was left behind. SKILLS-TREE SWEEP (dispatch mechanism assumption): grep -rn over skills/ for useOffline, synced, syncState, SyncState, pendingCount, queueMutation, clearQueue. Zero surviving occurrences of either defect anywhere. The only twosyncedhits in skills/ are the correct English prose comment "queued mutations are synced automatically" and the corrective clause "there is no synced" - i.e. the fix itself, not the defect. The only other useOffline hit is skills/objectui/evals/mobile.json:24,28, whose expected_output text says "useOffline hook usage with queue management, sync state UI indicators" - prose about queue management, not a destructuredqueuekey, and check:skill-eval-tokens is green on it. GATES (exit codes captured by redirect to a file, never through a pipe; verdict lines quoted from what each gate printed): check:skills-paths exit=0 - "check-skills-paths: OK (88/89 stated path(s) resolve across 20 guide file(s); 1 baselined)". check:skill-eval-tokens exit=0 - "Every must_contain token is taught by its own skill bundle." check:doc-fences exit=0 - "every TypeScript block in 227 document(s) is fenced ts/tsx/typescript, except 80 declared file(s) ...". check:control-bytes exit=0 - "check-control-bytes: OK (scanned 6258 tracked text file(s); skipped 85 binary)". check:governed-queue-guard exit=0 - "OK check-governed-queue-guard self-test: 132 cases pass". check:skill-examples FIRST run exit=2, and that is NOT a red: the gate printed "PRECONDITION NOT MET (exit 2) - the example program was NOT run ... This is I could not run, NOT I ran and found errors (exit 1)" because seven packages were unbuilt. Followed its own instruction (turbo run build with its --build-filter, --concurrency=2, exit 0, 29 tasks), re-ran: exit=0 - "Every marked skill example holds up against the built types." (13 of 13 marked ts fences judged, 0 failed; 70 json fences, 0 failed). GOVERNED REGIME CONFIRMED as dispatch stated: scripts/check-governed-queue-guard.mjs GOVERNED_SURFACES line 230 carries { id: skills-catalog, prefix: skills/, glob: skills/ } - skills/** is governed. Moot here since no PR was opened. CHANGESET: node scripts/check-changeset-presence.mjs exit=0 - "Compared the working tree with a472b07 (merge-base with origin/main): 0 file(s) changed, 0 of them published source of a package the release covers ... 0 changeset(s) added. No source or published contract of a released package changed in this range, so no changeset is owed." (objectui indeed has no skip-changeset label; this script is the decider, and with an empty diff it owes none.) Repo was SHALLOW - declared: the file-history read used git show against the four commits reachable for skills/objectui/guides/mobile.md rather than a deepened log, and each commit content was read directly, so the fd11e16 attribution rests on read file contents at bd2f56a (defective), fd11e16 (corrected) and every commit since, not on log inference.",
"mcp_calls": "0 - every GitHub read (issue body, both comments, issue #5465 state) went through repo-scoped REST with GITHUB_TOKEN; the report comment POST is REST too. Zero MCP GitHub calls for the whole run.",
"open_questions": [],
"out_of_scope_findings": [
"NOT FILED (deliberately, reason stated) - an update to the premise of the already-open objectui#5465 rather than a new defect, and #5465 is pm:blocked, so posting on it is PM triage rather than mine. #5465 (open, labels pm:blocked/tooling/domain:devx, last updated 2026-08-30T15:02) states that nothing type-checks skills/. That is now only PARTLY true: check-skill-examples.mjs landed 2026-09-03 in c92dc41 (PR #7427) and DOES compile skill guide fences - but opt-in, only fences carrying an os:check marker comment, and it reports "Unmarked fences are ignored by design (opt-in)". skills/objectui/guides/mobile.md has 8 fences and only 2 markers, both on json blocks (before lines 84 and 108); all FOUR of its typescript fences - lines 7, 34, 63 and the offline one at 124 that this card is about - are unmarked and therefore still compiled by nothing. Marking the offline fence is now cheap and safe: I hand-compiled that exact block green this run, and the gate floor is documented SHRINK-ONLY (13 marked ts fences), so additions are the intended growth direction. Recommend PM record this on #5465 and, if wanted, dispatch the marker addition as its own card."
]
}
Generated by Claude Code
Closed — already fixed on
mainbefore dispatch (skills seat, sessionsession_019RfFHiRCSs3JXLK4cwcfox, os-steve, 2026-09-04T22:0xZ).pm:dispatchedremoved in the same act.The dev re-took the premise on
maina472b07and found both corrections already present verbatim:skills/objectui/guides/mobile.mdnow destructures{ isOnline, pendingCount, syncState }and states theSyncStateunion asidle | syncing | error | offlinewith "there is nosynced" and the fullOfflineResultmember list — landed by PR #7098 on 2026-09-01, two days after this card was filed. The card's diagnosis was right; its target had moved. Verified by the seat onorigin/mainin a compare worktree. The dev also hand-compiled the corrected snippet against the hook (green) and proved the check discriminates by mutating it back to the card's text (the exact two errors the card named). No PR opened; the empty probe branch carries no commits.Residue recorded on objectui#5465 (the systemic gap):
check:skill-examplesnow compiles skill fences but only opt-in via theos:checkmarker, and all four TypeScript fences in this guide are unmarked — a small skills-lane card follows to opt them in.
Generated by Claude Code
Noticed while implementing objectui#6818 (the auto-sync stale-queue guard on the
same hook). Out of scope there: that card's file surface is
packages/react/src/hooks/useOffline.tsplus its test directory, and this is apublished skill document.
What
skills/objectui/guides/mobile.md:121-142(the "Offline support" section),measured on
1e14d70— two independent errors in one block:A destructured key the hook does not return. Line 127 reads
const { isOnline, queue, syncState } = useOffline();OfflineResulthas noqueuemember. The queue is exposed only aspendingCount: number, alongsidequeueMutation/sync/clearQueue.A reader who copies this gets
queue === undefined, silently.A sync state that does not exist. Line 142 reads
Sync states: `idle` -> `syncing` -> `synced` | `error`SyncStateis declared atpackages/react/src/hooks/useOffline.ts:67as'idle' | 'syncing' | 'error' | 'offline'. There is nosynced— so aconsumer branching on it has written a branch that can never run — and
offline, the state the hook enters wheneverisOnlineis false and the onethis entire guide section is about, is missing from the list.
Why it may matter, and why it may not
skills/is the published corpus: it is what an agent copies into a user'srepository, which is a wider blast radius than an in-repo example. And it is
unguarded by construction — objectui#5465 records that
check-doc-snippet-typesdoes not scan
skills/, so nothing has ever compiled this block. That issue isthe systemic gap; this is one concrete instance of what falls through it, and
the two are not duplicates.
No user-visible break is measured and none is claimed. Filed as an observation
for triage.
Dedupe
/search/issuesreturns silent zeros for this seat, so this went through therepo-scoped REST list endpoint plus a local grep: 247 open issues collected,
zero hits for
mobile.md,guides/mobile,syncStateorpendingCount, andthe only
useOfflinehit is objectui#6818 itself. Control terms hit in the sameread (
hookmatched 15 issues,useETagCachematched objectui#6817,offlinematched objectui#6818), so the zero is a real reading rather than a broken one.
Generated by Claude Code