Skip to content

Retire ObjectSchemaClientExtensions.editMode — the spec object document now declares it; derivation carries the key (release-gated on the spec version containing objectstack#11408) #6328

Description

@os-litant

Filed by the objectstack spec PM seat (session_01NDGG54XF5gbTLdQzCtnaVV, R6) at acceptance of the spec-side adoption, per the recorded maintainer ruling. Reader: the objectui execution seat's queue.

Blocked-by: a released @objectstack/spec version carrying the editMode object-document declaration (objectstack#11408, PR objectstack#12208) reaching this repo's installed pin — release-gated per the #11498 discipline, not merely merged upstream. Do not dispatch before the pin covers it; the unlock criterion is consumer-installable.

Provenance (ruling, verbatim from objectstack#11408)

Ruled: the spec's object document adopts editMode?: 'modal' | 'page' as an optional authored key. objectui then retires the ObjectSchemaClientExtensions.editMode member and lets the derivation carry it — its pinned rejection tests flip by design and say so. (Maintainer, 2026-08-24, live PM chat, verbatim: 「接受你的建议。」)

Executable acceptance criterion

Once the pin covers the spec release: remove the editMode member from ObjectSchemaClientExtensions (the client-side extension shim) and let the spec-derived object type carry the key; the pinned rejection tests that asserted "spec refuses editMode" flip by design — delete or invert them per their own in-test notes, never patch them green. Read points (recordFormNavigation.ts, AppContent's handleEdit) keep working unchanged, now typed by the derivation instead of the shim.

Refs: objectstack#11408 (ruling + spec adoption) · objectstack PR #12208 (the declaration, with the objectui read points named in its describe).

Activity

  1. objectstack-fleet commented on Sep 24, 2026

    @objectstack-fleet
    Contributor

    关闭 completed —— 本卡要做的事已经完成:spec 已接管 editMode,客户端那份已退役

    分诊席(session_01Tw7jnJinGHvoGSi8aFkhPJ,objectstack 座位贴 #6015),2026-09-24T01:40Z。objectui 清理第一批:本席逐张读完卡面与全部评论,把结论与理由报给维护者,维护者答复后执行。 维护者答:「其他同意」。本卡显示 1 条评论,本席的读取通道读不到它,在此如实说明。

    读数(objectui origin/main)

    packages/types/src/field-types.ts 的 ObjectSchemaClientExtensions 说明写明:「The delta is EMPTY today… editMode was the one member. @objectstack/spec 17.3.0 ADOPTED it」。并注明这次退役正是本卡与那处钉的说明所要求的。editMode 仍可编写、仍有类型,现在由 spec 的派生类型承载;recordFormNavigation.ts 的读点不变。

    ⇒ 本卡的验收标准(删掉客户端扩展成员,改由派生类型承载该键,反转那几条「spec 拒绝 editMode」的钉)已经在树上。只是卡没人关。

    标签:摘 pm:on-hold;以 completed 关闭。


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    domain:uiobjectui ui stream: fix lands on the published library or apps — objectui execution seat

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions