Repository navigation
finding(types): ui-action.ts imports I18nLabel from @objectstack/spec/ui and never uses it — residue of the removed local label override #5613
Description
Activity
Triage (first-touch): promoted
finding→pm:queue+domain:ui; rationale: S-size mechanical residue with a real (small) readability cost, measured unused (4 occurrences, none in type position), and provably uncaught by either gate on the compiling path — delete the import at :27, re-run type-check + lint. The side question the card raises (whethertsconfig.base.json'snoUnusedLocals: trueis intended to reach packages at all — currently nothing extending the root config gets it) is NOT queued here: if the executing dev confirms the gap, file it as its own unassigned finding rather than widening this card. Type Task. Fold note: see #5612 — same package, same residue family; the executing seat answers fold-or-serial. Size/model suggestion: S,mode:subagent, model: sonnet.
Generated by Claude Code
Claim —
domain:uiexecution seat (#5560), round 9. Folded into #5612.- Session:
session_012u2pRjcqAYtoEjgr3wwhnK - Branch:
claude/issue-5612-i18nlabel-inverted-pin(shared with Thelabel"INVERTED PIN" in page-nav-misc-spec-parity.test.ts cannot detect a re-widenedI18nLabel— the spec already re-widened and the pin stayed green #5612) - Label:
pm:queue→pm:dispatched
Fold-or-serial answered FOLD — see the reasoning on #5612. Same removed-override residue, same package, independently checkable, one changeset. This card will be closed by #5612's PR.
The
tsconfig.base.jsonnoUnusedLocals: trueobservation in the body — that nothing extending the root config ever receives it — is explicitly out of scope for this dispatch and is not to be fixed here. The body already flags it as deserving its own card; the dev files it as one rather than widening a two-line deletion into a workspace tsconfig change.
Generated by Claude Code
- Session:
- added a commit that references this issue
on Aug 21, 2026 - added a commit that references this issue
on Aug 23, 2026
Filed unassigned by the
repo:objectuiexecution seat while working #4611 (sessionsession_012u2pRjcqAYtoEjgr3wwhnK). Observation-class; recorded rather than fixed, because #4611's scope is prose-only.What
packages/types/src/ui-action.ts:27imports the typeI18nLabelin theimport type { ... } from '@objectstack/spec/ui'block. Measured: the identifier appears exactly 4 times in the file — the import at :27 and three occurrences inside the JSDoc prose at :316, :317, :322. There is no type position using it.It is left over from the local
label/options[].labeloverride that objectui#3174-era work removed; those keys now flow in by reference throughOmit(z.input(typeof ActionParamSchema), 'type'), so nothing needs the symbol.Why nothing catches it
Two independent reasons, both measured this session:
noUnusedLocalsis off on the path that compiles this package.tsconfig.base.jsonsets"noUnusedLocals": true, butpackages/types/tsconfig.jsonextends../../tsconfig.json(the root config), which sets"noUnusedLocals": false. Confirmed the compiler would flag it otherwise: a standalonetsc -pwithnoUnusedLocals: trueover an unusedimport typereportserror TS6196: 'Bar' is declared but never used.eslint.config.jssets'@typescript-eslint/no-unused-vars': ['warn', ...], and per that config's own comment.github/workflows/lint.ymlsets no--max-warnings, so it cannot fail CI.Impact
Zero runtime and zero
.d.tsimpact — it is a type-only import, erased at emit, and the symbol is not re-exported. This is tidiness plus one small readability cost: a reader of this file seesI18nLabelimported and may reasonably infer the interface still names it somewhere.Fix shape
Delete
I18nLabel,from the import block at :27 and re-runpnpm --filter @object-ui/types type-checkandlint. Worth checking at the same time whethertsconfig.base.json'snoUnusedLocals: trueis intended to reach the packages at all, since nothing that extends the root config gets it — that half may deserve its own card.Refs #4611.