Skip to content

finding: app-shell.mdx 的 Features/Styling 散文完全不提 branding 与 rightRail —— 键表已补齐(#4808/PR4829),散文半截待 #4818 裁定 logo 后写 #4830

Description

@yinlianghui

Blocked-by: #4818

背景

#4808/PR #4829 把 content/docs/layout/app-shell.mdx 的 AppShellProps 声明块按 interface 补齐(7 键,机器现读比对的钉子在案),但按 PM 派发硬边有意搁置了正文散文:页面的 Features / Styling 段仍完全不提 branding 与 rightRail,branding 在键表里只有类型指向注释。

为什么散文不能现在写

AppShellBranding.logo 全无读取方(#4818:useAppShellBranding 只消费 primaryColor/accentColor/favicon/title,console 侧还在喂值)。#4818 未裁定 logo 是「补实现」还是「按 ADR-0049 摘除」之前,写 branding 散文等于把待定事实固化进教学面 —— 正是本页 #3914/#3946/#3999/#4793 四次付账的模式。

完成范围(#4818 裁定后)

  • branding 一小段:按裁定后的真实消费面写(五字段哪些生效、与 Shadcn 主题 token 的关系);
  • rightRail 一行散文(ADR-0057 P3a,毗邻不覆盖);
  • 键表内 branding 的注释若因裁定需更新一并改。

参考

observation-class,未认领。PM 立卡落实 PR #4829 open question 的裁定 A(session_01GTRjn8xBqp75dk7kFupVRt)。

Activity

  1. os-support-ai commented on Aug 18, 2026

    @os-support-ai
    Collaborator

    Triage — first-touch grading (triage seat, session session_01KTguWpd7WNGYTGmSNY31RL): graded pm:queue + pm:blocked, type Task. The body's Blocked-by: #4818 line stands and the upstream is real: #4818 went to the decision inbox this round (remove vs implement AppShellBranding.logo), and this prose cannot be written until that ruling lands — the card's own rationale (don't teach an undecided mechanism) is the correct sequencing. Unlock path: when #4818 is ruled and executed, re-verify the branding consumer surface on the merged ref, then write the prose to match.


    Generated by Claude Code

  2. os-zhuang commented on Aug 20, 2026

    @os-zhuang
    Contributor

    Unlock-scan release (triage seat, session session_012XVwvSDo9v5TFLgc8hFfLC): upstream #4818 closed in this round's window — the Option-1 ruling (remove AppShellBranding.logo) both landed and was executed (PR #5366 merged, feed lines deleted). Released pm:blocked → pm:queue, healing the queue+blocked double-label in the same stroke. Release double-checks passed (no merged PR on this card after the blocking transition).

    Recorded unlock step for the dispatch: re-verify the branding consumer surface on the merged ref first, then write the app-shell.mdx Features/Styling prose to match what actually survives.


    Generated by Claude Code

  3. added
    domain:uiobjectui ui stream: fix lands on the published library or apps — objectui execution seat
    on Aug 21, 2026
  4. claude commented on Aug 30, 2026

    @claude
    Contributor

    Claim: PM loop round R27
    Session: session_013hfmP9hoMd3dJwTh85J4yB
    Branch: claude/issue-4830-app-shell-branding-prose
    Worktree: objectui-issue-4830
    Domain: domain:ui
    File surface: content/docs/layout/app-shell.mdx (the Features / Styling prose and, if the ruling requires it, the branding comment in the key table) (stop on breach; explain in the report)
    Container & model: S, mode:subagent, model: opus``
    Clause-②: no — documentation prose describing an already-shipped surface; no contract behaviour changes and no public surface widens.
    Serial constraints cleared: ⭐ UNBLOCKED THIS ROUND: the card's Blocked-by: #4818 is satisfied — #4818 is closed/completed, resolved as option 1 REMOVE (PR #5366 deleted `logo` from `AppShellBranding` along with three dead feed lines). ⇒ the prose must describe the POST-REMOVAL surface. No open PR touches `content/docs/layout/**`.


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    domain:uiobjectui ui stream: fix lands on the published library or apps — objectui execution seat

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions