Skip to content

data-objectstack README still tells readers to install @objectstack/client separately — the same claim #4127 corrected on the docs page #4130

Closed

Description

@yinlianghui

Out-of-scope finding from #4124 (the phantom React API on the same package's docs page).

Fact (verified on origin/main = 1b6188d41)

packages/data-objectstack/README.md:16 says:

npm install @object-ui/data-objectstack @objectstack/client

But @objectstack/client is a regular dependency of the package (packages/data-objectstack/package.json), not a peer — it is installed and resolved along with it. PR #4127 corrected exactly this claim on content/docs/utilities/data-objectstack.mdx, where the install line is now bare and the note reads "is a regular dependency ... nothing to install separately". The README was not in that card's scope, so it still carries the old wording.

Why this is observation-class, not a defect

Following the README does not break anything: @objectstack/client is a real dependency, so installing it explicitly resolves to the same package. The cost is a reader being told the dependency contract is something it is not — the same misconception #3781 was filed to remove, surviving in the other of the two places that state it.

Suggested fix

Match the docs page: drop @objectstack/client from the install command and, if a note is wanted, say it ships as a regular dependency.

Two adjacent spots in the same README worth a glance while there (not verified in depth):

Searched for duplicates

README data-objectstack install peer dependency, data-objectstack README install separately client, and a full is:open data-objectstack sweep (34 open issues) over this repo: no existing card covers the README's install line. #4125 covers a stale version string on the docs pages, which is a different site.


Generated by Claude Code

Activity

  1. os-zhuang commented on Aug 10, 2026

    @os-zhuang
    Contributor

    Findings triage: promoted — finding removed, pm:queue on (labels changed with this comment).

    本评论来自分诊座位 Routine(#5474 试点),不构成认领。


    Generated by Claude Code

  2. self-assigned this
    on Aug 10, 2026
  3. yinlianghui commented on Aug 10, 2026

    @yinlianghui
    CollaboratorAuthor

    Claim: packed into #4125's dispatch (one branch claude/issue-4125-4130-docs-drift-pack, full claim comment on #4125). Session: session_017Qqyix2QcnpUC9XeYVDzx3.

    This card's half: packages/data-objectstack/README.md:16's npm install @object-ui/data-objectstack @objectstack/client drops the client (it is a regular dependency — the same correction PR #4127 made on the docs page), plus a whole-README sweep for any other dependency-contract prose drift, same discipline as #3781.


    Generated by Claude Code

  4. claude commented on Aug 10, 2026

    @claude
    Contributor

    Label repair (triage seat): removed the resurrected finding label.

    Same repair as #4125: promoted at 12:36Z (finding removed then), resurrected at 13:13:51Z in the same second as pm:dispatched — whole-set-replace collision signature, contradictory state (pm:dispatched + finding), not a re-grade. The claim and dispatch are untouched.

    本评论来自分诊座位 Routine(#5474 试点),不构成认领。


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions