Repository navigation
finding(plugin-grid,core): the selection bar hides a bulk action authored visible: ' ' that the same grid's rows and toolbars show; bulkEligibility.hasVisibilityGate and core partitionRowsByPredicate keep their own "is a gate declared?" test #11322
Description
Activity
Triage: first grade —
bug·priority:p2·domain:ui·area:records·pm:queue. Direction:bulkEligibilityand core'spartitionRowsByPredicateaskhasDeclaredVisibilityGate. That is the last two private tests in the objectui#3812 familyTriage seat (objectstack-wide, seat post objectstack-ai/objectstack#6015) ·
session_01AavokzJ5DndAwitDXvKy4U· 2026-10-01T04:35Z. ⛔ Not a claim, ⛔ not a dispatch.Why p2. This is the family's grade. One action shows on rows and toolbars and is hidden on the selection bar of the same grid, as measured.
Direction: both sites ask
hasDeclaredVisibilityGate. ⛔ No third test, and the core docblock's claim ("nothing asks … anywhere but here") becomes true. Pins: a whitespacevisibleshows on the selection bar as on the rows, and''is the control.
Generated by Claude Code
Claim: PM loop round 13 —
domain:uiexecution seat 2
Session:session_011p7ikEivgXefNDaE5S5Uec
Account:os-support-ai(the seat's linked user asGET /useranswers it; the card's assignee)
Branch:claude/issue-11322-bulk-bar-declared-gate
Worktree:objectui-issue-11322
Domain:domain:ui
Seat:domain:ui#2
File surface: triage's direction5924826343. Both sites ask the repo's one declared-gate definition, with no third test.packages/plugin-grid/src/bulkEligibility.ts(hasVisibilityGate, about:75) askshasDeclaredVisibilityGate. That function is@object-ui/components' re-export of core'shasDeclaredPredicate(packages/core/src/evaluator/declaredPredicate.ts).packages/core/src/evaluator/listConditional.ts(partitionRowsByPredicate, about:397) asks core'shasDeclaredPredicatedirectly, because core cannot import@object-ui/components. The core docblock that says "nothing asks … anywhere but here" is made true.- Pins at the selection bar: a whitespace
visibleand an empty-sourceCEL envelope each show on the selection bar as on the rows, with''and no gate as the controls. Ablation legs. One.changeset/11322-*.mdper released package changed (patch).
⛔ No new predicate, and no copy of
hasDeclaredPredicate's scope. ⛔ No change to the row menu or toolbar paths. The dev stops on a breach and explains it in the report.
Container & model:S,mode:subagent,model: opus(TIER_DEFAULT;dispatch-gateshas no objectui derivation, so there is no path-derived mandate)
Clause-②: no
Why no: an internal predicate swap at two call sites. No published type, export or accept set changes; a whitespace gate now shows on the selection bar as it already does on rows and toolbars.
Thread-read: 5924826343
Serial constraints cleared: read 2026-10-01T06:02Z at objectuiorigin/main5262f7dd3.- None of the 16 open PRs touches
bulkEligibility.ts,listConditional.tsorBulkActionBar. - In-flight
domain:uiclaims: seat 1's objectui#11293 (plugin-kanban / plugin-calendar / the react navigation hook), layout,types: a nav entry's inline locale-maplabel(specI18nLabel) is honoured only halfway:objectui validaterefuses it, the renderer shows itsenfloor to every viewer, and three nav resolver props are inert after objectui#11201 #11299 (nav label: typesapp.zod.ts, layout, app-shell), Spec Main Shape Gate red: objectstackd830d71fgives a retired key a branded[REMOVED] Key retiredtype, and four objectui type pins plusLayoutRenderer.tsxdo not compile against objectstack main #11330 (types tests, runner) and fix(app-shell): a Studio pillar whose draft load is cancelled never clears its spinner — a report leaf opened while the first leaf loads leaves the Interfaces canvas on "Loading…" #11331 (app-shell Studio); this seat's objectui#10859 batch 6 (PR objectui#11337: typesobjectql.zod.ts, plugin-gantt). All are disjoint from this surface. os-verify-lock.sh --status: free, queue empty.
Generated by Claude Code
os-dev-report
{ "issue": 11322, "status": "done", "branch": "claude/issue-11322-bulk-bar-declared-gate", "pr": "https://github.com/objectstack-ai/objectui/pull/11350", "session": "session_011p7ikEivgXefNDaE5S5Uec — subagent of the PM session, so the parent id; identity is the branch named in claim 5925703783", "premise_still_valid": true, "summary": "Both selection-bar sites now ask the repo's one declared-gate definition. plugin-grid `hasVisibilityGate` returns `hasDeclaredVisibilityGate(def?.visible)` from the `@object-ui/components` barrel. Core `partitionRowsByPredicate` opens with `if (!hasDeclaredPredicate(pred))`. Neither keeps its old `!= null && !== ''` scope, and there is no new predicate and no copy of the scope. Both docblocks were made true: `declaredPredicate.ts` names the two new consumers, scopes 'anywhere but here' to the keys it serves, names the field-rule `*When` row rules that stay outside, and states per AGENTS.md commandment 9 that nothing re-derives that sentence. The `partitionRowsByPredicate` docblock now says what the code does. Premise and fork clause re-measured true at BASE 5262f7dd3 and pinned. PM mechanism assumption 2 was FALSIFIED: `partitionRowsByPredicate` has a second non-test caller, plugin-list `ListView` `bulkDeleteEligibility`. plugin-grid `ObjectGrid` also reaches it for the built-in bulk Delete, through `partitionBulkRows` with `userActions.delete.visibleWhen`. Because the definition's whole scope comes with it, two consequences go beyond the card's table, and both are in open_questions. (1) An `ast`-only bulk `visible` used to be hidden on the bar and fail closed with a warning. It is now no gate there, silently, as on rows and toolbars. That made the objectui#10946 pin and the `@object-ui/types` `BulkActionDef.visible` docblock false, so both were restated and a third changeset was added. (2) A blank built-in Delete `visibleWhen` used to exclude every record on both selection bars and now admits every record, while the built-in row item still hides. The installed spec 17.5.0 refuses all of these shapes at authoring (measured).", "tests": "HEAD 88ed87044 (the final commit; every gate below ran on it). (1) `pnpm exec vitest run packages/plugin-grid/src packages/core/src/evaluator packages/plugin-list/src/__tests__/ListView.bulkDeleteVisibleWhen.test.tsx --reporter=verbose`, under os-verify-lock: 'Test Files 199 passed (199) / Tests 2161 passed | 27 skipped (2188)', VERDICT command-exit 0. The first run at b90129359 was '1 failed | 198 passed'; the failing pin was objectui#10946's `ast`-only row, which was then restated. (2) `pnpm exec vitest run packages/types/ scripts/__tests__/unit-registry-absence-collision.test.ts`: '309 passed (309) / 7819 passed', exit 0. (3) `pnpm exec vitest run scripts/__tests__/`: '177 passed | 2 skipped (179) / 5371 passed | 2 skipped', exit 0. (4) After `turbo run build --filter='@object-ui/plugin-grid^...' --concurrency=2` ('13 successful'), `pnpm --filter @object-ui/core|types|plugin-grid type-check` each exited 0. `tsc -p tsconfig.test.json --listFilesOnly` counts the changed test files in: core 1, plugin-grid 4. (5) eslint on the 9 changed TS files with --format json: 9 files, 0 errors, 40 warnings, all pre-existing no-explicit-any; no added line uses any. Population: eslint.config.js `**/*.{ts,tsx}`. No parserOptions.project or projectService, and no custom rule reads the disk, so untouched files' verdicts are invariant. (6) check-changeset-presence ('9 source file(s) of 3 released package(s) changed ... 3 changeset(s)'), check-control-bytes OK, markdown-test-inputs --audit ('all adjudicated'), check:new-line-citations ('0 new citation(s)'): all exit 0. ABLATION, fix committed first. Each mutation went through objectstack `scripts/ablation-replace.mjs`: anchor x1 to x0, blob moved. Each restore was proven by blob == HEAD and an empty `git diff HEAD`. Tests resolve `@object-ui/*` to src through the vitest alias, so there was no dist leg. Each leg ran the same 5 files, 69 tests. Leg plugin-grid site only: 4 failed / 65 passed (3 blank `hasVisibilityGate` rows plus the parity row). Leg core site only: 7 / 62 (3 core by-reference rows, 3 `partitionBulkRows` by-reference rows, the restated `ast`-only row). Both sites: 14 / 55 (the union plus the 3 blank rows on the real `BulkActionBar`). In every leg, the controls (`''`, no key, `false`), the premise row, the report-once rows and `RowActionMenu.test.tsx` stayed green. Observed direction: either site alone shows the button, and the bar pins go red only with both sites restored. The report-once rows stay green under the old test too, because its fault warning carries the `[blank]` reason; they guard D4 against a silent private trim. CI: not awaited, per the role file. `Spec Main Shape Gate` is red on every head (objectui#11330) and is not this PR's.", "mcp_calls": "0 — no MCP GitHub tool was called", "api_writes": "3 REST writes, each relayed as one POST /repos/objectstack-ai/objectstack/dispatches executed by fleet-write as objectstack-fleet[bot]: (1) pr_create — POST /repos/objectstack-ai/objectui/pulls (draft, #11350); (2) label-write assign — POST /repos/objectstack-ai/objectui/issues/11350/assignees (os-support-ai, read back MATCHES); (3) this os-dev-report — POST /repos/objectstack-ai/objectui/issues/11322/comments. Plus 3 git pushes of the branch (empty probe, b90129359, 88ed87044), which are not REST writes. No label written, nothing PATCHed.", "open_questions": [ { "question": "A bulk def's `visible` that is an `ast`-only envelope (or any non-predicate value). Following the direction ('no copy of its scope'), the selection bar now reads it as no gate: the button shows and every selected record qualifies, silently. Before, it was hidden and failed closed with a warning, and that was pinned by objectui#10946 and the `BulkActionDef.visible` docblock, both restated here. Rows and toolbars already behaved the new way. Accept this, or rule on the definition itself?", "options": [ "A — accept as landed in PR #11350. Cost: a bulk run admits records that an unevaluable AST predicate may have been written to exclude, and the family definition stays silent on it (an ADR-0137 D4 'never a silent true' gap that already existed on rows and toolbars).", "B — follow-up card: make `hasDeclaredPredicate` diagnose an envelope with no evaluable `source` (report once like `[blank]`), or treat it as declared and faulting so that it fails closed everywhere. Cost: it moves every family consumer, and it needs a ruling on the definition's scope; the fork clause forbade doing it here.", "C — hold #11350 and keep the bar's private scope for this shape. Cost: it is the copy-of-scope or third test that the direction forbids, and the bar would disagree with rows and toolbars again." ], "recommendation": "A, with B only if someone names a producer. Business need: the installed spec 17.5.0 `BulkActionDefSchema` refuses an `ast`-only `visible` at authoring (measured), and no producer was found, so reach is stored or hand-written JSON only. Long-term: one definition with no per-surface carve-out is the family's north star. AI error: authoring-time refusal is the strong lever and it is already in place; consumer-side fail-closed for one surface is the tolerance that hides the producer. Startup focus: no new card or gate without pull." }, { "question": "The built-in Delete's `userActions.delete.visibleWhen`, when blank (whitespace or a blank envelope), on both selection bars. It flows through `partitionRowsByPredicate`: grid via `partitionBulkRows`, list via `ListView` `bulkDeleteEligibility`. It used to exclude every selected record (the grid's refusal dialog, the list's skipped notice). It now admits every record, and the grid hands them straight to the host's `onBulkDelete`. The built-in Delete ROW item (`isBuiltinRowActionVisible`, `!= null`) still hides on a blank, so row and bar now disagree on all three blank shapes. On main they disagreed only on `''`. This is the card's own 'Also noted' field-rule item. Accept, or rule first?", "options": [ "A — accept as landed. Then decide the field-rule family closure separately: whether the built-in Edit/Delete row rule asks the one definition too, so that rows also show on a blank and agree with the bars. Cost: until then, a destructive bulk action runs over records whose row menu hides Delete, for stored blank `visibleWhen` metadata. Mitigations: `''` already behaved this way, and the server is the authority (ADR-0124).", "B — hold #11350 until the built-in Delete keeps field-rule semantics on the bulk path (blank means excluded). Cost: it needs either a second blank test at the built-in Delete callers (the third test the direction forbids), or `partitionRowsByPredicate` dropping its declaredness question so that each caller decides (which re-rules Zone 1).", "C — align the row item in this PR. Cost: it breaks the claim ('no change to the row menu or toolbar paths'), and the card places that key outside this family." ], "recommendation": "A plus a ruled follow-up rather than a drop. Business need: `@objectstack/spec` 17.5.0 `ObjectSchema` refuses a whitespace `userActions.delete.visibleWhen` at authoring (measured), so only stored or hand-written metadata reaches it, and `''` already admitted everything on main. Long-term: one fold with one definition. The real cost is the destructive direction, which is why the row rule should be decided, not left. AI error: the contract refusal at authoring is the lever. Startup focus: no new gate; one family decision covers it." } ], "out_of_scope_findings": [ "carrier: PM seat via open_questions[1] · noted, not filed — the built-in Edit/Delete `visibleWhen` row rule (`isBuiltinRowActionVisible`, `!= null`, then fail closed) vs the bulk fold (blank means no gate): row and bar disagree on blank. Pre-existing for `''` and widened by this PR to whitespace and blank envelopes. No class: reach fails, because the spec refuses whitespace `visibleWhen` at authoring (measured) and no producer was named. It is the card's own 'Also noted' item, in the field-rule `*When` family. Dedupe words: isBuiltinRowActionVisible blank · built-in delete visibleWhen bulk · bulkDeleteEligibility blank · field-rule row rule declared", "carrier: PM seat via open_questions[0] · noted, not filed — `hasDeclaredPredicate` answers an `ast`-only envelope as no gate WITHOUT a report, while ADR-0137 D4 says a faulting gate predicate is 'diagnosed, never a silent true'. No class: reach fails, because the installed spec refuses `ast`-only gates at authoring (measured) and no producer was named. Dedupe words: hasDeclaredPredicate ast-only silent · declared gate ast envelope · D4 silent true", "carrier: none · noted, not filed — `action-member-visible-gate.test.tsx`'s docblock still describes `hasDeclaredVisibilityGate` as `!= null && !== ''`, stale since objectui#3850 (test comment drift; PR Acceptance notes)", "carrier: none · noted, not filed — the 'installed spec admits it' sentences in the `BulkActionDef.visible` docblock and the `specExpressionWire-10946.test.tsx` docblock are stale: installed spec 17.5.0 `BulkActionDefSchema` refuses an `ast`-only `visible` (measured). Left untouched as prose drift outside what this change made false (PR Acceptance notes)" ], "gates": [ { "gate": "vitest plugin-grid/src + core/src/evaluator + plugin-list ListView.bulkDeleteVisibleWhen (verbose)", "head": "88ed87044", "exit": 0, "verdict": "Test Files 199 passed (199); Tests 2161 passed | 27 skipped (2188)" }, { "gate": "vitest packages/types/ + scripts/__tests__/unit-registry-absence-collision.test.ts", "head": "88ed87044", "exit": 0, "verdict": "Test Files 309 passed (309); Tests 7819 passed (7819)" }, { "gate": "vitest scripts/__tests__/ (whole root suite; changesets are markdown)", "head": "88ed87044", "exit": 0, "verdict": "Test Files 177 passed | 2 skipped (179); Tests 5371 passed | 2 skipped (5373)" }, { "gate": "turbo build @object-ui/plugin-grid^... (closure for type-check)", "head": "88ed87044", "exit": 0, "verdict": "Tasks: 13 successful, 13 total" }, { "gate": "pnpm --filter @object-ui/core type-check", "head": "88ed87044", "exit": 0, "verdict": "tsc --noEmit && tsc -p tsconfig.test.json, exit 0" }, { "gate": "pnpm --filter @object-ui/types type-check", "head": "88ed87044", "exit": 0, "verdict": "exit 0" }, { "gate": "pnpm --filter @object-ui/plugin-grid type-check", "head": "88ed87044", "exit": 0, "verdict": "exit 0" }, { "gate": "pnpm exec eslint (9 changed TS files, --format json)", "head": "88ed87044", "exit": 0, "verdict": "9 files, 0 errors, 40 pre-existing no-explicit-any warnings" }, { "gate": "node scripts/check-changeset-presence.mjs", "head": "88ed87044", "exit": 0, "verdict": "9 source file(s) of 3 released package(s) changed, and this change declares 3 changeset(s)" }, { "gate": "node scripts/check-control-bytes.mjs", "head": "88ed87044", "exit": 0, "verdict": "OK (scanned 9809 tracked text file(s))" }, { "gate": "node scripts/markdown-test-inputs.mjs --audit", "head": "88ed87044", "exit": 0, "verdict": "108 candidate test files, all adjudicated; 80 declared entries, all present" }, { "gate": "pnpm check:new-line-citations", "head": "88ed87044", "exit": 0, "verdict": "VERDICT new-cross-file-line-citations: 0 new citation(s), enforcement report-only" }, { "gate": "node scripts/check-governed-queue-guard.mjs --test (12 paths)", "head": "88ed87044", "exit": 0, "verdict": "NOT GOVERNED" }, { "gate": "ablation leg plugin-grid site", "head": "88ed87044", "exit": 1, "verdict": "4 failed / 65 passed — expected red; restored blob == HEAD, git diff HEAD empty" }, { "gate": "ablation leg core site", "head": "88ed87044", "exit": 1, "verdict": "7 failed / 62 passed — expected red; restored" }, { "gate": "ablation leg both sites", "head": "88ed87044", "exit": 1, "verdict": "14 failed / 55 passed — expected red; restored" }, { "gate": "CI on PR #11350", "head": "88ed87044", "exit": null, "verdict": "NOT MEASURED: CI, reason: not awaited per the role file; Spec Main Shape Gate red on every head (objectui#11330), not this PR" } ], "line_budget": "n/a — no skills/** file and no ledger or ratchet file touched", "files_changed": [ ".changeset/11322-bulk-bar-blank-visible-shown.md", ".changeset/11322-bulk-def-visible-docblock.md", ".changeset/11322-partition-rows-declared-gate.md", "packages/core/src/evaluator/__tests__/partitionBlankGate-11322.test.ts", "packages/core/src/evaluator/declaredPredicate.ts", "packages/core/src/evaluator/listConditional.ts", "packages/plugin-grid/src/__tests__/bulk-action-visible.test.tsx", "packages/plugin-grid/src/__tests__/bulkEligibility.test.ts", "packages/plugin-grid/src/__tests__/specExpressionWire-10946.test.tsx", "packages/plugin-grid/src/bulkEligibility.ts", "packages/plugin-grid/src/components/__tests__/RowActionMenu.test.tsx", "packages/types/src/objectql.ts" ], "deviations": [ "File surface widened beyond the claim. `packages/types/src/objectql.ts` (`BulkActionDef.visible` docblock only), `specExpressionWire-10946.test.tsx` (pin and docblock restated) and a third changeset (`@object-ui/types` patch). Reason: the role file says published text this change makes false must be fixed, and the direction's 'no copy of its scope' made the `ast`-only answer move. The claim's file surface needs the seat's same-round supplement.", "PM mechanism assumption 2 falsified. `partitionRowsByPredicate`'s non-test callers include plugin-list `ListView` (`bulkDeleteEligibility`), and `ObjectGrid`'s built-in bulk Delete reaches it through `partitionBulkRows`. Consequences are in open_questions.", "Ablation direction differs from the order's wording ('restore the old test at each site, and exactly the blank-shape rows go red'). Per site, only that site's unit rows go red. The bar's blank rows go red only with both sites restored, because either site alone shows the button.", "Pins add the empty-source envelope `{ dialect: 'cel', source: '' }` beside the card's two shapes. It is also a blank shape and was also hidden on main (measured in the both-sites leg).", "Attribution. The harness reminder asked for a model-named Co-Authored-By trailer and a different PR footer. Commits carry AGENTS.md's model-free pair (`Claude-Session` plus `Co-authored-by: Claude`), and the PR ends with the order's session-URL footer, per the precedence rule." ] }
Generated by Claude Code
Question for triage: the direction moves a field-rule key, built-in Delete's bulk
visibleWhen, that this card puts outside the familydomain:uiseat 2,session_011p7ikEivgXefNDaE5S5Uec. ⛔ Not a ruling.pm:retriageis added besidepm:dispatched. PR objectui#11350 (88ed87044, draft) stays draft and is not reviewed or landed until this is answered.What the dev measured (report
5926214831). The PM's mechanism assumption thatpartitionRowsByPredicate's only non-test caller is the bulk-action fold is false. Two callers feed it a field-rule key:- plugin-list
ListViewbulkDeleteEligibility, withuserActions.delete.visibleWhen; - plugin-grid
ObjectGrid's built-in bulk Delete, throughpartitionBulkRows, with the same key.
What the direction does to that key (
5924826343: core'spartitionRowsByPredicateasks the one declared-gate definition):blank built-in Delete visibleWhenbulk Delete on mainbulk Delete with PR #11350 built-in Delete row item (unchanged) ''every record admitted every record admitted hidden whitespace, blank envelope every record excluded (refusal dialog / skipped notice) every record admitted; the grid hands them to the host's onBulkDeletehidden So on these shapes the bulk bar and the row item now disagree on all three blank shapes, not only on
''. The change runs in the destructive direction.Why the seat does not answer it.
- This card's body says: "the built-in Edit / Delete
visibleWhenkeeps!= null… Both are ADR-0137 field-rule keys outside this family." - The direction, applied literally, moves one of those keys into the action family's definition. That is a product-semantics fork, not a bookkeeping call.
- The installed spec 17.5.0 refuses whitespace
visibleWhenat authoring (dev measurement), so the reach is stored or hand-written metadata only.
Options (the dev's analysis,
open_questions[1]):- A. Accept PR fix(plugin-grid,core): the selection bar asks the one declared-gate definition, so a whitespace or empty-source visible gate shows there as on rows and toolbars (objectui#11322) #11350 as built. The field-rule row rule (
isBuiltinRowActionVisible) is decided separately, as a family closure. Cost: until then, a bulk Delete runs over records whose row menu hides Delete, for stored blank metadata. Mitigations:''already behaved this way, and the server is the authority (ADR-0124). The dev recommends A plus a ruled follow-up. - B. The field-rule callers keep fail-closed on blank, and only the action fold asks the declared definition. Cost: a second blank test at the built-in Delete callers, which the direction forbids, or a re-rule of where the declared question lives.
- C. Align the built-in row item in this PR. Cost: outside the claim, and outside the family by this card's own text.
Also for the ruling (
open_questions[0], the dev recommends accepting): anast-only bulkvisiblewas hidden on the bar and failed closed with a warning. It now reads as no gate, silently, as on rows and toolbars. The objectui#10946 pin and theBulkActionDef.visibledocblock were restated.hasDeclaredPredicateanswers anast-only envelope with no report, which sits beside ADR-0137 D4's "never a silent true".File-surface supplement to claim
5925703783(the dev's declared deviation):packages/types/src/objectql.ts: theBulkActionDef.visibledocblock only, a different hunk from PR objectui#11337's.packages/plugin-grid/src/__tests__/specExpressionWire-10946.test.tsx.- A third changeset,
@object-ui/typespatch.
domain:uiseat 2 · retriage question · 2026-10-01T06:49Z
Generated by Claude Code
- plugin-list
Triage:
pm:retriageanswer. Not A. Core's shared partitioner is not changed in this PR. The action family's declared question is asked at plugin-grid's site only; built-in Delete'svisibleWhenkeepsmain's answer.pm:retriageoffTriage seat (objectstack-wide, seat post objectstack-ai/objectstack#6015) ·
session_01AavokzJ5DndAwitDXvKy4U· 2026-10-01T07:01Z. ⛔ Not a claim, ⛔ not a dispatch.This answers
5926251271.This seat's direction was wrong on one site, and the error is triage's.
5924826343sent core'spartitionRowsByPredicateto the declared-gate definition on the premise that its only caller is the bulk-action fold. The dev falsified that: two callers feed it built-in Delete'svisibleWhen, an ADR-0137 field-rule key that this card's body puts outside the family. That half of the direction is withdrawn.The ruling (triage's; overturnable by the maintainer):
- No destructive widening in this PR. A blank built-in Delete
visibleWhen(whitespace, or an empty envelope) stays excluded on both bulk bars, as onmain. PR objectui#11350 as built would admit every record there, while the row item still hides. That is the destructive direction, so A is not taken. - Where the declared question lives: at the action family's own site. plugin-grid's
hasVisibilityGateaskshasDeclaredVisibilityGate, as built, and that alone delivers the card's measured table: a whitespace bulkvisibleshows on the selection bar as on the rows.- Core's
partitionRowsByPredicatereturns tomain's opening in this PR. It is a shared partitioner, and its blank test is the field-rule callers' answer. - Its docblock says which callers it serves and that the action family decides "declared?" before calling it. ⛔ No second blank test is written anywhere.
- Core's
- The
ast-only bulkvisible(open_questions[0]): accepted as built. The bar now answers as the rows and toolbars already do, from one definition. The objectui#10946 pin and theBulkActionDef.visibledocblock restatements stand.- Whether
hasDeclaredPredicate's silent answer for anast-only envelope meets ADR-0137 D4 ("never a silent true") is a question for that definition on all three surfaces at once. - It goes in the PR's Acceptance notes with a
carrier:line. If authoring admits anast-only envelope (measure it), the seat files it as a ① card.
- Whether
- The field-rule family (built-in Delete's
'': bulk admits, the row item hides, already onmain) is not this card's. The installed spec refuses these shapes at authoring, so no producer reaches them. It goes in the Acceptance notes,carrier: none, under the filing gate.
State:
pm:retriageoff.pm:dispatchedand the claim stand. PR objectui#11350 reverts its core hunk and that hunk's pins, then goes to review. The file-surface supplement (5926251271) is accepted for theast-only restatements.
Generated by Claude Code
- No destructive widening in this PR. A blank built-in Delete
os-dev-report
{ "issue": 11322, "status": "done", "branch": "claude/issue-11322-bulk-bar-declared-gate", "pr": "https://github.com/objectstack-ai/objectui/pull/11350", "session": "session_011p7ikEivgXefNDaE5S5Uec — subagent of the PM session, so the parent id; identity is the branch named in claim 5925703783", "premise_still_valid": true, "summary": "Revision per triage 5926391467 ('Not A'), as two new commits on top (b889377c3, 5661606d6); no rebase, amend or force-push. (1) Core's `partitionRowsByPredicate` is back at main's opening (`pred == null || pred === ''`), and core's code is byte-identical to main; the core diff is comments only. Its docblock names its callers (the bulk-action fold via `partitionBulkRows`, and the built-in Delete's `visibleWhen` from `ObjectGrid` and `ListView` `bulkDeleteEligibility`), says the action family decides 'declared?' before calling it, and its 'absent' bullet now says `null`/`undefined`/`''` instead of 'blank string'. `declaredPredicate.ts` names only `hasVisibilityGate` as the new consumer. (2) plugin-grid's `hasVisibilityGate` still asks `hasDeclaredVisibilityGate`. Point 2 was re-measured with core at main and plugin-grid as built: the button showed, but `partitionBulkRows` still handed the blank to the fold and every record was excluded, so the run would refuse what the bar offers (3 by-reference rows and the accepted `ast`-only row were red). So `partitionBulkRows` now asks `hasVisibilityGate` first and passes an undeclared gate as `undefined`. That is the 'action family decides before calling it' half of the ruling, done in plugin-grid without touching core. (3) Because the grid's built-in Delete went through `partitionBulkRows`, `ObjectGrid` now hands `userActions.delete.visibleWhen` to core's fold directly, as `ListView` does, with the same options. A blank one stays excluded on both bars, as on main (point 1). (4) The core-hunk pin file is removed. New pins through the real `ObjectGrid` and `ListView` show that a whitespace or blank-envelope built-in Delete `visibleWhen` excludes every record, with the existing no-gate cases as controls. (5) Changesets: plugin-grid rewritten; core rewritten as docblock-only (renamed `11322-core-docblocks-name-callers.md`); types unchanged; the pending 10946 entry got an append-only dated note, with frontmatter and sentences byte-identical. (6) Acceptance notes carry (a) and (b) as triage named them. Measured for (a): authoring DOES admit an `ast`-only envelope through one door. objectui's own `safeValidateSchema` accepts it on an `object-grid` node's `bulkActionDefs[].visible`, because that member is unmirrored on the zod face (ledgered KnownDrift; `42` and `'nope'` pass too). The spec 17.5.0 refuses it on all three slots measured. The corrected PR body is at scratchpad/a11322/pr-body.md for the seat to apply; I did not PATCH it.", "tests": "HEAD 5661606d6 (final; every gate below ran on it). (1) `pnpm exec vitest run packages/plugin-grid/src packages/core/src/evaluator packages/plugin-list/src/__tests__/ListView.bulkDeleteVisibleWhen.test.tsx --reporter=verbose`, under os-verify-lock: 'Test Files 198 passed (198) / Tests 2153 passed | 27 skipped (2180)', VERDICT command-exit 0. The same set at b889377c3 was also 198 / 2153 passed. (2) `pnpm exec vitest run scripts/__tests__/ packages/types/`: 'Test Files 485 passed | 2 skipped (487) / Tests 13175 passed | 2 skipped (13177)', exit 0. (3) After `turbo run build --filter='@object-ui/plugin-grid^...' --concurrency=2` ('13 successful, 13 total', 5 cached), `pnpm --filter @object-ui/core|types|plugin-grid|plugin-list type-check` each exited 0. `--listFilesOnly` puts the changed test files in the programs: plugin-grid 5, plugin-list 1. (4) eslint on the 11 changed TS files: 0 errors; per-file warning counts are equal to `main`'s (BASE blob linted by stdin) for all 11, e.g. ObjectGrid.tsx 208 = 208, so no warning was added. No type-aware linting and no disk-reading custom rule, so untouched files' verdicts are invariant. (5) check-changeset-presence ('11 source file(s) of 4 released package(s) changed, and this change declares 3 changeset(s)'), check-control-bytes OK, check:new-line-citations ('0 new citation(s)'), markdown-test-inputs --audit ('all adjudicated'): exit 0. check-changeset-overwrite: report-only, `M .changeset/10946-…` with 'declared at base: @object-ui/types: minor / declares now: @object-ui/types: minor', which is case 2 (intentional correction). Governed guard: NOT GOVERNED. ABLATION (fix committed; objectstack `scripts/ablation-replace.mjs`, anchor x1 to x0, blob moved; every restore proven by blob == HEAD and an empty `git diff HEAD`). Each leg ran 6 files, 69 tests: baseline 0 failed / 69 passed. Leg `hasVisibilityGate` restored to `!= null && !== ''`: 11 / 58 (the 3 blank rows on the real BulkActionBar, 3 hasVisibilityGate rows, 3 partitionBulkRows by-reference rows, the parity row, the ast-only row). This is the point-2 verification: with core at main, the plugin-grid site alone decides the bar. Leg `partitionBulkRows` passing `def.visible` unasked: 4 / 65 (3 by-reference rows and the ast-only row; bar rows green): the run path needs the door. Leg `ObjectGrid` built-in Delete routed back through `partitionBulkRows`: 2 / 67 (both grid blank-visibleWhen rows: 'Unable to find ... bulk-skipped-notice', so the whole selection went through): the reroute is what keeps point 1. Controls (`''`, no key, `false`, no built-in gate) and RowActionMenu.test.tsx stayed green in every leg. CI: not awaited, per the role file.", "mcp_calls": "0 — no MCP GitHub tool was called", "api_writes": "This round: 1 REST write, this os-dev-report comment, POST /repos/objectstack-ai/objectui/issues/11322/comments, relayed as one POST /repos/objectstack-ai/objectstack/dispatches by fleet-write (objectstack-fleet[bot]). Plus 2 git pushes (b889377c3, 5661606d6; fast-forward, plain push). The PR body was NOT patched: the corrected body is in scratchpad/a11322/pr-body.md for the seat. Whole run: 4 REST writes (pr_create, PR assignee, two os-dev-report comments).", "open_questions": [], "out_of_scope_findings": [ "class: c · reach: objectui's own `safeValidateSchema` (the validator `os validate` and `os check` run, per the 10946 changeset) accepts an `object-grid` node whose `bulkActionDefs[].visible` is `{ dialect: 'cel', ast: {…} }`, measured in-process. The runtime then reads that envelope as no gate, silently (`hasDeclaredPredicate` answers 'not declared' with no report, against ADR-0137 D4 'never a silent true'), so the bar shows the action and it runs over every record. The cause on the authoring side is that `ObjectGridSchema`'s zod face does not mirror `bulkActionDefs` at all: it is ledgered as KnownDrift in zod-mirror-parity.test.ts, and `visible: 42` and `bulkActionDefs: 'nope'` pass too. Controls: spec 17.5.0 refuses the envelope on `ActionSchema.visible`, `BulkActionDefSchema.visible` and `ObjectSchema` `userActions.delete.visibleWhen`; objectui's validator refuses it on `action:button` `visible` and `list-view` `bulkActionDefs[].visible`. objectstack main's spec was NOT measured (no built dist in the shared checkout). carrier: PM seat (triage 5926391467 point 3: file a ① card if authoring admits it). Dedupe words: hasDeclaredPredicate ast-only silent · object-grid bulkActionDefs unmirrored · bulkActionDefs KnownDrift · ast envelope declared gate D4", "carrier: none · noted, not filed (triage 5926391467 point 4) — the field-rule family: for the built-in Delete with `visibleWhen: ''`, the bulk bars admit every record while the row item (`isBuiltinRowActionVisible`, `!= null`) hides; already so on main. The spec refuses these shapes at authoring, so no producer reaches them.", "carrier: none · noted, not filed — stale prose untouched by this PR. `action-member-visible-gate.test.tsx`'s docblock describes `hasDeclaredVisibilityGate` as `!= null && !== ''` (stale since objectui#3850). The 'installed spec admits it' sentences in the `BulkActionDef.visible` docblock and the `specExpressionWire-10946.test.tsx` docblock are stale: spec 17.5.0 `BulkActionDefSchema` refuses an ast-only `visible`." ], "objectgrid_why": "Yes, the final diff touches `packages/plugin-grid/src/ObjectGrid.tsx`, at one call site plus its comment and one import name. With core at main's opening (point 1), the action family has to decide 'declared?' before the fold (point 2's 'reaches partitionBulkRows only when declared'), so `partitionBulkRows` now asks `hasVisibilityGate` first. The grid's built-in Delete used that same door with `{ name: 'delete', visible: userActions.delete.visibleWhen }`. Left there, a blank built-in Delete `visibleWhen` would be read as no gate and every selected record handed to `onBulkDelete`: the destructive widening point 1 forbids. So `ObjectGrid` hands that field-rule key to core's `partitionRowsByPredicate` directly, as plugin-list's `ListView` already does, with the options `partitionBulkRows` passed (`warnOnError` true, label `delete`). Its answer is main's. The ablation leg that routes it back through `partitionBulkRows` turns both grid blank-`visibleWhen` pins red (2 / 67). No open PR touches the file.", "pending_changesets_judged": { "date_noted": [ "10946-expression-wire-slots-by-reference — append-only dated note; frontmatter and existing sentences byte-identical; check-changeset-overwrite case 2 (declaration unchanged)" ], "true_as_is_bot_named": [ "4730-retire-dead-locale-key-batch (ObjectGrid i18n keys)", "5903-objectgantt-declared-keys (objectql.ts gantt keys)", "6152-object-form-unmirrored-members (objectql.ts form)", "6505-predicate-valued-gate-rules (read in full; validator delegation to hasDeclaredPredicate, code unchanged)", "6597-retire-fieldmeta-referenceto (ObjectGrid applyRelationalMeta)", "7322-object-kanban-group-by-limit", "7363-objectql-union-arms", "7632-shared-record-source-config", "7762-object-grid-export-options-bare-array-refusal (ObjectGrid exportOptions)", "7804-objectql-handler-key-arms", "7804-tree-view-handler-slot", "7963-alert-dialog-footer-keys-retired", "8069-field-rule-fault-direction-declared (read in full; field-rule blank report, code unchanged)", "8767-object-grid-refuses-string-sort", "8801-object-kanban-allow-collapse-retired", "8885-object-chart-drilldown-title-compareto", "8913-object-kanban-columns-declared", "8990-object-kanban-groupby-optional", "9092-inline-locale-declared-face", "9309-object-gallery-filter-destination-typed", "9511-record-id-is-a-string", "9549-tree-filter-declared", "9550-object-tree-root-barrel", "9606-object-kanban-card-title", "9628-kanban-column-collapsed-honoured", "9722-bulk-executor-datasource-face (ObjectGrid RecordDetailPanel / BulkActionDialog casts)", "9853-grid-non-positive-page-size (ObjectGrid pageSize)" ], "true_as_is_found_by_symbol": [ "4420-bulk-delete-visiblewhen (read in full; built-in Delete stays per-record fail-closed with main's answer)", "row-predicate-phase2-record-only-5741 (read in full; a retired spelling is declared and still faults to every row excluded)", "8730-bulk-action-defs-unusable-member (matching sentences only; unrelated subject)", "9572-declared-actions-bar-capability-mirror (matching sentences only; unrelated subject)" ], "method": "The bot's 28 entries (comment 5926180748, rerun at 07:30Z), each read at the paragraph it quotes, with 6505 and 8069 read in full. Plus a symbol grep over all pending `.changeset/*.md` for partitionBulkRows, partitionRowsByPredicate, hasVisibilityGate, bulkEligibility, bulkDeleteEligibility, BulkActionBar and 'selection bar'." }, "gates": [ { "gate": "vitest plugin-grid/src + core/src/evaluator + plugin-list ListView.bulkDeleteVisibleWhen (verbose)", "head": "5661606d6", "exit": 0, "verdict": "Test Files 198 passed (198); Tests 2153 passed | 27 skipped (2180)" }, { "gate": "vitest scripts/__tests__/ + packages/types/", "head": "5661606d6", "exit": 0, "verdict": "Test Files 485 passed | 2 skipped (487); Tests 13175 passed | 2 skipped (13177)" }, { "gate": "turbo build @object-ui/plugin-grid^... (type-check closure)", "head": "5661606d6", "exit": 0, "verdict": "Tasks: 13 successful, 13 total" }, { "gate": "pnpm --filter @object-ui/core type-check", "head": "5661606d6", "exit": 0, "verdict": "exit 0" }, { "gate": "pnpm --filter @object-ui/types type-check", "head": "5661606d6", "exit": 0, "verdict": "exit 0" }, { "gate": "pnpm --filter @object-ui/plugin-grid type-check", "head": "5661606d6", "exit": 0, "verdict": "exit 0" }, { "gate": "pnpm --filter @object-ui/plugin-list type-check", "head": "5661606d6", "exit": 0, "verdict": "exit 0" }, { "gate": "pnpm exec eslint (11 changed TS files, --format json; per-file counts vs BASE)", "head": "5661606d6", "exit": 0, "verdict": "0 errors; warnings equal to main for every file (no new warning)" }, { "gate": "node scripts/check-changeset-presence.mjs", "head": "5661606d6", "exit": 0, "verdict": "11 source file(s) of 4 released package(s) changed, and this change declares 3 changeset(s)" }, { "gate": "node scripts/check-control-bytes.mjs", "head": "5661606d6", "exit": 0, "verdict": "OK (scanned 9808 tracked text file(s))" }, { "gate": "pnpm check:new-line-citations", "head": "5661606d6", "exit": 0, "verdict": "VERDICT new-cross-file-line-citations: 0 new citation(s), enforcement report-only" }, { "gate": "node scripts/markdown-test-inputs.mjs --audit", "head": "5661606d6", "exit": 0, "verdict": "108 candidate test files, all adjudicated; 80 declared entries, all present" }, { "gate": "node scripts/check-changeset-overwrite.mjs", "head": "5661606d6", "exit": 0, "verdict": "report-only: M 10946 entry, declaration unchanged (case 2)" }, { "gate": "node scripts/check-governed-queue-guard.mjs --test (15 paths)", "head": "5661606d6", "exit": 0, "verdict": "NOT GOVERNED" }, { "gate": "ablation baseline (6 files)", "head": "5661606d6", "exit": 0, "verdict": "69 passed" }, { "gate": "ablation leg hasVisibilityGate restored", "head": "5661606d6", "exit": 1, "verdict": "11 failed / 58 passed — expected red incl. the 3 bar rows; restored" }, { "gate": "ablation leg partitionBulkRows unasked", "head": "5661606d6", "exit": 1, "verdict": "4 failed / 65 passed — expected red; bar rows green; restored" }, { "gate": "ablation leg ObjectGrid built-in Delete via partitionBulkRows", "head": "5661606d6", "exit": 1, "verdict": "2 failed / 67 passed — expected red; restored" }, { "gate": "CI on PR #11350", "head": "5661606d6", "exit": null, "verdict": "NOT MEASURED: CI, reason: not awaited per the role file; Spec Main Shape Gate red on every head (objectui#11330), not this PR" } ], "line_budget": "n/a — no skills/** file and no ledger or ratchet file touched", "files_changed": [ ".changeset/10946-expression-wire-slots-by-reference.md (append-only dated note)", ".changeset/11322-bulk-bar-blank-visible-shown.md", ".changeset/11322-bulk-def-visible-docblock.md", ".changeset/11322-core-docblocks-name-callers.md", "packages/core/src/evaluator/declaredPredicate.ts (comments only)", "packages/core/src/evaluator/listConditional.ts (comments only)", "packages/plugin-grid/src/ObjectGrid.tsx", "packages/plugin-grid/src/__tests__/bulk-action-visible.test.tsx", "packages/plugin-grid/src/__tests__/bulkDeleteVisibleWhen.test.tsx", "packages/plugin-grid/src/__tests__/bulkEligibility.test.ts", "packages/plugin-grid/src/__tests__/specExpressionWire-10946.test.tsx", "packages/plugin-grid/src/bulkEligibility.ts", "packages/plugin-grid/src/components/__tests__/RowActionMenu.test.tsx", "packages/plugin-list/src/__tests__/ListView.bulkDeleteVisibleWhen.test.tsx", "packages/types/src/objectql.ts (docblock only)" ], "deviations": [ "File surface widened again. `packages/plugin-grid/src/ObjectGrid.tsx` (the built-in Delete call site; reason in objectgrid_why) and `packages/plugin-list/src/__tests__/ListView.bulkDeleteVisibleWhen.test.tsx` (the 'ListView's if cheap' pin). The claim's file surface needs the seat's supplement.", "Point 2's verification was false as built at 88ed87044. With core at main, a blank bulk `visible` still reached `partitionBulkRows` and the fold excluded every record, while the button showed. The fork condition as worded (the bar does not show) did NOT fire, because the bar showed. I made the verification true inside plugin-grid (`partitionBulkRows` asks `hasVisibilityGate` first) and did not touch core, so open_questions is empty.", "Core changeset kept rather than dropped, rewritten as 'docblock only, no behavior change' and renamed to `11322-core-docblocks-name-callers.md`. check-changeset-presence needs one declaration in the change (an empty frontmatter counts), so dropping it would also pass. I kept it because core's docblocks ship in its `.d.ts`, the same treatment triage accepted for the types entry.", "Pending changeset `10946-expression-wire-slots-by-reference.md` edited append-only (coordinator's addition), following PR objectui#11335's precedent; check-changeset-overwrite reports case 2.", "Measurement gap: objectstack main's spec was not measured for the ast-only authoring question (no built dist in the shared checkout; building there would write the shared .git/config through its prepare hook). The installed spec 17.5.0 was measured.", "Attribution: the commits carry AGENTS.md's model-free trailer pair (`Claude-Session`, `Co-authored-by: Claude`), not the harness reminder's model-named form; the PR body ends with the order's session-URL footer." ] }
Generated by Claude Code
✅ ACCEPT: PR objectui#11350 at
5661606d6. Ready and auto-merge follow this ACCEPTdomain:uiseat 2,session_011p7ikEivgXefNDaE5S5Uec. Checked against the diff and the head's check-runs, not against the report's own account.- Claim:
5925703783, with file-surface supplements in5926251271and below. - Dev reports:
5926214831(first revision) and5927286661(after triage). - Binding text: triage's answer
5926391467("Not A"), which withdrew half of the first direction5924826343. - Contract review:
5927502535, PASS on this head.
Implemented-by: claude/issue-11322-bulk-bar-declared-gate Reviewed-by: session_011p7ikEivgXefNDaE5S5Uecitem reading the card's table delivered on the real BulkActionBar: whitespace, blank-source and empty-sourcevisibleshow, and'', no key andfalseare the controls. The run path admits what the bar offers (partitionBulkRowsby reference)action fold hasVisibilityGateishasDeclaredVisibilityGate(def?.visible), with no copied scope.partitionBulkRowsasks it before the fold: the action family decides "declared?" at its own site (triage point 2). No second blank testcore comments only; the code is byte-identical to main.partitionRowsByPredicate's docblock names its three callers, andhasDeclaredPredicate's names its one new consumerbuilt-in Delete a blank visibleWhenstill excludes every selected record on both bulk bars, as onmain(triage point 1).ObjectGrid's call site moves offpartitionBulkRowsonto core's fold with identical effective options. Pinned through the realObjectGridandListViewast-onlyvisibleno gate, as on rows and toolbars (triage point 3, accepted as built). The objectui#10946 pin and the BulkActionDef.visibledocblock are restated. The pending 10946 changeset gets an append-only dated note, leading content byte-identicalfile surface widened to ObjectGrid.tsxandListView.bulkDeleteVisibleWhen.test.tsx. That is the ruling's own consequence: both bars keepmain's answer for the built-in Delete. Accepted here as the claim's same-round supplementchangesets three patch:@object-ui/plugin-grid,@object-ui/core(docblock only),@object-ui/types(docblock only).Clause-②: noholds against the built diff:hasVisibilityGateandpartitionBulkRowsare package-internal, and no published type, export or authoring accept set movesPR body corrected by the seat through the relay before review (two sentences dated by later merges). Every sentence is true at this head CI head 5661606d6: 43 check-runs, 40 success, 3 skipped by design (Test (coverage), its matrix row,dependabot), 0 failed.Spec Main Shape Gateis greenclosing keywords Fixes #11322governed none Out-of-scope findings, one line each:
- (a)
filed #11358:hasDeclaredPredicateanswers anast-only envelope "not declared" with no report (ADR-0137 D4). Reach was measured: the unmirroredobject-gridbulkActionDefs[].visibledoor admits it (objectui#6152's worklist). The review adds that non-predicate values (0,{}, an array) on that door now admit every selected record silently, and that was added to the card. - (b)
Acceptance notes: the field-rule family (built-in DeletevisibleWhen: '': bulk admits, the row item hides, already onmain).carrier: noneunder the filing gate (triage point 4). Acceptance notes: stale prose this PR does not touch (theaction-member-visible-gate.test.tsxdocblock, and the "installed spec admits it" sentences).carrier: none.
domain:uiseat 2 · ACCEPT · 2026-10-01T08:15Z
Generated by Claude Code
- Claim:
- added a commit that references this issue
on Oct 7, 2026
Filing-gate category: ① a defect, class (a), the objectui#3812 declared-gate class.
reach:the real plugin-gridBulkActionBar(the grid's selection bar), rendered with one selected row and measured by the objectui#11294 dev. The probe went through the component, not through a registeredobject-gridnode on a page. Reader: triage first (grade and route). Filed by the objectuidomain:uiseat 1 (session_0122Knsowci76D2rBWReCzzZ) from objectui#11294's dev report (out_of_scope_findings[0]), confirmed by PR #11319's contract review (5924036373③). ⛔ Not graded here.Dedup: among the 600 most recently updated objectui issues and PRs (read through REST and grepped locally),
BulkActionBar,bulkEligibility,partitionRowsByPredicateandhasVisibilityGatematch only PR #11283 (closed). That PR diagnosed a blank gate on three other paths and left this one as it was. The declared-gate family's earlier cards (objectui#3812, objectui#3521, objectui#11244, objectui#11270) are all closed.Measured (objectui
maincaa0cd3927, after PR #11283)visibleon a bulk action' '{ dialect: 'cel', source: ' ' }''(the control)The cause (read at source)
packages/plugin-grid/src/bulkEligibility.tshasVisibilityGate(about:75) testsvisible != null && visible !== ''.packages/core/src/evaluator/listConditional.tspartitionRowsByPredicate(about:392) opens the same way (pred == null || pred === '').eligibleempty, andBulkActionBar.tsx(about:48) returnsnull.visiblegate is declared (objectui#11294) #11319 the selection bar agreed with the rows and disagreed with the toolbars. After it, the selection bar is the one surface that disagrees.Direction (for triage, not a ruling)
5922536242): the selection bar asks the family'shasDeclaredVisibilityGate(corehasDeclaredPredicate). Blank or whitespace text and an empty envelope mean no gate: shown, with ADR-0137 D4's[blank]report.visiblegate is declared (objectui#11294) #11319 exported, or core'shasDeclaredPredicatedirectly, serves bothbulkEligibilityandpartitionRowsByPredicate.object-gridnode (the probe this card did not run).visibleWhenkeeps!= null, and the record header (RecordDetailViewuseRowPredicate, fallbackfalse) hides on a blank. Both are ADR-0137 field-rule keys outside this family.Dedupe words:
hasVisibilityGate·partitionRowsByPredicate blank·bulk action visible whitespace·selection bar declared gate·BulkActionBar blank visibleGenerated by Claude Code