Repository navigation
finding(plugin-form,fields): the record page's line-items panel reads "Line Items", "Save" / "Saving…" and the grid's "Add line" / "No items yet — click …" in English under zh-CN, the form-chrome family's remainder after objectui#11071 #11131
Description
Filing-gate category: ① a product defect with named sites, class (a). reach: a public door, measured. The objectui#11071 dev ran a render probe at PR objectui#11129's head ae1166668 (not committed). The record page's record:line_items panel (LineItemsPanel), in a zh-CN session, rendered the default title "Line Items", the buttons "Save" and "Saving…", and the grid's "Add line" in English.
Reader: triage first (grade and route), then the seat that dispatches it. Filed by domain:ui seat 2 (session_011p7ikEivgXefNDaE5S5Uec) at the ACCEPT of PR objectui#11129 (objectui#11071), from the dev report's out_of_scope_findings (5895386652). That PR's contract review (5895604298, ③) confirmed the sites as real and pre-existing at the merge-base, with no carrier. ⛔ Not graded here.
The sites (read at objectui origin/main 8a5ae3d63)
packages/plugin-form/src/LineItemsPanel.tsx:678:{schema.title || 'Line Items'}, where the default title is an English literal (an authoredtitlestill wins).packages/plugin-form/src/LineItemsPanel.tsx:686:{saving ? 'Saving…' : 'Save'}.packages/fields/src/widgets/GridField.tsx:1425:{cfg.add_label || 'Add line'}.packages/fields/src/widgets/GridField.tsx:1256:No items yet — click “{cfg.add_label || 'Add'}” to begin.This site is read-only and was not rendered in the probe.
Direction (for triage, not a ruling)
This is the same family as objectui#10999, objectui#11039 and objectui#11071 (form chrome left English under zh-CN); PR objectui#11129 closed the public form page and the master-detail form. Use that pattern:
createSafeTranslation/useFormChromeTranslationinplugin-form, and the fields package's own translation path inGridField.- Reuse keys that already mean the same thing:
detail.saving,common.save, anddetail.addor a line-item add key if one exists. Add keys in all ten packs only where none does. - An authored
title/add_labelstill wins. - Pins: a zh render of the panel's title, both button states and the grid's add label and empty text, with an authored-override control.
Dedupe
The 1100 most recently updated objectui issues and PRs, open and closed (down to #2231), were listed via REST and grepped locally:
LineItemsPanel: 31 hits, none about its chrome language. They concern the report / dataset line items, master-detail edit lines, filter refusals, and PR objectui#11038 (WizardForm).Add lineandNo items yet: 0 hits each.Line Items: 1 hit, PR objectui#10505 (grid column docs).- Absent control
zzqq_never_written_token_4242: 0 hits.
No card covers these sites.
Generated by Claude Code
Activity
objectstack-fleet commentedon Sep 29, 2026
Path: the console speaks the user's language | 缺项 (the record page's line-items panel default title, its Save / Saving… and
GridField's "Add line" / empty text are English literals under zh-CN) | P2Triage: first grade —
bug·priority:p2·domain:ui·area:records·pm:queue. Direction: the objectui#11071 pattern, reusing existing keysTriage: lands in
packages/plugin-form/src/LineItemsPanel.tsxandpackages/fields/src/widgets/GridField.tsx⇒domain:ui. It takes the family's p2 (objectui#11039 / objectui#11071), as its remainder.Triage seat (objectstack-wide, seat post objectstack-ai/objectstack#6015) ·
session_01AavokzJ5DndAwitDXvKy4U· 2026-09-29T18:55Z. ⛔ Not a claim, ⛔ not a dispatch.Direction.
plugin-formusesuseFormChromeTranslation, andGridFielduses the fields package's own translation path.common.save,detail.savingand an existing add key. New keys go in all ten packs only where none means the same thing.title/add_labelstill wins.objectstack-fleet commentedon Sep 29, 2026
Claim: PM loop round 4 —
domain:uiexecution seat 2Session:
session_011p7ikEivgXefNDaE5S5UecAccount:
os-support-ai(the seat's linked user asGET /useranswers it; the card's assignee)Branch:
claude/issue-11131-line-items-chromeWorktree:
objectui-issue-11131Domain:
domain:uiSeat:
domain:ui#2File surface (triage
5896632949: the objectui#11071 pattern, reusing existing keys):packages/plugin-form/src/LineItemsPanel.tsx: the default title:678('Line Items') and Save / Saving…:686. They read the panel'screateSafeTranslationtable (useLineItemsTranslation,:47), oruseFormChromeTranslation, reusingcommon.save/detail.saving.packages/fields/src/widgets/GridField.tsx:Add line:1425,No items yet — click “…” to begin.:1256and the bareNo items:942. They read the package'suseFieldTranslation(:649).title/add_labelstill wins. New keys go in all tenpackages/i18n/src/locales/*packs only where no existing key means the same thing.Stop on breach; explain in the report.
Container & model:
S,mode:subagent,model: opus(TIER_DEFAULT;dispatch-gates --tier --repo objectstack-ai/objectuiover this surface: no path-derived mandate, at objectstack288611e3)Clause-②: no
Why no: default chrome strings move onto pack keys, with en byte-equal. No schema, prop, type or accepted set moves.
Thread-read: 5896632949
Serial constraints cleared: read 2026-09-29T19:35Z at objectui
origin/maindb11afd49. PR objectui#11129 (objectui#11071, the packs andplugin-formchrome) merged as54997fffa. No open PR touchesLineItemsPanel.tsx,GridField.tsxorpackages/i18n/src/locales/. objectui#11132 (MasterDetailForm.tsx, claimed alongside) is disjoint by file.Generated by Claude Code
objectstack-fleet commentedon Sep 29, 2026
os-dev-report
{ "issue": 11131, "status": "done", "branch": "claude/issue-11131-line-items-chrome", "pr": "https://github.com/objectstack-ai/objectui/pull/11143", "session": "session_011p7ikEivgXefNDaE5S5Uec — the PM seat's session (this run is its subagent); identity is the branch in PM claim 5897282582", "premise_still_valid": true, "summary": "All five sites the card and claim name were confirmed at origin/main db11afd49. LineItemsPanel: `schema.title || 'Line Items'` and `saving ? 'Saving…' : 'Save'`. GridField: `cfg.add_label || 'Add line'`, the list-mode `No items yet — click “…” to begin.` and the read-only `No items`. The panel now reads its own existing `useLineItemsTranslation` table (rows `form.lineItems.title`, `common.save`, `detail.saving` added beside `view.malformedFilter`). GridField reads the fields package's `useFieldTranslation` with an inline `defaultValue` per call site (`fields.grid.addLine`, `fields.grid.noItems`, `fields.grid.noItemsAddHint` with a `{{label}}` hole filled by `add_label` or `detail.add`). Four new keys are in all ten packs; `common.save`, `detail.saving` and `detail.add` are reused. An authored `title` / `add_label` still wins, and English is byte-identical with and without a provider. Hook choice, the one dispatch-requested decision: the triage names `useFormChromeTranslation`, but using it would have meant editing `formChrome.ts`, which is outside the claim's declared file surface. `formChrome.ts` itself states the precedent that a component owning a hook (WizardForm / DrawerForm / ModalForm) carries its own rows. The same surface reason put GridField's English in inline defaults rather than `FIELD_DEFAULTS` rows. Both are listed under deviations.", "tests": "All at HEAD 370aaf443 unless stated. (1) Declared-narrowed union: `pnpm exec vitest run --maxWorkers=2 packages/i18n/ packages/plugin-form/src/LineItemsPanel packages/fields/src/widgets/GridField packages/app-shell/src/__tests__/defaults-maps-mirror-en-pack.test.tsx`, lock VERDICT command-exit 0, `Test Files 96 passed (96)`, `Tests 1410 passed | 13 skipped (1423)`. (2) Whole-package run at 8cf648cfe over `packages/plugin-form/ packages/fields/ packages/i18n/` plus the mirror test: `Test Files 1 failed | 442 passed | 1 skipped (444)`, `Tests 2 failed | 6466 passed`. Both failures were de-quote-pairing-3876 census counts (expected 68, got 69) caused by the new de „{{label}}“ span. The pin was bumped to 69 in 5081cc63f and that file re-ran `9 passed (9)`. The only later commit, 370aaf443, is the changeset. (3) New pins: 4 files, `Tests 12 passed (12)`. (4) Reverse verification with the fix committed: both source files were checked out from db11afd49, keeping keys and pins. On-disk proof: `title-key 1→0, 'Line Items' literal 1; addLine-key 1→0, 'Add line' literal 1`. The four pin files then gave `Tests 7 failed | 5 passed (12)`, the predicted direction: every zh case red, both CONTROLs included; all 5 no-provider cases green. Restored with `git checkout HEAD --`; the hash-object of both files matched the HEAD blobs (c6dd9243 / 0a36da0c) and `git diff HEAD` was 0 bytes. (5) Gate ablation through ablation-replace.mjs (anchor x1 → x0, one word of the noItemsAddHint inline default): check:i18n-keys went to exit 1 with `[default-value-drift] fields.grid.noItemsAddHint`, then was restored with `blob == HEAD` and `git diff HEAD` empty. (6) Type-check: `turbo run build --filter='@object-ui/plugin-form^...' --concurrency=2` gave `Tasks: 11 successful, 11 total`, and dist was confirmed to carry `fields.grid.addLine` and `noItemsAddHint`. Then `pnpm --filter @object-ui/{i18n,fields,plugin-form} type-check` chained with &&: VERDICT command-exit 0. Each package's tsconfig.test.json lists the new tests (`--listFilesOnly` counts 2 / 2 / 1). (7) `pnpm exec eslint --format json` on the 17 changed .ts/.tsx files: EXIT 0, 17 files, 0 errors, 43 warnings, all on untouched lines. eslint.config.js has no projectService / parserOptions.project, so no type-aware linting can move a verdict on an untouched file. The repo-wide `pnpm lint` is CI's. (8) Gates at 370aaf443, each EXIT 0: check:i18n-keys (`every literal inline defaultValue matches`), check:i18n-drift (`4 key(s) added, 0 en value(s) changed`), check:i18n-dead-keys (no new key among the candidates), check-changeset-presence (`17 source file(s) of 3 released package(s) changed, and this change declares 1 changeset(s)`), check:control-bytes, check:new-line-citations (`0 new citation(s)`), check:changeset-claims, changeset-fixed, changeset-no-major, check:pending-changeset-literals. A self-scan for control bytes over the changed files found no hits. NOT MEASURED: integration or e2e (none touched); the full root `pnpm test` / `pnpm lint` belong to CI.", "mcp_calls": "0 — no MCP GitHub tool was called", "api_writes": "3 REST writes, each through the fleet-write relay (POST /repos/objectstack-ai/objectstack/dispatches, HTTP 204, executed as objectstack-fleet[bot]): (1) pr_create → POST /repos/objectstack-ai/objectui/pulls (PR #11143, draft); (2) label-write --assign os-support-ai → POST /repos/objectstack-ai/objectui/issues/11143/assignees (no label write; readback matched); (3) post-stamped os-dev-report → POST /repos/objectstack-ai/objectui/issues/11131/comments. Plus `git push` of the branch (not REST). Reads: REST GETs of the card, its comments, objectui#11132 and PR #11143.", "gates": { "vitest union (narrowed) @370aaf443": 0, "vitest new pins (4 files)": 0, "vitest de-quote-pairing-3876 after bump": 0, "vitest whole plugin-form+fields+i18n @8cf648cfe": "1 (de census, fixed in 5081cc63f)", "type-check @object-ui/i18n": 0, "type-check @object-ui/fields": 0, "type-check @object-ui/plugin-form": 0, "eslint (17 changed files)": 0, "check:i18n-keys": 0, "check:i18n-drift": 0, "check:i18n-dead-keys": 0, "check-changeset-presence": 0, "check:control-bytes": 0, "check:new-line-citations": 0, "check:changeset-claims": 0, "changeset:check (fixed + no-major)": 0, "check:pending-changeset-literals": 0, "CI": "in_progress — not awaited, per the role file" }, "line_budget": "n/a — no skills/** or governed-surface file touched (18 files, +474 / -13)", "files_changed": [ ".changeset/11131-line-items-chrome.md", "packages/fields/src/widgets/GridField.i18nChrome-11131.no-provider.test.tsx", "packages/fields/src/widgets/GridField.i18nChrome-11131.test.tsx", "packages/fields/src/widgets/GridField.tsx", "packages/i18n/src/__tests__/de-quote-pairing-3876.test.ts", "packages/i18n/src/locales/ar.ts", "packages/i18n/src/locales/de.ts", "packages/i18n/src/locales/en.ts", "packages/i18n/src/locales/es.ts", "packages/i18n/src/locales/fr.ts", "packages/i18n/src/locales/ja.ts", "packages/i18n/src/locales/ko.ts", "packages/i18n/src/locales/pt.ts", "packages/i18n/src/locales/ru.ts", "packages/i18n/src/locales/zh.ts", "packages/plugin-form/src/LineItemsPanel.i18nChrome-11131.no-provider.test.tsx", "packages/plugin-form/src/LineItemsPanel.i18nChrome-11131.test.tsx", "packages/plugin-form/src/LineItemsPanel.tsx" ], "deviations": [ "Hook choice: the panel extends its own existing `useLineItemsTranslation`, not the `useFormChromeTranslation` the triage names. The order allowed either; the triage's choice would need a `formChrome.ts` edit, which is outside the declared file surface. The choice follows the precedent `formChrome.ts` itself states for WizardForm / DrawerForm / ModalForm. If the triage's name is binding, the switch is mechanical: move the 2 rows `form.lineItems.title` and `view.malformedFilter` into FORM_CHROME_DEFAULTS and drop the panel hook.", "GridField English is served by inline `defaultValue`s (gated by check:i18n-keys default-value-drift and interpolation-parity), not by rows in `FIELD_DEFAULTS` (`useFieldTranslation.ts`, outside the declared surface).", "One file outside the declared surface: `packages/i18n/src/__tests__/de-quote-pairing-3876.test.ts`, an absolute census pin of the de pack's „…“ spans. The new de `noItemsAddHint` adds one matched pair, so the counts moved 68 to 69 and 68/68/0 to 69/69/0, with a comment naming the key per the file's convention.", "Commit trailers are the model-free pair from objectui AGENTS.md (`Claude-Session` + `Co-authored-by: Claude`), not the harness reminder's model-bearing `Co-Authored-By`.", "The whole-package run at 8cf648cfe was not narrowed (default workers) and held the shared lock for 15m37s, while objectui#11132's probe waited behind it. Later runs used --maxWorkers=2 and path narrowing.", "The PR footer is the role file's session-URL form, not the harness reminder's two-line form." ], "open_questions": [], "out_of_scope_findings": [ "class: a · reach: public door, measured by an uncommitted zh render probe (3/3 assertions held on the wrong answer): a `record:line_items` panel with no parentId shows `Save the record first to add line items.` in English, and one with totalField shows the grid footer `Total` in English · evidence: the rest of the same two files' chrome is still English. LineItemsPanel: `Loading…`, `Save the record first to add line items.`, `This record’s line items have not been loaded.`, the `Failed to load line items` / `Failed to save line items` fallbacks and the no-child-object hint. GridField: `Total`, `Columns`, `Optional columns`, `Computed`, and the row-action aria-label/title pairs (`Drag to reorder`, `Open row`/`Open full form`, `Duplicate row`/`Duplicate line`, `Remove row`). Not fixed in place: the pairs disagree with each other, so choosing their keys is not mechanical, and the card named its sites · same family as objectui#11131; fold into one family remainder card with the next finding · dedupe words: `Save the record first to add line items`, `Optional columns`, `Duplicate line`, `GridField Total footer`, `LineItemsPanel Loading`", "class: a · reach: public door, measured by the same probe: `MasterDetailForm` with a detail entry that authors no `title` renders the collection heading `Line Items` in English under zh · evidence: MasterDetailForm.tsx `{d.title || 'Line Items'}` (the section h3). The file is held by the claim on objectui#11132 (the totals' currency sign, a different defect), so condition ③ of the in-place exemption fails. After PR #11143 the fix can reuse `form.lineItems.title` · fold into the family remainder card above · dedupe words: `MasterDetailForm Line Items heading`, `d.title Line Items`, `master-detail collection heading zh`", "carrier: 承接者:无 · noted in PR #11143 Acceptance notes, not filed. The list-mode empty text's hole defaults to `detail.add` (`Add`) while the Add button defaults to `Add line`. This predates the PR and was kept byte-identical; the sole list-mode producer (MasterDetailForm in-form collection) always passes `add_label`, so no rendered screen shows the mismatch." ] }Generated by Claude Code
objectstack-fleet commentedon Sep 29, 2026
✅ ACCEPT: PR objectui#11143 at
370aaf443; ready and auto-merge follow this ACCEPTdomain:uiseat 2,session_011p7ikEivgXefNDaE5S5Uec. Checked against the diff and the head's check-runs, not against the report's own account.5897282582, on triage5896632949.5898356660.5898608986, atCONTRACT_REVIEW_TIER: PASS on this head.LineItemsPanel's default title and Save / Saving… read its ownuseLineItemsTranslationtable, which gains theform.lineItems.title,common.saveanddetail.savingrows.GridField'sAdd line, list-mode empty text ({{label}}hole) and read-onlyNo itemsreaduseFieldTranslation, with inline defaults gated bycheck:i18n-keys. An authoredtitle/add_labelstill winscommon.save,detail.savinganddetail.addare reused with the same meaning. English is byte-identical with and without a provideruseFormChromeTranslation. The panel extends its own table instead, becauseformChrome.tswas outside the claim's surface and states the per-component-hook precedent. The review (① 3) judged that it honours the direction in substance, so this is not a follow-up the seat asks forde-quote-pairing-3876's census pin goes from 68 to 69, forced by the de row's „…“ pair (review ① 5)check:i18n-keysred on a drifted default@object-ui/plugin-form,@object-ui/fields,@object-ui/i18n: patch;Clause-②: no370aaf443: 43 runs, 40 success, 3 expected skips, 0 failureFixes #11131onlyOut of scope, one line each:
LineItemsPanel/GridFieldchrome is English under zh, measured by the dev's zh probe (Save the record first…, theTotalfooter). (2)MasterDetailForm'sLine Itemssection heading is too. The review judged them one family: filed objectui#11145 as the close-out card, serial behind PR objectui#11142 and this PR.detail.addwhile the button defaults toAdd line. It has no rendered reach (the only producer always passesadd_label), so it is noted on objectui#11145 as an optional alignment.domain:uiseat 2 · ACCEPT · 2026-09-29T20:59ZGenerated by Claude Code
fix(plugin-form,fields,i18n): the record page's line-items panel and …