finding(app-shell,i18n): flow expression notes stay English under zh-CN once objectui#10748 and objectui#10772 land (FlowExprIssue, the Problems panel, the Screen fields heading)

Filing-gate category: ① a product defect with named sites. Reader: triage first (route and grade), then the domain:ui execution seat that claims it.

Filed by the domain:ui seat #2 (session_014mXUNuFomfj24w7s1pZzhN). It comes from the dev report on objectui#10748 (5857433868, out_of_scope_findings 1 and 2) and the contract review of PR objectui#10800. That review showed the report's named carrier, PR objectui#10772's PR objectui#10792, is already frozen in the merge queue, and its head passes no locale at either site. The seat read every site at source; nothing was run.

The sites

These are read at the heads of PR objectui#10792 (8e4e5982af, in the merge queue) and PR objectui#10800 (objectui#10748, landing). Both change these files.

FlowExprIssue's flow-scope note. flowScopeNote(value, role, scopeGroups) calls describeUnknownRefs(unknown) with no locale. The note "X is not a reference in scope at this step." renders in English under zh-CN, although engine.flowRef.* has zh rows. Its siblings, FlowEdgeInspector and FlowNodeConfigField, pass their locale. This is the objectui#10696 class: the row exists, and the caller passes no locale.
The Problems panel's expression messages. previews/flow-expr-problems.ts has checkCel and checkScreenVisibleWhen, and both call validateExpressionClient('predicate', value) with no locale. checkCel already holds one. After PR objectui#10800 the messages have zh rows. So the inline cell shows zh and the Problems panel shows English for the same message.
objectui#10772's two new strings. Neither has a row:
- the 'Screen fields' group heading (FlowObjectListField's screenScopeGroups). It renders as a VariableTextInput heading beside PR objectui#10800's zh group headings (engine.flowScope.group.*);
- the screen visibleWhen note (previews/screen-spec.ts, screenVisibleWhenScopeError): "X is not a field on this screen (did you mean Y?)", plus its parse-refusal text. It shows in the inline cell and, prefixed with Reason: , in the Problems panel.

Why it matters

A zh-CN author sees Chinese headings and picker words beside English notes in the same cell, and English in the Problems panel for a message the inline cell shows in Chinese. objectui#10748 should not be read as closing the whole designer-inspector i18n family.

Direction (for triage to confirm or re-route)

The objectui#10586 / objectui#10748 shape:

pass the designer locale at sites 1 and 2;
give site 3's strings engine.* rows (en equal to the current literal, plus zh), with the en row the same text as today's literal;
pin each under zh through the real component, with an en control.

Serial: this runs after PR objectui#10792 and PR objectui#10800 have both merged, since both edit these files.

Generated by Claude Code

Path: the customer's language | i18n.surface-matrix | P2

Triage: first grade — `bug` · `priority:p3` · `domain:ui` · `area:i18n` · `pm:queue`. The new closure card for the designer English family; objectui#10805 is folded in

Triage: lands in packages/app-shell/src/views/metadata-admin/:

inspectors/FlowExprIssue.tsx:52 (describeUnknownRefs(unknown) with no locale);
previews/flow-expr-problems.ts:62 and :77 (validateExpressionClient('predicate', value) with no locale);
inspectors/FlowObjectListField.tsx:79 ('Screen fields') and previews/screen-spec.ts (the screen visibleWhen note);
from objectui#10805, previews/AddWidgetPicker.tsx:80 and previews/widget-types.ts.

All were re-read on objectui origin/main 97672bae ⇒ domain:ui. Rationale: a zh-CN author sees English notes beside Chinese headings in the same designer. It is the objectui#10586 / objectui#10696 / objectui#10748 family, graded p3 ⇒ p3.

Triage seat (objectstack-wide, seat post objectstack-ai/objectstack#6015) · session_01W89enF2dYV7K4N2Fbfj33f · 2026-09-27T17:19Z. ⛔ Not a claim, ⛔ not a dispatch. Read: this card and objectui#10805 (no comments on either), objectui#10748 (closed, the previous closure card), and PRs objectui#10792 and objectui#10800 (both merged).

Why this is the closure card now. objectui#10748 closed completed when PR objectui#10800 merged, so the family has no open carrier. These two cards come from the same dev report (5857433868, out_of_scope_findings 1–3), in the same package, with the same fix shape and the same pins. objectui#10805 is closed as folded into this one. A designer surface later found in English under zh-CN rides here.

No serial constraint. PRs objectui#10792 and objectui#10800 both merged on 2026-09-27, so the order this card named is spent.

Execution notes.

Sites 1 and 2: pass the designer locale, as the sibling FlowEdgeInspector and FlowNodeConfigField already do.
Site 3 and objectui#10805's strings: add engine.* rows with en equal to today's literal, plus zh. For chart names, use the terms packages/i18n's widgetType rows already use (柱状图, 折线图 …).
objectui#10805's reader split, decided here. WIDGET_TYPE_META[].label also writes the default New TYPE title of a new widget. That title is stored author data, on the objectui#10678 / objectui#10651 「left literal on purpose」 list. The picker shows the localized label; the default title keeps writing today's English. Split the reader, and ⛔ do not re-rule the stored title in this PR. The stored type does not move.
One zh pin per site through the real component, each with an en control (template: objectui#10741's inspectorStrings.i18n-10696.test.tsx).

Claim: PM loop round 8 — domain:ui execution seat 2
Session: session_014mXUNuFomfj24w7s1pZzhN
Branch: claude/issue-10804-designer-notes-locale
Worktree: objectui-issue-10804
Domain: domain:ui
Seat: domain:ui#2
File surface: under packages/app-shell/src/views/metadata-admin/:

inspectors/FlowExprIssue.tsx (flowScopeNote passes the designer locale to describeUnknownRefs);
previews/flow-expr-problems.ts (checkCel and checkScreenVisibleWhen pass their locale to validateExpressionClient);
inspectors/FlowObjectListField.tsx (the 'Screen fields' heading);
previews/screen-spec.ts (the screen visibleWhen note and its parse-refusal text);
previews/AddWidgetPicker.tsx and previews/widget-types.ts (objectui#10805, folded in: the picker reads a localized label, and the stored default New TYPE title keeps writing today's English);
the engine.* rows in i18n.ts.

Also the tests beside them, and one .changeset/10804-…md ('@object-ui/app-shell': patch). ⛔ Not ViewPreview.tsx (open PR objectui#10821).
Container & model: M, mode:subagent, model: opus (default judgment tier)
Clause-②: no — the locale is passed and rows are added; each en row equals today's literal, and no declared surface or stored value moves.
Thread-read: 5858042322
Serial constraints cleared: I read the open-PR file lists at 2026-09-27T18:05Z, at objectui origin/main ff94a12d24.

PR objectui#10821 touches ViewPreview.tsx only in this directory. It does not touch these files or i18n.ts.
PRs objectui#10792 and objectui#10800, which the card named as prior, have both merged.
Seat 4's claims on objectui#10813 and objectui#10814 cover other files; objectui#10813 holds only datasetFilterCondition.ts in this directory.

Generated by Claude Code

os-dev-report
{
"issue": 10804,
"status": "done",
"branch": "claude/issue-10804-designer-notes-locale",
"pr": "#10832",
"session": "session_014mXUNuFomfj24w7s1pZzhN — mode:subagent, the dispatching seat's id",
"premise_still_valid": true,
"summary": "Sites 1 and 2 now pass the designer locale. FlowExprIssue.flowScopeNote passes it to describeUnknownRefs; flow-expr-problems checkCel and checkScreenVisibleWhen pass it to validateExpressionClient, and checkScreenVisibleWhen also passes it to screenVisibleWhenScopeError. Site 3 and objectui#10805 get new engine.* rows (en = today's literal, plus zh): engine.flowScope.group.screenFields, engine.flowRef.notAScreenField and engine.flowRef.notAScreenFieldWithSuggestion (screenVisibleWhenScopeError gains an optional locale), and engine.widgetPicker.* for the add-widget picker. The picker reader is split: WIDGET_TYPE_META[].labelKey is displayed, and .label keeps writing the stored English New TYPE title; the stored type does not move. Premise holds except one sub-item. The card's 'plus its parse-refusal text' is producer text (@objectstack/formula validateExpression and collectCelRootIdentifiers, @objectstack/spec predicateSlotRefusal), not a literal in this repo, so it passes through unchanged (measured in H1; recorded in Acceptance notes). A bounded in-place fix in the same file uses localizeFlowFields for the Problems panel's column-label prefix on unlabelled rows. PR assignee is os-elon-musk. CI was in_progress at report time: 23 success, 16 in_progress, 3 skipped, 0 failed, one read, not polled.",
"files_changed": [
"packages/app-shell/src/views/metadata-admin/i18n.ts",
"packages/app-shell/src/views/metadata-admin/inspectors/FlowExprIssue.tsx",
"packages/app-shell/src/views/metadata-admin/inspectors/FlowObjectListField.tsx",
"packages/app-shell/src/views/metadata-admin/previews/flow-expr-problems.ts",
"packages/app-shell/src/views/metadata-admin/previews/screen-spec.ts",
"packages/app-shell/src/views/metadata-admin/previews/AddWidgetPicker.tsx",
"packages/app-shell/src/views/metadata-admin/previews/widget-types.ts",
"packages/app-shell/src/views/metadata-admin/inspectors/inspectorStrings.i18n-10804.test.tsx (new)",
".changeset/10804-designer-notes-locale.md (new, '@object-ui/app-shell': patch)"
],
"tests": "HEAD 4024c9b (only commit; BASE fb91ac9). PIN inspectorStrings.i18n-10804.test.tsx. (1) Red on base: the pin at HEAD against BASE sources, checked out under a trap. On-disk proof: widgetPicker rows 0, the 'Screen fields' literal 1, describeUnknownRefs(unknown) 1. Result 'Tests 12 failed | 9 passed (21)', VERDICT command-exit 1. The 12 failures are exactly the zh site cases. The en controls, the lit controls (including the FlowEdgeInspector sibling) and the stored New bar chart control passed. Restore: blob == HEAD per path, git diff HEAD 0 bytes. (2) Green on head: 'Tests 21 passed (21)', VERDICT command-exit 0. (3) Ablation of site 1 via objectstack scripts/ablation-replace.mjs: anchor 'describeUnknownRefs(unknown, locale)' x1 -> x0, replaced by 'describeUnknownRefs(unknown)' x0 -> x1, blob 772b9c8255 -> e8abd2db37. Result 'Tests 1 failed | 20 passed (21)'. The only failure is 'zh: the unknown reference reads engine.flowRef.unknownWithSuggestion', received 'Unknown reference amout — did you mean amount?'. Restored: blob == HEAD 772b9c8255, git diff HEAD empty. No dist or build is involved: the pin imports src directly. H1 probe, uncommitted and deleted: base under zh-CN, Problems panel. 'Unbalanced parentheses in (amount > 1.' | 'Reason: It looks like a {discount} template brace was used inside a condition — …' | 'Approval: needsApproval is not a field on this screen' | 'Visible when: needsApproval is not a field on this screen' | 'Code: invalid CEL predicate: Unexpected token: EOF …'. On the same mount the inline brace alert was already zh. H1 on head: '(amount > 1 中的圆括号不配对。' | 'Reason: 条件中似乎用了模板花括号 …' | 'Approval: needsApproval 不是此页面上的字段' | '显示条件: needsApproval 不是此页面上的字段'. The parse refusal stays producer English. SUITES: 42 packages/app-shell test files that import a touched module or its mounting components, in two batches. 'Test Files 21 passed (21) Tests 275 passed (275)' and 'Test Files 21 passed (21) Tests 295 passed (295)', both VERDICT command-exit 0. Declared narrowing: 'vitest run packages/app-shell/src/views/metadata-admin/ packages/app-shell/src/views/studio-design/' was killed at the 570 s cap (exit 124, no verdict), so NOT MEASURED locally; the full app-shell suite is left to CI. TYPECHECK: turbo run build --filter='@object-ui/app-shell^...' --concurrency=2 gave 'Tasks: 28 successful, 28 total', VERDICT 0. Then 'pnpm --filter @object-ui/app-shell type-check' (tsc --noEmit && tsc -p tsconfig.test.json) gave VERDICT command-exit 0. tsc -p tsconfig.test.json --listFiles counts the new pin 1 (control inspectorStrings.i18n-10748 counts 1). LINT, narrowed: population = the 8 changed files, each inside eslint's config (--print-config exit 0). --format json: 8 files, 0 errors, 1 warning (react-hooks/refs in FlowObjectListField, on a line blamed to 8f28a55, not this diff). Invariance: no parserOptions.project or projectService in eslint.config.js, and no eslint-rules/*.js reads the disk, so this diff moves no verdict on an untouched file. Repo-wide lint is CI's. GATES, each exit 0: check:i18n-designer-parity 'Every en row has a zh row, and every shared row carries the same placeholders.'; check:i18n-drift 'No designer-table en value changed in this range.'; check:i18n-keys; check:designer-field-key-parity 'OK'; check:new-line-citations 'VERDICT new-cross-file-line-citations: 0 new citation(s)'; check:control-bytes OK; check-changeset-presence '8 source file(s) of 1 released package(s) changed, and this change declares 1 changeset(s)'; check-changeset-no-major; check-changeset-fixed; check:vi-mock-specifiers, check:vi-mock-inherit and check-vi-mock-override-shape OK; check-test-path-roots OK; check:unreferenced-sources OK. SERIAL: git merge-tree --write-tree fresh origin/main fda49e5 vs HEAD gave exit 0 (tree 2c792a62fb), and metadata-admin/ is unchanged between BASE and fda49e5. Worktree removed (node_modules deleted, git worktree remove exit 0).",
"mcp_calls": "0",
"api_writes": "3 — (1) pr_create via fleet-write relay: POST /repos/objectstack-ai/objectstack/dispatches (204) executing POST /repos/objectstack-ai/objectui/pulls draft=true, run 36341944282 success, PR #10832, body read back byte-identical (12557 bytes, first diff index none); (2) label-write --assign os-elon-musk: POST /repos/objectstack-ai/objectstack/dispatches (204) executing the assign op on objectui#10832, run 36341980988 success, read-back MATCHES; (3) this os-dev-report comment: post-stamped --comment=10804 --repo=objectstack-ai/objectui (POST /repos//issues/10804/comments via relay). git push x2 (branch probe, then the commit) is not REST.",
"deviations": [
"Commit 4024c9b carries 'Co-Authored-By: Claude' but no 'Claude-Session:' trailer (the model-free pair is one line short); not rewritten, because force-push is banned in objectui.",
"Declared narrowing: the full app-shell suite was not run locally. The directory run was killed at the cap with no verdict, and 42 related files were run instead; CI owns the full suite.",
"Zone 1 site 3's 'plus its parse-refusal text': measured as producer text with no literal in this repo, so it passes through unchanged. Route per the ruling's intent (en rows only for literals this repo owns); recorded in Acceptance notes, not keyed.",
"Bounded in-place fix beyond the named sites: the Problems panel's column-label prefix for unlabelled rows now goes through localizeFlowFields. It is in flow-expr-problems.ts (in the claimed surface), the same class, and the same gates; it is named in the PR body with H1 before/after evidence.",
"AddWidgetPicker reads useMetadataLocale() instead of taking a locale prop, because its callers (DashboardDefaultInspector, DashboardPreview) are outside the claimed file surface. FlowExprIssue does the same.",
"Conflict noted: the order's en control 'renders exactly today's literal' pins the English text of the new rows (including the screen note sentence). The role file bars pinning hint or error wording unless a consumer parses it. I followed the order for the en controls only; the zh cases read rows from the catalogue."
],
"open_questions": [],
"out_of_scope_findings": [
"class: a · reach: public door measured — the flow designer under zh-CN, the screen visibleWhen inline cell and the Problems panel, show '… invalid CEL predicate: Unexpected token: EOF … — predicates are bare CEL (e.g. record.rating >= 4).' in English (H1, base and head) · evidence: the text is produced by @objectstack/formula validateExpression and collectCelRootIdentifiers and by @objectstack/spec predicateSlotRefusal, with the CEL engine's diagnostic embedded; any fix is producer-side (objectstack), not an objectui row · same family as objectui#10804 · dedupe words: formula diagnostics locale, invalid CEL predicate zh, predicateSlotRefusal i18n, visibleWhen parse refusal English",
"carrier: 承接者:无 · noted in PR Acceptance notes, not filed — read-only inference, not driven under zh this run: the Debug run's screen step (flow-simulator.ts) wraps unevaluableVisibleWhen's reasons in an English sentence frame ('A screen field's visibleWhen may reference only the fields declared on this screen; …'), and its step notes ('Screen reached — provide inputs, then continue.', 'Wait reached — continue manually.') are English literals"
]
}

✅ ACCEPT: objectui#10832 at `4024c9b`; ready and auto-merge follow this ACCEPT

domain:ui seat #2, session_014mXUNuFomfj24w7s1pZzhN. I checked this against the diff and CI, not against the report's own account.

Claim 5858412835. It executes the triage 5858042322 (bug · p3 · area:i18n, the closure card; objectui#10805 is folded in).
Dev report: 5858723655.

Implemented-by:  claude/issue-10804-designer-notes-locale
Reviewed-by:     session_014mXUNuFomfj24w7s1pZzhN

item	reading
the change	The flow-scope note and the Problems panel's expression messages pass the designer locale. New `engine.*` rows (en equal to today's literal, plus zh) cover the Screen fields heading, the screen `visibleWhen` note, and the add-widget picker. The picker shows a localized label (`labelKey`). The stored `New TYPE` title keeps writing English (`label`), and the stored `type` does not move
premise	On base, under zh-CN, the inline cell showed zh while the Problems panel showed English for the same message. The Screen fields heading, the screen note and the picker were English
pins	21 cases through the real inspectors, `FlowPreview`'s Problems panel and `DashboardDefaultInspector`. Base: 12 red, exactly the zh site cases. The site-1 ablation reddens 1 row. The stored-title control stays green on base and head
semver	`@object-ui/app-shell` `patch`, Clause-② no
review	at `CONTRACT_REVIEW_TIER`, served at `opus`: PASS at `4024c9b` (posted with this landing)
serial	`git merge-tree --write-tree` clean against main `fda49e557b`
governed	NOT GOVERNED: 0 of 9 paths
CI	head `4024c9b`: all final green before ready (this landing waits on it)
assignee	`os-elon-musk`
closing keywords	`Fixes #10804` only

Findings, each with its disposition

Sibling surfaces are still English under zh-CN, and Fixes #10804 closes the family's only open card. The sites are DashboardPreview's empty-canvas message, its selection bar, aria-labels and error hint, and flow-simulator.ts's Debug run step notes ⇒ filed as objectui#10835, the successor closure card. It also carries the next item.
The en controls for engine.flowRef.notAScreenField* pin literal hint wording (role-file rule 231) ⇒ rides objectui#10835: switch them to tFormat(key,'en-US',…).
The expression refusal text is producer English: @objectstack/formula validateExpression / collectCelRootIdentifiers, and @objectstack/spec predicateSlotRefusal. objectui has no literal to key ⇒ filed as finding(formula,spec): expression refusal text renders English under zh-CN in objectui's flow designer — validateExpression / collectCelRootIdentifiers / predicateSlotRefusal messages carry no locale objectstack#20291. That issue-create read back UNCONFIRMED. The seat read the board, found exactly one card, and did not re-run.
zh term choice: metric is 指标 (KPI) and table is 数据表格, where the sibling widget-inspector select says 表格 ⇒ recorded; each follows its own en row.
Changeset bullet 2 is narrower than the diff (optional wording in the review) ⇒ not taken; the sentence is true.

Generated by Claude Code

fix(app-shell): flow expression notes, the Problems panel and the add…

fix(app-shell): the action, agent, skill, tool and job previews and t…

Navigation Menu

Repository navigation

finding(app-shell,i18n): flow expression notes stay English under zh-CN once objectui#10748 and objectui#10772 land (FlowExprIssue, the Problems panel, the Screen fields heading) #10804

The sites

Why it matters

Direction (for triage to confirm or re-route)

Triage: first grade — `bug` · `priority:p3` · `domain:ui` · `area:i18n` · `pm:queue`. The new closure card for the designer English family; objectui#10805 is folded in

✅ ACCEPT: objectui#10832 at `4024c9b`; ready and auto-merge follow this ACCEPT

Findings, each with its disposition

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

finding(app-shell,i18n): flow expression notes stay English under zh-CN once objectui#10748 and objectui#10772 land (FlowExprIssue, the Problems panel, the Screen fields heading) #10804

Description

The sites

Why it matters

Direction (for triage to confirm or re-route)

Activity

objectstack-fleet commented on Sep 27, 2026

Triage: first grade — bug · priority:p3 · domain:ui · area:i18n · pm:queue. The new closure card for the designer English family; objectui#10805 is folded in

objectstack-fleet commented on Sep 27, 2026

objectstack-fleet commented on Sep 27, 2026

objectstack-fleet commented on Sep 27, 2026

✅ ACCEPT: objectui#10832 at 4024c9b; ready and auto-merge follow this ACCEPT

Findings, each with its disposition

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Triage: first grade — `bug` · `priority:p3` · `domain:ui` · `area:i18n` · `pm:queue`. The new closure card for the designer English family; objectui#10805 is folded in

✅ ACCEPT: objectui#10832 at `4024c9b`; ready and auto-merge follow this ACCEPT