Repository navigation
feat(spec)!: remove dead author-facing metadata properties (#2377, A2) - #3176
Merged
Merged
Conversation
Removes spec properties that parsed but had no runtime consumer (ADR-0049 enforce-or-remove) — a false affordance, especially for AI-authored metadata. Follow-up slice to #2402. Verified dead against packages/spec/liveness/*.json and a repo-wide reader grep. Removed: - field: vectorConfig (+VectorConfigSchema+types), fileAttachmentConfig (+FileAttachmentConfigSchema+types), dependencies - object: versioning, softDelete, search, recordName, keyPrefix (+ their sub-schemas/types) — each now a rejecting tombstone in UNKNOWN_KEY_GUIDANCE - action: timeout - agent: planning.strategy, planning.allowReplan (keep planning.maxIterations) - dataset: measures.certified Ledgers, ledger README table, api-surface.json, and json-schema.manifest.json updated; spec tests/fixtures migrated (analytics/rest/lint/cli). Deferred the authoring-form-surfaced dead props (field.index/columnName/referenceFilters; object.tags/active/isSystem/abstract/enable.searchable/trash/mru; agent.tenantId) and action.type:'form' — they cascade into i18n/lint/UX and stay authorWarn'd. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011XchBKhKdjbhQZymt9Gn9B
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
documentation
Contributor
📓 Docs Drift CheckThis PR changes 5 package(s): 110 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
6 tasks
Regenerated content/docs/references/ from the updated spec schema (pnpm gen:schema && gen:docs) — field/object/action/agent/dataset reference pages drop the removed properties; data/search-engine.mdx and api/object.mdx removed as spec no longer defines them. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011XchBKhKdjbhQZymt9Gn9B
…2377) The whole publishable set is in the Changesets fixed group, so a `major` would promote the entire monorepo. Breaking spec cleanups ride the minor line during the launch window (precedent: #2402 → 11.1.0). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011XchBKhKdjbhQZymt9Gn9B
os-zhuang
marked this pull request as ready for review
July 18, 2026 07:22
This was referenced Jul 22, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-evaluation + next slice of #2377 (ADR-0049 enforce-or-remove). Follow-up to the merged #2402. Removes spec properties that parse but have no runtime consumer — a false affordance, especially for AI-authored metadata. Each was verified
deadagainstpackages/spec/liveness/*.jsonand a repo-wide reader grep.Removed (each dead, no reader anywhere)
field.zod.ts):vectorConfig(+VectorConfigSchema+types),fileAttachmentConfig(+FileAttachmentConfigSchema+types),dependencies. Vector fields keep the live flatdimensions; file/image fields keep the live flatmultiple/accept/maxSize.object.zod.ts):versioning(+VersioningConfigSchema),softDelete(+SoftDeleteConfigSchema),search(+SearchConfigSchema),recordName,keyPrefix— each is now a rejecting tombstone inUNKNOWN_KEY_GUIDANCEcarrying the upgrade prescription (matching thedefaultDetailForm/compactLayoutprecedent).action.zod.ts):timeout(server usesbody.timeoutMs; no action-level timeout is enforced).agent.zod.ts):planning.strategy,planning.allowReplan(runtime reads onlyplanning.maxIterations).dataset.zod.ts):measures.certified(declared-but-unenforced governance flag; never compiled into the Cube).Bookkeeping
api-surface.jsonregenerated (drops exactly the removed public exports); removed sub-schema keys dropped fromjson-schema.manifest.json.content/docs/references/) regenerated viagen:schema && gen:docs.service-analytics(×4),rest,lint,cli.Deliberately NOT removed (dead, but entangled — scoped follow-up)
These are dead but surfaced in the Studio metadata-authoring forms (
*.form.ts), so removing them cascades into i18n-bundle regeneration:index/columnName/referenceFilterstags/active/isSystem/abstract/enable.searchable/enable.trash/enable.mrutenantIdPlus
action.type:'form'(has a dedicated build-time lintlint-view-refs.ts+ a first-party showcase action → needs a UX decision) andfield.columnName(also has an ADR-0062 D7 lint). All staydead+authorWarnin the ledgers.Migration
dimensions; file/image → flatmultiple/accept/maxSize.ObjectSchema.create()now throws a located error naming the replacement —versioning/softDelete→ hard deletes +Field.trackHistory/lifecycle;search→searchableFields;recordName→ anautonumberFielddesignated asnameField;keyPrefix→ remove.Versioning
Breaking spec-surface change, but versioned as a
minorchangeset per the launch-window policy — the whole publishable set is in the Changesets fixed group, so amajorwould promote the entire monorepo. Breaking cleanups ride the minor line (precedent: #2402 → 11.1.0).Verification
check:api-surface✓;check:docs✓ (256 generated files in sync); spec-liveness gate ✓ (all governed props classified).@objectstack/specclean.Also in this task
Re-evaluated #2378 (IDataEngine) — no code work remains: the scope-corrected removal of the deprecated
DriverInterfacealias already landed in #2384 (IDataEngineis the live engine contract, not deprecated). Closed #2378 with that note.🤖 Generated with Claude Code