Repository navigation
fix(setup): drop Advanced nav entries for non-listable objects (verifications, device codes) - #2266
Merged
Merged
Conversation
Browser-dogfooding every Setup menu found two Advanced entries that always render "failed to load": Verifications (sys_verification) and Device Codes (sys_device_code). Both objects intentionally omit `list` from `apiMethods` (sensitive ephemeral secrets), so the generic list-view menu 405s every time. Removed both nav entries + their orphaned zh labels; objects stay reachable by id. (Re-adding a browse menu needs `list` enabled — a security decision.) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
documentation
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 3 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes two Setup → Advanced menu entries that can never load:
sys_verification)sys_device_code)Why
Found by browser-verifying every Setup menu (all 38). Both objects intentionally omit
listfromapiMethods(sys_verification:get/create/delete;sys_device_code:get/create/update/delete) — they're sensitive, ephemeral secrets that aren't meant to be browsed. But the Advanced group pinned them as generic object/list-view menus, so every visit hit405 OBJECT_API_METHOD_NOT_ALLOWEDand rendered the "无法加载记录 / failed to load" error boundary.Removed both nav entries (and their now-orphaned zh labels). The objects stay reachable by id (
get). Re-introducing a browse menu would require enablingliston the object — a security decision, not a nav change.Sibling objects in the same group (
sys_oauth_application,sys_jwks,sys_account,sys_user_preference) all allowlistand render fine.Verification
Re-built
platform-objects, restarted, re-swept: Advanced now shows OAuth 应用 / 签名密钥 / 身份链接 / 用户偏好; the two broken entries are gone; all remaining 36 Setup menus render without error.Relates to #2246.