Repository navigation
fix(setup): first-run admin polish — nav pin, widget service-gate, i18n, settings PUT envelope - #2249
Merged
Merged
Conversation
…8n, settings PUT envelope Dogfooding the Setup app as a brand-new system administrator surfaced a cluster of small first-run gaps. This fixes the bounded ones (larger gaps tracked in #2246): - Pin Localization + Company in the Setup sidebar (were reachable only via the All Settings hub despite being the two lowest-order Workspace settings). - Extend the ADR-0057 D10 server-side visibility gate to dashboard widgets: rest-server strips widgets whose requiresService names an unregistered kernel service. Removes the orphan "Organizations" KPI in single-tenant runtimes, matching the already-hidden org nav entries. - i18n: translate nav labels Cloud Connection (云连接), Datasources (数据源), Capabilities (能力); add missing zh help for the Localization settings fields. - settings: PUT /api/settings/:ns now also accepts the { values: {...} } envelope that GET returns (symmetry). Tests: service-settings 128 green (+2), rest 133 green (+6). All fixes browser-verified on the showcase example. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
documentation
Contributor
📓 Docs Drift CheckThis PR changes 3 package(s): 10 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
First-run system-administration polish found by dogfooding the Setup app (系统设置) as a brand-new admin standing up the platform. Fixes the bounded items; the larger gaps stay tracked in #2246.
service-settingsmanifests (the two lowest-orderWorkspace settings) but were reachable only via the "All Settings" hub.widget_organizationswithrequiresService: 'org-scoping'and extend the ADR-0057 D10 server-side visibility gate to dashboard widgets (rest-server) — single-tenant runtimes no longer render an orphan "Organizations" KPI (matching the already-hidden org nav entries).helpfor the Localization settings fields.PUT /api/settings/:nsnow also accepts the{ values: { … } }envelope thatGETreturns (symmetry; was a confusingUNKNOWN_KEY).Why
A real admin's first hour hit these: the two most important first-run settings (company identity, locale) weren't in the sidebar; the overview dangled an "Organizations: 0" KPI with no way to act on it; several nav/help strings leaked English in a zh session; and reading then writing a setting back failed.
The widget gate is the one non-trivial change: widget visibility was enforced client-side only (the console honors
requiresObjectbut notrequiresService), whereas ADR-0057 D10 makes the server the authoritative gate ("client filtering is courtesy"). This adds the missing server-siderequiresServiceenforcement for widgets, mirroring the existing app-nav gate.Verification
platform-objects,service-settings,rest(incl. DTS typecheck).service-settings128 (+2),rest133 (+6 dashboard-gate tests).examples/app-showcase(objectstack dev, zh session): Localization & Company pages reachable from the sidebar; Organizations KPI gone from the overview; 云连接 / 能力 shown;PUT {values:{…}}→ 200.Relates to #2246.