Repository navigation
docs(qa): re-point 17 platform-checklist clauses the 17.7 pre-release runs proved stale or mis-asserted - #21741
Merged
objectstack-fleet[bot] merged 3 commits intoOct 4, 2026
Conversation
… and 2FA checklist clauses to measured behaviour Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VDtqoecgES7ScQYGbFVDRv
…install and field-unique checklist clauses to measured behaviour Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VDtqoecgES7ScQYGbFVDRv
…r-remove checklist clauses to measured behaviour Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VDtqoecgES7ScQYGbFVDRv
objectstack-fleet
Bot
added
the
skip-changeset
objectstack-fleet
Bot
deleted the
claude/issue-21735-checklist-clause-repoint
branch
October 4, 2026 13:57
akarma-synetal
pushed a commit
to akarma-synetal/framework
that referenced
this pull request
Oct 7, 2026
…tead of a tracker number (stage 12) (objectstack-ai#21750) Part of objectstack-ai#20749 Clause-②: no Stage 12 of this card, and the third area of class (e): the test strings shipped under `packages/spec/src`, as ruled in `5902360492` on objectstack-ai#20513. This stage takes the whole `shared/` directory. Its 85 test-title and test-string literals carried 95 tracker ids: 92 cite 49 records, and 3 are a `#0000` placeholder that cites none. Each id now either states what its record decided, in words (form D), or is dropped where the title already says it. Text only: no assertion, identifier, test count or code comment changes. ## Census at the base (`72b6333cd8`, the claim's base) Instrument: stage 10's `census10.cjs` (md5 `9d08602ab972b4b8643c90d64d40fa41`) and stage 9's `census.cjs` (md5 `6e42a45a926d375013c32d62f16a296e`), both byte-identical to the copies stages 10 and 11 used. A literal counts as a test title when its folded message is argument 0 of a `describe` / `it` / `test` call, `.each` / `.skip` / `.only` chains included. Everything else is an "other" string. Both instruments read **1594 messages / 1701 ids in 369 files at the base**, which is stage 11's reading at its head exactly. `shared/` reads 85 / 95, also stage 11's figure. | directory | files | messages / ids | titles | other | |:--|--:|--:|--:|--:| | `data/` | 95 | 468 / 501 | 445 / 475 | 23 / 26 | | `ui/` | 81 | 392 / 415 | 374 / 397 | 18 / 18 | | `api/` | 40 | 189 / 201 | 181 / 193 | 8 / 8 | | `system/` | 34 | 154 / 165 | 128 / 138 | 26 / 27 | | (files directly in `src/`) | 30 | 118 / 120 | 117 / 119 | 1 / 1 | | **`shared/`** (this PR) | 21 | **85 / 95** | 73 / 81 | 12 / 14 | | `contracts/` | 25 | 63 / 74 | 59 / 70 | 4 / 4 | | `conversions/` | 9 | 34 / 34 | 34 / 34 | 0 | | `security/` | 8 | 28 / 28 | 28 / 28 | 0 | | `ai/` | 9 | 18 / 20 | 13 / 15 | 5 / 5 | | `identity/` | 6 | 15 / 15 | 14 / 14 | 1 / 1 | | `integration/` | 4 | 14 / 14 | 13 / 13 | 1 / 1 | | `migrations/` | 2 | 9 / 12 | 9 / 12 | 0 | | `marketplace/`, `meta-spelling/`, `studio/` | 5 | 7 / 7 | 7 / 7 | 0 | | **total** | **369** | **1594 / 1701** | **1495 / 1596** | **99 / 105** | - **Controls.** Lit, a title: `shared/duration.test.ts:45` reads one message with objectstack-ai#18122. Lit, an `expect` message: `shared/retry-policy.test.ts:113` reads one message. Dark: the comment at `shared/alias-integrity.test.ts:519` ("objectstack-ai#5593 migrated the last of them") reads 0; the file's messages sit at `:516`, `:770` and onwards. Planted in a scratch copy: an id added to a title reads 1 / 1, and an id in an added comment reads 0. - **A wider pattern** (any `#` plus digits) reads 87 / 97 under `shared/` at the base. The two extra hits are `(objectstack-ai#1)` placeholders in two fixtures of `retired-key-migrate-sentence.test.ts` (`:378`, `:380`, the "accepts the two legal shapes" case). They fall outside the gate's 3-to-5-digit pattern and the claim's surface, and are untouched. At the head the wider pattern reads only those two, and the gate pattern reads 0 / 0. - **At the head:** 1509 messages / 1606 ids in 348 files. `shared/` reads 0 / 0. Nothing else moved. ## How the area was chosen Stage 10's rule: rank whole first-level directories by ids, and take the busiest one within about 10% of the ~100-id bound. The four busiest each exceed the bound alone: `data/` (501), `ui/` (415), `api/` (201) and `system/` (165). The files directly in `src/` (120) are 20% over. `shared/` (95) is the busiest whole directory within the bound, and its census reads exactly stage 11's 95, so the rule needed no second pass. **Named for the next stages:** `data/` (about five stages, by subdirectory or file group; `data/driver/` alone is 52), `ui/` (about four), `api/` (two), `system/` (two), the files directly in `src/` (one, 120), `contracts/` with `conversions/` (one, 108), and `security/`, `ai/`, `identity/`, `integration/`, `migrations/`, `marketplace/`, `meta-spelling/` and `studio/` together (one, 96). ## What each id became 22 ids now state a decision in words, one per literal. 73 are dropped: 67 where the title already says what a live record decided, 3 dead numbers whose decisions were read from what landed, and the 3 `#0000` placeholders. Every cited record was read with its comments through REST. 46 answer 200. Three answer 404, and their decisions were read from their landing commits. | record | ids | result | |:--|--:|:--| | objectstack-ai#7889 | 3 of 5 | The three synthetic `history` strings in the reachability self-test read "n/a — planted for the reachability self-test". Nothing reads them: `unreachableAliasRows` reads only `aliases` and `guidanceSets`. Dropped from the 2 titles that state the check. | | objectstack-ai#6416 | 1 of 2 | "the three hand-written error maps are FOLDED and judged here". Dropped from the `expect` message that already explains the blind spot. | | objectstack-ai#6619 | 1 of 6 | "the two maps the first fold MISSED": objectstack-ai#6619 folded three maps, and objectstack-ai#6805 found two more. Dropped from 5 literals that state the fold. | | objectstack-ai#7887 | 1 of 4 | "editability lives on fields — the boundary prescription an author actually sees". That is the maintainer's boundary ruling: sections and page components gate visibility only. Dropped from 3 titles. | | objectstack-ai#5955 | 1 of 2 | "(the fix-first order survives the new set)": the history sentence is emitted last, so the author reads the fix first. Dropped once. | | objectstack-ai#15811 | 1 of 2 | "evaluated-slot population — no declaring position still mounts the persistence schema". Dropped once, where the title states the rule. | | objectstack-ai#3278 | 1 | "never re-advertises `js`, retired in favour of ScriptBody". objectstack-ai#3278 retired the `js` expression dialect as redundant with the L2 `ScriptBody`. | | objectstack-ai#7739 | 1 | "EXTERNAL_ERROR_HTTP_STATUS — each external error carries an HTTP status". The title was the symbol alone. Its landing gave the whole family one status table, so none can leak as a bare 500. | | objectstack-ai#19101 | 1 of 2 | "lazySchema × z.toJSONSchema — a lazy reference keeps its metadata". The ruling fixed the root cause in `lazySchema`, so descriptions no longer depend on which generator ran. Dropped once. | | objectstack-ai#8421 | 1 of 2 | "(flipped once unknown type names were refused)", where the title said "objectstack-ai#8421 flipped this". Dropped once. | | objectstack-ai#16845 | 1 of 2 | "ProtectionSchema — unknown-key refusal names the surface and the rename": the block adopted `strictObject`. Dropped from "accept set is unchanged". | | objectstack-ai#12840 | 1 | "acceptRetiredDefaultResidue — a retired default parses as inert residue". The title was the symbol alone. | | objectstack-ai#17109 | 1 | "enumWithRetiredValues — value-level retirement beside retiredKey()": the maintainer chose a generic helper, not a one-enum refinement. | | objectstack-ai#6414 | 1 | The `expect` message reads "the prescription must not point at the retired ETL layer": objectstack-ai#6414 retired L2 `ETLPipeline`. | | objectstack-ai#4001 | 2 | The synthetic widget `history` reads "Until unknown keys were refused, these were dropped silently". Both copies change together. The test asserts the message ends with that exact constant, so the fixture and its expectation move as one. | | objectstack-ai#7832 | 3 of 5 | "the reverse-direction alias curation added here", "already curated before the reverse-direction sweep", and "the two `visibleWhen` shapes the first sweep never enumerated". objectstack-ai#7832 was the reverse direction of the action shapes' alias table. Dropped twice. | | objectstack-ai#7816 | 1 | "the boolean `enabled: false` first". objectstack-ai#7816 noted that the boolean case must point at `enabled`, or the hint just moves the confusion. | | dropped only (live) | 49 | objectstack-ai#4661 (2), objectstack-ai#4962, objectstack-ai#4964, objectstack-ai#4971, objectstack-ai#4990, objectstack-ai#5389 (3), objectstack-ai#5481 (2), objectstack-ai#5552, objectstack-ai#5593 (2), objectstack-ai#6630, objectstack-ai#6805 (4), objectstack-ai#6856, objectstack-ai#7030, objectstack-ai#8201, objectstack-ai#8202 (2), objectstack-ai#8318 (4), objectstack-ai#8382 (2), objectstack-ai#8424, objectstack-ai#9529 (3), objectstack-ai#7894 (4), objectstack-ai#10096, objectstack-ai#10848, objectstack-ai#13859 (3), objectstack-ai#15028, objectstack-ai#15035, objectstack-ai#15423, objectstack-ai#15430, objectstack-ai#16320, objectstack-ai#18122. Each title already states the pinned decision. | | dropped only (404) | 3 | objectstack-ai#6085 (landing `026101660`: the dialect table drops `js`, adds `template` and states it IS the enum), objectstack-ai#10485 (`35ad101`: the `themes` carrier key and `ThemeSchema` retired, `/meta/theme` refused), objectstack-ai#11166 (`735f5c709`: `SchemaDiffEntry` gains a distinct `unreachable` kind). Each title already carries what landed. | | `#0000` | 3 | A placeholder in synthetic fixtures (`retired-key.test.ts:26`, `:28`; the planted source in `retired-key-migrate-sentence.test.ts:342`), cited no record. Dropped. The two `retired-key.test.ts` constants are both input and expectation, so the byte-for-byte assertions move with them. It is the same reasoning by which objectstack-ai#17109's patch round took the made-up `(ADR-0000)` out of these fixtures: a made-up number squats on a real one. | ## Readers - **Test-name filters:** none. A tracked-tree search for `-t` and `--testNamePattern` finds only `packages/qa/dogfood/README.md:142` (`-t "owner-scoped"`), which is unrelated. - **Snapshots:** none. `shared/` has no `__snapshots__`, and no `.snap` file is tracked under `packages/spec`. - **Gates that read a touched file:** - `scripts/check-future-spec-major.mjs` keeps a witnessed ledger entry for `retired-key.test.ts` (`witness: /was removed in @objectstack\/spec 99/`, `covers: 4`). The rewritten constants still carry that sentence. `check:future-spec-major` was derived for this diff and exits 0, "every witness still matching". - `packages/spec/vitest.repo-tests.json` lists `retired-key-migrate-sentence.test.ts`, so that file runs in the `repo` project. It was run there at the base and at the head. - **Titles by substring:** every old literal, plus a window around each id (221 needles), was searched across the tracked tree outside its own file. No gate, doc, filter or script reads one. The 21 needle hits land on 8 lines: - Sibling titles in other lanes' files: `packages/cli/test/format-zod-union.test.ts:301` (`[objectstack-ai#5389] formatZodErrors …`) and `packages/metadata-protocol/src/protocol.unrecognised-meta-type.test.ts:171` (`[objectstack-ai#10485] \`theme\` …`). - A later stage's row in this package: `packages/spec/src/ai/knowledge-source.test.ts:97`, an `it.each` row name with "retired at objectstack-ai#3278". - A self-test fixture in `scripts/check-future-spec-major.mjs:767-768` that copies the two `retired-key.test.ts` constants with `(#0000)`. It is its own text and does not read the file. - Code comments: the `strict-object.ts:71` docblock example and `suggestions.zod.ts:319`. - A self-test fixture with a different string in `scripts/check-doc-authoring.mjs:2507`. ## Text-only proof Stage 10's scratch tool (`textonly10.cjs`, md5 `d5e4801dbb4329ab1984da91e92fc47c`) compares base and head file by file on three legs: 1. **Skeleton:** the full AST, with string pieces masked. It must be identical. 2. **Comments:** every comment, byte-equal. 3. **Strings:** each string leaf that changed must sit in a test-call title position, or on one of the 12 declared lines. Each changed leaf must carry a tracker id before and no `#` plus digits after. The declared lines are: - the synthetic `history` strings at `alias-integrity.test.ts:917`, `:939`, `:952` and `strict-object.test.ts:16`, `:196`; - the `expect` messages at `alias-integrity.test.ts:1100` and `retry-policy.test.ts:113`; - the fixture constants at `retired-key.test.ts:26`, `:28` and the planted source at `retired-key-migrate-sentence.test.ts:342`; - the fixture names at `union-branch-policy.parity.test.ts:164`, `:169`, which reach `it` titles through a template. - **Result:** 21 of 21 files SAME, 85 changed (73 title, 12 declared), on all three legs. - **Diff hunks:** exactly the 85 planned lines, with every file keeping its line count. - **Controls (10 of 10 as predicted, on scratch copies, each anchor hit once):** identifier rename DIFF; numeric literal DIFF; comment edit COMMENT DIFF; a non-title string with an id VIOLATION; a rewritten title given a new id VIOLATION; a title that was id-free at base edited VIOLATION; one title reverted to base SAME; a declared string keeping an id VIOLATION; an undeclared `expect` message changed VIOLATION; a title re-split into a `+` chain DIFF. **Test counts:** the 21 files were run at the base (in a separate base worktree) and at the head, 20 in the `local` project and one in `repo`. Both sides read 567 / 567 passed, with the same count and status sequence per file in 21 of 21. 450 full test names change, and each equals the base name with the planned replacements applied. ## Changeset: `skip-changeset` Measured, not assumed: - `npm pack --dry-run` of `@objectstack/spec` lists 2068 files under `files[]`. 0 of the 21 touched files are in it, and 0 `*.test.ts` at all. The control `src/shared/expression.zod.ts` is in it. - In `dist/`, four new phrases read in 0 files. Of three old ones, two read in 0, and the third reads only in `shared/index.d.ts` / `.d.mts`, from the `strict-object.ts` docblock comment, not from a test. The control `Unrecognized key(s) on` reads in 42. So this PR publishes nothing, and no changeset is added. ## Verification (at `fd8fd92d13`) - `pnpm turbo run build` over all packages: 71 / 71. - `@objectstack/spec`: - `vitest run --project local`: 613 files, 18215 passed, 1 todo. - `typecheck` exit 0, including `check:test-typecheck`. Its program holds all 21 touched files, counted with `tsc --listFilesOnly`. - **Gates:** `dispatch-gates --commands` derived 80 families, and all 80 exit 0. That is stage 11's 79 plus `check:future-spec-major`. `--ran` reconciles: 80 derived, 80 run, 0 NOT-MEASURED, 0 UNRUN. - Five roster families whose rosters sit under a touched directory were also run, and each exits 0: `check:meta-url-spelling`, `check:spec-changes`, `check:authz-resolver`, `check:error-code-casing` and `check:filter-alias-parity`. - **ESLint, a proven narrowing:** `--no-inline-config` over the 21 files, 0 errors and 0 warnings. The population comes from ESLint's own config: 21 configured, 0 ignored. No `parserOptions.project` or `projectService`, so no untouched file's verdict can move. - `check-governed-merges --test`: NOT governed, 170 changed lines. ## Acceptance notes - **Code comments still carry ids** in these 21 files and in the `shared/` sources. One of them ships: the `strict-object.ts:71` docblock example quotes the old widget `history` with `objectstack-ai#4001`, and it is emitted into `dist/shared/index.d.ts`. Comments are not this card's share and are untouched here. - **Sibling titles in other packages** repeat two rewritten titles' ids (`cli`'s `format-zod-union.test.ts:301`, `metadata-protocol`'s `protocol.unrecognised-meta-type.test.ts:171`). Each is its own lane's test-string stage. `spec`'s `ai/knowledge-source.test.ts:97` is this card's later small-directories stage. - **`scripts/check-future-spec-major.mjs:767-768`** keeps its own self-test copy of the two fixture constants with `(#0000)`. It is a non-test file outside this claim's surface, and it reads nothing from `retired-key.test.ts`. - **`origin/main` moved** seven commits past the base before this PR opened (objectstack-ai#21737, objectstack-ai#21741, objectstack-ai#21739, objectstack-ai#21744, objectstack-ai#21740, objectstack-ai#21746, objectstack-ai#21749). One touches `packages/spec` (`api/error-code-ledger.zod.ts`); none touches a file in this diff, so nothing was merged. --- _Generated by [Claude Code](https://claude.ai/code/session_01T9u38rswFp5Rw8DswRUReJ)_ Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21735
Clause-②: no
What this changes
Re-points 17 clauses on 16 items in
docs/qa/platform-checklist/areas/*.json. The 17.7 pre-release runs named on the card proved each one stale or mis-asserted. Every item keeps its id, area and selectors, gets exactly onerevisionbump (both rows ofintegration-system.external-schema-introspectionride one bump), and gets onehistoryentry that cites the source commit and card.No product code changes. No run record.
docs/qa/**publishes nothing, so there is no changeset.Each row was re-derived from source at the claim ref
316be321ef, not copied from the card. Line numbers below are at that commit. The checklist itself carries symbol citations only, because its validator refusesfile:line.if (!record) return null), share-links.ts:128 + :228 (invalidOrExpired()fall-through)?state=draft); package-shipped is 403 NOT_OVERRIDABLEallowOrgOverride: false), sys-metadata-repository.ts:1694options.continueOnError: true, and asserts the default stop + NOT_ATTEMPTED tail as a second legX-OS-Debug-Timingis admin-only;OS_SERVER_TIMING=truesends spans to everyone;X-OS-Debug-Timing-Detailadmin-onlysys_user.enable_two_factordeclares resultDialog (qrcode + code-list); knownGap reworded in the same revisiongenerate_backup_codesdeclares a one-shot resultDialogfields.FIELD.primaryKey+ type-only import →// Remote primary key:comment,ObjectSchemavalue importsys_metadata_activationoccurs once)object.fieldstays a memory-pin assertion; SQL knownGap inverted--fromtarget prints "Nothing to migrate" → empty range prints "⚠ No migration step exists for protocol N → N …"; canonical-source replay; default--to18_objectstack_sequences+sqlite_masterbyte-identicalid: ""reaches the post-parse guard → located Zod error (reverse-domain rule); guard unreachableos migrate metaDivergences and choices worth a reviewer's eye
cli.migrate-meta-codemod). The card says to replay a canonical source. Measured: over the real range--from 17(default--to 18), a canonical source shows no "Applied N mechanical change(s)" block, but it still lists the step-18 semantic advisories.chain.tslists every hop's semantic entries unconditionally. So "Nothing to migrate — …" does not print there either. The clause asserts zero mechanical edits plus exit 0, not the success line.api-backend.enforce-or-remove-authoring-gates). The full prescription reaches the wire only on a caller-authoredwhere. A predicate whose provenance cannot be vouched gets the withheld "RETIRED" sentence, with the full diagnostic in the server log (sql-driver.tswithheldFilterError). The verify text says which shape to expect.enumSourcedoes. Nothing enforces this array's length, so the count is dropped from the assertion and kept as context.coverage.jsonis untouched. No item's capability mapping moved.Verification (at
d52c1fe937)pnpm check:platform-checklist→ exit 0:OK — 15 areas, 270 items …; line citations: 0 survive …; symbol anchors: 652/662 resolved. On the base316be321efthe same check reads 650/660. The two new anchors (hono-plugin.ts#serverTiming,duplicate-record-error.ts#buildDuplicateMessage) resolve, and the unresolved count stays at the named residual of 10.node scripts/pm/dispatch-gates.mjs --commands: 13 families derived. All 13 ran with exit 0.--ranreconciliation:13 derived, 13 run, 0 NOT-MEASURED, 0 UNRUN.Generated by Claude Code