Repository navigation
docs(qa): re-point the two-factor-disable mfa_required anchor at a declaration the resolver reads - #21027
Merged
Conversation
…claration the resolver reads
`pnpm check:platform-checklist` was red on main with one ABSENT SYMBOL:
identity-auth.two-factor-disable-lifecycle cited
`auth-plugin.ts#twoFactor`. After the mfa_required forcing branch was
reworked into a refusable patch, `twoFactor` survives in that file only as
a key written INLINE in `plugins: { twoFactor: true }`, which the shared
resolver deliberately does not read as a declaration. The anchor now names
`'mfa_required'`, the quoted settings key that guards the same forcing
branch, and the parenthetical says why it moved. Same repair shape as the
accept-set re-points; scripts/symbol-anchors.mjs is untouched and the
item's steps, clauses and oracle are unchanged, so no revision bump.
Clause-②: no
Claude-Session: https://claude.ai/code/session_01MRdbfpy4sQT8bUjmMhxsN7
Co-authored-by: Claude <noreply@anthropic.com>
objectstack-fleet
Bot
added
the
skip-changeset
This was referenced Oct 1, 2026
Contributor
Author
|
Landing note: this PR was authored in-session by the seat that later ran the P0 sweep, so the "a seat never lands its own PR" rule would normally hold it for a human merge. The maintainer authorized the landing explicitly: in Claude Code session Pre-landing check: the diff applied on Generated by Claude Code |
This was referenced Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20464
Refs #20559
Clause-②: no
What this does
pnpm check:platform-checklistis red onmainwith one ABSENT SYMBOL:identity-auth.two-factor-disable-lifecyclecitespackages/plugins/plugin-auth/src/auth-plugin.ts#twoFactor. Since themfa_requiredforcing branch became a refusable patch,twoFactorsurvives in that file only as a key written INLINE inplugins: { twoFactor: true }, which the shared resolver deliberately does not read as a declaration.The anchor now names
mfa_required— the quoted settings key (isExplicit('mfa_required'),key: 'mfa_required') that guards the same forcing branch — and the parenthetical says why it moved. This is the same repair shape as the accept-set re-points:scripts/symbol-anchors.mjsis untouched, no citation is dropped to a bare one.Premise check
The behaviour the item tests did not move:
auth-plugin.tsstill forcesplugins.twoFactoron whenevermfa_requiredis explicitly on, so the card's "if the behaviour moved, report instead" branch does not apply. The item's steps, clauses and oracle are unchanged, sorevisionis not bumped (a citation re-point is not a semantic edit, as in the accept-set precedent).Verification
symbolResolutionClass(auth-plugin.ts, 'mfa_required')→literal;'twoFactor'→null(the red), measured atef1ed17.pnpm check:platform-checklist→OK — 15 areas, 268 items (264 active, 2 planned), symbol anchors637/647 resolved … 10 on the named residual(unchanged residual).Changeset
Docs-only (
docs/qa/**): publishes nothing from any released package —skip-changeset.Generated by Claude Code